mirror of
https://github.com/rtk-ai/rtk.git
synced 2026-09-19 07:33:17 +08:00
fix/ls-eza-passthrough-fallback
11 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Nicolas Le Cam
|
45938b2a4d |
feat(js): distinguish between jest and vitest and don't rewrite npm test commands as we don't know which test framework is used under the hood
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com> |
||
|
sveitser
|
bec18c40a2 | fix: use /usr/bin/env shebangs for portability across systems | ||
|
patrick szymkowiak
|
d0396da1ce |
chore: merge develop into master (#499)
* fix: handle tail rewrites with read tail-lines * feat: add 32 TOML-filtered commands to hook rewrite rules (#475) Add rewrite rules for all TOML-filtered commands so the Claude Code hook automatically rewrites them to `rtk proxy <cmd>`. This ensures TOML filters apply transparently without manual `rtk` prefixing. Commands added: ansible-playbook, brew, composer, df, dotnet, du, fail2ban-client, gcloud, hadolint, helm, iptables, make, markdownlint, mix, mvn, ping, pio, poetry, pre-commit, ps, quarto, rsync, shellcheck, shopify, sops, swift, systemctl, terraform, tofu, trunk, uv, yamllint. Tests updated to use `htop` as unsupported command example since terraform is now supported via TOML filter. Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * fix: git log --oneline no longer silently truncated to 10 entries (#461) (#478) Only inject -10 limit when RTK applies its own compact format. When user provides --oneline/--pretty/--format, respect git's default behavior (no limit). Also detect -n and --max-count as user-provided limit flags. Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * fix: gh run view --job flag loses its value (#416) (#477) Add --job and --attempt to flags_with_value in extract_identifier_and_extra_args() so their values are not mistaken for the run identifier when placed before it. Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * fix: rtk read no longer corrupts JSON files with glob patterns (#464) (#479) Add Language::Data variant for JSON, YAML, TOML, XML, Markdown, CSV and other data formats. These files have no comment syntax, so the MinimalFilter skips comment stripping entirely. Previously, `packages/*` in package.json was treated as a block comment start (`/*`), causing everything until the next `*/` to be stripped — corrupting the JSON structure. Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * fix: npm routing, discover cat redirect, proxy quoted args (#480) * fix: npm routing, discover cat redirect, proxy quoted args (#470, #315, #388) #470: rtk npm now correctly routes npm subcommands (install, list, audit, etc.) without injecting "run". Previously, `rtk npm install` was executed as `npm run install`. #315: discover no longer counts `cat >`, `cat >>`, `cat |` as missed savings. These are write/pipe operations with no terminal output to compress. #388: rtk proxy now auto-splits a single quoted argument containing spaces. `rtk proxy 'head -50 file.php'` now works like `rtk proxy head -50 file.php`. Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * fix: proxy quote-aware split, redirect detection scan all tokens, npm test routing - Proxy: replace split_whitespace with shell_split() that respects quotes (#388) e.g. 'git log --format="%H %s"' no longer splits on space inside quotes - Discover: scan all tokens for redirect operators, not just nth(1) (#315) e.g. 'cat file.txt > output.txt' now correctly detected as write - npm: replace tautological test with actual routing logic verification Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> --------- Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * feat: add 11 new TOML built-in filters (xcodebuild, jq, basedpyright, ty, skopeo, stat, biome, oxlint, jj, ssh, gcc) (#490) Closes #484, #483, #449, #448, #428, #283, #316, #195, #271, #333, #87, #376 Signed-off-by: Patrick <patrick@rtk.ai> Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * fix: rtk rewrite accepts multiple args without quotes (#504) * fix: rtk rewrite accepts multiple args without quotes `rtk rewrite ls -al` now works the same as `rtk rewrite "ls -al"`. Previously, args after the command were rejected or caused ENOENT. Also adds rewrite tests to benchmark.sh to prevent regression. Signed-off-by: Patrick Szymkowiak <patrick.szymkowiak@rtk-ai.app> Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * test: add Clap rewrite tests + fix benchmark false failures - Add 2 Clap try_parse_from tests for rewrite multi-args (catches the KuSh bug at unit test level, not just benchmark) - Fix git diff benchmark: use HEAD~1 on both sides for fair comparison - Skip cargo/rustc benchmarks when tools not in PATH instead of false FAIL - Benchmark: 0 fail, 4 skip (env-dependent), 52 green Signed-off-by: Patrick Szymkowiak <patrick.szymkowiak@rtk-ai.app> Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> --------- Signed-off-by: Patrick Szymkowiak <patrick.szymkowiak@rtk-ai.app> Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * fix: use rtk <cmd> instead of rtk proxy for TOML-filtered commands (#507) - Replace all 32 `rtk proxy <cmd>` rules with `rtk <cmd>` so TOML filters actually apply (proxy bypasses filters, giving 0% real savings) - Extract NPM_SUBCOMMANDS to module-level const to prevent test/prod drift Reported-by: FlorianBruniaux Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * fix: warn when no hook installed + rtk gain hook status + PR #499 fixes - hook_check: detect missing hook (not just outdated), warn with ⚠️ Only warns if ~/.claude/ exists (Claude Code user) — once per day - gain: show hook status warning (missing/outdated) in rtk gain output - ssh.toml: bump max_lines 50→200, truncate_lines_at 120→200 (Florian review) - git.rs: mark integration test #[ignore] + assert binary exists (Florian review) - Add HookStatus enum for reuse across gain/diagnostics Fixes #508, Fixes #509 Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * fix: address code review — hook_check edge cases - status() checks .claude/ existence (no false warning for non-CC users) - Unreadable hook file returns Outdated not Missing - Swap marker/warning order (emit warning before touching rate-limit marker) - Rename misleading test, add end-to-end status() test Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * fix: review iteration 2 — double-warning, case-sensitive test, ssh truncate - Refactor check_and_warn to delegate to status() (single source of truth) - Fix double-warning: skip maybe_warn() for `rtk gain` (has its own inline warning) - Fix git test: case-insensitive assertion for cross-locale compatibility - ssh.toml: keep truncate_lines_at=120 (terminal width convention) - Robust mtime handling: unwrap_or(u64::MAX) instead of nested .ok()? - Test handles all CI environments (no hook, no .claude, hook present) Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * fix: detect and warn RTK_DISABLED=1 overuse (#508) - discover: count RTK_DISABLED= bypassed commands, report top 5 examples - gain: lightweight 7-day JSONL scan, warn if >10% commands bypassed - registry: add has_rtk_disabled_prefix() and strip_disabled_prefix() helpers - gitignore: add .fastembed_cache/ and .next/ Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * fix: preserve trailing newline in tail_lines + add missing test - apply_line_window() now preserves trailing newline when input has one - Add test for tail --lines N (space form) rewrite - Add test for tail_lines without trailing newline Signed-off-by: Patrick <patrick@rtk-ai.com> Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * fix: respect user-specified git log limits instead of silently truncating RTK was silently capping git log output in two ways: 1. `--oneline` without `-N` defaulted to 10 entries (now 50) 2. `filter_log_output()` re-truncated even when user explicitly set `-N` 3. Lines >80 chars were truncated, hiding PR numbers and author names This matters for LLM workflows: Claude needs full commit history for rebase, squash, and changelog operations. Silent truncation caused incomplete context and repeated re-runs. Changes: - User-explicit `-N` → no line cap, wider 120-char truncation - `--oneline`/`--pretty` without `-N` → default 50 (was 10) - No flags → unchanged (default 10) - Extract `truncate_line()` helper for clarity Fixes #461 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: handle -n N and --max-count=N forms in git log limit parsing - Extract parse_user_limit() to handle all 4 forms: -20, -n 20, --max-count=20, --max-count 20 - Add token savings test for filter_log_output (≥60%) - Add 5 tests for parse_user_limit edge cases Signed-off-by: Patrick <patrick@rtk-ai.com> Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * feat: add structured dotnet support (build/test/restore/format) Integrate PR #172 by @danielmarbach onto develop: - MSBuild binlog parser (binary format, gzip, 7-bit varint) - TRX test result parser (quick-xml) - Format report JSON parser - Subcommand routing: build, test, restore, format + passthrough - Sensitive env var scrubbing (GH_TOKEN, AWS_SECRET_ACCESS_KEY, etc.) - Fallback to text parsing when binlog unavailable - 86-93% token savings on real .NET projects Maintainer fixes applied: - Removed binlog temp path from output (wastes tokens) - Dropped hook file changes (incompatible with develop architecture) - Fixed unused variable warnings 888 tests pass. Signed-off-by: Patrick <patrick@rtk-ai.com> Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> * feat: add OpenCode plugin support (#300) * feat(opencode): add OpenCode plugin support Add `--opencode` flag to `rtk init` for installing a global OpenCode plugin that rewrites Bash/shell commands through `rtk rewrite`. - New plugin: hooks/opencode-rtk.ts (thin delegator to rtk rewrite) - New init modes: --opencode (OpenCode only), combinable with Claude modes - Plugin install/update/remove lifecycle with idempotent writes - Uninstall cleans up OpenCode plugin alongside Claude Code artifacts - `rtk init --show` reports OpenCode plugin status - Replace unreachable!() with bail!() in match exhaustiveness guard * docs: add OpenCode plugin documentation - README: OpenCode plugin section, install flags, troubleshooting - TROUBLESHOOTING: OpenCode-specific checklist - Update init mode table to reflect Claude Code default --------- Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu> Signed-off-by: Patrick <patrick@rtk.ai> Signed-off-by: Patrick Szymkowiak <patrick.szymkowiak@rtk-ai.app> Signed-off-by: Patrick <patrick@rtk-ai.com> Co-authored-by: Qingyu Li <2310301201@stu.pku.edu.cn> Co-authored-by: Ousama Ben Younes <benyounes.ousama@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: José Almeida <57680069+zeval@users.noreply.github.com> |
||
|
patrick szymkowiak
|
85b0b3eb0b |
fix: prettier false positive when not installed (#221) (#359)
* fix: prettier reports "All OK" when not installed (#221) Empty or failed prettier output was incorrectly treated as "all files formatted". Now detects empty output and non-zero exit code, shows the actual error message instead of a false positive. * test: add smoke tests for rewrite, verify, proxy, discover, diff, wc, smart, docker, json edge cases Covers bug fixes #196, #344, #345, #346, #347 and previously untested commands. Adds assert_fails helper. 118 assertions total (was 69). * chore: update benchmark.sh with missing commands and fix paths - Add cargo (build/test/clippy/check), diff, smart, wc, curl, wget sections - Fix Python commands: use dedicated rtk ruff/pytest instead of rtk test - Fix Go commands: use dedicated rtk go/golangci-lint, add go build/vet - Make BENCH_DIR absolute so debug files work from temp fixture dirs - Fallback to installed rtk if target/release/rtk not found |
||
|
Florian BRUNIAUX
|
ac80bfa88f |
fix: improve CI reliability and hook coverage (#95)
* feat(cargo): aggregate test output into single line (#83) Problem: `cargo test` shows 24+ summary lines even when all pass. An LLM only needs to know IF something failed, not 24x "ok". Before (24 lines): ``` ✓ test result: ok. 2 passed; 0 failed; ... ✓ test result: ok. 0 passed; 0 failed; ... ... (x24) ``` After (1 line): ``` ✓ cargo test: 137 passed (24 suites, 1.45s) ``` Changes: - Add AggregatedTestResult struct with regex parsing - Merge multiple test summaries when all pass - Format: "N passed, M ignored, P filtered out (X suites, Ys)" - Fallback to original behavior if parsing fails - Failures still show full details (no aggregation) Tests: 6 new + 1 modified, covering all cases: - Multi-suite aggregation - Single suite (singular "suite") - Zero tests - With ignored/filtered out - Failures → no aggregation (detail preserved) - Regex fallback Closes #83 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix(ci): prevent Python/Go benchmark sections from being silently skipped **Problem:** Python and Go benchmark sections were silently skipped in CI because the RTK repository doesn't contain pyproject.toml or go.mod files. The sections only ran when these project files existed. **Solution:** 1. Create temporary fixtures with minimal project structure: - Python: pyproject.toml + sample.py + test_sample.py - Go: go.mod + main.go + main_test.go 2. Resolve RTK to absolute path to work after cd into temp dirs 3. Install required tools in CI workflow: - Python: ruff, pytest - Go: stable version + golangci-lint **Impact:** - Python/Go sections now appear in CI benchmark output - Self-contained fixtures ensure consistent benchmarking - No dependency on RTK project structure Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(hooks): add missing RTK command rewrites Add 8 missing command rewrites to rtk-rewrite.sh and rtk-suggest.sh: - cargo check/install/fmt - tree, find, diff - head → rtk read (with --max-lines transformation) - wget Fixes BSD sed compatibility for head transformation by using literal spaces instead of \s+ (which doesn't work on macOS). Impact: ~18.2K tokens saved on previously missed commands discovered by `rtk discover`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> |
||
|
Florian BRUNIAUX
|
e5adba8b21 |
fix(vitest): robust JSON extraction for pnpm/dotenv prefixes (#92)
* fix(vitest): robust JSON extraction for pnpm/dotenv prefixes
Problem: RTK's vitest parser forces --reporter=json but pnpm/dotenv prepend
non-JSON text to stdout (banners, env messages), causing 100% Tier 1 failure
and useless 500-char passthrough.
Solution:
- Add extract_json_object() to parser/mod.rs (shared utility)
- Algorithm: find "numTotalTests" or first standalone {, brace-balance forward
- VitestParser now tries direct parse → extract+parse → regex → passthrough
- Replace hardcoded Command::new("pnpm") with package_manager_exec("vitest")
- Delete orphan doc comment on line 203
Impact:
- Before: 100% Tier 3 passthrough with pnpm workflows
- After: Tier 1 success with prefixes, maintains 99.5% token savings
Tests:
- 6 tests for extract_json_object (clean, pnpm, dotenv, nested, no-json, strings)
- 3 tests for VitestParser with prefixes
- All 277 tests pass
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* chore(benchmark): add vitest, pnpm, and gh commands
Add benchmarks for recently implemented commands:
- vitest run (PR #92 - JSON extraction fix)
- pnpm list/outdated (PR #6)
- gh pr list/run list (existing gh support)
These commands are now tested in CI to ensure token savings are maintained.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
|
||
|
Florian BRUNIAUX
|
a005bb15c0 |
feat: add Python and Go support (#88)
* feat(cargo): aggregate test output into single line (#83) Problem: `cargo test` shows 24+ summary lines even when all pass. An LLM only needs to know IF something failed, not 24x "ok". Before (24 lines): ``` ✓ test result: ok. 2 passed; 0 failed; ... ✓ test result: ok. 0 passed; 0 failed; ... ... (x24) ``` After (1 line): ``` ✓ cargo test: 137 passed (24 suites, 1.45s) ``` Changes: - Add AggregatedTestResult struct with regex parsing - Merge multiple test summaries when all pass - Format: "N passed, M ignored, P filtered out (X suites, Ys)" - Fallback to original behavior if parsing fails - Failures still show full details (no aggregation) Tests: 6 new + 1 modified, covering all cases: - Multi-suite aggregation - Single suite (singular "suite") - Zero tests - With ignored/filtered out - Failures → no aggregation (detail preserved) - Regex fallback Closes #83 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * feat: add Python and Go language support Implements comprehensive support for Python and Go development tooling with 70-90% token reduction across all commands. Python commands (3): - rtk ruff: Linter/formatter with JSON (check) and text (format) parsing (80%+) - rtk pytest: Test runner with state machine text parser (90%+) - rtk pip: Package manager with auto-detect uv (70-85%) Go commands (4): - rtk go test: NDJSON streaming parser for interleaved test events (90%+) - rtk go build: Text filter showing errors only (80%) - rtk go vet: Text filter for issues (75%) - rtk golangci-lint: JSON parser grouped by rule (85%) Architecture: - Standalone Python commands (mirror lint/prettier pattern) - Go sub-enum (mirror git/cargo pattern) - 5 new modules: ruff_cmd, pytest_cmd, pip_cmd, go_cmd, golangci_cmd - Hook integration in rtk-rewrite.sh for transparent rewrites - Comprehensive tests (47 new tests, all passing) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * feat(benchmark): add Python and Go commands Add benchmark sections for Python (ruff, pytest, pip) and Go (go test/build/vet, golangci-lint) to validate >80% token savings in CI pipeline. Sections conditionally execute based on project markers (pyproject.toml, go.mod) and tool availability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> |
||
|
Patrick szymkowiak
|
ea7cdb7a3b |
fix(ls): compact output (-72% tokens) + fix discover panic
- ls: rewrite to strip permissions/owner/group/dates, show only names with dir/ suffix and human sizes. Properly handle flag ordering (path -l), -lh, multi-paths, --all. - discover: remove orphan diff pattern that caused index out of bounds panic (PATTERNS had 22 entries vs RULES 21) - benchmark: add 8 ls test cases - test-all: add 5 ls smoke tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> |
||
|
Patrick szymkowiak
|
fcc14624f8 |
fix(find): rewrite with ignore crate + fix json stdin + benchmark pipeline
- find: replace fd/find subprocess with ignore::WalkBuilder for native .gitignore support, fix "." pattern, fix --max file counting - json: add stdin support via "-" path (same pattern as read) - benchmark: one-line-per-test format with icons for CI logs, local debug files only when not in CI, remove md upload/PR steps Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> |
||
|
Florian BRUNIAUX
|
b868987f6f |
feat: add Modern JS Stack commands to benchmark script
Add benchmarks for the 6 new commands in scripts/benchmark.sh: - tsc: TypeScript compiler error grouping - prettier: Format checker with file filtering - lint: ESLint/Biome grouped violations - next: Next.js build metrics extraction - playwright: E2E test failure filtering - prisma: Prisma CLI without ASCII art All benchmarks are conditional (skip if tools not available or not applicable to current project). Tests only run on projects with package.json and relevant configuration files. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> |
||
|
Patrick szymkowiak
|
50f501c92a | adding benchmark |