Core fix (src/init.rs — uninstall()):
- Added step 3b after existing @RTK.md removal: checks for <!-- rtk-instructions marker in CLAUDE.md and removes the block
using the existing remove_rtk_block() helper
- Handles both artifacts in a single pass (covers edge case where both @RTK.md and the instructions block exist, e.g. after
running both rtk init -g and rtk init -g --claude-md)
- If CLAUDE.md becomes empty after cleanup, deletes the file
Hardening:
- Extracted RTK_BLOCK_START and RTK_BLOCK_END constants — all marker matching across uninstall(), upsert_rtk_block(),
remove_rtk_block(), patch_claude_md(), and show_config() now uses these instead of duplicated string literals
- When uninstall finds nothing to remove, prints which paths were checked to help users diagnose path issues
- resolve_claude_dir() error message now shows %USERPROFILE% on Windows instead of $HOME
Signed-off-by: Adrien Eppling <adrien.eppling@supinfo.com>
When running `rtk lint npx eslint ...`, args[0] was "npx" instead of
"eslint", causing no JSON format flag injection and duplicated output.
Extract strip_pm_prefix() and detect_linter() helpers, skip package
manager prefixes before identifying the actual linter name.
gh view/checks commands (pr view, issue view, pr checks, run view)
were ignoring extra flags like -R/--repo, causing failures outside
git repositories where gh needs -R to know which repo to query.
The root cause: these functions took args[0] as the identifier and
discarded everything else, while constructing hardcoded gh commands.
Changes:
- Add extract_identifier_and_extra_args() to separate the positional
identifier from flags, handling both `view 123 -R owner/repo` and
`view -R owner/repo 123` argument orders
- Pass extra args through to gh in view_pr, view_issue, pr_checks,
and view_run
- Add has_json_flag() check at top of run() to passthrough when user
explicitly requests --json output (related fix from #313)
Fixes#223
* fix: gh pr edit/comment pass correct subcommand to gh
pr_action was receiving the past-tense display label ("edited",
"commented") and using it as both the gh subcommand and the
ok_confirmation message. This caused `gh pr edited` to be invoked
instead of `gh pr edit`, which fails with "unknown flag" errors.
Split the parameter into subcmd (for the gh invocation) and
display_label (for ok_confirmation output).
* smaller diff
Clap was rejecting -a, --amend, --allow-empty etc. because Commit only
declared -m/--message. Switch to trailing_var_arg like other git
subcommands so all flags pass through to git directly.
Fixes#327
* fix: prettier reports "All OK" when not installed (#221)
Empty or failed prettier output was incorrectly treated as "all files
formatted". Now detects empty output and non-zero exit code, shows the
actual error message instead of a false positive.
* test: add smoke tests for rewrite, verify, proxy, discover, diff, wc, smart, docker, json edge cases
Covers bug fixes#196, #344, #345, #346, #347 and previously untested
commands. Adds assert_fails helper. 118 assertions total (was 69).
* chore: update benchmark.sh with missing commands and fix paths
- Add cargo (build/test/clippy/check), diff, smart, wc, curl, wget sections
- Fix Python commands: use dedicated rtk ruff/pytest instead of rtk test
- Fix Go commands: use dedicated rtk go/golangci-lint, add go build/vet
- Make BENCH_DIR absolute so debug files work from temp fixture dirs
- Fallback to installed rtk if target/release/rtk not found
The rewrite pattern matched all `docker` commands but the regex didn't
cover `docker compose`, so compose subcommands were never rewritten.
Meanwhile unsupported compose commands (up, down, config) would fail
if manually prefixed with rtk.
- Extend regex to match `docker compose (ps|logs|build)`
- Unsupported compose subcommands (up, down, config, exec, etc.) are
correctly skipped by the regex and not rewritten
- 6 new tests covering supported and unsupported compose subcommands
Fixes#336
Two fixes for command passthrough issues:
1. Restore `--` separator stripped by clap (#287): When running
`rtk cargo test -- --nocapture`, clap consumes `--` and passes only
`["--nocapture"]` to cargo, which rejects it. Now detect `--` from
the original command line and re-insert it in the correct position.
2. Remove noisy `[rtk: parse failed, running raw]` stderr message (#286):
Unrecognized commands like `rtk make` or `rtk ruby` pass through
silently via the fallback, matching the documented behavior.
Fixes#286Fixes#287
Version mentions (README.md, CLAUDE.md, ARCHITECTURE.md) were still
on 0.25.0. Module count was 56 (missed hook_check module added in #350).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- #345: rewrite_segment() now returns None when env_prefix contains
RTK_DISABLED= — prevents rewriting commands the user explicitly
opted out of
- #346: rewrite_compound() detects redirect operators (2>&1, >&2,
&>/dev/null, &>>) before treating bare & as background operator —
fixes corrupted compound commands containing stderr redirects
- #347: validate_json_extension() helper added to json_cmd.rs — early
rejection with clear error message for TOML/YAML/XML/CSV/etc. files,
with a dedicated tip for Cargo.toml (suggests rtk deps)
Tests: 16 new unit tests (4 + 6 + 6), 7 new hook integration tests.
All 672 tests pass. Quality gate clean.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat: add Claude Code skills for PR and issue triage
Two skills that power structured audits directly in Claude Code sessions.
They replace ad-hoc manual reviews with a repeatable, documented workflow.
**`/pr-triage`** — Pull request audit
Scans open PRs, runs deep review on selected ones, and posts formatted
review comments to GitHub. Covers code quality, test coverage, security
surface, and alignment with CLAUDE.md conventions. Useful before every
merge and for contributor onboarding.
**`/issue-triage`** — Issue audit
Audits open issues, auto-categorizes (bug/feature/doc/question), detects
duplicates, cross-references related PRs, and estimates risk/priority.
Posts structured comments so maintainers have a clear action queue.
Both skills integrate with the `gh` CLI and can be invoked with args:
/pr-triage 42 57 — deep review of specific PRs
/pr-triage all — full audit of all open PRs
/issue-triage — audit-only mode (no comments posted)
/issue-triage all en — deep analysis, English output
These reduce the overhead of code review and issue management to a single
slash command, keeping context inside the Claude Code session.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* docs: fix version references 0.24.0 → 0.25.0 and module count (pre-existing)
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: curl size guard (#297) + exclude_commands config (#243)
**#297 — curl JSON inflation guard**
- `rtk curl` no longer replaces small JSON responses with a type schema
that is larger than the original payload
- Size guard in `filter_curl_output()`: only return schema when
`schema.len() <= original.len()`
- Inspired by PR #324 (@rursache)
**#243 — exclude_commands config**
- Add `[hooks] exclude_commands = ["curl"]` in config.toml to prevent
the auto-rewrite hook from rewriting specific commands
- Survives `rtk init -g` re-runs (config.toml is user-owned)
- Implemented in `rewrite_cmd::run()` via `HooksConfig` struct
- Threaded through `rewrite_command()` → `rewrite_compound()` → `rewrite_segment()`
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* docs: add #297 and #243 to CHANGELOG + exclude_commands in README
* docs: fix version references 0.24.0 → 0.25.0 across all docs
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>