mirror of https://github.com/rohitg00/agentmemory.git synced 2026-09-14 20:16:33 +08:00

Files

T

Matt Van Horn 1a706ca2d6 fix(integrations): warn when bearer auth crosses plaintext HTTP to non-loopback (#315 )

* fix(integrations): warn when bearer auth crosses plaintext HTTP to non-loopback (#275)

Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>

* test(integrations/315): edge cases for IPv6 loopback + LAN IPs + lookalike hostnames + docs

@mvanhorn's PR #315 lands the right plaintext-bearer-auth warn-once
pattern across three runtimes (hermes/python, openclaw/mjs,
pi/typescript). Reviewed cleanly. Adding test cases + docs before
merge so the contract is locked:

Test additions (test/integration-plaintext-http.test.ts pi suite,
+4 cases, 13 total in suite):

- IPv6 loopback (http://[::1]:3111) — URL parser strips brackets,
  hostname comes back as `::1`, the LOOPBACK_HOSTS set already covers
  this. Test pins the parsing semantic so a future refactor can't
  silently break it.

- Private LAN IPs (RFC1918 ranges 192.168.x.y, 10.x.x.x) — NOT
  loopback, guard MUST warn. RFC1918 was a deliberate design choice
  (loopback set stays minimal: localhost / 127.0.0.1 / ::1). LAN
  deployment behind a tunnel still leaks the bearer over the wire.

- No-secret short-circuit (guard with secret="" or undefined) — guard
  never fires when a bearer wouldn't actually be sent. Mirrors the
  usesPlaintextBearerAuth() early-return.

- Lookalike hostname (http://localhost.evil.com:3111) — `parsed.hostname`
  returns the full `localhost.evil.com` string, which is NOT in
  LOOPBACK_HOSTS. Guard warns. This pins the exact-match (vs prefix)
  loopback semantic.

Docs additions:

- integrations/pi/README.md and integrations/hermes/README.md now
  document AGENTMEMORY_REQUIRE_HTTPS in the env-vars table — same row
  shape as AGENTMEMORY_SECRET, names the env value (=1), describes the
  warn-vs-throw semantic, and lists the loopback hostnames the guard
  recognises.

No code changes to the guard itself — it's already correct. Pre-merge
hardening only.

899 / 899 tests pass on rebased branch. Build clean.

---------

Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-authored-by: Rohit Ghumare <ghumare64@gmail.com>

2026-05-13 15:59:50 +01:00

2.5 KiB

Raw Permalink Blame History

agentmemory for pi

Your pi sessions remember everything. No more re-explaining.
_{Persistent cross-session memory via agentmemory — shared with Claude Code, Codex CLI, Gemini CLI, Hermes, OpenClaw, and more.}

Quick setup

Start the agentmemory server in a separate terminal:

npx @agentmemory/agentmemory

Copy this folder into pi's global extensions directory:

mkdir -p ~/.pi/agent/extensions/agentmemory
cp integrations/pi/index.ts ~/.pi/agent/extensions/agentmemory/index.ts

Then enable it in ~/.pi/agent/settings.json if you prefer explicit loading:

{
  "extensions": ["~/.pi/agent/extensions/agentmemory"]
}

If you place it under ~/.pi/agent/extensions/agentmemory/, pi will also auto-discover it and /reload can hot-reload it.

What it adds

memory_health — confirm the shared memory server is reachable
memory_search — search prior decisions, bugs, workflows, and preferences
memory_save — write durable facts back to long-term memory
/agentmemory-status — check health from inside pi
before_agent_start recall — injects relevant memories into the prompt
agent_end capture — saves completed conversation turns back to agentmemory

Environment variables

Variable	Default	Description
`AGENTMEMORY_URL`	`http://localhost:3111`	agentmemory server URL
`AGENTMEMORY_SECRET`	(none)	Bearer token for protected instances
`AGENTMEMORY_REQUIRE_HTTPS`	(off)	When set to `1`, refuse to send a bearer token over plaintext HTTP to a non-loopback host. Sends the token only when `AGENTMEMORY_URL` is `https://...` or points at `localhost`/`127.0.0.1`/`::1`. With this off, the plugin warns once but still sends.

Smoke test

Run pi and ask it to use the memory_health tool, or call the command directly:

/agentmemory-status

You should see agentmemory healthy and a footer status like 🧠 agentmemory.

Notes

This extension uses pi's extension API, not MCP, so it can hook directly into the agent lifecycle.
One local agentmemory server can be shared across pi, pi2, Hermes, OpenClaw, Claude Code, Codex CLI, and Gemini CLI.

2.5 KiB Raw Permalink Blame History