Commit Graph

597 Commits

Author SHA1 Message Date
Tommy D. Rossi bd6c7eb363 fix playwriter multi-profile browser routing
Route extension relay connections by their per-profile install id before falling back to Google account identity. This keeps two Chrome profiles signed into the same account from replacing each other in the relay.

Keep Playwright-created tabs in the intended Chrome window by remembering the window where the extension was activated and using that window for Target.createTarget and initial tabs.

Handle Chrome debugger cancellation as a global detach event. When Chrome reports canceled_by_user, clear all tracked debugger tabs and emit detach events so Playwright stops sending commands to tabs Chrome already detached from. Also avoid resurrecting stale error tab state if the detach happens while attachTab is still unwinding.

Validation:
- pnpm test --run src/relay-state.test.ts
- pnpm typecheck
- pnpm build in extension/
- Manual two-profile Hacker News navigation and comment extraction
- Mythos review found no blocking issues

Session: ses_120923e0fffe5l4GT77WwyXEGP
2026-06-19 13:31:31 +02:00
Tommy D. Rossi 6847ac41fa add remote access page to website docs, reference from skill.md
- Create website/src/docs/remote-access.mdx with full remote access guide
  (traforo tunnel setup, Docker/devcontainer, LAN, security, env vars)
- Add docs/remote-access to website navigation in docs.json
- Add "Remote access" section to skill.md with quick-start snippet
  linking to https://playwriter.dev/docs/remote-access
- Converted original docs/remote-access.md content to MDX with
  diagram code fences and Aside components

Session: ses_1257fc4baffeU7BhTtBImAFQ1a
2026-06-18 14:11:00 +02:00
Tommy D. Rossi e486f87914 revert relay block, keep only skill.md warning for clearBrowserCookies
The runtime block was too aggressive; the command might be useful in
some cases. Instead, rely on the skill doc rule so agents know not to
use it unless explicitly asked.

Session: ses_12890788fffeo527ik9Os483KR
2026-06-17 23:22:25 +02:00
Tommy D. Rossi db13737808 remove redundant never-use warning from skill.md, relay already blocks it
Session: ses_12890788fffeo527ik9Os483KR
2026-06-17 23:21:45 +02:00
Tommy D. Rossi 7ea40c0e04 block Network.clearBrowserCookies and Network.clearBrowserCache in CDP relay
These CDP commands are profile-wide destructive operations that wipe ALL
cookies/cache across every domain in the user Chrome profile, not just
the current page. A previous incident wiped Gmail, GitHub, and every
authenticated session.

Changes:
- cdp-relay.ts: added blocklist at top of routeCdpCommand() that throws
  a descriptive error if an agent or script tries to send either command.
  The error message explains the safe alternative (Network.getCookies +
  Network.deleteCookies for per-domain cookie clearing).
- skill.md: added prominent warning in the cookies section with the
  correct per-domain cookie clearing pattern using getCookies/deleteCookies.
- MEMORY.md: documented the incident for future sessions.

Session: ses_12890788fffeo527ik9Os483KR
2026-06-17 23:16:44 +02:00
Tommy D. Rossi 95ed4a1f04 release: playwriter@0.3.1 2026-06-13 17:40:55 +02:00
Tommy D. Rossi c1112964e6 Enable Playwriter auto pages by default
Auto page creation is now the default policy instead of per-client plumbing. MCP and CLI both create an initial blank tab when no Playwriter-enabled pages are available, which prevents a connected extension with zero targets from failing before the agent can act.

PLAYWRITER_AUTO_ENABLE=false is the single opt-out. The relay and executor both consult the same shouldAutoEnablePlaywriter helper so Target.setAutoAttach auto-creation and executor fallback page creation stay aligned.

This removes the earlier CLI-only autoEnable request flow from session creation and CDP URLs because auto-enable is no longer a special CLI capability.

Session: ses_143538111ffe2cKnv4TqZ7ZoqQ
2026-06-13 17:32:07 +02:00
Tommy D. Rossi 1088381e9f release: playwriter@0.3.0
Release Playwriter 0.3.0 with the pending user-facing changes since 0.2.0.

Included release notes:

1. Add `sinceLastCall` to `getLatestLogs()` so agents can inspect only new browser logs after each action.
2. Rotate `~/.playwriter/cdp.jsonl` automatically to prevent unbounded disk growth.
3. Include page runtime errors and related frame target logs in `getLatestLogs({ page })`.
4. Let CLI-created sessions auto-open initial extension tabs when MCP owns the shared relay.
5. Send bearer tokens on remote extension status checks.
6. Handle concurrent relay startup races without surfacing `EADDRINUSE` crashes.
7. Improve browser names in multi-browser session selection.
8. Document `getLatestLogs()` as the preferred page diagnostics API for agents.

Fixes #75
Fixes #85
Fixes #92

Session: ses_unknown
2026-06-13 17:21:11 +02:00
Tommy D. Rossi a7af83b7c0 Fix CLI auto-enable when MCP owns relay
CLI sessions requested auto-enable only by setting PLAYWRITER_AUTO_ENABLE when they spawned the relay process. That fails when MCP already owns the shared relay, because the CLI reuses the existing process and no per-session intent reaches the CDP connection.

Send an explicit autoEnable flag when creating CLI extension sessions, carry it through the generated CDP URL, and let the relay auto-create an initial tab for that specific Playwright client even if the process env was not set at startup.

This keeps MCP behavior unchanged while making CLI sessions resilient after the last enabled tab is closed.

Session: ses_143538111ffe2cKnv4TqZ7ZoqQ
2026-06-13 17:17:46 +02:00
Tommy D. Rossi dade84e7bd Address oracle review: atomic rotation, flush(), input validation, changeset
Oracle review fixes for CDP log rotation:
- Wrap rotate() in try/catch so failures do not break the write queue
- Use temp file + fs.rename for atomic rotation (no corruption on crash)
- Add resolvePositiveInt() to validate maxEntries from env/options
- Remove redundant `rotating` flag (queue serialization is sufficient)
- Expose flush() on CdpLogger so tests can await the queue
- Rewrite tests to use flush() instead of setTimeout (14ms vs 1.3s)
- Assert exact retained entry IDs via inline snapshot
- Add test for atomic rename (no .tmp file left behind)
- Add patch changeset for playwriter package

Session: ses_1545c4395ffeRR6V3ko2KSiVHT
2026-06-09 11:16:50 +02:00
Tommy D. Rossi d6176d484d Add CDP log rotation to prevent unbounded cdp.jsonl growth (#92)
The cdp.jsonl file grew without bound during long relay sessions,
causing disk exhaustion (5.7 GB reported in issue #92).

Added rotation logic to createCdpLogger:
- New `maxEntries` option (default 10,000, env PLAYWRITER_CDP_LOG_MAX_ENTRIES)
- When line count exceeds maxEntries, file is trimmed to keep the last half
- Rotation is chained on the async write queue, safe with concurrent writes
- File oscillates between maxEntries/2 and maxEntries lines

Added unit tests:
- Rotation triggers correctly at threshold
- No rotation when under limit
- Multiple rotations work with small maxEntries

Fixes #92

Session: ses_1545c4395ffeRR6V3ko2KSiVHT
2026-06-09 11:12:52 +02:00
Tommy D. Rossi 0ac72e189d fix clearAllLogs stale cursor bug, add changeset for sinceLastCall
clearAllLogs() now also clears pageLogCursor so subsequent sinceLastCall
calls do not see stale cursors that would cause them to return empty arrays.

Added changeset describing the sinceLastCall option and persistent logs
behavior change.

Session: ses_154681872ffeqje784ZqFUspy5
2026-06-09 11:12:01 +02:00
Tommy D. Rossi cbf0d6ce35 add sinceLastCall option to getLatestLogs, persist logs across navigation
getLatestLogs() now supports a sinceLastCall option that returns only new
console logs and page errors since the previous call. The first call returns
all buffered logs including pre-existing ones. This lets agents check for
errors after every action without seeing duplicates.

Browser console logs no longer clear on page navigation (framenavigated).
Logs persist across gotos and reloads so errors from page transitions are
never missed. The existing 5000-entry-per-page cap prevents unbounded growth.
When entries are shifted out at the cap, per-page cursors are decremented to
stay in sync.

Updated skill.md interaction feedback loop to instruct agents to always call
getLatestLogs({ page: state.page, sinceLastCall: true }) after every action
(goto, click, submit) to catch hydration errors, failed network requests,
and runtime exceptions.

Updated tests: two assertions that expected logs to be cleared on reload now
expect logs to persist (lines 831 and 978).

Session: ses_154681872ffeqje784ZqFUspy5
2026-06-09 11:07:41 +02:00
Tommy D. Rossi 7235248b4d block process.exit() and process.chdir() in sandbox
process.exit() would kill the relay server, affecting all sessions.
process.chdir() would change the relay cwd, affecting all sessions.

Both now throw descriptive errors instead.
Also simplified the Proxy: always use it (no conditional on sessionCwd),
falling back to real process.cwd() when sessionCwd is null.

Session: ses_16234add5ffeXGeXpSdt8Jttuc
2026-06-06 19:06:45 +02:00
Tommy D. Rossi 27728bb8bc expose process global in sandbox with correct session cwd
- Add `process` to usefulGlobals so it is available in the VM sandbox
- Override `process.cwd()` via Proxy to return the session cwd
  (where `playwriter session new` was invoked) instead of the
  relay server cwd
- Document `process` in the skill.md context variables section
- Document sandboxed fs write restrictions (only session cwd,
  /tmp, os.tmpdir() are writable)
- Document unavailable globals: __dirname, __filename, import

Session: ses_16234add5ffeXGeXpSdt8Jttuc
2026-06-06 19:05:07 +02:00
Tommy D. Rossi e39122bc5b fix: handle EADDRINUSE race on first relay startup (#75)
When two CLI/MCP commands start simultaneously with no relay running,
both detect the relay is down and both spawn one. The second process
crashes with EADDRINUSE on port 19988.

Three changes fix this:

1. cdp-relay.ts: switch from serve() to createAdaptorServer() so we
   inject WebSocket upgrade handlers before binding, then explicitly
   call server.listen() with once(listening)/once(error) handlers.
   EADDRINUSE is now a catchable promise rejection instead of an
   unhandled async error event.

2. start-relay-server.ts: catch EADDRINUSE in the spawned relay
   process. Poll /version for up to 2 seconds to check if another
   relay won the race. If yes, exit cleanly (code 0) instead of
   crashing with a scary error in the logs.

3. relay-client.ts: add module-level promise dedup so concurrent
   ensureRelayServer() calls within the same process only spawn once.
   When a process is found on the port but /version does not respond,
   poll /version for 2 seconds before killing it (prevents accidentally
   killing a relay that is still starting during a race).

Shared waitForRelayVersion() helper extracted to avoid duplicating the
poll loop in two places.

Session: ses_16355a286ffekJzHDlexPGKG56
2026-06-06 13:40:58 +02:00
Tommy D. Rossi 25dc876686 document getLatestLogs for browser log inspection
Update the Playwriter skill to tell agents to use getLatestLogs when inspecting browser logs instead of manually attaching page.on('console') listeners.

Manual console listeners only see future events, which can miss logs emitted during page startup or React hydration. The docs now explain that getLatestLogs captures browser console logs and pageerror entries from page start, and the examples now show page-scoped and hydration-error lookups.

Also add a playwriter patch changeset for the docs change.

Verification:
- pnpm typecheck

Known local check limitations:
- lintcn still reports pre-existing unrelated errors in aria-snapshot.ts, cdp-relay.ts, mcp.ts, and wait-for-page-load.ts

Session: ses_1913ab7ecffeHGoDq9rqCrGbCK
2026-05-28 15:49:16 +02:00
Tommy D. Rossi d9226b66cf fix getLatestLogs page error capture
Capture uncaught page runtime errors in getLatestLogs by listening to Playwright pageerror events and storing browser logs by Page object instead of target id.

This fixes page-scoped log lookup for pages where useful runtime errors surface outside the main page target, including React hydration failures on unframer.co.

Also add a regression assertion for pageerror entries and a playwriter patch changeset.

Verification:
- pnpm typecheck
- manual playwriter CLI check on https://unframer.co/ returns [pageerror] Minified React error #418

Known local check limitations:
- targeted Vitest could not launch because the local Playwright Chromium binary is missing
- lintcn still reports pre-existing unrelated errors in other files

Session: ses_1913ab7ecffeHGoDq9rqCrGbCK
2026-05-28 15:41:06 +02:00
Tommy D. Rossi e9339a3ecc fix: send auth token on remote status check routes
When using `--token` with a remote `--host`, the CLI and executor
status check fetches (`/extensions/status`, `/extension/status`) were
not sending the bearer token. The host validation middleware rejects
non-localhost requests without a valid token, so remote `session new`
and `session list` would silently fail with "no connected browsers".

**cli.ts**: `fetchExtensionsStatus` now accepts `{ host, token }` and
passes auth headers via `buildAuthHeaders` to both status endpoints.

**executor.ts**: `checkExtensionStatus` reads `token` from
`this.cdpConfig` (falling back to `PLAYWRITER_TOKEN` env) and attaches
`Authorization: Bearer` header to all status fetch calls.

`relay-client.ts` left unchanged since those functions are hardcoded
to `127.0.0.1` (local-only, always passes host validation).

Closes #91
Fixes #85

Session: ses_1b4c572a4ffev2Dct63TjK77gJ
2026-05-21 17:53:18 +02:00
Tommy D. Rossi 70f8deac7b Add Host header validation to prevent DNS rebinding attacks
DNS rebinding lets an attacker serve a page from http://evil.com:19988,
then rebind the DNS to 127.0.0.1. The browser treats subsequent requests
as same-origin, bypassing Sec-Fetch-Site, CORS preflight, and
Content-Type enforcement. This gives full access to privileged HTTP
routes like /cli/execute without any existing defense catching it.

The new global middleware rejects requests whose Host header hostname is
not localhost, 127.0.0.1, [::1], or ::1. Requests carrying a valid
bearer/query token bypass the check so remote clients still work.

The Host parser handles IPv6 brackets, bare ::1, case-insensitive
hostnames, and port suffixes via indexOf instead of a fragile regex.

Unit tests use raw http module (Node fetch forbids overriding Host) to
verify evil.com is rejected and all localhost variants pass, including
uppercase LOCALHOST.

Session: ses_1bfec4b08ffeL3NJunw0EC9plq
2026-05-19 14:03:02 +02:00
Tommy D. Rossi 668d97eb00 release: playwriter@0.2.0
Merges all changes since 0.1.0 (last published npm version):

- New -f/--file flag for executing JS from files
- React component inspection for pinned elements
- Performance profiling guide resource
- Shell tab completions via goke
- Security: token required on all requests regardless of source
- --token works on every remote subcommand
- Fixed Next.js webpack layer prefixes in React source paths
- Skill docs require absolute paths for saved artifacts

Session: ses_1bff6e68fffe5Ls42bfN8RUyVp
2026-05-19 13:46:21 +02:00
Tommy D. Rossi 014fd520ce docs(skill): add -f/--file execute-from-file section
Add "Execute from file" subsection to skill.md documenting the -f flag
for executing JavaScript from a file instead of inline -e code.

Session: ses_1d0419706ffelv53Gc4OrfwZ4L
2026-05-16 09:48:52 +02:00
Tommy D. Rossi d02fa5df17 feat(cli): add -f/--file flag, shell completions, and unknown command errors
Add `-f, --file <path>` option so users can execute JavaScript from a file
instead of inline `-e` strings. The two flags are mutually exclusive.

Enable `cli.completions()` from goke for shell tab completion support.

Change `cli.parse()` to `await cli.parse()` so async command actions
properly propagate errors and exit codes.

Add tests for unknown command and unknown subcommand error handling,
verifying they exit with code 1 and print helpful messages.

Bump goke from ^6.6.0 to ^6.12.1 which includes the completions API
and improved error messages for unknown commands.
2026-05-16 09:45:25 +02:00
Tommy D. Rossi bcd1e25ea2 docs: document changesets workflow for agents
Replace the old changelog instructions with the repo changesets workflow so future package changes add .changeset entries instead of editing generated CHANGELOG.md files or manually bumping public package versions.

Keep the Chrome extension manifest bump requirement separate because extension releases are not driven by npm changesets, and add a .changeset/readme.md so agents can quickly see what belongs in the folder.

Move the pending playwriter typecheck emit change into a changeset and revert the manual package version bump from the prior commit, leaving version updates to the publish flow.

Session: ses_1f763e4ecffenZcbrWQbx0Oh5F
2026-05-09 08:38:06 +02:00
Tommy D. Rossi a3ce2146ff fix: keep playwriter typecheck emitting dist
Run the playwriter package typecheck script through plain tsc instead of tsc --noEmit so local validation keeps compiled dist files up to date.

Bump the package version to 0.1.7 so the local dist-backed shim reports the updated package version after rebuilding.

Session: ses_1f763e4ecffenZcbrWQbx0Oh5F
2026-05-08 19:43:31 +02:00
Tommy D. Rossi d1346e7ca4 docs: add profano CPU profiling tips to performance resource
Mention .cpuprofile recording via CDP Profiler.* commands and
profano CLI for inspecting hot functions when vitals alone are
not enough to diagnose performance issues.

Session: ses_208943d84ffenqdbjxK0cO0iak
2026-05-05 11:39:01 +02:00
Tommy D. Rossi 7195359b22 fix: strip Next.js webpack layer prefixes from React source paths
bippy.normalizeFileName strips "/app-pages-browser/" but not the
parenthesized form "/(app-pages-browser)/" that Next.js webpack
actually uses in source maps. Added cleanFileName/cleanName that
runs after normalizeFileName and strips any /(layer-name)/ prefix
using regex, plus trailing "./".

Covers all Next.js webpack layer names: (app-pages-browser), (ssr),
(rsc), (action-browser), (pages-dir-browser), (pages-dir-edge),
(pages-dir-node).

Applied in both:
- Extension context menu handler (background.ts)
- MCP react-source.ts (getReactSource + getReactComponentInfo)

Also applied oracle review fixes:
- userGesture: true on clipboard Runtime.evaluate calls to prevent
  NotAllowedError when page loses focus after context menu
- Defensive fileName null check before building clipboard text

Session: ses_208943d84ffenqdbjxK0cO0iak
2026-05-05 11:38:36 +02:00
Tommy D. Rossi 10790c7392 auth: drop loopback bypass, attach token from env in in-process callers
Reviewer flagged the loopback-bypass added in 0.1.5 as a full auth
bypass under the recommended remote-access topology: tunnel agents
(traforo, ngrok, cloudflared) run as local processes and forward
public traffic to localhost:19988, so every public request reaches
the relay from 127.0.0.1. The bypass made `/cli/execute` (RCE),
`/cli/session/*`, `/recording/*` (file writes via outputPath), and
`/mcp-log` callable by anyone with the public tunnel URL.

Fix
---
1. cdp-relay.ts: privilegedRouteMiddleware now requires the token on
   every request, regardless of source. Loopback bypass removed.
2. cli.ts (`serve` action): exports `process.env.PLAYWRITER_TOKEN` at
   startup so in-process callers can attach Authorization: Bearer ...
   when calling the relay's own privileged endpoints.
3. screen-recording.ts: new `recordingHeaders()` helper reads
   PLAYWRITER_TOKEN from env and attaches the Bearer header to all
   four /recording/* calls (start, stop, status, cancel). Mirrors
   what mcp.ts already does for /mcp-log.
4. cli.ts (`executeCode`): refactored the inline header-build into
   the shared `buildAuthHeaders` helper so the six /cli/* fetch
   sites stay in sync.
5. connect-cdp-demo.ts: replaced the hardcoded 'secret_token'
   fallback with a hard error so the demo can never accidentally be
   the source of a leaked credential warning.

Bumps playwriter to 0.1.6 + CHANGELOG entry. Adds a MEMORY.md note
so the next person doesn't re-introduce the bypass.

Session: ses_20d25dcc7ffeJhVK7aC8Zh7OkW
2026-05-04 17:09:28 +02:00
Tommy D. Rossi 3d6f2d4239 auth: thread token through every remote CLI command + protect /mcp-log
Builds on Ivan Leo's auth-header pass with the missing pieces needed to
actually run `playwriter serve --token` end to end against a remote relay.

Fixes
-----
1. `--token` (or PLAYWRITER_TOKEN) now plumbed through every remote
   subcommand: `session new/list/delete/reset` and `browser list`. Until
   now only `playwriter -e` sent the Bearer header, so against a token-
   protected relay every other subcommand returned 401.
2. In-process `ExecutorManager` carries `token` in its `cdpConfig`, so the
   executor's own `chromium.connectOverCDP(ws://127.0.0.1:19988/cdp/<id>)`
   call passes the relay's own auth check.
3. `/mcp-log` is now under `privilegedRouteMiddleware`. Previously open,
   so any reachable client could spam the log file.
4. `mcp.ts` `sendLogToRelayServer` sends `Authorization: Bearer …` when
   `PLAYWRITER_TOKEN` is set.
5. Loopback connections (127.0.0.1, ::1, ::ffff:127.0.0.1) bypass the
   token check on `/cli/*`, `/recording/*`, and `/mcp-log`. They can only
   originate from in-process executor code which already runs downstream
   of an authenticated `/cdp/*` WebSocket, so re-checking the token would
   mean smuggling it into every internal helper for no real security
   gain. Resolves the broken `/recording/*` calls from
   `screen-recording.ts`.
6. New `connect-cdp-demo.ts` script: minimal example showing an external
   Playwright client connecting through `/cdp/<id>?token=<token>` over a
   tunnel.

Bumps `playwriter` to 0.1.5 and updates CHANGELOG.

Co-authored-by: Ivan Leo <ivanleomk@gmail.com>

Session: ses_20d25dcc7ffeJhVK7aC8Zh7OkW
2026-05-04 14:10:42 +02:00
Tommy D. Rossi fabd25e8f6 feat: add React component info for pinned elements
Expose getReactComponentInfo so agents can inspect the React component name, parent hierarchy, sanitized props, and source metadata for a locator or element handle. Non-React elements return null so the helper is safe to call from generic DOM inspection flows.

Update toolbar and context-menu pinned element copy to use a short inspectPinnedElement(url, expression) call. The wrapper resolves the pinned element, logs outerHTML plus React info internally, and keeps copied prompts small.

Session: ses_221fdd7c5ffexkyCmOtfmgwjoI
2026-04-30 15:51:45 +02:00
Tommy D. Rossi 480c1b9d64 docs: add performance profiling guide resource
Add a generated website resource that shows how to profile a real site with Playwriter using CDP, Navigation Timing, and PerformanceObserver.

The new guide focuses on the questions people actually ask during performance work: whether rendering is good or bad, which requests dominate transfer cost, what usually blocks first paint or LCP, and what is most likely blocking interactivity. It also includes ready-to-run Playwriter commands plus reusable TypeScript examples so the profiling workflow can be copied directly.

Session: ses_22252b7b8ffee2VFXqmaCzA2NR
2026-04-30 12:24:34 +02:00
Tommy D. Rossi e9918fcadc docs: require absolute paths for saved artifacts
Document that Playwright artifact APIs resolve paths inside Playwright client code instead of the sandboxed fs, so relative paths can land under the relay cwd.

Update the skill examples to use absolute paths for screenshots, PDFs, downloads, resize inputs, and recordings, and bump playwriter to 0.1.1 so the guidance ships with the release notes.

Session: ses_2411fc3d3ffe2bK1VDhxJd0u15
2026-04-24 13:11:31 +02:00
Tommy D. Rossi b7a2811caf release: playwriter@0.1.0 2026-04-16 12:01:54 +02:00
Tommy D. Rossi 9c2bac37d3 fix: handle shared dialog auto-close races in dialog abstraction
Move the JavaScript dialog race fix down into the Playwright fork instead of teaching the relay about a specific CDP error.

When multiple connectOverCDP clients share the same Playwriter tab, they all observe the same dialog and may all attempt the automatic best-effort close. Chrome accepts the first Page.handleJavaScriptDialog and rejects later attempts with "No dialog is showing". That follow-up failure should not crash the process because the dialog is already closed and the cleanup goal was achieved.

This commit:
- updates @xmorse/playwright-core Dialog.close() to ignore benign duplicate close races
- bumps playwright-core to 1.59.9 and documents the behavior in its changelog
- bumps playwriter to 0.0.112 and documents the user-visible fix
- adds a relay integration test that attaches two CDP clients to the same tab, opens an alert, and verifies both clients remain usable without an unhandled rejection

Why this abstraction is better:
- Dialog.close() is already the best-effort cleanup boundary
- the relay no longer needs protocol-specific knowledge of Page.handleJavaScriptDialog failures
- the behavior also protects any other shared-target setup that triggers the same close race

Validation:
- pnpm playwright:build
- pnpm typecheck (playwriter)
- pnpm test --run relay-core.test.ts -t "should ignore duplicate dialog dismissals from multiple CDP clients"
2026-04-14 10:57:03 +02:00
Tommy D. Rossi 19b0959585 fix: wrap all ghost cursor code in try/catch so it never crashes main logic
Every cursor code path that touches page.evaluate, DOM manipulation, or
runs inside a Playwright callback is now wrapped so errors stay cosmetic:

- onMouseAction callback: outer try/catch prevents cursor errors from
  propagating to Playwright's input dispatch (would break page.click)
- show()/hide(): swallow errors from closed/navigating pages
- enableGhostCursor/disableGhostCursor: same
- applyGhostCursorMouseAction: same
- Browser DOMContentLoaded auto-enable: inner try/catch
2026-04-13 09:26:26 +02:00
Tommy D. Rossi f7499bd1d9 fix: two-element cursor split so move and press transitions don't interfere
The cursor DOM is now outer (translate, move timing) + inner (scale+opacity,
press timing). Previously setPressed() overrode transitionDuration to 140ms
which retargeted in-flight 1500ms move transitions, causing clicks to
'sprint' the cursor to the target.

Also:
- Fix toast animation jump when positioned above anchor (toolbar.ts):
  keyframes now use --toast-transform CSS variable so translateY(-100%)
  base transform is included during animation, not just after.
- Remove stale navigation-rehydration entry from CHANGELOG (was cut in
  the simplification pass but the changelog entry remained).
2026-04-13 09:21:25 +02:00
Tommy D. Rossi 7455abbf5a feat: always-on ghost cursor injected by extension on tab attach
The Chrome extension now injects the ghost-cursor-client.js bundle into
every attached tab via CDP Page.addScriptToEvaluateOnNewDocument +
Runtime.evaluate. The cursor auto-enables on load (top frame only, skips
iframes) and stays on the last spot Playwright clicked or moved to.

Key changes:

- Extension injects cursor bundle via ?raw vite import, inlined into
  background.js at build time. Torn down on detachTab.
- RecordingGhostCursorController renamed to GhostCursorController with
  attachToPage/detachFromPage instead of enableForRecording/disableForRecording.
  Single instance on PlaywrightExecutor, wired in setupPageListeners.
- Recording no longer toggles the cursor on/off.
- 5s idle debounce: cursor fades out (600ms) after no activity, wakes on
  next action by teleporting to the new target and fading back in (140ms).
- Animation polish (Emil Kowalski guidelines): easeInOutCubic for moves,
  dedicated 140ms press duration with strong ease-out, subtler 0.95 press
  scale, transform-origin anchored to cursor hotspot.
- Slower cinematic defaults: 220ms min, 1500ms max, 1.2 px/ms.
- Test: verify cursor element exists on attached tab without explicit enable.
2026-04-13 09:10:34 +02:00
Tommy D. Rossi 8ee26ffcb4 update @modelcontextprotocol/sdk to 1.29.0 and hono to 4.12.12 2026-04-13 09:00:31 +02:00
Tommy D. Rossi 9e33e21484 refactor(toolbar): drop session plumbing, copy raw eval code on pin-click
The previous implementation fetched the CLI session list from the relay via
a new GET /extension/sessions endpoint, plumbed it into the MAIN-world
toolbar via chrome.scripting.executeScript args, cached it in a closure,
and baked `playwriter -s <id> -e '<code>'` into the clipboard. The
picked session id was fragile: sessions[0] is the oldest by insertion
order, which is almost never the session the agent is actually using.
The agent also has its own active session already — guessing one is
the wrong job for a browser extension.

Drop all of it. The toolbar now copies only the JS eval code. The agent
wraps it in their own `playwriter -s <session> -e '<paste>'` using
whichever session they already have (or they create a new one). The
code is JSON.stringify'd so it contains no single quotes and slots
into any shell quoting strategy the agent prefers.

Removed:
- `GET /extension/sessions` on the relay (playwriter/src/cdp-relay.ts)
- `fetchSessionSummary` helper in background.ts
- `ToolbarConfig` interface + import + args plumbing
- Async wrapping around `chrome.scripting.executeScript` in both
  injection sites (attachTab + webNavigation.onDOMContentLoaded)
- `currentSessions` / `nextSuggested` closure vars in toolbar.ts
- `window.__playwriterUpdateSessions` setter
- `pickSessionId()` helper
- `shellSingleQuote()` helper (agent does their own shell quoting)
- Re-init update routing through `window.__playwriterUpdateSessions`

`onClick` now just:

    copyText(buildInspectionCode(n, url, summary))
    showToast(`Copied inspection code (pin #${n})`)

The eval code shape is unchanged:

    state.page=context.pages().find(x=>x.url()===URL)||context.pages()[0];
    console.log(SUMMARY + "\n\nouterHTML:\n" +
      await state.page.evaluate(n => globalThis["playwriterPinnedElem"+n]?.outerHTML, N))

Bundle drops from 74.35 kB to 72.79 kB (-1.56 kB). Bumps extension to
0.0.84 and playwriter to 0.0.108 with CHANGELOG entries in both packages.
2026-04-11 14:45:42 +02:00
Tommy D. Rossi 2cbb943b00 feat(toolbar): copy full playwriter -s X -e inspection command on pin-click
The in-page toolbar's pin button used to copy a plain
`see playwriter reference: globalThis.playwriterPinnedElem1` string that
still required the agent to wrap it in their own `-e` call. It now copies
a complete, ready-to-run shell command:

    playwriter -s 1 -e 'state.page=context.pages().find(x=>x.url()===URL)||context.pages()[0]; console.log(SUMMARY+"\n\nouterHTML:\n"+await state.page.evaluate(n=>globalThis["playwriterPinnedElem"+n]?.outerHTML,N))'

Two `;`-separated statements: pick the right page by URL with first-page
fallback, assign state.page for follow-up calls, log a pre-baked element
summary plus the current outerHTML of `globalThis.playwriterPinnedElemN`
fetched via one `page.evaluate`. No `getCleanHTML`, no
`getLocatorStringForElement`, no ElementHandle dance, no locator round-
trips — the generated JS is runnable against any playwriter version.

Everything the eval code doesn't strictly need a Playwright sandbox for is
pre-computed at pin time in MAIN world (synchronous DOM access) and baked
into the command via `JSON.stringify`:

- page URL from `location.href`
- element summary: tag, id, classes, role, aria-label, name, href, type,
  truncated text, bounding rect, visibility
- pin index

Session-id plumbing:

- New public `GET /extension/sessions` endpoint on the relay returns
  `{ sessions: [{ id, stateKeys }], nextSuggested }`. It sits outside the
  `/cli/*` privileged middleware, which rejects the cross-site
  `Sec-Fetch-Site` that chrome-extension fetches to 127.0.0.1 send. It
  exposes the same data as `playwriter session list`, so no new attack
  surface.
- `background.ts` `fetchSessionSummary()` calls the endpoint with a
  1500ms timeout and falls back to `{ sessions: [], nextSuggested: '1' }`
  on any failure (relay down, old relay without the endpoint, timeout,
  malformed JSON). The extension stays backward-compatible with older
  relays.
- Both toolbar injection sites (`attachTab` + `webNavigation.onDOMContentLoaded`
  re-inject) now fetch the summary and pass it as
  `chrome.scripting.executeScript({ args: [summary] })`.
- The guarded re-init path in `initPlaywriterToolbar` now calls
  `window.__playwriterUpdateSessions?.(config)` so re-injects refresh the
  closure cache instead of becoming no-ops.
- `pickSessionId()` prefers the first existing session id, falling back
  to `nextSuggested` (typically "1") so the agent stays in their current
  state when one exists.

Toolbar runtime behavior does not depend on the relay: sessions are
cached in closure at inject time, clipboard writes stay offline, and
all failure modes surface as visible `undefined` in the command's
output rather than exceptions or timeouts.

Bumps extension to 0.0.83 and playwriter to 0.0.107 with CHANGELOG
entries in both packages.
2026-04-11 14:29:20 +02:00
Tommy D. Rossi af0f4aabe5 chore(deps): bump goke to ^6.6.0 and update --direct flag handling
goke 6.6.0 normalizes optional-value flags from 'string | boolean'
to 'string | undefined', with '' meaning 'flag present, no value'.
Update the --direct [endpoint] handler to match the new shape:
  - directEndpoint is just 'options.direct || null'
  - bare --direct check uses === '' instead of === true
2026-04-11 10:00:21 +02:00
Tommy D. Rossi 389e3cf23a chore(deps): bump goke to ^6.5.2 2026-04-11 09:32:15 +02:00
Tommy D. Rossi b6e241f487 fix: restore playwriter serve startup on clean installs
Closes #84\n\nThe CLI started importing browser-start helpers at module load time, which\npulled @xmorse/playwright-core into generic startup paths like\nplaywriter --help and playwriter serve. In clean installs that immediately\nreached the vendored extract-zip runtime, which still uses CommonJS\nrequire('get-stream'), and crashed with ERR_REQUIRE_ESM once the fork had\nget-stream v9 installed.\n\nThis change fixes the failure from both sides:\n- lazily load browser-start-only modules so normal CLI startup/help paths\n  do not pull playwright-core unless browser start is actually invoked\n- bump the playwright submodule to @xmorse/playwright-core 1.59.8, pinning\n  get-stream back to ^5.2.0 so the vendored unzip runtime stays compatible\n- add a black-box regression test that runs root help and serve help\n  through vite-node\n- update versions, changelogs, lockfile, and local memory notes\n\nVerified with pnpm typecheck, a direct require of playwright-core, and\npnpm vitest --run src/cli-help.test.ts.\n\nNote: lintcn still reports unrelated pre-existing warnings/errors in\ncli.ts, cdp-relay.ts, aria-snapshot.ts, and mcp.ts that were not part of\nthis fix.
2026-04-08 11:55:40 +02:00
Tommy D. Rossi 7e633d5ac0 fix: prevent cross-browser extension takeover loops
Persist a per-install fallback identity for the extension so Chromium-family browsers without chrome.identity profile data no longer collapse to browser-only relay keys and replace each other.

Also stop replaced workers from reclaiming the relay slot while the replacement connection is merely idle, add a regression test that launches a second Chromium context against the same relay, and bump the shipped package versions/changelogs for the extension and playwriter packages.
2026-04-07 21:43:46 +02:00
Tommy D. Rossi 91c69b54cf remove extension-outdated version check — extension auto-updates 2026-04-07 11:55:17 +02:00
Tommy D. Rossi 129fff896c feat: auto-relocate popup windows into source tab's window
Chrome popup windows (window.open with features, OAuth login popups)
could not be controlled by Playwriter because chrome.debugger does not
attach to separate popup windows. Agents had to work around this with
cmd+click (`{ modifiers: ['Meta'] }`) to coerce new tabs instead.

The extension now listens for chrome.windows.onCreated with
type === 'popup' and relocates the tab(s) into the source tab's window,
then auto-attaches Playwriter so the new tab appears in context.pages().

Gating: the popup is only relocated when the source tab is already
Playwriter-connected. Otherwise the popup is left alone so unrelated
sites keep their normal Chrome popup behavior. Source tab is discovered
via chrome.webNavigation.onCreatedNavigationTarget because
chrome.tabs.Tab.openerTabId is unreliable for window.open popups on
Chromium 145 (leaves it null).

Focus is not stolen — the relocated tab is appended at the end of the
source tab's strip (index: -1) but the user's active tab stays active.

Executor changes
- Replaced setupPopupDetection with setupNewPageLogging. Warning
  message changed from "Popup window detected ... cannot be controlled"
  to "New page opened from current page (index N, initial url: ...)"
  pointing the agent at the controllable tab.
- Added MIN_EXTENSION_PLAYWRITER_VERSION check so agents running with
  old extensions see a targeted warning to update via chrome://extensions.
- enqueueWarning is now called from warnIfExtensionOutdated so the LLM
  sees version-skew messages in its warning stream, not just stdout.

Extension changes
- New `webNavigation` permission for the source-tab correlation map.
- connectTab now verifies `chrome.tabs.get(tabId)` before writing an
  `error` state, preventing dead tabs from leaking into store.tabs /
  badge counts / group sync when a tab closes mid-attach.
- popupSourceTabMap entries are cleaned up both on a 10s timeout and
  when chrome.tabs.onRemoved fires, capping memory for plain-new-tab
  cases that never trigger windows.onCreated.

Tests
- popup-relocation.test.ts verifies both paths: when a Playwriter tab
  is connected the popup is relocated into the main window and appears
  in context.pages(); when no tab is connected the popup-type window
  remains (extension does not interfere).

Skill docs
- Removed section #10's cmd+click workaround; added a note about
  auto-relocation under "working with pages".

Versions
- extension 0.0.79 -> 0.0.80
- playwriter 0.0.103 -> 0.0.104
2026-04-05 14:22:21 +02:00
Tommy D. Rossi adc7125b47 fix: skip auto-printing Playwright handles in CLI execute output (#82)
When a single-expression code snippet auto-returns a Playwright object
(e.g. `await page.goto(url)` returning a Response), the CLI previously
called util.inspect() at depth 4 on the handle, producing 400K+ chars
that included every process.env variable (API keys, tokens, secrets).

Even with the playwright-core util.inspect fix (@xmorse/playwright-core@1.59.7),
these handles are useless output — they're programmatic references with no
display value. Agents and users get nothing meaningful from seeing:

  [return value] Response@response@abc123 { request: Channel<...>, ... }

Fix: add isPlaywrightChannelOwner() duck-type check in the executor return
value path. Handles are silently skipped (duck: _type + _guid + _connection).
The existing 'Code executed successfully (no output)' fallback applies when
there's no other output.

To see data, users must explicitly:
  return response.url()      → prints the URL string
  return response.status()   → prints 200
  console.log(response)      → prints safe summary via playwright-core

Also includes:
- Regression test (channel-owner-inspect.test.ts) for inspect handler
- isPlaywrightChannelOwner() unit tests (executor.unit.test.ts)
- Stale color-scheme snapshot fix (relay-core.test.ts)
- MEMORY.md with learnings (Node util.inspect bypass of Proxy traps)
2026-04-05 11:57:30 +02:00
Tommy D. Rossi 2a2db6be25 fix: correct test assertions for screenshot format and color scheme
- snapshot-tools.test.ts: fix wrong assertion expecting 'jpg' when screenshot returns 'png' (contradicted the mimeType assertion on the same screenshot)
- relay-core.test.ts: update inline snapshot for color scheme test to match actual system preference (light mode)
2026-04-01 12:16:31 +02:00
Tommy D. Rossi 7d54c4b6a0 fix: handle chrome-extension:// iframes from other extensions (#18)
Chrome's chrome.debugger.attach API refuses to attach to tabs containing
chrome-extension:// iframes from other extensions (LastPass, SurfingKeys,
password managers, etc). This causes the extension to immediately disconnect
after clicking the icon.

Two-layer fix:

1. Pre-attachment (removeRestrictedIframes): when chrome.debugger.attach fails
   with the chrome-extension:// error, use chrome.scripting.executeScript to
   remove restricted iframes from the DOM, then retry attachment. Requires
   new 'scripting' permission.

2. Runtime filtering (onDebuggerEvent): when Target.attachedToTarget arrives
   for a restricted child target (injected after debugger attached), filter it
   out immediately — don't track, don't forward to relay, detach the child
   target. Defense-in-depth against runtime re-injection by other extensions'
   content scripts.

Test: loads a fixture extension alongside playwriter, creates a page with a
chrome-extension:// iframe, enables the debugger, and verifies it stays
connected and can execute JS.

Closes #18
2026-03-29 23:26:26 +02:00
Tommy D. Rossi a746f895da release: playwriter@0.0.102 2026-03-29 13:25:52 +02:00