mirror of
https://github.com/redwoodjs/local-ci.git
synced 2026-09-19 07:54:29 +08:00
Peter Pistorius
044de23532
The YAML parser extracted `jobs.<id>.container.options` into job.container but the docker createContainer call never consumed it, so `options: --env FOO=bar` silently produced a container without FOO. parseContainerOptions now pulls --env/-e and --label/-l out of the options string and merges them into the container's Env array and Labels map. All other Docker flags in options: are still ignored by design — --privileged, --user, --network, --cap-add, --workdir tend to clash with agent-ci's own container orchestration, and silently dropping them is safer than a partial honoring that breaks the runner's invariants. Documented in the compatibility.json note for jobs.<id>.container. Also updated two nearby notes while running through #296: * actions/cache — documents the lack of ref-based isolation (branches share cache keys locally, unlike GitHub's per-ref scoping) * GITHUB_TOKEN — documents that OIDC id-token issuance is not wired up, so permissions: id-token: write → federated cloud auth does not work Refs #296. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>