mirror of
https://github.com/proffesor-for-testing/agentic-qe.git
synced 2026-09-19 08:45:47 +08:00
Dragan Spiridonov
e82a7240ec
11 improvements across 4 priority tiers, all integrated into production code paths with 416 new tests across 33 test files. Each wave passed a brutal honesty audit with all findings resolved. Wave 0-2 (P0/P1): Middleware chain, microcompact, tool concurrency, retry engine, session durability, prompt cache latch, startup fast paths, hook security hardening. Wave 3 (P2): 4-tier context compaction pipeline, plugin architecture with local/GitHub/npm sources. Wave 4 (P3): QE Quality Daemon — priority queue, git watcher (with Linux polling fallback), coverage delta analyzer, CI monitor, test suggester, nightly consolidation, notification service with SSRF guard, persistent SQLite-backed memory, CLI commands, MCP startup integration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
75 lines
2.3 KiB
TypeScript
75 lines
2.3 KiB
TypeScript
/**
|
|
* Tests for exit-codes: HOOK_EXIT_CODES and classifyHookExit
|
|
* @see IMP-07 Hook Security Hardening
|
|
*/
|
|
|
|
import { describe, it, expect } from 'vitest';
|
|
import {
|
|
HOOK_EXIT_CODES,
|
|
classifyHookExit,
|
|
type HookExitCode,
|
|
} from '../../../src/hooks/security/exit-codes.js';
|
|
|
|
// =============================================================================
|
|
// HOOK_EXIT_CODES constants
|
|
// =============================================================================
|
|
|
|
describe('HOOK_EXIT_CODES', () => {
|
|
it('SUCCESS is 0', () => {
|
|
expect(HOOK_EXIT_CODES.SUCCESS).toBe(0);
|
|
});
|
|
|
|
it('USER_VISIBLE is 1', () => {
|
|
expect(HOOK_EXIT_CODES.USER_VISIBLE).toBe(1);
|
|
});
|
|
|
|
it('MODEL_BLOCKING is 2', () => {
|
|
expect(HOOK_EXIT_CODES.MODEL_BLOCKING).toBe(2);
|
|
});
|
|
|
|
it('constants are readonly (frozen via as const)', () => {
|
|
// TypeScript enforces this at compile time via `as const`,
|
|
// but verify the values are stable at runtime.
|
|
const codes: Record<string, number> = { ...HOOK_EXIT_CODES };
|
|
expect(codes).toEqual({ SUCCESS: 0, USER_VISIBLE: 1, MODEL_BLOCKING: 2 });
|
|
});
|
|
});
|
|
|
|
// =============================================================================
|
|
// classifyHookExit
|
|
// =============================================================================
|
|
|
|
describe('classifyHookExit', () => {
|
|
it('classifies exit code 0 as success', () => {
|
|
expect(classifyHookExit(0)).toBe('success');
|
|
});
|
|
|
|
it('classifies exit code 1 as user_error', () => {
|
|
expect(classifyHookExit(1)).toBe('user_error');
|
|
});
|
|
|
|
it('classifies exit code 2 as model_blocking', () => {
|
|
expect(classifyHookExit(2)).toBe('model_blocking');
|
|
});
|
|
|
|
it.each([
|
|
[3, 'user_error'],
|
|
[126, 'user_error'],
|
|
[127, 'user_error'],
|
|
[137, 'user_error'],
|
|
[255, 'user_error'],
|
|
[-1, 'user_error'],
|
|
] as const)('classifies exit code %d as %s', (code, expected) => {
|
|
expect(classifyHookExit(code)).toBe(expected);
|
|
});
|
|
|
|
it('type HookExitCode accepts only valid constant values', () => {
|
|
// Runtime check that the type union matches the constants
|
|
const validCodes: HookExitCode[] = [0, 1, 2];
|
|
expect(validCodes).toHaveLength(3);
|
|
expect(validCodes).toContain(HOOK_EXIT_CODES.SUCCESS);
|
|
expect(validCodes).toContain(HOOK_EXIT_CODES.USER_VISIBLE);
|
|
expect(validCodes).toContain(HOOK_EXIT_CODES.MODEL_BLOCKING);
|
|
});
|
|
});
|