Commit Graph

7 Commits

Author SHA1 Message Date
Dragan Spiridonov 05dcfe92dd fix(init): release-gate corpus + --json contract (#401)
Addresses the v3.9.1–v3.9.4 init regression series by building the
verification layer that #401's post-mortem identified as structurally
missing. The load-bearing changes are the real-public-repo corpus, the
--json contract, and the restructured error handling in phase 06 that
stops lying about success when a non-critical phase fails.

What landed
-----------
* `aqe init --json` — structured InitResult output with schema version 1,
  stricter exit code semantics (exit 1 on any step.status='error', not
  just on critical failures). Stable contract for the gate and other CI
  consumers. See InitJsonOutput in src/cli/handlers/init-handler.ts.

* Phase 06 no longer swallows errors as `{status:'skipped',entries:0}`.
  Exceptions now propagate to BasePhase.execute() and surface as real
  step errors in result.steps[]. Fixed a resource leak where kgService
  and memory handles were leaked on the old throw path — now always
  released via try/finally.

* `tests/fixtures/init-corpus/` — 4 pinned real public repo fixtures:
  - tiny-ts (developit/mitt@b240473)
  - mid-ts (sindresorhus/p-queue@55d306b)
  - multi-lang-real (ruvnet/RuView@2a05378 — contains the exact 28,745
    byte / 776 line ruview_live.py that triggered the v3.9.4 hang,
    sha256-pinned to detect content drift)
  - self-dogfood (agentic-qe HEAD)

* 22 gate assertions per fixture (A1–A22) including per-step JSON error
  inspection (A10), snapshot-based KG threshold with tolerance (A12),
  skills/agents/MCP/CLAUDE.md/workers/config.yaml presence (A13–A20),
  subthreshold stall detection (A21), and a second init pass that
  exercises the delta-scan path of phase 06 — the actual surface that
  hung in v3.9.1 ruview, never reached on a first init (A22).

* `.github/workflows/npm-publish.yml` — new pre-publish-gate job that
  runs the corpus against the freshly-built tarball before publish; new
  tests-on-tag-sha job that re-runs fast unit tests on release events
  (replaces a buggy gh-api conditional caught by devils-advocate review).

* `.github/workflows/post-publish-canary.yml` — fires on real publishes
  only (not workflow_dispatch dry runs), polls npm CDN via
  `npm install --dry-run` (actual CDN edge, not just registry metadata),
  runs the corpus against the published package, opens P0 issue on
  failure via heredoc-based body.

* Watchdog effectiveness unit test
  (tests/unit/init/phases/code-intelligence-watchdog.test.ts) — 4 cases
  proving the async-stall branches of runBoundedScan work and
  documenting the sync-block limitation that requires AQE_SKIP_CODE_INDEX
  or (future) worker isolation.

* `.github/PULL_REQUEST_TEMPLATE.md` — single load-bearing checkbox:
  every PR failure mode must have a test or tracking issue. Honor-system
  today; CI enforcement tracked in #408.

* AQE_SKIP_CODE_INDEX promoted from "temporary escape hatch" to
  permanent supported flag in docs, CLI help, and source comments.

Verification
------------
* `npm run typecheck` — clean
* `npx eslint` on all touched files — clean (plus fixed two pre-existing
  unused-var warnings in init-handler.ts)
* `aqe security --sast` on all touched source + workflows — 0 findings
* `tests/unit/init/` — 377/377 pass
* `tests/unit/init/phases/code-intelligence-watchdog.test.ts` — 4/4 pass
* Local gate against `npm pack`'d tarball — 4/4 fixtures pass all 22
  assertions including double-init delta path and sha256 regression
  marker

Failure paths independently verified (F1–F5 injection tests):
* F1 wrong sha256 → A3 fires, exit 2, actionable diagnostic
* F2 absurd expectedKgEntries → A12 fires, exit 2, shows actual vs expected
* F3 expectedElapsedSec=0 → A21 fires on slow fixture, A22 fires on
  double-init — same `(( elapsed > soft_cap ))` math proven in both paths
* F4 injected throw in runCodeIntelligenceScan → reproduces the exact
  v3.9.3 failure shape (`success:true` at orchestrator level, phase 06
  step.status='error'). A7 catches via strict exit code, A10 catches as
  defense-in-depth via jq inspection. Both layers verified.
* F5 expectedSkillsInstalled=999 → A13 fires with OR-logic showing
  json=84, disk=84 vs expected 999

Deferred with tracking issues
-----------------------------
* Phase 06 worker_threads isolation — #407
* PR template CI enforcement — #408
* VERIFICATION.md + release-notes matrix — #409
* Chaos workflow for pathological inputs — #410
* Mirror init-corpus tarballs to GitHub Releases — #411

What is NOT verified
--------------------
* The CI workflows have never actually executed in a real Actions run.
  YAML syntactically validated via js-yaml, job dependency graph traced,
  but the first real execution is the first push of this branch.
* The canary on a real publish is unexecuted. First execution is the
  first real release after merge.

Refs: #401, #407, #408, #409, #410, #411

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 16:44:27 +00:00
Dragan Spiridonov db99c17c7d feat(init): warn on stale ./vectors.db post hnswlib-node migration (#399)
Prior to ADR-090, NativeHnswBackend wrapped @ruvector/router's
VectorDb, whose constructor unconditionally wrote a `vectors.db`
redb file to the current working directory — outside .agentic-qe/,
in a non-SQLite format, never read by anything in production
(its HNSW search returned wrong answers anyway). Users who upgrade
from a pre-#399 version will have an orphaned multi-MB file in
their project root.

`aqe init` now detects `./vectors.db` in the project root and logs
a one-time warning identifying it as stale from the @ruvector/router
era and suggesting `rm vectors.db` for cleanup.

The phase does NOT auto-delete the file. Per CLAUDE.md data
protection rules, AQE never overwrites, replaces, recreates, or
removes any .db file without explicit user confirmation. Users who
want to clean up run `rm vectors.db` themselves.

Three new unit tests in `tests/unit/init/phases/database-phase.test.ts`:
  - asserts the warning fires when `./vectors.db` is present
  - asserts the warning does not fire when it is absent
  - asserts the phase never calls fs.unlinkSync or fs.rmSync,
    regardless of whether vectors.db exists (data protection guard)

Refs #399, ADR-090.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 18:23:09 +00:00
Dragan Spiridonov ca0c6e7c5e fix: use CLAUDE_PROJECT_DIR for hook paths and remove ruflo permissions from aqe init
Hook commands using relative paths (node ./dist/...) or git rev-parse
broke when invoked from subfolders. Adopted the CLAUDE_PROJECT_DIR
pattern (sh -c 'exec node "${CLAUDE_PROJECT_DIR:-.}/..."') which
Claude Code sets to the project root.

Also: removed ruflo/claude-flow permissions from _aqePermissions
injected by aqe init — only AQE-specific entries belong in user
settings. Fixed init-wizard-hooks.ts missing union-merge for
permissions (#362 parity).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-31 08:04:04 +00:00
Dragan Spiridonov 418d8d9c52 fix(hooks): remove hardcoded absolute paths from generated hook commands (#369)
Hook commands generated by `aqe init` embedded the host machine's absolute
path as a fallback, making settings.json non-portable across machines.
Since Claude Code runs hooks with cwd=project root and the helpers already
use __dirname internally, simple relative paths are sufficient.

Also fixes stale test that asserted on old `permissions` key renamed to
`_aqePermissions` in #362.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-18 17:45:26 +00:00
Dragan Spiridonov 6442491a09 fix: deduplicate brain-checkpoint hooks and fix governance time budget (#344, #345)
Hook deduplication: add brain-checkpoint.cjs and .claude/helpers/ patterns to
AQE_COMMAND_PATTERNS so mergeHooksSmart() correctly identifies them as AQE-owned
and removes old copies on re-init instead of accumulating duplicates.

Governance time budget: change budgetRemaining.timeMs to measure idle time since
last action instead of total elapsed since first action, and increase default
idleTimeoutMs from 5 to 15 minutes. Prevents false "Budget exhausted: time"
blocks on requirements_validate and coverage_analyze_sublinear.

Closes #344, closes #345

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-12 18:51:49 +00:00
Profa e2fb4a2f14 feat(multi-lang): add docs, ADRs, tests, and fixtures for multi-language support
Update ADRs 075-079 with implementation details, revise the
multi-language GOAP implementation plan, add test generators and
parser test fixtures for Go, Rust, Java, C#, Swift, Python.
Include skill validation schema updates and v2→v3 migration skill.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-05 12:00:01 +00:00
Profa 2253d05618 feat: flatten project structure — archive v2, promote v3 to root
Remove the nested v3/ subdirectory by moving all active source code,
tests, configs, and assets directly to the project root. Archive v2/
(dead code, 847MB) to v2-archive.tar.gz.

Key changes:
- Move v3/src/ → src/, v3/tests/ → tests/, v3/packages/ → packages/
- Move v3/tsconfig.json, v3/vitest.config.ts to root
- Merge v3/package.json into root package.json (ESM, scripts, deps, exports)
- Merge v3/scripts/ into scripts/, v3/implementation/ into docs/implementation/
- Update all CI workflows to remove "cd v3 &&" and v3/ path prefixes
- Fix all init installer path resolution (3-level-up → 2-level-up)
- Fix hooks to use "node ./dist/cli/bundle.js" instead of bare "aqe"
- Update settings.json ADR/DDD directories to docs/implementation/
- Fix helper scripts (statusline, adr-compliance, ddd-tracker, guidance-hooks)
- Update 58 agent definitions: aqe/v3/ → aqe/ memory namespaces
- Update 15 guidance shards: v3/src/ → src/ path references
- Fix sync interfaces: remove v3/ and v2/ path references
- Fix test path calculations (process.cwd() + '..' no longer needed)
- Fix flaky perf test threshold (500ms → 1000ms for CI environments)
- Fix complexity-analyzer test to match ADR-051 keyword-based eligibility

Build passes, 17,901 tests pass, CLI and MCP bundles verified.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-01 11:35:41 +00:00