mirror of
https://github.com/personamanagmentlayer/pcl.git
synced 2026-09-14 15:40:22 +08:00
4e07a6a874
* chore(stdlib): add conformance tooling for the skills library
The library had no gate that could express what a valid skill is, so
malformed frontmatter, over-budget files and credential literals went
unnoticed. These scripts define and enforce that contract.
- validate-skills.py: extend with Agent Skills v1.0 conformance -
naming rules and directory agreement, an explicit activation trigger
in the description, canonical layout, the 500-line SKILL.md budget,
relative-link integrity, and two security rules (no unrestricted
Bash(*) grant, no credential literals). Structural checks now read a
skill as a whole so material moved into references/ still counts.
- split-skill-references.py: move the heaviest sections of an oversized
SKILL.md into references/. Verifies line by line that every source
line lands in exactly one output and refuses to write otherwise.
- generate-skill-inventory.py: derive SKILLS_INVENTORY.md and
DIRECTORY_STRUCTURE.md from the tree so they cannot drift.
- generate-skill-catalog.py: index the canonical layout only, count
references/ toward a skill's size, and stop truncating descriptions
at 200 characters - the catalog is the discovery surface and must
carry the activation trigger.
- .gitignore: Python bytecode from these scripts, and local .pcl state.
Reviewed-by: Security Analyst, Compiler Engineer, DevX Engineer
* fix(stdlib): bring all 174 skills to Agent Skills v1.0 conformance
No skill in the library was conformant. 41 of 175 failed the existing
validator outright, and none satisfied the spec. This pass fixes the
tree and records the result. See stdlib/CHANGELOG.md for the per-skill
versioning and migration notes.
BREAKING CHANGE: one skill removed, five moved, seven with a capability
withdrawn. Library version 2.0.0 -> 3.0.0.
Structure
- Convert 71 skills stored as flat files to <category>/<name>/SKILL.md,
the layout the spec requires and the only one able to carry companion
resources.
- Rename 5 directories that disagreed with their declared name:, so
resolution by path and by name stop giving different answers. The
repository docs already referenced the corrected paths.
- Merge the duplicate legal-technology skills into legaltech-expert and
delete legal-tech-expert, carrying over everything the survivor
lacked.
Metadata
- Repair 20 unparseable frontmatters: an H1 preceded the --- block and
the key was skill_id: instead of name:, so any parser reading
frontmatter at offset 0 saw no metadata at all. The objectives,
prerequisites and outcome they carried become real body sections.
- Add the missing version: to 21 skills, fold keywords into tags, move
expertise_level under metadata, and align 10 category: values with
their directory.
Discoverability
- Give all 174 descriptions an explicit "Use when ..." trigger, built
from each skill's own tags and section headings. 152 previously said
only what the skill was about, leaving an agent nothing to match on.
Progressive disclosure
- Split 127 oversized skills, moving bulk material into references/ read
on demand and leaving an index behind. A SKILL.md now averages 277
lines instead of 644 and none exceeds 500. Verified lossless line by
line against the previous revision.
Security
- Withdraw the unrestricted Bash(*) grant from 7 skills; none of the six
non-financial ones contained a single shell command. finance-expert
documents code that charges cards and reads bank accounts, so it now
grants no shell at all.
- Remove credential literals: Stripe keys, two JWT signing keys, an
Express session secret, a Redis password and WiFi credentials, all
inlined in examples. They load from the environment now.
- finance-expert: idempotency keys were documented but absent, so a
retry double-charged; webhook signature failures were not caught, so a
forged event raised uncaught instead of being rejected;
int(amount * 100) truncated fractions of a cent. All fixed, plus a
money-movement guardrails section.
- trading-expert: place_order routed without any pre-trade risk check
although a RiskManager sat unused in the next section. Risk validation
now runs before routing and raises rather than returning a boolean a
caller can ignore; live routing is opt-in.
- Correct an Ansible Vault example that showed plaintext under an
"encrypted" label.
Also fixes 8 broken documentation links and a prematurely closed code
fence in skill-creator-expert that leaked template content into prose.
Per the repository file-organization policy, four stale progress reports
(SKILLS_MANIFEST, COMPLETE_SKILLS_LIBRARY, COMPLETE_LIBRARY_MANIFEST,
PHASE_3_DATA_ANALYTICS) move out of stdlib/ into the gitignored
.roadmap/status/stdlib/; they claimed 31 of 100 skills complete. They
appear here as deletions because .roadmap/ is not tracked.
Reviewed-by: Security Analyst, Language Designer, DevX Engineer,
Documentation Specialist
* fix(skills): resolve standard library skills from their real layout
No stdlib skill was resolvable. SkillResolver looked for
`<stdlibDir>/<name>.md` with stdlibDir defaulting to `stdlib/skills`, a
directory that does not exist, and the path ignored the category level
the library actually uses. The two LSP providers had the same wrong
directory and scanned only one level deep, so neither completion nor
go-to-definition could see a skill either.
- skill-discovery.ts: enumerate skill entry points across the shapes in
use - a flat `<name>.md`, `<name>/SKILL.md`, and
`<category>/<name>/SKILL.md` - while skipping references/, scripts/
and assets/, which hold supporting material rather than entry points.
- skill-resolver.ts: point stdlibDir at `stdlib`, and look the name up
as a directory under any category as well as the two legacy shapes, so
existing custom stdlib directories keep working. The name is used as a
single path segment and rejected if it contains a separator or
traversal, so a reference cannot escape the stdlib root.
- Rewire both LSP providers onto the shared discovery helper.
Tests: 13 new cases covering the layouts, ordering, the references/
exclusion, path-traversal rejection, and an integration test that
resolves real shipped skills by bare name.
Reviewed-by: Compiler Engineer, Runtime Architect, Security Analyst
* feat(stdlib): add 17 skills covering the library's largest gaps
Selection was driven by cross-referencing coverage against observed usage
rather than by intuition: Stack Overflow and GitHub Octoverse data for
which technologies matter, and install rankings on public agent-skill
registries for the shape of skills people actually use.
That comparison found a mismatch of form, not only of coverage. The
most-installed skills in the ecosystem are procedures - tdd, refactoring,
frontend design, browser automation - while all 174 existing skills were
domain knowledge shaped as <domain>-expert. The new workflows/ category
closes that gap and introduces the <activity>-workflow convention.
New category workflows/ (4)
- tdd-workflow, refactoring-workflow, debugging-workflow,
code-review-workflow. code-review-workflow complements rather than
replaces code-review-expert: procedure versus judgement. Merge them if
the split proves confusing in use.
Applied AI (3) - the largest coverage gap
- llm-engineering-expert, rag-expert, agent-engineering-expert.
The library referenced LLMs in tags but covered none of it: pgvector
appeared zero times across 174 skills, LangChain once, MCP twice
despite the repository shipping an MCP integration guide.
Capabilities (2)
- document-processing-expert (PDF, DOCX, XLSX, PPTX in one skill),
browser-automation-expert (a client against third-party sites,
distinct from playwright-expert which tests your own application).
Data (3)
- mysql-expert, the second most used database and previously absent
while rarer stores had skills; analytical-databases-expert;
stream-processing-expert.
Security (3)
- secrets-management-expert, supply-chain-security-expert (OWASP A03
2025), identity-access-expert (OWASP A01).
Interface and meta (2)
- accessibility-expert: design/ held only design-expert, which despite
its name covers software architecture, so WCAG had no home.
- skill-router: find and compose skills across 191, with a
disambiguation table for overlapping pairs.
Grouping by decision context rather than by technology keeps the growth
to 17 skills for roughly 50 topics. Five vector stores live inside
rag-expert; four document formats inside document-processing-expert.
Per-tool depth sits in references/, which the progressive-disclosure work
in 3.0.0 made cheap.
Four further gaps are better served by extending existing skills -
PyTorch and TensorFlow in ml-expert, OpenTelemetry in monitoring-expert,
Pulumi and Crossplane in terraform-expert - and are not in this change.
Library 3.0.0 -> 3.1.0, additive only. Adds the workflows label to the
inventory generator; catalogue, inventory, structure and CHANGELOG
regenerated.
Reviewed-by: Product Strategist, Security Analyst, DevX Engineer,
Documentation Specialist
* fix(test): create test directories with mkdtempSync
CodeQL flagged js/insecure-temporary-file (CWE-377) on both suites.
`join(tmpdir(), <predictable name>)` followed by mkdirSync creates a
world-readable directory at a guessable path, so another local user can
pre-create it or plant a symlink between the name being computed and the
directory being created.
mkdtempSync creates the directory atomically with a random suffix and
0700 permissions, which closes both the disclosure and the race.
One occurrence is new in this branch (skill-discovery); the other
pre-dates it in skill-resolver and is fixed in the same pass rather than
left as a known finding in a file this branch already touches.
12 KiB
12 KiB
name, version, description, category, tags, allowed-tools
| name | version | description | category | tags | allowed-tools | |||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| gdpr-expert | 1.1.0 | Expert in GDPR compliance, data protection, privacy by design, consent management, DPO responsibilities, and EU data regulations. Use when the user mentions privacy, data protection, compliance, consent, a DPO, or eu regulation, or when the task involves GDPR Fundamentals, Key Principles, Data Subject Rights, or Privacy by Design. | security |
|
|
GDPR Expert
You are an expert in GDPR (General Data Protection Regulation) compliance, specializing in data protection, privacy by design, consent management, data subject rights, and DPO responsibilities.
Core Concepts
GDPR Fundamentals
- Lawful Basis: Legal grounds for processing data
- Data Subject Rights: Access, rectification, erasure, portability
- Consent Management: Explicit, informed, freely given
- Data Minimization: Collect only necessary data
- Purpose Limitation: Use data only for stated purposes
- Accountability: Demonstrate compliance
Key Principles (Article 5)
- Lawfulness, Fairness, Transparency: Clear processing
- Purpose Limitation: Specific, explicit purposes
- Data Minimization: Adequate, relevant, limited
- Accuracy: Kept up to date
- Storage Limitation: Retained only as needed
- Integrity and Confidentiality: Secure processing
- Accountability: Controller responsibility
Data Subject Rights
- Right to Access (Article 15): Obtain copy of data
- Right to Rectification (Article 16): Correct inaccurate data
- Right to Erasure (Article 17): "Right to be forgotten"
- Right to Restriction (Article 18): Limit processing
- Right to Portability (Article 20): Transfer data
- Right to Object (Article 21): Object to processing
- Automated Decisions (Article 22): Human intervention
Privacy by Design
- Data Protection by Default: Maximum privacy settings
- Pseudonymization: Separate identity from data
- Encryption: Protect data at rest and in transit
- Access Controls: Role-based permissions
- Privacy Impact Assessments: Risk evaluation
- Data Protection Officers: Oversight and compliance
Code Examples
Consent Management System
# consent_management.py - GDPR-compliant consent tracking
from datetime import datetime, timedelta
from enum import Enum
import json
class ConsentPurpose(Enum):
MARKETING = "marketing"
ANALYTICS = "analytics"
PERSONALIZATION = "personalization"
ESSENTIAL = "essential"
class ConsentManager:
def __init__(self):
self.consents = {}
def record_consent(self, user_id, purpose, metadata):
"""Record user consent with full audit trail."""
consent_record = {
'user_id': user_id,
'purpose': purpose.value,
'status': 'given',
'timestamp': datetime.now().isoformat(),
'expires_at': (datetime.now() + timedelta(days=730)).isoformat(),
'version': '1.0',
'metadata': metadata
}
if user_id not in self.consents:
self.consents[user_id] = {}
self.consents[user_id][purpose.value] = consent_record
self._audit_log('consent_given', consent_record)
return consent_record
def withdraw_consent(self, user_id, purpose):
"""Allow users to withdraw consent easily."""
if user_id in self.consents and purpose.value in self.consents[user_id]:
self.consents[user_id][purpose.value]['status'] = 'withdrawn'
self.consents[user_id][purpose.value]['withdrawn_at'] = datetime.now().isoformat()
self._audit_log('consent_withdrawn', self.consents[user_id][purpose.value])
return True
return False
def check_consent(self, user_id, purpose):
"""Verify valid consent before processing."""
if user_id not in self.consents or purpose.value not in self.consents[user_id]:
return False
consent = self.consents[user_id][purpose.value]
if consent['status'] != 'given':
return False
# Check expiration
expires_at = datetime.fromisoformat(consent['expires_at'])
if datetime.now() > expires_at:
return False
return True
def _audit_log(self, action, record):
"""Maintain audit trail as required by GDPR."""
print(f"GDPR Audit: {action} - {json.dumps(record)}")
Data Subject Access Request Handler
# dsar_handler.py - Handle Article 15 access requests
from datetime import datetime
class DSARHandler:
def __init__(self, data_sources):
self.data_sources = data_sources
def process_access_request(self, user_id):
"""Process right to access within 30 days."""
collected_data = {}
for source in self.data_sources:
collected_data[source.name] = source.get_user_data(user_id)
return {
'user_id': user_id,
'export_date': datetime.now().isoformat(),
'data': collected_data,
'format': 'JSON'
}
def process_erasure_request(self, user_id):
"""Process right to erasure (Article 17)."""
# Check retention obligations
if self._must_retain(user_id):
return {'status': 'partial', 'reason': 'legal_obligation'}
# Delete from all systems
results = {}
for source in self.data_sources:
results[source.name] = source.delete_user_data(user_id)
return {'status': 'completed', 'results': results}
def process_portability_request(self, user_id):
"""Provide data in machine-readable format (Article 20)."""
data = self.process_access_request(user_id)
return json.dumps(data, indent=2)
def _must_retain(self, user_id):
"""Check if legal obligations require retention."""
# Check financial, legal, regulatory requirements
return False
Privacy Impact Assessment
# privacy_impact_assessment.py - DPIA for high-risk processing
class PrivacyImpactAssessment:
def __init__(self, project_name):
self.project_name = project_name
self.data_types = []
self.risks = []
def add_data_type(self, data_type, is_special_category=False):
"""Track what personal data is processed."""
self.data_types.append({
'type': data_type,
'special_category': is_special_category # Article 9 data
})
def assess_risk(self, description, likelihood, impact):
"""Assess privacy risks."""
risk_score = likelihood * impact
self.risks.append({
'description': description,
'likelihood': likelihood,
'impact': impact,
'score': risk_score
})
def requires_dpia(self):
"""Determine if DPIA required (Article 35)."""
# Required for high-risk processing
has_special_data = any(d['special_category'] for d in self.data_types)
has_high_risk = any(r['score'] >= 12 for r in self.risks)
return has_special_data or has_high_risk
def generate_report(self):
"""Generate DPIA report for documentation."""
return {
'project': self.project_name,
'dpia_required': self.requires_dpia(),
'data_types': self.data_types,
'risks': self.risks,
'date': datetime.now().isoformat()
}
Data Retention Policy
# data_retention.py - Implement storage limitation principle
from datetime import datetime, timedelta
class RetentionPolicy:
POLICIES = {
'account_data': 2555, # 7 years (legal requirement)
'transaction_data': 1825, # 5 years (financial records)
'marketing_data': 730, # 2 years (business need)
'analytics_data': 180, # 6 months
'logs': 90 # 90 days
}
@classmethod
def should_delete(cls, data_type, created_at):
"""Check if data exceeds retention period."""
retention_days = cls.POLICIES.get(data_type, 0)
age = (datetime.now() - created_at).days
return age > retention_days
@classmethod
def get_deletion_date(cls, data_type, created_at):
"""Calculate when data should be deleted."""
retention_days = cls.POLICIES.get(data_type, 0)
return created_at + timedelta(days=retention_days)
class DataRetentionManager:
def __init__(self, data_store):
self.data_store = data_store
def scan_and_delete_expired(self):
"""Automatically delete data past retention period."""
deleted_count = 0
for item in self.data_store.get_all():
if RetentionPolicy.should_delete(item.type, item.created_at):
self.data_store.delete(item.id)
deleted_count += 1
self._audit_log(item)
return deleted_count
def _audit_log(self, item):
"""Log deletion for accountability."""
print(f"Deleted {item.type} data - retention period expired")
Best Practices
Compliance Foundation
- Conduct data mapping and inventory
- Document all processing activities (Article 30)
- Implement privacy by design from the start
- Appoint DPO if required (Article 37)
- Establish data breach procedures
- Maintain comprehensive audit trails
Consent Management
- Obtain explicit, informed consent
- Use clear, plain language
- Provide granular options
- Make withdrawal as easy as giving
- Never use pre-ticked boxes
- Refresh expired consents regularly
Data Subject Rights
- Respond within 30 days (one month)
- Verify requester identity
- Provide data in portable format
- Automate DSAR processes
- Train staff on procedures
- Document all requests
Security Measures
- Encrypt data at rest and in transit
- Implement strong access controls
- Use pseudonymization where possible
- Regular security audits
- Incident response plan
- Report breaches within 72 hours
International Transfers
- Use Standard Contractual Clauses (SCCs)
- Conduct Transfer Impact Assessments
- Implement appropriate safeguards
- Document transfer mechanisms
- Review adequacy decisions
- Update processor agreements
Anti-Patterns
Compliance Mistakes
- Treating GDPR as one-time checkbox
- Not documenting processing activities
- Ignoring data subject requests
- Missing breach notification deadlines
- No Data Protection Impact Assessments
- Inadequate staff training
Consent Failures
- Using pre-ticked consent boxes
- Bundling consent with terms
- Not offering granular choices
- Difficult consent withdrawal
- Implied or assumed consent
- Not tracking consent versions
Data Handling Issues
- Collecting excessive data
- Indefinite data retention
- No documented retention policy
- Sharing without legal basis
- Inadequate security measures
- No data minimization
Rights Management
- Slow response to DSARs
- Charging unjustified fees
- Incomplete data exports
- Not verifying identity
- Ignoring erasure requests
- Poor documentation
Organizational Problems
- No DPO when required
- Missing privacy policies
- No breach response plan
- Poor vendor management
- Missing processor agreements
- No privacy training
Resources
Official Documentation
- GDPR Official Text
- European Data Protection Board
- ICO GDPR Guidance
- Article 29 Working Party Guidelines
Implementation Tools
Certifications
- CIPP/E - Certified Information Privacy Professional
- CIPM - Certified Information Privacy Manager
- CIPT - Certified Information Privacy Technologist