mirror of https://github.com/oxc-project/oxc.git synced 2026-09-14 19:36:11 +08:00

Files

T

History

Changsu Seong 116c8b8303 fix(transformer/class-properties): keep private methods in class-expression scope (#26308 )

Private methods lowered from a class expression inside a concise arrow
were inserted next to the arrow's outer statement, while private field
storage remained inside the arrow. Starting with Oxc 0.143, this could
leave the generated helper unable to resolve the private field and throw
a `ReferenceError` at runtime.

Concise arrow bodies have no statement list where the helper declaration
can be inserted. In that context, the helper is now emitted as an
assignment in the class-expression sequence, with its `var` binding
inside the expanded arrow body. Ordinary statement-backed class
expressions keep block-local function declarations so classes created by
repeated block evaluation retain their own captured values. The
generated symbol flags and scope parents match the emitted form in both
cases.

## Example

```js
const makeClass = () => class {
  #field = 41;
  #read() { return this.#field; }
  run() { return this.#read() + 1; }
};

new (makeClass())().run();
```

Before Oxc emitted a helper outside `makeClass`, and the call threw
`ReferenceError: _field is not defined`. After this change it returns
`42`.

Verified with the private-method transform conformance suite, runtime
regressions for concise arrows and repeated block evaluation, `cargo
test -p oxc_transformer`, and transformer clippy.

Fixes the upstream cause of
[rolldown/rolldown#10818](https://github.com/rolldown/rolldown/issues/10818).

AI assistance: Cursor was used for the original patch; OpenAI Codex was
used for follow-up review, fixes, and testing.

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Dunqing <dengqing0821@gmail.com>

2026-09-07 20:47:40 +08:00

overrides

fix(transformer): keep enum IIFE when a non-inlinable value reference remains (#22501 )

2026-05-18 02:19:11 +00:00

snapshots

fix(transformer/class-properties): keep private methods in class-expression scope (#26308 )

2026-09-07 20:47:40 +08:00

src

fix(transformer): avoid filtered exec snapshot updates (#26052 )

2026-08-24 10:44:11 +00:00

tests

fix(transformer/class-properties): keep private methods in class-expression scope (#26308 )

2026-09-07 20:47:40 +08:00

.gitignore

chore(transformer_conformance): only ignore root fixtures directory (#7198 )

2024-11-08 02:36:22 +00:00

Cargo.toml

refactor(ast)!: remove old AstBuilder methods (#24563 )

2026-07-21 15:22:46 +00:00

package.json

chore(deps): update npm packages (major) (#23692 )

2026-06-22 20:08:46 +02:00

README.md

docs(tasks/transform_conformance): update README.md (#22176 )

2026-05-06 08:48:34 +00:00

reporter.mjs

chore(deps): update vitest to v5 (#26299 )

2026-09-03 19:05:05 +00:00

update_fixtures.ts

chore(oxfmt): dogfood operator position at line start (#25937 )

2026-08-20 14:36:47 +00:00

README.md

Transformation Conformance Test Runner

Execution

This test runner uses the transformation plugin test suite from the Babel repository.

Additional tests are in the tests directory.

The failing test cases are listed in:

To get started, run

cargo run -p oxc_transform_conformance

or watch for changes

just watch 'cargo run -p oxc_transform_conformance'

Options

--filter

To filter for a specific test case, apply the --filter path option, e.g.

cargo run -p oxc_transform_conformance -- --filter react/arrow-functions

--exec

The Babel test suite contains many exec.js files, which need to be executed by a runtime.

These tests are executed with Node.js and Vitest. Apply the --exec flag:

cargo run -p oxc_transform_conformance -- --exec

This is also available as:

just test-transform

The failing test cases are listed in: