mirror of
https://github.com/oxc-project/oxc.git
synced 2026-09-14 19:36:11 +08:00
Boshen
6efce65746
## Summary `oxc_react_compiler` had no committed test over the upstream React Compiler fixture corpus — the fixtures lived only in the `oxc-project/forked-react-compiler` checkout, exercised out-of-tree. That gap let real regressions slip past the 15 in-crate integration tests. This PR closes it. - **`crates/oxc_react_compiler/fixtures/`** — 1734 fixture *input* files (`.js`/`.ts`/`.tsx`/`.jsx`/`.mjs`), copied from the fork's `babel-plugin-react-compiler/src/__tests__/fixtures/compiler` tree with subdirectories preserved. Flow fixtures (the `@flow`-pragma ones) are excluded — oxc has no Flow parser. The upstream `.expect.md` goldens are also not copied; insta is the golden here. - **`crates/oxc_react_compiler/tests/snapshot.rs`** — an `insta::glob!` test that, per fixture, derives `PluginOptions`/`EnvironmentConfig` from the first-line `// @directive` pragmas (base `compilationMode=all` / `panicThreshold=all_errors`, matching the upstream `snap` runner), parses → builds semantic → runs `transform`, and snapshots the compiled output plus diagnostics. Unrecognised directives are ignored, as upstream does; camelCase flag directives map to `EnvironmentConfig` fields via `convert_case`. - **`crates/oxc_react_compiler/tests/snapshots/`** — 1734 committed `.snap` goldens (oxc's own output). - **`.typos.toml`** — excludes the fixtures dir (the upstream fixtures contain intentional typos; `**/*.snap` was already excluded). These snapshots are oxc's own golden output, so `cargo test` (and CI) now catches any change in compiler behaviour across the corpus. Regenerate after an intended change with `cargo insta accept`. ## Verification - `cargo test -p oxc_react_compiler` passes — the 1734-fixture snapshot test plus the existing 15 integration tests; also green under `--all-features` (matches the cross-target CI job). - clippy `-D warnings`, `cargo fmt`, and `typos` clean. - No fixture panics; 1336 compiled / 398 unchanged / 335 with diagnostics. - The `error.*` fixtures capture the exact diagnostics — including the "Cannot reassign variable after render" error that a recent scoping change had silently suppressed, confirming the suite catches real regressions. --- AI usage disclosure: authored with Claude Code and reviewed before submission. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
51 lines
1.7 KiB
Plaintext
51 lines
1.7 KiB
Plaintext
---
|
|
source: crates/oxc_react_compiler/tests/snapshot.rs
|
|
input_file: crates/oxc_react_compiler/fixtures/aliased-nested-scope-fn-expr.tsx
|
|
---
|
|
import { c as _c } from "react/compiler-runtime";
|
|
// @enableTransitivelyFreezeFunctionExpressions:false
|
|
import { Stringify, mutate, identity, setPropertyByKey, shallowCopy } from "shared-runtime";
|
|
/**
|
|
* Function expression version of `aliased-nested-scope-truncated-dep`.
|
|
*
|
|
* In this fixture, the output would be invalid if propagateScopeDeps did not
|
|
* avoid adding MemberExpression dependencies which would other evaluate during
|
|
* the mutable ranges of their base objects.
|
|
* This is different from `aliased-nested-scope-truncated-dep` which *does*
|
|
* produce correct output regardless of MemberExpression dependency truncation.
|
|
*
|
|
* Note while other expressions evaluate inline, function expressions *always*
|
|
* represent deferred evaluation. This means that
|
|
* (1) it's always safe to reorder function expression creation until its
|
|
* earliest potential invocation
|
|
* (2) it's invalid to eagerly evaluate function expression dependencies during
|
|
* their respective mutable ranges.
|
|
*/
|
|
function Component(t0) {
|
|
const $ = _c(2);
|
|
const { prop } = t0;
|
|
let t1;
|
|
if ($[0] !== prop) {
|
|
const obj = shallowCopy(prop);
|
|
const aliasedObj = identity(obj);
|
|
const getId = () => obj.id;
|
|
mutate(aliasedObj);
|
|
setPropertyByKey(aliasedObj, "id", prop.id + 1);
|
|
t1 = <Stringify getId={getId} shouldInvokeFns={true} />;
|
|
$[0] = prop;
|
|
$[1] = t1;
|
|
} else {
|
|
t1 = $[1];
|
|
}
|
|
return t1;
|
|
}
|
|
export const FIXTURE_ENTRYPOINT = {
|
|
fn: Component,
|
|
params: [{ prop: { id: 1 } }],
|
|
sequentialRenders: [
|
|
{ prop: { id: 1 } },
|
|
{ prop: { id: 1 } },
|
|
{ prop: { id: 2 } }
|
|
]
|
|
};
|