Files
oxc-project__oxc/crates/oxc_react_compiler/fixtures/mutation-within-jsx.tsx
Boshen 6efce65746 test(react_compiler): snapshot the upstream fixture corpus (#24101)
## Summary

`oxc_react_compiler` had no committed test over the upstream React
Compiler fixture corpus — the fixtures lived only in the
`oxc-project/forked-react-compiler` checkout, exercised out-of-tree.
That gap let real regressions slip past the 15 in-crate integration
tests. This PR closes it.

- **`crates/oxc_react_compiler/fixtures/`** — 1734 fixture *input* files
(`.js`/`.ts`/`.tsx`/`.jsx`/`.mjs`), copied from the fork's
`babel-plugin-react-compiler/src/__tests__/fixtures/compiler` tree with
subdirectories preserved. Flow fixtures (the `@flow`-pragma ones) are
excluded — oxc has no Flow parser. The upstream `.expect.md` goldens are
also not copied; insta is the golden here.
- **`crates/oxc_react_compiler/tests/snapshot.rs`** — an `insta::glob!`
test that, per fixture, derives `PluginOptions`/`EnvironmentConfig` from
the first-line `// @directive` pragmas (base `compilationMode=all` /
`panicThreshold=all_errors`, matching the upstream `snap` runner),
parses → builds semantic → runs `transform`, and snapshots the compiled
output plus diagnostics. Unrecognised directives are ignored, as
upstream does; camelCase flag directives map to `EnvironmentConfig`
fields via `convert_case`.
- **`crates/oxc_react_compiler/tests/snapshots/`** — 1734 committed
`.snap` goldens (oxc's own output).
- **`.typos.toml`** — excludes the fixtures dir (the upstream fixtures
contain intentional typos; `**/*.snap` was already excluded).

These snapshots are oxc's own golden output, so `cargo test` (and CI)
now catches any change in compiler behaviour across the corpus.
Regenerate after an intended change with `cargo insta accept`.

## Verification

- `cargo test -p oxc_react_compiler` passes — the 1734-fixture snapshot
test plus the existing 15 integration tests; also green under
`--all-features` (matches the cross-target CI job).
- clippy `-D warnings`, `cargo fmt`, and `typos` clean.
- No fixture panics; 1336 compiled / 398 unchanged / 335 with
diagnostics.
- The `error.*` fixtures capture the exact diagnostics — including the
"Cannot reassign variable after render" error that a recent scoping
change had silently suppressed, confirming the suite catches real
regressions.

---

AI usage disclosure: authored with Claude Code and reviewed before
submission.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
2026-07-03 16:49:53 +08:00

53 lines
1.9 KiB
TypeScript

import {
Stringify,
makeObject_Primitives,
mutateAndReturn,
} from 'shared-runtime';
/**
* In this example, the `<Stringify ... />` JSX block mutates then captures obj.
* As JSX expressions freeze their values, we know that `obj` and `myDiv` cannot
* be mutated past this.
* This set of mutable range + scopes is an edge case because the JSX expression
* references values in two scopes.
* - (freeze) the result of `mutateAndReturn`
* this is a mutable value with a mutable range starting at `makeObject()`
* - (mutate) the lvalue storing the result of `<Stringify .../>`
* this is a immutable value and so gets assigned a different scope
*
* obj@0 = makeObj(); ⌝ scope@0
* if (cond) { |
* $1@0 = mutate(obj@0); |
* myDiv@1 = JSX $1@0 <- scope@1 |
* } ⌟
*
* Coincidentally, the range of `obj` is extended by alignScopesToBlocks to *past*
* the end of the JSX instruction. As we currently alias identifier mutableRanges to
* scope ranges, this `freeze` reference is perceived as occurring during the mutable
* range of `obj` (even though it is after the last mutating reference).
*
* This case is technically safe as `myDiv` correctly takes `obj` as a dependency. As
* a result, developers can never observe myDiv can aliasing a different value generation
* than `obj` (e.g. the invariant `myDiv.props.value === obj` always holds).
*/
function useFoo({data}) {
let obj = null;
let myDiv = null;
if (data.cond) {
obj = makeObject_Primitives();
if (data.cond1) {
myDiv = <Stringify value={mutateAndReturn(obj)} />;
}
}
return myDiv;
}
export const FIXTURE_ENTRYPOINT = {
fn: useFoo,
params: [{data: {cond: true, cond1: true}}],
sequentialRenders: [
{data: {cond: true, cond1: true}},
{data: {cond: true, cond1: true}},
],
};