mirror of
https://github.com/oxc-project/oxc.git
synced 2026-09-14 19:36:11 +08:00
6efce65746
## Summary `oxc_react_compiler` had no committed test over the upstream React Compiler fixture corpus — the fixtures lived only in the `oxc-project/forked-react-compiler` checkout, exercised out-of-tree. That gap let real regressions slip past the 15 in-crate integration tests. This PR closes it. - **`crates/oxc_react_compiler/fixtures/`** — 1734 fixture *input* files (`.js`/`.ts`/`.tsx`/`.jsx`/`.mjs`), copied from the fork's `babel-plugin-react-compiler/src/__tests__/fixtures/compiler` tree with subdirectories preserved. Flow fixtures (the `@flow`-pragma ones) are excluded — oxc has no Flow parser. The upstream `.expect.md` goldens are also not copied; insta is the golden here. - **`crates/oxc_react_compiler/tests/snapshot.rs`** — an `insta::glob!` test that, per fixture, derives `PluginOptions`/`EnvironmentConfig` from the first-line `// @directive` pragmas (base `compilationMode=all` / `panicThreshold=all_errors`, matching the upstream `snap` runner), parses → builds semantic → runs `transform`, and snapshots the compiled output plus diagnostics. Unrecognised directives are ignored, as upstream does; camelCase flag directives map to `EnvironmentConfig` fields via `convert_case`. - **`crates/oxc_react_compiler/tests/snapshots/`** — 1734 committed `.snap` goldens (oxc's own output). - **`.typos.toml`** — excludes the fixtures dir (the upstream fixtures contain intentional typos; `**/*.snap` was already excluded). These snapshots are oxc's own golden output, so `cargo test` (and CI) now catches any change in compiler behaviour across the corpus. Regenerate after an intended change with `cargo insta accept`. ## Verification - `cargo test -p oxc_react_compiler` passes — the 1734-fixture snapshot test plus the existing 15 integration tests; also green under `--all-features` (matches the cross-target CI job). - clippy `-D warnings`, `cargo fmt`, and `typos` clean. - No fixture panics; 1336 compiled / 398 unchanged / 335 with diagnostics. - The `error.*` fixtures capture the exact diagnostics — including the "Cannot reassign variable after render" error that a recent scoping change had silently suppressed, confirming the suite catches real regressions. --- AI usage disclosure: authored with Claude Code and reviewed before submission. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
60 lines
1.8 KiB
JavaScript
60 lines
1.8 KiB
JavaScript
import {
|
|
arrayPush,
|
|
identity,
|
|
makeArray,
|
|
Stringify,
|
|
useFragment,
|
|
} from 'shared-runtime';
|
|
|
|
/**
|
|
* Bug repro showing why it's invalid for function references to be annotated
|
|
* with a `Read` effect when that reference might lead to the function being
|
|
* invoked.
|
|
*
|
|
* Note that currently, `Array.map` is annotated to have `Read` effects on its
|
|
* operands. This is incorrect as function effects must be replayed when `map`
|
|
* is called
|
|
* - Read: non-aliasing data dependency
|
|
* - Capture: maybe-aliasing data dependency
|
|
* - ConditionallyMutate: maybe-aliasing data dependency; maybe-write / invoke
|
|
* but only if the value is mutable
|
|
*
|
|
* Invalid evaluator result: Found differences in evaluator results Non-forget
|
|
* (expected): (kind: ok)
|
|
* <div>{"x":[2,2,2],"count":3}</div><div>{"item":1}</div>
|
|
* <div>{"x":[2,2,2],"count":4}</div><div>{"item":1}</div>
|
|
* Forget:
|
|
* (kind: ok)
|
|
* <div>{"x":[2,2,2],"count":3}</div><div>{"item":1}</div>
|
|
* <div>{"x":[2,2,2,2,2,2],"count":4}</div><div>{"item":1}</div>
|
|
*/
|
|
|
|
function Component({extraJsx}) {
|
|
const x = makeArray();
|
|
const items = useFragment();
|
|
// This closure has the following effects that must be replayed:
|
|
// - MaybeFreeze / Capture of `items`
|
|
// - ConditionalMutate of x
|
|
const jsx = items.a.map((item, i) => {
|
|
arrayPush(x, 2);
|
|
return <Stringify item={item} key={i} />;
|
|
});
|
|
const offset = jsx.length;
|
|
for (let i = 0; i < extraJsx; i++) {
|
|
jsx.push(<Stringify item={0} key={i + offset} />);
|
|
}
|
|
const count = jsx.length;
|
|
identity(count);
|
|
return (
|
|
<>
|
|
<Stringify x={x} count={count} />
|
|
{jsx[0]}
|
|
</>
|
|
);
|
|
}
|
|
export const FIXTURE_ENTRYPOINT = {
|
|
fn: Component,
|
|
params: [{extraJsx: 0}],
|
|
sequentialRenders: [{extraJsx: 0}, {extraJsx: 1}],
|
|
};
|