mirror of
https://github.com/oxc-project/oxc.git
synced 2026-09-14 19:36:11 +08:00
777f02ae10
## Summary Introduces `oxc_diagnostics::Diagnostics` — a `Vec<OxcDiagnostic>` newtype that knows the difference between errors and warnings — and makes it the standard diagnostics return value across oxc. - **New type**: `Diagnostics` with `has_errors()`, `has_warnings()`, `errors()`, `warnings()`, plus `Vec`-like ergonomics (Deref, `IntoIterator`, `Extend`, `From`/`Into<Vec>`) so most call sites are unchanged. - **Return types**: `ParserReturn`, `SemanticBuilderReturn`, `IsolatedDeclarationsReturn`, the React Compiler `TransformResult`/`LintResult`, and `TransformerReturn` now expose `diagnostics: Diagnostics` instead of `errors: Vec<OxcDiagnostic>` (the React Compiler's separate `errors`/`warnings` are merged into one severity-tagged list). - **Behaviour**: a React Compiler **error** now stops the transform (no output), while **warnings** flow through and the transform continues. `compile()` aborts codegen only when `diagnostics.has_errors()` — warnings alone no longer abort (previously any diagnostic did). ## Breaking change Consumers reading `*.errors` on these return values must read `*.diagnostics`. React Compiler consumers that read `.errors`/`.warnings` separately should use `diagnostics.has_errors()` / `diagnostics.errors()` / `diagnostics.warnings()`. Parser/semantic/isolated-declarations fatality is otherwise unchanged. Builds on the React Compiler transform feature (#23201). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
44 lines
1.8 KiB
Rust
44 lines
1.8 KiB
Rust
use oxc_allocator::Allocator;
|
|
use oxc_benchmark::{BenchmarkId, Criterion, black_box, criterion_group, criterion_main};
|
|
use oxc_parser::Parser;
|
|
use oxc_semantic::SemanticBuilder;
|
|
use oxc_tasks_common::TestFiles;
|
|
|
|
fn bench_semantic(criterion: &mut Criterion) {
|
|
let mut group = criterion.benchmark_group("semantic");
|
|
for file in TestFiles::minimal().files() {
|
|
let id = BenchmarkId::from_parameter(&file.file_name);
|
|
let source_text = &file.source_text;
|
|
let source_type = file.source_type;
|
|
|
|
// Create `Allocator` outside of `bench_function`, so same allocator is used for
|
|
// both the warmup and measurement phases
|
|
let mut allocator = Allocator::default();
|
|
|
|
group.bench_function(id, |b| {
|
|
b.iter_with_setup_wrapper(|runner| {
|
|
// Reset allocator at start of each iteration
|
|
allocator.reset();
|
|
|
|
// Create fresh AST for each iteration, as `SemanticBuilder` alters the AST
|
|
let program = Parser::new(&allocator, source_text, source_type).parse().program;
|
|
let program = black_box(program);
|
|
|
|
runner.run(|| {
|
|
// We drop `Semantic` inside this closure as drop time is part of cost of using this API.
|
|
// We return `errors` to be dropped outside of the measured section, as usually
|
|
// real-world code has no errors, so allocating and dropping them is atypical and
|
|
// we don't want to include it in benchmark time.
|
|
let ret = SemanticBuilder::new_compiler().build(&program);
|
|
let ret = black_box(ret);
|
|
ret.diagnostics
|
|
});
|
|
});
|
|
});
|
|
}
|
|
group.finish();
|
|
}
|
|
|
|
criterion_group!(semantic, bench_semantic);
|
|
criterion_main!(semantic);
|