Files
Boshen 777f02ae10 refactor(diagnostics)!: return a Diagnostics type instead of Vec<OxcDiagnostic> (#23217)
## Summary

Introduces `oxc_diagnostics::Diagnostics` — a `Vec<OxcDiagnostic>` newtype that knows the difference between errors and warnings — and makes it the standard diagnostics return value across oxc.

- **New type**: `Diagnostics` with `has_errors()`, `has_warnings()`, `errors()`, `warnings()`, plus `Vec`-like ergonomics (Deref, `IntoIterator`, `Extend`, `From`/`Into<Vec>`) so most call sites are unchanged.
- **Return types**: `ParserReturn`, `SemanticBuilderReturn`, `IsolatedDeclarationsReturn`, the React Compiler `TransformResult`/`LintResult`, and `TransformerReturn` now expose `diagnostics: Diagnostics` instead of `errors: Vec<OxcDiagnostic>` (the React Compiler's separate `errors`/`warnings` are merged into one severity-tagged list).
- **Behaviour**: a React Compiler **error** now stops the transform (no output), while **warnings** flow through and the transform continues. `compile()` aborts codegen only when `diagnostics.has_errors()` — warnings alone no longer abort (previously any diagnostic did).

## Breaking change

Consumers reading `*.errors` on these return values must read `*.diagnostics`. React Compiler consumers that read `.errors`/`.warnings` separately should use `diagnostics.has_errors()` / `diagnostics.errors()` / `diagnostics.warnings()`.

Parser/semantic/isolated-declarations fatality is otherwise unchanged. Builds on the React Compiler transform feature (#23201).

🤖 Generated with [Claude Code](https://claude.com/claude-code)
2026-06-10 14:46:52 +00:00

48 lines
1.7 KiB
Rust

use std::path::{Path, PathBuf};
use oxc_allocator::Allocator;
use oxc_benchmark::{BenchmarkId, Criterion, criterion_group, criterion_main};
use oxc_codegen::{Codegen, CodegenOptions};
use oxc_parser::Parser;
use oxc_semantic::SemanticBuilder;
use oxc_tasks_common::TestFiles;
use oxc_transformer::{TransformOptions, Transformer};
fn bench_codegen(criterion: &mut Criterion) {
for file in TestFiles::minimal().files() {
let id = BenchmarkId::from_parameter(&file.file_name);
let source_text = &file.source_text;
let source_type = file.source_type;
let allocator = Allocator::default();
let parser_ret = Parser::new(&allocator, source_text, source_type).parse();
assert!(parser_ret.diagnostics.is_empty());
let mut program = parser_ret.program;
let scoping =
SemanticBuilder::new().with_enum_eval(true).build(&program).semantic.into_scoping();
let transform_options = TransformOptions::enable_all();
let transformer_ret =
Transformer::new(&allocator, Path::new(&file.file_name), &transform_options)
.build_with_scoping(scoping, &mut program);
assert!(transformer_ret.diagnostics.is_empty());
let mut group = criterion.benchmark_group("codegen");
group.bench_function(id, |b| {
b.iter_with_large_drop(|| {
Codegen::new()
.with_options(CodegenOptions {
source_map_path: Some(PathBuf::from(&file.file_name)),
..CodegenOptions::default()
})
.build(&program)
});
});
group.finish();
}
}
criterion_group!(codegen, bench_codegen);
criterion_main!(codegen);