overlookmotel 6c5ad1b723 fix(codegen): only add mapping names for PrivateIdentifiers which have changed (#25958) ...

A `PrivateIdentifier`'s span includes the leading `#`, but the `name` the AST holds does not.

The source map name was read from the whole span and then compared to `name` from AST, so the check which omits the mapping's `name` when it wasn't renamed compared `#foo` against `foo`. It never matched, so a named mapping was created for _every_ private identifier, renamed or not.

This PR fixes that in both Rust `oxc_codegen` and JS `oxc-codegen`, by comparing correctly including the `#`.

This also makes mapping names correct when a normal `Identifier` has been replaced with a `PrivateIdentifier` (`this.foo` -> `this.#foo)`, or vice-versa (`this.#foo` -> `this.foo`). New tests cover both directions.

2026-08-21 14:08:12 +00:00

..

snapshots

fix(codegen): escape sources for empty import specifiers (#25586)

2026-08-13 11:26:56 +00:00

comments.rs

fix(codegen): preserve property key annotations (#25766)

2026-08-17 09:23:04 +00:00

esbuild.rs

fix(codegen): don't emit space between postfix -- and > when minifying (#23036)

2026-06-07 02:52:51 +00:00

js.rs

fix(codegen): escape sources for empty import specifiers (#25586)

2026-08-13 11:26:56 +00:00

main.rs

feat(codegen): add sourcemap feature flag (#17305)

2025-12-23 10:28:49 +00:00

sourcemap.rs

fix(codegen): only add mapping names for PrivateIdentifiers which have changed (#25958)

2026-08-21 14:08:12 +00:00

tester.rs

perf(codegen)!: borrow sourcemaps from codegen (#23422)

2026-06-15 19:07:21 +08:00

ts.rs

fix(codegen): output newline after export default interface (#25487)

2026-08-11 08:01:54 +00:00