mirror of
https://github.com/oxc-project/oxc.git
synced 2026-09-14 19:36:11 +08:00
Boshen
6efce65746
## Summary `oxc_react_compiler` had no committed test over the upstream React Compiler fixture corpus — the fixtures lived only in the `oxc-project/forked-react-compiler` checkout, exercised out-of-tree. That gap let real regressions slip past the 15 in-crate integration tests. This PR closes it. - **`crates/oxc_react_compiler/fixtures/`** — 1734 fixture *input* files (`.js`/`.ts`/`.tsx`/`.jsx`/`.mjs`), copied from the fork's `babel-plugin-react-compiler/src/__tests__/fixtures/compiler` tree with subdirectories preserved. Flow fixtures (the `@flow`-pragma ones) are excluded — oxc has no Flow parser. The upstream `.expect.md` goldens are also not copied; insta is the golden here. - **`crates/oxc_react_compiler/tests/snapshot.rs`** — an `insta::glob!` test that, per fixture, derives `PluginOptions`/`EnvironmentConfig` from the first-line `// @directive` pragmas (base `compilationMode=all` / `panicThreshold=all_errors`, matching the upstream `snap` runner), parses → builds semantic → runs `transform`, and snapshots the compiled output plus diagnostics. Unrecognised directives are ignored, as upstream does; camelCase flag directives map to `EnvironmentConfig` fields via `convert_case`. - **`crates/oxc_react_compiler/tests/snapshots/`** — 1734 committed `.snap` goldens (oxc's own output). - **`.typos.toml`** — excludes the fixtures dir (the upstream fixtures contain intentional typos; `**/*.snap` was already excluded). These snapshots are oxc's own golden output, so `cargo test` (and CI) now catches any change in compiler behaviour across the corpus. Regenerate after an intended change with `cargo insta accept`. ## Verification - `cargo test -p oxc_react_compiler` passes — the 1734-fixture snapshot test plus the existing 15 integration tests; also green under `--all-features` (matches the cross-target CI job). - clippy `-D warnings`, `cargo fmt`, and `typos` clean. - No fixture panics; 1336 compiled / 398 unchanged / 335 with diagnostics. - The `error.*` fixtures capture the exact diagnostics — including the "Cannot reassign variable after render" error that a recent scoping change had silently suppressed, confirming the suite catches real regressions. --- AI usage disclosure: authored with Claude Code and reviewed before submission. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
124 lines
2.4 KiB
Plaintext
124 lines
2.4 KiB
Plaintext
---
|
|
source: crates/oxc_react_compiler/tests/snapshot.rs
|
|
input_file: crates/oxc_react_compiler/fixtures/nested-optional-chains.ts
|
|
---
|
|
import { c as _c } from "react/compiler-runtime";
|
|
import { identity } from "shared-runtime";
|
|
/**
|
|
* identity(...)?.toString() is the outer optional, and prop?.value is the inner
|
|
* one.
|
|
* Note that prop?.
|
|
*/
|
|
function useFoo(t0) {
|
|
const $ = _c(15);
|
|
const { prop1, prop2, prop3, prop4, prop5, prop6 } = t0;
|
|
let t1;
|
|
if ($[0] !== prop1?.value) {
|
|
t1 = identity(prop1?.value)?.toString();
|
|
$[0] = prop1?.value;
|
|
$[1] = t1;
|
|
} else {
|
|
t1 = $[1];
|
|
}
|
|
const x = t1;
|
|
let t2;
|
|
if ($[2] !== prop2?.inner.value) {
|
|
t2 = identity(prop2?.inner.value)?.toString();
|
|
$[2] = prop2?.inner.value;
|
|
$[3] = t2;
|
|
} else {
|
|
t2 = $[3];
|
|
}
|
|
const y = t2;
|
|
let t3;
|
|
if ($[4] !== prop3 || $[5] !== prop4?.inner) {
|
|
t3 = prop3?.fn(prop4?.inner.value).toString();
|
|
$[4] = prop3;
|
|
$[5] = prop4?.inner;
|
|
$[6] = t3;
|
|
} else {
|
|
t3 = $[6];
|
|
}
|
|
const z = t3;
|
|
let t4;
|
|
if ($[7] !== prop5 || $[8] !== prop6?.inner) {
|
|
t4 = prop5?.fn(prop6?.inner.value)?.toString();
|
|
$[7] = prop5;
|
|
$[8] = prop6?.inner;
|
|
$[9] = t4;
|
|
} else {
|
|
t4 = $[9];
|
|
}
|
|
const zz = t4;
|
|
let t5;
|
|
if ($[10] !== x || $[11] !== y || $[12] !== z || $[13] !== zz) {
|
|
t5 = [
|
|
x,
|
|
y,
|
|
z,
|
|
zz
|
|
];
|
|
$[10] = x;
|
|
$[11] = y;
|
|
$[12] = z;
|
|
$[13] = zz;
|
|
$[14] = t5;
|
|
} else {
|
|
t5 = $[14];
|
|
}
|
|
return t5;
|
|
}
|
|
export const FIXTURE_ENTRYPOINT = {
|
|
fn: useFoo,
|
|
params: [{
|
|
prop1: null,
|
|
prop2: null,
|
|
prop3: null,
|
|
prop4: null,
|
|
prop5: null,
|
|
prop6: null
|
|
}],
|
|
sequentialRenders: [
|
|
{
|
|
prop1: null,
|
|
prop2: null,
|
|
prop3: null,
|
|
prop4: null,
|
|
prop5: null,
|
|
prop6: null
|
|
},
|
|
{
|
|
prop1: { value: 2 },
|
|
prop2: { inner: { value: 3 } },
|
|
prop3: { fn: identity },
|
|
prop4: { inner: { value: 4 } },
|
|
prop5: { fn: identity },
|
|
prop6: { inner: { value: 4 } }
|
|
},
|
|
{
|
|
prop1: { value: 2 },
|
|
prop2: { inner: { value: 3 } },
|
|
prop3: { fn: identity },
|
|
prop4: { inner: { value: 4 } },
|
|
prop5: { fn: identity },
|
|
prop6: { inner: { value: undefined } }
|
|
},
|
|
{
|
|
prop1: { value: 2 },
|
|
prop2: { inner: { value: undefined } },
|
|
prop3: { fn: identity },
|
|
prop4: { inner: { value: undefined } },
|
|
prop5: { fn: identity },
|
|
prop6: { inner: { value: undefined } }
|
|
},
|
|
{
|
|
prop1: { value: 2 },
|
|
prop2: {},
|
|
prop3: { fn: identity },
|
|
prop4: {},
|
|
prop5: { fn: identity },
|
|
prop6: { inner: { value: undefined } }
|
|
}
|
|
]
|
|
};
|