mirror of
https://github.com/oxc-project/oxc.git
synced 2026-09-14 19:36:11 +08:00
Boshen
6efce65746
## Summary `oxc_react_compiler` had no committed test over the upstream React Compiler fixture corpus — the fixtures lived only in the `oxc-project/forked-react-compiler` checkout, exercised out-of-tree. That gap let real regressions slip past the 15 in-crate integration tests. This PR closes it. - **`crates/oxc_react_compiler/fixtures/`** — 1734 fixture *input* files (`.js`/`.ts`/`.tsx`/`.jsx`/`.mjs`), copied from the fork's `babel-plugin-react-compiler/src/__tests__/fixtures/compiler` tree with subdirectories preserved. Flow fixtures (the `@flow`-pragma ones) are excluded — oxc has no Flow parser. The upstream `.expect.md` goldens are also not copied; insta is the golden here. - **`crates/oxc_react_compiler/tests/snapshot.rs`** — an `insta::glob!` test that, per fixture, derives `PluginOptions`/`EnvironmentConfig` from the first-line `// @directive` pragmas (base `compilationMode=all` / `panicThreshold=all_errors`, matching the upstream `snap` runner), parses → builds semantic → runs `transform`, and snapshots the compiled output plus diagnostics. Unrecognised directives are ignored, as upstream does; camelCase flag directives map to `EnvironmentConfig` fields via `convert_case`. - **`crates/oxc_react_compiler/tests/snapshots/`** — 1734 committed `.snap` goldens (oxc's own output). - **`.typos.toml`** — excludes the fixtures dir (the upstream fixtures contain intentional typos; `**/*.snap` was already excluded). These snapshots are oxc's own golden output, so `cargo test` (and CI) now catches any change in compiler behaviour across the corpus. Regenerate after an intended change with `cargo insta accept`. ## Verification - `cargo test -p oxc_react_compiler` passes — the 1734-fixture snapshot test plus the existing 15 integration tests; also green under `--all-features` (matches the cross-target CI job). - clippy `-D warnings`, `cargo fmt`, and `typos` clean. - No fixture panics; 1336 compiled / 398 unchanged / 335 with diagnostics. - The `error.*` fixtures capture the exact diagnostics — including the "Cannot reassign variable after render" error that a recent scoping change had silently suppressed, confirming the suite catches real regressions. --- AI usage disclosure: authored with Claude Code and reviewed before submission. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
67 lines
1.9 KiB
TypeScript
67 lines
1.9 KiB
TypeScript
import {mutate} from 'shared-runtime';
|
|
/**
|
|
* Fixture showing that it's not sufficient to only align direct scoped
|
|
* accesses of a block-fallthrough pair.
|
|
* Below is a simplified view of HIR blocks in this fixture.
|
|
* Note that here, s is mutated in both bb1 and bb4. However, neither
|
|
* bb1 nor bb4 have terminal fallthroughs or are fallthroughs themselves.
|
|
*
|
|
* This means that we need to recursively visit all scopes accessed between
|
|
* a block and its fallthrough and extend the range of those scopes which overlap
|
|
* with an active block/fallthrough pair,
|
|
*
|
|
* bb0
|
|
* ┌──────────────┐
|
|
* │let s = null │
|
|
* │test cond1 │
|
|
* │ <fallthr=bb3>│
|
|
* └┬─────────────┘
|
|
* │ bb1
|
|
* ├─►┌───────┐
|
|
* │ │s = {} ├────┐
|
|
* │ └───────┘ │
|
|
* │ bb2 │
|
|
* └─►┌───────┐ │
|
|
* │return;│ │
|
|
* └───────┘ │
|
|
* bb3 │
|
|
* ┌──────────────┐◄┘
|
|
* │test cond2 │
|
|
* │ <fallthr=bb5>│
|
|
* └┬─────────────┘
|
|
* │ bb4
|
|
* ├─►┌─────────┐
|
|
* │ │mutate(s)├─┐
|
|
* ▼ └─────────┘ │
|
|
* bb5 │
|
|
* ┌───────────┐ │
|
|
* │return s; │◄──┘
|
|
* └───────────┘
|
|
*/
|
|
function useFoo({cond1, cond2}) {
|
|
let s = null;
|
|
if (cond1) {
|
|
s = {};
|
|
} else {
|
|
return null;
|
|
}
|
|
|
|
if (cond2) {
|
|
mutate(s);
|
|
}
|
|
|
|
return s;
|
|
}
|
|
|
|
export const FIXTURE_ENTRYPOINT = {
|
|
fn: useFoo,
|
|
params: [{cond1: true, cond2: false}],
|
|
sequentialRenders: [
|
|
{cond1: true, cond2: false},
|
|
{cond1: true, cond2: false},
|
|
{cond1: true, cond2: true},
|
|
{cond1: true, cond2: true},
|
|
{cond1: false, cond2: true},
|
|
],
|
|
};
|