mirror of
https://github.com/openprose/prose.git
synced 2026-09-19 05:55:05 +08:00
dan
ddc7736ec5
* fix(cli): typecheck repository-reactor-bridge test against branded Receipt fields #106 hard-branded the reactor Receipt identity fields (node: NodeId, contract_fingerprint / fingerprints: Fingerprint) and added this bridge test in the same commit, constructing the Receipt fixture from raw strings — so the test was born failing tsc. CLI Release Check only runs on tools/cli + release-script paths and main has no required checks, so #106 merged with the typecheck red and it stayed hidden (no cli-path change re-ran the check) until a release-infra PR surfaced it. Author the fixture with the same brand constructors the production bridge uses (asNodeId / asFingerprint from @openprose/reactor/internals). The constructors are identity-at-runtime brands, so behavior is unchanged: the affected test passes 10/10 and tsc is clean. Note: this unmasks a SEPARATE pre-existing failure, also from #106 — the repository-ir compiler fixtures were regenerated with kind "openprose.compile-phase-ir" while validateRepositoryIr and its tests still expect "openprose.repository-ir" (23 failing tests). That is a distinct IR-reconciliation fix, tracked separately. * fix(cli): restore repository-ir v0 validator tests with CLI-owned fixtures #106 migrated the SKILL compiler's golden outputs (repo-root tests/open-prose/compiler/) from repository-ir v0 to compile-phase-ir v2, but the CLI's own compile path (compileRepositorySource -> validateRepositoryIr -> repositoryIrToTopology) stayed v0. repository-ir.test.ts and responsibility-status.test.ts borrowed those golden files across the package boundary, so the v0 validator was being fed v2 inputs -> 21 failing tests. Give the CLI's v0 validator tests their OWN v0 fixtures under tools/cli/tests/prose/fixtures/repository-ir/ (recovered from f12dcda~1, the last commit before the migration; the CLI compiler and validator are unchanged since, so they still describe the current contract). The two compilers no longer share fixtures: the SKILL compiler's compile-phase-ir fixtures are validated by compiler-ir.test.ts; these repository-ir v0 fixtures are the CLI's. A README in the fixtures dir documents the split and the migration path. No validator or compiler change (not papering over) — the v0 validator is simply fed correct v0 inputs. tools/cli suite: 573 -> 594 passing; the v0 validator suite is 30/30. The 2 remaining failures (quickstart's dangling deleted-demo reference and the agent-observatory example's missing id) are unrelated non-IR #106 fallout, tracked separately. * chore: deprecate prose-cli npm publish flow; park the eval suite The `prose` CLI (@openprose/prose-cli) is deprecated in favor of the reactor harness (@openprose/reactor + @openprose/reactor-cli) and the SKILL/plugin. This removes its npm publish flow (it will be marked deprecated on npm manually) and parks the eval harness out of the working tree. Rip out the prose-cli publish flow: - delete .github/workflows/{release,cli-release-check,cli-real-harness-smoke}.yml and scripts/release-preflight.sh (the "OpenProse Release" publisher + its preflight/checks). - drop the `cli` track from .version-bump.json (only the skill/plugin track releases here now) and the prose-cli sections from RELEASE.md. - decouple the root build/test/lint scripts from @openprose/prose-cli. Park the eval suite (it is rethought from scratch in the reactor backlog): - remove the judge-era harness tools/cli/src/evals (45) + tools/cli/tests/evals (18) and spec/04-Evals.md; they are copied verbatim into the planning backlog-reactor for rehydration, and the methodology is synthesized there. The harness was import-isolated (no code imported it); removal breaks nothing. - fix the now-dangling spec/02 cross-reference to 04-Evals.md. - remove the obsolete quickstart.test.ts (it read a #106-deleted demo test file). The reactor packages, the new reactor-native tools/eval-harness, the skill examples gate, and plugin-manifest are unaffected; prose-cli still typechecks.