mirror of
https://github.com/NomaDamas/k-skill.git
synced 2026-09-14 16:37:18 +08:00
541967e96c
Reviewer flagged 4/30 seed namuwiki_url values returning HTTP 404 on live Namu Wiki. These URLs are part of the documented response contract and get surfaced directly to agents, so broken links are a functional bug, not a cosmetic one. Root causes per entry: - 중꺾마: wrong 꺾 codepoint (U+AFFA 꿺 instead of U+AEBE 꺾). - 아아: typo in aliased title (아이스 아메리칸노 instead of 아메리카노). - 어쩔티비: missing 받침 (어쩌티비 instead of 어쩔티비). - 당모치: encoding correct but no live Namu Wiki article exists; dropped. Also fixes two separately-broken 중꺾마 example URLs in SKILL.md (U+AFBE 꾾 instead of U+AEBE 꺾) — these were discovered while auditing the seed and would have surfaced as 404 to agents following the example snippets. Adds two regression tests: - test_each_seed_url_decodes_to_term_or_alias: decodes every seed URL's path segment and asserts it equals the term or one of its aliases. Catches Hangul-codepoint typos offline (no network dependency) and would have caught all 3 encoding bugs in this PR. - test_no_seed_entry_points_at_known_missing_namuwiki_page: locks the 당모치 drop so nobody re-adds an entry pointing at a page that does not exist on Namu Wiki. Fixes the existing LookupNetworkTest assertion that was hard-coding the broken URL — it now derives the expected URL via build_namuwiki_url() so the test cannot drift out of sync with the helper again. Verification: - PYTHONPATH=.:scripts python3 -m unittest scripts.test_korean_slang_writing -> 40/40 pass - Live GET with browser headers against all 29 remaining seed URLs -> 29/29 return 200 - npm run ci -> exit 0 - Manual QA: slang_search on 중꺾마, 어쩔티비, 아이스 아메리카노 returns correct URLs; slang_lookup live-fetches 중꺾마 and extracts the canonical title '중요한 것은 꺾이지 않는 마음'.