Commit Graph

3 Commits

Author SHA1 Message Date
Jeffrey (Dongkyu) Kim fed3d9e2e7 Align Danawa offers with total price contract
Sort offer rows by computed delivered total before limiting results, reject non-positive limits, and align the feature docs with the actual compare flags and url field.

Constraint: PR #226 documents total_price-first comparison and the helper must match that contract.

Rejected: Leaving Danawa minPrice order untouched | it can surface a higher delivered total before a cheaper offer.

Confidence: high

Scope-risk: narrow

Directive: Preserve total_price as the user-facing ranking key unless Danawa exposes a better delivered-price endpoint.

Tested: python3 -m py_compile danawa-price-search/scripts/danawa_search.py; ./scripts/validate-skills.sh; git diff --check

Not-tested: Full live Danawa offer scrape after patch.
2026-05-12 19:11:28 +09:00
Jeffrey (Dongkyu) Kim 5680497cb3 Keep Danawa price search mergeable and consistent
Merge the current dev branch so PR #226 no longer conflicts with the SH notice removal and marathon-schedule additions, while keeping the Danawa helper/documentation aligned with its 실구매가 contract. The PR diff is narrowed to Danawa files, README discovery, and the root lint hook for the new helper.

Constraint: PR #226 targets dev and GitHub reported DIRTY before this worker fix.

Rejected: Leaving inherited court-auction release metadata and SH-notice whitespace in the PR | they were unrelated to the Danawa skill and disappeared after reconciling with current dev.

Confidence: high

Scope-risk: narrow

Directive: Keep Danawa examples and JSON field docs synchronized with danawa_search.py CLI/output names.

Tested: python3 -m py_compile danawa-price-search/scripts/danawa_search.py; python3 danawa-price-search/scripts/danawa_search.py --help; python3 danawa-price-search/scripts/danawa_search.py search '에어팟 프로 2세대' --limit 1; npm run ci; git diff --check

Not-tested: Live Danawa offers endpoint after commit beyond search smoke.
2026-05-12 19:05:29 +09:00
TaeyoungPark 7f66f04c46 feat: add Danawa price comparison skill 2026-05-10 02:39:32 +09:00