mirror of
https://github.com/NickCrew/Claude-Cortex.git
synced 2026-09-14 20:17:11 +08:00
Nicholas Ferguson
6832d415c6
Adds 'cortex project curate' (and a 'cortex skills curate' alias) that launches the existing SkillPickerScreen, replaces the project manifest's skills.enabled with the selection, and reconciles the filesystem in one shot. Unlike 'project init --pick' (append-only), the replace semantics let a deselected skill be unlinked. Extracts the inlined picker launcher into a reusable run_skill_picker() that preserves None (cancel) vs [] (deselect-all); init --pick now uses it. Adds regression tests covering select, unselect->unlink, and cancel->no-op.
256 lines
7.9 KiB
Python
256 lines
7.9 KiB
Python
"""Unit tests for cortex project and skills move CLI commands."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from claude_ctx_py.cli import build_parser
|
|
|
|
|
|
def _parse(args: list[str]):
|
|
return build_parser().parse_args(args)
|
|
|
|
|
|
# ── parser smoke tests ────────────────────────────────────────────────────────
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_project_init_parses() -> None:
|
|
ns = _parse(["project", "init"])
|
|
assert ns.command == "project"
|
|
assert ns.project_command == "init"
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_project_init_with_skills_parses() -> None:
|
|
ns = _parse(["project", "init", "--with-skills", "a,b,c"])
|
|
assert ns.init_skills == "a,b,c"
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_project_sync_parses() -> None:
|
|
ns = _parse(["project", "sync"])
|
|
assert ns.project_command == "sync"
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_project_status_parses() -> None:
|
|
ns = _parse(["project", "status"])
|
|
assert ns.project_command == "status"
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_skills_move_parses() -> None:
|
|
ns = _parse(["skills", "move", "my-skill", "--to", "project"])
|
|
assert ns.skills_command == "move"
|
|
assert ns.skill == "my-skill"
|
|
assert ns.move_to == "project"
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_skills_move_global_parses() -> None:
|
|
ns = _parse(["skills", "move", "my-skill", "--to", "global"])
|
|
assert ns.move_to == "global"
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_skills_move_requires_to_flag() -> None:
|
|
with pytest.raises(SystemExit):
|
|
_parse(["skills", "move", "my-skill"])
|
|
|
|
|
|
# ── integration: project init writes valid YAML ───────────────────────────────
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_project_init_writes_manifest(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:
|
|
import yaml
|
|
from claude_ctx_py.cli import main
|
|
|
|
monkeypatch.chdir(tmp_path)
|
|
(tmp_path / ".claude").mkdir()
|
|
|
|
rc = main(["project", "init", "--with-skills", "systematic-debugging,atomic-commits"])
|
|
assert rc == 0
|
|
|
|
manifest_path = tmp_path / ".cortex" / "manifest.yaml"
|
|
assert manifest_path.exists()
|
|
data = yaml.safe_load(manifest_path.read_text())
|
|
assert "skills" in data
|
|
assert set(data["skills"]["enabled"]) == {"systematic-debugging", "atomic-commits"}
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_project_init_merges_with_existing_manifest(
|
|
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
import yaml
|
|
from claude_ctx_py.cli import main
|
|
|
|
monkeypatch.chdir(tmp_path)
|
|
(tmp_path / ".claude").mkdir()
|
|
# Pre-existing manifest
|
|
(tmp_path / ".cortex").mkdir()
|
|
(tmp_path / ".cortex" / "manifest.yaml").write_text(
|
|
"skills:\n enabled:\n - existing-skill\n"
|
|
)
|
|
|
|
rc = main(["project", "init", "--with-skills", "new-skill"])
|
|
assert rc == 0
|
|
|
|
data = yaml.safe_load((tmp_path / ".cortex" / "manifest.yaml").read_text())
|
|
enabled = data["skills"]["enabled"]
|
|
assert "existing-skill" in enabled
|
|
assert "new-skill" in enabled
|
|
|
|
|
|
# ── integration: project sync materialises skills ────────────────────────────
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_project_sync_materialises_skills(
|
|
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
import yaml
|
|
from claude_ctx_py.cli import main
|
|
|
|
monkeypatch.chdir(tmp_path)
|
|
(tmp_path / ".claude").mkdir()
|
|
|
|
# Create a minimal bundle skill
|
|
cortex_root = tmp_path / "bundle"
|
|
skill_dir = cortex_root / "skills" / "test-skill"
|
|
skill_dir.mkdir(parents=True)
|
|
(skill_dir / "SKILL.md").write_text("# Test\n")
|
|
|
|
# Write manifest + point CORTEX_ROOT at our bundle
|
|
(tmp_path / ".cortex").mkdir()
|
|
(tmp_path / ".cortex" / "manifest.yaml").write_text(
|
|
"skills:\n enabled:\n - test-skill\n"
|
|
)
|
|
monkeypatch.setenv("CORTEX_ROOT", str(cortex_root))
|
|
|
|
rc = main(["project", "sync"])
|
|
assert rc == 0
|
|
|
|
assert (tmp_path / ".agents" / "skills" / "test-skill" / "SKILL.md").is_file()
|
|
assert (tmp_path / ".claude" / "skills" / "test-skill").is_symlink()
|
|
|
|
|
|
# ── curate: parser smoke ──────────────────────────────────────────────────────
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_project_curate_parses() -> None:
|
|
ns = _parse(["project", "curate"])
|
|
assert ns.project_command == "curate"
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_skills_curate_parses() -> None:
|
|
ns = _parse(["skills", "curate"])
|
|
assert ns.skills_command == "curate"
|
|
|
|
|
|
# ── curate: integration (picker stubbed; replace-then-reconcile semantics) ─────
|
|
|
|
|
|
def _make_bundle(root: Path, *slugs: str) -> None:
|
|
"""Create a minimal bundle with the given skill slugs."""
|
|
for slug in slugs:
|
|
d = root / "skills" / slug
|
|
d.mkdir(parents=True)
|
|
(d / "SKILL.md").write_text(f"# {slug}\n")
|
|
|
|
|
|
def _stub_curate(monkeypatch: pytest.MonkeyPatch, selection: list[str] | None) -> None:
|
|
"""Stub the TUI picker (return *selection*) and the recommender (no-op)."""
|
|
import claude_ctx_py.core.manifest as manifest_mod
|
|
import claude_ctx_py.tui.dialogs.skill_picker as picker_mod
|
|
|
|
monkeypatch.setattr(
|
|
picker_mod, "run_skill_picker", lambda cortex_root, pre_selected=None: selection
|
|
)
|
|
monkeypatch.setattr(manifest_mod, "suggest_skills_for_project", lambda *a, **k: [])
|
|
|
|
|
|
def _enabled(tmp_path: Path) -> set[str]:
|
|
import yaml
|
|
|
|
data = yaml.safe_load((tmp_path / ".cortex" / "manifest.yaml").read_text())
|
|
return set(data["skills"]["enabled"])
|
|
|
|
|
|
def _materialised(tmp_path: Path) -> set[str]:
|
|
d = tmp_path / ".agents" / "skills"
|
|
return {p.name for p in d.iterdir()} if d.is_dir() else set()
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_curate_materialises_picked_skills(
|
|
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
from claude_ctx_py.cli import main
|
|
|
|
monkeypatch.chdir(tmp_path)
|
|
(tmp_path / ".claude").mkdir()
|
|
cortex_root = tmp_path / "bundle"
|
|
_make_bundle(cortex_root, "skill-a", "skill-b")
|
|
monkeypatch.setenv("CORTEX_ROOT", str(cortex_root))
|
|
_stub_curate(monkeypatch, ["skill-a", "skill-b"])
|
|
|
|
rc = main(["project", "curate"])
|
|
assert rc == 0
|
|
assert _enabled(tmp_path) == {"skill-a", "skill-b"}
|
|
assert _materialised(tmp_path) == {"skill-a", "skill-b"}
|
|
assert (tmp_path / ".claude" / "skills" / "skill-a").is_symlink()
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_curate_unselect_removes_skill(
|
|
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
from claude_ctx_py.cli import main
|
|
|
|
monkeypatch.chdir(tmp_path)
|
|
(tmp_path / ".claude").mkdir()
|
|
cortex_root = tmp_path / "bundle"
|
|
_make_bundle(cortex_root, "skill-a", "skill-b")
|
|
monkeypatch.setenv("CORTEX_ROOT", str(cortex_root))
|
|
|
|
_stub_curate(monkeypatch, ["skill-a", "skill-b"])
|
|
assert main(["project", "curate"]) == 0
|
|
assert _materialised(tmp_path) == {"skill-a", "skill-b"}
|
|
|
|
# Re-run with skill-b deselected → it is unlinked (replace, not append).
|
|
_stub_curate(monkeypatch, ["skill-a"])
|
|
assert main(["skills", "curate"]) == 0 # exercise the alias path too
|
|
assert _enabled(tmp_path) == {"skill-a"}
|
|
assert _materialised(tmp_path) == {"skill-a"}
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_curate_cancel_makes_no_changes(
|
|
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
from claude_ctx_py.cli import main
|
|
|
|
monkeypatch.chdir(tmp_path)
|
|
(tmp_path / ".claude").mkdir()
|
|
cortex_root = tmp_path / "bundle"
|
|
_make_bundle(cortex_root, "skill-a")
|
|
monkeypatch.setenv("CORTEX_ROOT", str(cortex_root))
|
|
|
|
_stub_curate(monkeypatch, ["skill-a"])
|
|
assert main(["project", "curate"]) == 0
|
|
assert _materialised(tmp_path) == {"skill-a"}
|
|
|
|
# Cancel (picker returns None) must not touch the manifest or filesystem.
|
|
_stub_curate(monkeypatch, None)
|
|
assert main(["project", "curate"]) == 0
|
|
assert _enabled(tmp_path) == {"skill-a"}
|
|
assert _materialised(tmp_path) == {"skill-a"}
|