Files
Tom Huang b99a9fdc3d feat(manual-edit): add direct manipulation and reliable history (#5890)
* feat(web): manual edit v2 direct manipulation (v2.2–v2.4)

Selection overlay with action bar and drag/resize handles, floating text
toolbar with range-format highlight (queryCommandState round trip), Manus
color picker, image replace/crop/paste/drop, element copy/duplicate/delete,
and the systematized in-place content pipeline: every element-scoped patch
now reconciles the live iframe DOM from the saved source over
od-edit-apply-dom (replace/insert-after/append-child/prepend-child/remove)
with positional identity restamping, so commits, undo and redo never reload
the canvas, never flash, and never move the scroll position. Frozen-source
reloads remain only as a scroll-capturing fallback. Includes the Chromium
Home/End double-booking fix, the dblclick word-selection guard, and light
targets-broadcast dedupe.

* test(web): manual edit v2 unit and e2e coverage

Bridge (in-place apply ops, positional restamp, selection format state,
Home/End consumption, dblclick selection guard), source-patches (insert
readback, restore descriptors, sanitization), gestures/shortcuts/color
units, and host-level FileViewer suites proving content commits mutate the
canvas without a srcDoc reload, hand selection to inserted elements, and
record labeled manual versions for undo/redo. Also realigns the
manual-edit-history and srcdoc-reload-races helpers with the v2.1 opt-in
inspector two-step flow.

* docs(specs): manual edit v2 architecture spec

Six-layer map (identity/chrome/style/content/history/external-sync), core
invariants (DOM equals saved source without reloads; positional identity
restamps on structural change; every save is a labeled manual version),
patch-kind application matrix, performance contract, and the v2.1–v2.4
revision log including the real-browser verification round.

* fix(tools-dev): fail fast when a sidecar process dies during startup wait

waitForDaemonRuntime/waitForWebRuntime now accept a liveness probe for the
spawned pid, so a crashed daemon/web process surfaces immediately instead
of burning the full startup timeout.

* fix(web): edit brand-kit pages in place — no reload flash, no scroll jump

Brand-kit targets carry runtime-annotated ids with no markup of their own in
the saved source (edits persist into the payload / runtime overrides), so
the in-place readback came up empty and every commit fell back to a
srcDoc reload — the flash-and-jump-to-top the user hit when editing text
after an image. New od-edit-apply-dom op 'apply-content' mirrors the patch
fields (text/href/src/alt/html/attributes, on*/data-od-* filtered) onto the
live element instead, and set-outer-html reuses replace with the patch
html. The reload fallback's scroll restore also gains a clamped-only retry
ladder (600–4000ms) so async-rendering pages (brand kit renders after
load) no longer land at the top when a reload is genuinely needed.

* refactor(FileViewer): unify manual edit history management and enhance undo/redo functionality

This update introduces a consistent approach to managing manual edit history and undo/redo stacks by utilizing refs to mirror state. The new `updateManualEditHistoryStack` and `updateManualEditUndoneStack` functions ensure that the state remains in sync with the refs, preventing stale data issues during undo/redo operations. Additionally, the handling of in-session undo (Cmd+Z) has been improved to escalate to the host's global history when no local changes remain, ensuring a seamless user experience. Tests have been added to verify the correct behavior of these features.

* feat(manual-edit): enhance manual edit functionality with space scaling and improved gesture handling

This update introduces a new `ManualEditSpaceScale` interface to manage the scaling between viewport pixels and CSS pixels, ensuring accurate positioning during manual edits. The `manualEditMovePreviewTransform` and `manualEditResizeStyles` functions have been updated to utilize this scaling, improving the precision of drag and resize gestures. Additionally, the `ManualEditSelectionOverlay` component now maintains pointer capture during gestures to prevent interaction issues with nested iframes. Tests have been added to verify the correct behavior of these enhancements, ensuring a smoother user experience in manual editing scenarios.

* feat(FileViewer): add localized toasts for image upload process in manual edit

This update enhances the manual editing experience by introducing localized toast notifications for the image upload process. New messages for uploading, processing, and successful addition of images have been added to the i18n files. The `insertManualEditImage` function now manages these notifications, providing users with real-time feedback during image uploads. Additionally, tests have been implemented to ensure the correct display of these toasts across different locales.

* fix(manual-edit): drag whole image to move + lock selection frame to element box (#5888)

Two direct-manipulation fixes reported from real prototype/landing/deck edits:

1. Move by dragging the image body, not only the top pill. Adds a
   full-interior moveBody surface inside the selection frame that starts the
   same undoable move gesture; scoped to image targets so text/link bodies
   keep click-to-edit. Rendered under the resize handles so edges still resize.

2. Keep the selection frame locked to the element during resize. The frame
   previously drew the gesture-intent x/width and only adopted the iframe's
   measured y/height, so an element that re-centers, caps at max-width, or
   reflows on width change left the frame drifting horizontally off the
   picture. adoptMeasuredExtent now takes the full measured rect and
   displayRect follows it, so the chrome always wraps the element.

Adds ManualEditSelectionOverlay tests for body-drag move and measured-box
frame sync; records the change as spec v2.5.

Co-authored-by: Claude <noreply@anthropic.com>

* test(web): stabilize manual edit browser validation

* fix(manual-edit): address structural edit review blockers

* fix(manual-edit): preserve runtime formatting and restore order

* fix(manual-edit): flush toolbar styles before navigation

* fix(manual-edit): preserve runtime target identity

* fix(manual-edit): serialize saves and image handoff

* fix(manual-edit): clear stale runtime clipboard

* fix(manual-edit): scrub rich text identities

* fix(manual-edit): save inspector text after formatting

* fix(manual-edit): action-bar boundary avoidance, select-without-reflow, image paste shortcut (#5892)

Three edit-mode canvas fixes from user feedback:

1. Action bar no longer covers the element frame/handles. A small or
   edge-hugging element previously had its move pill and resize handles
   hidden under the floating action bar (clamped to the top), so it could not
   be moved or resized. New pure helper manualEditActionBarTop places the bar
   above the frame, flips it below when the element hugs the top edge, and
   keeps it inside the canvas; horizontal clamping already handles the side
   edges. Adds a data-placement attribute.

2. Selecting a text element no longer makes it jump/grow. The bridge fused
   'select' and 'enter inline edit' into one click, and making a deck text box
   contenteditable releases its line-clamp/height cap so it visibly reflows
   larger the instant it is selected. The first click now only selects (no
   contenteditable, no reflow); editing begins on a second click of the
   already-selected element or a double-click — matching how images/containers
   already select.

3. A selected image/container can be pasted with Cmd/Ctrl+V. The native paste
   event only fires while an editable element holds the caret, which never
   happens for non-text selections, so the shortcut did nothing for images.
   The bridge keydown handler now forwards od-edit-paste-request for a selected
   non-editable element (paired with the existing Cmd/Ctrl+C copy).

Updates the 14 inline-edit bridge tests to enter edit via double-click and
adds coverage for all three fixes; recorded as spec v2.6.

Co-authored-by: Claude <noreply@anthropic.com>

* fix(manual-edit): image corner scaling, nowrap unlock on resize, restore image paste

Three edit-mode canvas fixes from user feedback:

1. Images get four corner anchors that scale aspect-locked from any corner,
   anchored at the opposite corner (new resize-nw/ne/sw/se gesture kinds).
   The dominant pointer axis drives the scale, the floor binds the larger
   dimension, and corner gestures skip snapping so the ratio never breaks.
   Corner resizes persist width AND height (space-scale corrected) plus the
   offsets that keep the anchored corner fixed.

2. Resizing an element with white-space: nowrap (or pre) now unlocks
   wrapping (normal / pre-wrap) alongside the width — a narrowed heading
   previously stayed on one line and overflowed its own new box.
   ManualEditStyles and the bridge style props gain whiteSpace.

3. Image paste works again. The v2.6 Cmd/Ctrl+V keydown branch called
   preventDefault, which suppresses the native paste event — the only place
   clipboard image bytes are readable — so pasting an image did nothing.
   The shortcut now arms a 150ms one-shot element-paste fallback instead;
   any real paste event disarms it and routes image vs element itself, so
   the two channels never double-fire.

Adds gesture/overlay/bridge coverage for all three; recorded as spec v2.7.

* fix(manual-edit): replay runtime history in place

* fix(brands): reject scraped CSS junk font families before token emission

An extraction can capture CSS source text instead of a real font family
(e.g. Tailwind v4's `--theme(--default-font-family` from aliyun.com).
Interpolated raw into the kit's `--brand-font-family`, the unbalanced
parenthesis swallows every later :root declaration, so the component kit
renders unstyled (UA serif, collapsed buttons) while earlier color tokens
still work.

isRenderableFontFamily() now guards both emission seams: the seed's
fontStack (kit/variables/artifacts token block) and brandFontAssets'
display-family stack (h1-h3 face). Junk families drop out and the
renderable fallbacks + system stack take over.

* fix(manual-edit): replay runtime-only style history from the persisted override rule

Runtime-only brand-kit targets persist set-style patches in the
style[data-od-manual-edit-runtime-overrides] rule, not as element inline
styles. The in-place history replay read inline styles only, so redo of a
runtime style change replayed empty values while reporting success — the
file held the redone style while the canvas stayed on the undone one.

readManualEditSavedStyles() now reads a target's persisted styles wherever
they live (inline attribute for source-backed nodes, the runtime override
rule otherwise), and the set-style history branch replays through it. The
same inline-only read also made reconcileManualEditStyleSave() treat every
runtime style save as "target vanished" — erroring, dropping the selection,
and reloading the canvas — so it now consults
hasManualEditRuntimeStyleOverride() before taking that path.

Regressions: source-patches unit coverage for the saved-styles read and the
override predicate, plus a FileViewer spec that styles a runtime target,
undoes and redoes it without any srcdoc change, and asserts the redo
preview carries the persisted value (red on the previous head).

* fix(manual-edit): merge partial runtime style patches into the persisted rule

Successive debounced toolbar autosaves send only the touched property, but
setRuntimeStyleOverride() rebuilt the target's override rule solely from the
incoming patch, so a runtime-only brand-kit target lost its earlier saved
declarations (fontSize save, then color save -> font-size silently dropped).
Persistence now merges the incoming patch into the existing rule
declarations, treating empty incoming values as deletions and removing the
rule once its last declaration is deleted.

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-07-27 04:09:02 +00:00

37 lines
1.0 KiB
TypeScript

import assert from "node:assert/strict";
import { describe, it } from "node:test";
import {
DAEMON_STARTUP_TIMEOUT_MS,
waitForDaemonRuntime,
waitForDesktopRuntime,
waitForWebRuntime,
} from "../src/sidecar-client.js";
describe("sidecar startup waits", () => {
it("allows daemon initialization to continue past the legacy 35 second deadline", () => {
assert.equal(DAEMON_STARTUP_TIMEOUT_MS, 120_000);
});
it("fails immediately when a spawned app exits before publishing status", async () => {
const waits = [
["daemon", waitForDaemonRuntime],
["web", waitForWebRuntime],
["desktop", waitForDesktopRuntime],
] as const;
for (const [appName, waitForRuntime] of waits) {
const startedAt = Date.now();
await assert.rejects(
waitForRuntime(
{ base: "unused", namespace: `exited-${appName}-${process.pid}` },
5_000,
() => false,
),
new RegExp(`${appName} exited before exposing status`),
);
assert.ok(Date.now() - startedAt < 1_000);
}
});
});