mirror of
https://github.com/nexu-io/open-design.git
synced 2026-09-20 06:15:06 +08:00
PerishFire
14fcc411cd
* chore(scripts): make root scripts/ test-free and purify the guard entrypoint
Root scripts/ is now source-only, enforced by a new "scripts test-free"
guard check (any *.test.{ts,tsx,js,jsx,mjs,cjs} under scripts/ fails
pnpm guard). The root guard script becomes a pure tsx ./scripts/guard.ts
invocation instead of chaining a hand-maintained node --test file list.
Script behavior-contract coverage follows the boundary e2e/AGENTS.md
already declares for e2e/tests/scripts/: the fork PR approval security
tests migrate there (converted to Vitest, 24 tests passing), and the
remaining script unit tests are deleted — five of them (batch-design-
system-test, check-design-system-package-quality, plugin-previews-diff,
plugin-previews-gc, migrate-to-plugins/example) were orphans no runner
ever executed; the guard-chained checker tests covered logic whose
repo-wide enforcement remains in guard.ts checks. Coverage with a real
test claim gets rebuilt in e2e/tests/scripts/ on demand.
* test(ci): pin characterization goldens for scopes.ts scope detection
Golden tests run scripts/scopes.ts as a subprocess exactly the way ci.yml
does, with gh stubbed through the existing OPEN_DESIGN_GH_NODE_SCRIPT seam
(hermetic stub materialized per run), and pin the complete 20-key output
plan for a matrix of changed-file sets across pull_request,
workflow_dispatch (hot/full), and merge_group events.
They deliberately pin current quirks (skills/*.md arming daemon+web without
the ui-critical fallback; e2e/ui/*.md arming ui_p0 with workspace validation
off; dispatch-hot skipping the workspace_validation re-derivation) so the
upcoming rule-table restructuring can prove behavior preservation
byte-for-byte.
* refactor(ci): restructure scopes.ts into a confidence-tiered rule table
Scope detection becomes data plus a pure evaluator: every changed file is
classified by an additive rule table (union of matched effects, minimum
confidence across matched rules), and an evaluation context brings a trust
threshold — files below it, or matching no rule, escalate fail-closed to
the full radius. Today's behavior is exactly the degenerate case of this
structure (all rules medium, certain set empty): pull_request/hot believes
everything, the merge queue believes nothing and stays full. The
characterization goldens pass unchanged, byte-for-byte.
The exempt surface becomes an explicit empty-radius rule instead of a
special case, so exemptions can be split, rated, and promoted per rule.
Promotion to "certain" requires a guard field naming the enforcing check
(enforced by a rule-table invariant test).
New offline entry points for rule iteration: `plan --context
pr|merge-queue|full --files ...` evaluates without any GitHub environment
and prints { plan, trace }; `rules` lists the table. Every evaluation now
returns a decision trace (per-rule hit counts, per-file escalations, and
an ifTrustAll shadow plan that shows what medium-confidence rules would
have allowed — the evidence stream for future certain-tier promotions);
github-output mode logs it and writes a step-summary table without
touching the frozen 20-key output contract.
The legacy dispatch-hot asymmetry (no workspace_validation re-derivation)
is preserved behind an explicit option and pinned by the goldens.
* feat(ci): evaluate merge-group union diffs at the certain threshold with shadow trace
The merge queue now resolves the queued group's union diff
(compare base_sha...head_sha from the merge_group event payload) and
evaluates it through the rule table at the "certain" trust threshold.
While the certain rule set is empty every file escalates and the queue
keeps running everything — the goldens pin this byte-for-byte — but the
evaluation's ifTrustAll shadow column now records, for every queued
group, what medium-confidence rules would have allowed: the evidence
stream that future certain-tier promotions will cite.
Queue lanes derive from the evaluated outputs (ci_mode stays reported as
"full", but lanes are no longer unconditionally forced), so promoting a
rule to "certain" later is a pure rule-table change with no further
structural work.
Fail-safe behavior is explicit and tested: resolution errors and empty
resolutions fall open to the full plan without failing the scopes job
(queue throughput must never depend on this evaluation), while
pull_request resolution failures keep failing the run as before.
Changed-file resolution no longer filters out removed files (manual hot
runs previously did): deleting a runtime source file must trigger the
same validation scopes as editing it. This is the only behavior change,
and it is strictly fail-closed.
* fix(ci): preserve guard contracts and fail closed on compare limits
Restore the eight guard behavior suites in the e2e script lane and make merge-group compare resolution treat GitHub's 300-file ceiling as incomplete.
Generated-By: looper 0.11.0 (runner=fixer, agent=codex)
* fix(ci): enforce extension-agnostic script test boundary
Match every suffix after .test. and cover TypeScript, MTS, and non-test filenames in the e2e script suite.
Generated-By: looper 0.11.0 (runner=fixer, agent=codex)
* fix(ci): route script contract tests to e2e
Ensure changes under e2e/tests/scripts arm E2E Vitest with the same daemon and web scope effects as their root script counterparts, and pin the behavior with a PR golden.\n\nGenerated-By: looper 0.11.0 (runner=fixer, agent=codex)
---------
Co-authored-by: Looper <looper@noreply.github.com>
915 lines
25 KiB
TypeScript
915 lines
25 KiB
TypeScript
import assert from "node:assert/strict";
|
|
import { test } from "vitest";
|
|
|
|
import {
|
|
hasPullApprovalStateDrift,
|
|
isAllowedChangedPath,
|
|
isDeniedChangedPath,
|
|
isPendingApprovalRun,
|
|
listPendingApprovalRuns,
|
|
runTargetsPullRequest,
|
|
waitForPendingApprovalRuns,
|
|
} from "../../../scripts/approve-fork-pr-workflows.ts";
|
|
|
|
test("isPendingApprovalRun matches approval-gated fork PR runs from GitHub's captured payload shape", () => {
|
|
const pull = {
|
|
number: 2683,
|
|
state: "open",
|
|
changed_files: 1,
|
|
head: {
|
|
ref: "fix/workflow-linkage",
|
|
sha: "734076155c44e569304856590019cea54506fdab",
|
|
repo: { full_name: "someone/open-design" },
|
|
},
|
|
base: {
|
|
ref: "main",
|
|
sha: "4cd93a5c7a7b0db1961c854e55f8e0e6b1b45542",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
const run = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
|
|
assert.equal(isPendingApprovalRun(run, pull), true);
|
|
});
|
|
|
|
test("isPendingApprovalRun also accepts action_required runs reported only in status", () => {
|
|
const pull = {
|
|
number: 2683,
|
|
state: "open",
|
|
changed_files: 1,
|
|
head: {
|
|
ref: "fix/workflow-linkage",
|
|
sha: "734076155c44e569304856590019cea54506fdab",
|
|
repo: { full_name: "someone/open-design" },
|
|
},
|
|
base: {
|
|
ref: "main",
|
|
sha: "4cd93a5c7a7b0db1961c854e55f8e0e6b1b45542",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
const run = {
|
|
id: 26273463770,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "action_required",
|
|
conclusion: null,
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
|
|
assert.equal(isPendingApprovalRun(run, pull), true);
|
|
});
|
|
|
|
test("isPendingApprovalRun rejects runs outside the allowlist or without action_required state", () => {
|
|
const pull = {
|
|
number: 2683,
|
|
state: "open",
|
|
changed_files: 1,
|
|
head: {
|
|
ref: "fix/workflow-linkage",
|
|
sha: "734076155c44e569304856590019cea54506fdab",
|
|
repo: { full_name: "someone/open-design" },
|
|
},
|
|
base: {
|
|
ref: "main",
|
|
sha: "4cd93a5c7a7b0db1961c854e55f8e0e6b1b45542",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
assert.equal(
|
|
isPendingApprovalRun(
|
|
{
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "success",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
},
|
|
pull,
|
|
),
|
|
false,
|
|
);
|
|
|
|
assert.equal(
|
|
isPendingApprovalRun(
|
|
{
|
|
id: 26273463770,
|
|
name: "Visual PR Comment",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/comment.atom.yml@main",
|
|
pull_requests: [],
|
|
},
|
|
pull,
|
|
),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("runTargetsPullRequest accepts empty run.pull_requests only when the head SHA maps to this one open PR", () => {
|
|
const pull = {
|
|
number: 2683,
|
|
state: "open",
|
|
changed_files: 1,
|
|
head: {
|
|
ref: "fix/workflow-linkage",
|
|
sha: "734076155c44e569304856590019cea54506fdab",
|
|
repo: { full_name: "someone/open-design" },
|
|
},
|
|
base: {
|
|
ref: "main",
|
|
sha: "4cd93a5c7a7b0db1961c854e55f8e0e6b1b45542",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
const run = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
|
|
assert.equal(runTargetsPullRequest(run, pull, [pull], []), true);
|
|
});
|
|
|
|
test("runTargetsPullRequest accepts fork PR runs with no GitHub PR association when head identity matches", () => {
|
|
const pull = {
|
|
number: 2683,
|
|
state: "open",
|
|
changed_files: 1,
|
|
head: {
|
|
ref: "fix/workflow-linkage",
|
|
sha: "734076155c44e569304856590019cea54506fdab",
|
|
repo: { full_name: "someone/open-design" },
|
|
},
|
|
base: {
|
|
ref: "main",
|
|
sha: "4cd93a5c7a7b0db1961c854e55f8e0e6b1b45542",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
const run = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
head_branch: "fix/workflow-linkage",
|
|
head_repository: { full_name: "someone/open-design" },
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: pull.head.sha,
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
|
|
assert.equal(runTargetsPullRequest(run, pull, [], [pull]), true);
|
|
});
|
|
|
|
test("runTargetsPullRequest rejects ambiguous empty run.pull_requests associations", () => {
|
|
const pull = {
|
|
number: 2683,
|
|
state: "open",
|
|
changed_files: 1,
|
|
head: {
|
|
ref: "fix/workflow-linkage",
|
|
sha: "734076155c44e569304856590019cea54506fdab",
|
|
repo: { full_name: "someone/open-design" },
|
|
},
|
|
base: {
|
|
ref: "main",
|
|
sha: "4cd93a5c7a7b0db1961c854e55f8e0e6b1b45542",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
const otherPull = {
|
|
...pull,
|
|
number: 3001,
|
|
base: {
|
|
ref: "release",
|
|
sha: "8db117d728f967d108f6fdd64cb8d921d057f7f6",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
const run = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
|
|
assert.equal(runTargetsPullRequest(run, pull, [pull, otherPull], []), false);
|
|
});
|
|
|
|
test("runTargetsPullRequest rejects fork PR runs when multiple open PRs share the same head identity", () => {
|
|
const pull = {
|
|
number: 2683,
|
|
state: "open",
|
|
changed_files: 1,
|
|
head: {
|
|
ref: "fix/workflow-linkage",
|
|
sha: "734076155c44e569304856590019cea54506fdab",
|
|
repo: { full_name: "someone/open-design" },
|
|
},
|
|
base: {
|
|
ref: "main",
|
|
sha: "4cd93a5c7a7b0db1961c854e55f8e0e6b1b45542",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
const otherPull = {
|
|
...pull,
|
|
number: 3001,
|
|
base: {
|
|
ref: "release",
|
|
sha: "8db117d728f967d108f6fdd64cb8d921d057f7f6",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
const run = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
head_branch: pull.head.ref,
|
|
head_repository: pull.head.repo,
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: pull.head.sha,
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
|
|
assert.equal(runTargetsPullRequest(run, pull, [], [pull, otherPull]), false);
|
|
});
|
|
|
|
test("runTargetsPullRequest rejects empty associations when fork head identity does not match", () => {
|
|
const pull = {
|
|
number: 2683,
|
|
state: "open",
|
|
changed_files: 1,
|
|
head: {
|
|
ref: "fix/workflow-linkage",
|
|
sha: "734076155c44e569304856590019cea54506fdab",
|
|
repo: { full_name: "someone/open-design" },
|
|
},
|
|
base: {
|
|
ref: "main",
|
|
sha: "4cd93a5c7a7b0db1961c854e55f8e0e6b1b45542",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
const run = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
head_branch: "different-branch",
|
|
head_repository: { full_name: "someone/open-design" },
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: pull.head.sha,
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
|
|
assert.equal(runTargetsPullRequest(run, pull, [], [pull]), false);
|
|
});
|
|
|
|
test("runTargetsPullRequest rejects runs that GitHub already associates to a different PR", () => {
|
|
const pull = {
|
|
number: 2683,
|
|
state: "open",
|
|
changed_files: 1,
|
|
head: {
|
|
ref: "fix/workflow-linkage",
|
|
sha: "734076155c44e569304856590019cea54506fdab",
|
|
repo: { full_name: "someone/open-design" },
|
|
},
|
|
base: {
|
|
ref: "main",
|
|
sha: "4cd93a5c7a7b0db1961c854e55f8e0e6b1b45542",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
const run = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [
|
|
{
|
|
number: 3001,
|
|
head: pull.head,
|
|
base: {
|
|
ref: "release",
|
|
sha: "8db117d728f967d108f6fdd64cb8d921d057f7f6",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
},
|
|
],
|
|
};
|
|
|
|
assert.equal(runTargetsPullRequest(run, pull, [pull], []), false);
|
|
});
|
|
|
|
test("runTargetsPullRequest approves only the run that GitHub associates to the current PR when two PRs share a head SHA", () => {
|
|
const pull = {
|
|
number: 2683,
|
|
state: "open",
|
|
changed_files: 1,
|
|
head: {
|
|
ref: "fix/workflow-linkage",
|
|
sha: "734076155c44e569304856590019cea54506fdab",
|
|
repo: { full_name: "someone/open-design" },
|
|
},
|
|
base: {
|
|
ref: "main",
|
|
sha: "4cd93a5c7a7b0db1961c854e55f8e0e6b1b45542",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
const otherPull = {
|
|
...pull,
|
|
number: 3001,
|
|
base: {
|
|
ref: "release",
|
|
sha: "8db117d728f967d108f6fdd64cb8d921d057f7f6",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
const currentPrRun = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: pull.head.sha,
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [pull],
|
|
};
|
|
|
|
const otherPrRun = {
|
|
...currentPrRun,
|
|
id: 26273463770,
|
|
pull_requests: [otherPull],
|
|
};
|
|
|
|
assert.equal(runTargetsPullRequest(currentPrRun, pull, [pull, otherPull], []), true);
|
|
assert.equal(runTargetsPullRequest(otherPrRun, pull, [pull, otherPull], []), false);
|
|
});
|
|
|
|
test("runTargetsPullRequest ignores base tip churn for the same PR association", () => {
|
|
const pull = {
|
|
number: 2683,
|
|
state: "open",
|
|
changed_files: 1,
|
|
head: {
|
|
ref: "fix/workflow-linkage",
|
|
sha: "734076155c44e569304856590019cea54506fdab",
|
|
repo: { full_name: "someone/open-design" },
|
|
},
|
|
base: {
|
|
ref: "main",
|
|
sha: "4cd93a5c7a7b0db1961c854e55f8e0e6b1b45542",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
const run = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: pull.head.sha,
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [
|
|
{
|
|
number: pull.number,
|
|
head: pull.head,
|
|
base: {
|
|
...pull.base,
|
|
sha: "08a88a65482123629ebda5a090c71533bd6b8a88",
|
|
},
|
|
},
|
|
],
|
|
};
|
|
|
|
assert.equal(runTargetsPullRequest(run, pull, [pull], []), true);
|
|
});
|
|
|
|
test("listPendingApprovalRuns paginates all pull_request runs for the head SHA and filters action_required client-side", async () => {
|
|
const pull = {
|
|
number: 2683,
|
|
state: "open",
|
|
changed_files: 1,
|
|
head: {
|
|
ref: "fix/workflow-linkage",
|
|
sha: "734076155c44e569304856590019cea54506fdab",
|
|
repo: { full_name: "someone/open-design" },
|
|
},
|
|
base: {
|
|
ref: "main",
|
|
sha: "4cd93a5c7a7b0db1961c854e55f8e0e6b1b45542",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
const requestedPaths: string[] = [];
|
|
const pendingRuns = await listPendingApprovalRuns("nexu-io/open-design", pull, {
|
|
loadWorkflowRunsResponsePage: async (path) => {
|
|
requestedPaths.push(path);
|
|
if (path.endsWith("page=1")) {
|
|
return {
|
|
workflow_runs: Array.from({ length: 100 }, (_, index) => ({
|
|
id: 26273463600 + index,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
head_branch: pull.head.ref,
|
|
head_repository: pull.head.repo,
|
|
status: "completed",
|
|
conclusion: "success",
|
|
head_sha: pull.head.sha,
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
})),
|
|
};
|
|
}
|
|
|
|
return {
|
|
workflow_runs: [
|
|
{
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
head_branch: pull.head.ref,
|
|
head_repository: pull.head.repo,
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: pull.head.sha,
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
},
|
|
{
|
|
id: 26273463770,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
head_branch: pull.head.ref,
|
|
head_repository: pull.head.repo,
|
|
status: "completed",
|
|
conclusion: "success",
|
|
head_sha: pull.head.sha,
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
},
|
|
],
|
|
};
|
|
},
|
|
loadPullRequestsForHeadSha: async () => [],
|
|
loadPullRequestsForHeadRef: async () => [pull],
|
|
});
|
|
|
|
assert.deepEqual(requestedPaths, [
|
|
"/repos/nexu-io/open-design/actions/runs?event=pull_request&head_sha=734076155c44e569304856590019cea54506fdab&per_page=100&page=1",
|
|
"/repos/nexu-io/open-design/actions/runs?event=pull_request&head_sha=734076155c44e569304856590019cea54506fdab&per_page=100&page=2",
|
|
]);
|
|
assert.equal(requestedPaths.some((path) => path.includes("status=action_required")), false);
|
|
assert.deepEqual(
|
|
pendingRuns.map((run) => run.id),
|
|
[26273463769],
|
|
);
|
|
});
|
|
|
|
test("listPendingApprovalRuns only approves the unified CI workflow", async () => {
|
|
const pull = {
|
|
number: 2683,
|
|
state: "open",
|
|
changed_files: 1,
|
|
head: {
|
|
ref: "fix/readme-copy",
|
|
sha: "734076155c44e569304856590019cea54506fdab",
|
|
repo: { full_name: "someone/open-design" },
|
|
},
|
|
base: {
|
|
ref: "main",
|
|
sha: "4cd93a5c7a7b0db1961c854e55f8e0e6b1b45542",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
const workflowRuns = [
|
|
{
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
head_branch: pull.head.ref,
|
|
head_repository: pull.head.repo,
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: pull.head.sha,
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
},
|
|
];
|
|
const deps = {
|
|
loadWorkflowRunsResponsePage: async () => ({ workflow_runs: workflowRuns }),
|
|
loadPullRequestsForHeadSha: async () => [pull],
|
|
};
|
|
|
|
assert.deepEqual(
|
|
(await listPendingApprovalRuns("nexu-io/open-design", pull, [{ filename: "README.md", status: "modified" }], deps)).map((run) => run.id),
|
|
[26273463769],
|
|
);
|
|
assert.deepEqual(
|
|
(await listPendingApprovalRuns(
|
|
"nexu-io/open-design",
|
|
pull,
|
|
[{ filename: "apps/web/src/components/Button.tsx", status: "modified" }],
|
|
deps,
|
|
)).map((run) => run.id),
|
|
[26273463769],
|
|
);
|
|
});
|
|
|
|
test("hasPullApprovalStateDrift ignores base tip churn but still rejects base retargeting and head drift", () => {
|
|
const pull = {
|
|
number: 2683,
|
|
state: "open",
|
|
changed_files: 1,
|
|
head: {
|
|
ref: "fix/workflow-linkage",
|
|
sha: "734076155c44e569304856590019cea54506fdab",
|
|
repo: { full_name: "someone/open-design" },
|
|
},
|
|
base: {
|
|
ref: "main",
|
|
sha: "4cd93a5c7a7b0db1961c854e55f8e0e6b1b45542",
|
|
repo: { full_name: "nexu-io/open-design" },
|
|
},
|
|
};
|
|
|
|
assert.equal(hasPullApprovalStateDrift(pull, pull), false);
|
|
assert.equal(
|
|
hasPullApprovalStateDrift(pull, {
|
|
...pull,
|
|
base: { ...pull.base, sha: "08a88a65482123629ebda5a090c71533bd6b8a88" },
|
|
}),
|
|
false,
|
|
);
|
|
assert.equal(hasPullApprovalStateDrift(pull, { ...pull, draft: true }), true);
|
|
assert.equal(hasPullApprovalStateDrift(pull, { ...pull, state: "closed" }), true);
|
|
assert.equal(
|
|
hasPullApprovalStateDrift(pull, {
|
|
...pull,
|
|
head: { ...pull.head, sha: "08a88a65482123629ebda5a090c71533bd6b8a88" },
|
|
}),
|
|
true,
|
|
);
|
|
assert.equal(
|
|
hasPullApprovalStateDrift(pull, {
|
|
...pull,
|
|
base: { ...pull.base, ref: "release" },
|
|
}),
|
|
true,
|
|
);
|
|
});
|
|
|
|
test("isDeniedChangedPath blocks common tool config files under allowlisted source trees", () => {
|
|
assert.equal(isDeniedChangedPath("apps/web/vitest.config.ts"), true);
|
|
assert.equal(isDeniedChangedPath("apps/web/vite.config.ts"), true);
|
|
assert.equal(isDeniedChangedPath("apps/web/playwright.config.ts"), true);
|
|
assert.equal(isDeniedChangedPath("apps/web/tsconfig.sidecar.json"), true);
|
|
assert.equal(isDeniedChangedPath("apps/daemon/tsconfig.tests.json"), true);
|
|
assert.equal(isDeniedChangedPath("packages/contracts/tsconfig.tests.json"), true);
|
|
assert.equal(isDeniedChangedPath("apps/packaged/tsconfig.json"), true);
|
|
assert.equal(isDeniedChangedPath("apps/packaged/vitest.config.ts"), true);
|
|
assert.equal(isDeniedChangedPath("apps/web/src/app/page.tsx"), false);
|
|
});
|
|
|
|
test("isAllowedChangedPath allows ordinary app and package source/test paths while keeping denied surfaces blocked", () => {
|
|
assert.equal(isAllowedChangedPath("apps/packaged/src/main.ts"), true);
|
|
assert.equal(isAllowedChangedPath("apps/packaged/tests/main.test.ts"), true);
|
|
assert.equal(isAllowedChangedPath("apps/desktop/src/main.ts"), true);
|
|
assert.equal(isAllowedChangedPath("packages/sidecar/src/index.ts"), true);
|
|
assert.equal(isAllowedChangedPath("tools/pack/src/index.ts"), false);
|
|
assert.equal(isAllowedChangedPath("apps/packaged/tsconfig.json"), false);
|
|
assert.equal(isAllowedChangedPath("apps/packaged/vitest.config.ts"), false);
|
|
});
|
|
|
|
test("waitForPendingApprovalRuns retries until action_required runs appear and keeps polling through the retry window", async () => {
|
|
const run = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
|
|
const batches = [[], [], [run]];
|
|
const sleeps: number[] = [];
|
|
let now = 0;
|
|
|
|
const pendingRuns = await waitForPendingApprovalRuns(
|
|
async () => batches.shift() ?? [run],
|
|
async (ms) => {
|
|
sleeps.push(ms);
|
|
now += ms;
|
|
},
|
|
() => now,
|
|
{ settlingWindowMs: 9_000 },
|
|
);
|
|
|
|
assert.deepEqual(pendingRuns, [run]);
|
|
assert.deepEqual(sleeps, [3000, 3000, 3000, 3000, 3000]);
|
|
});
|
|
|
|
test("waitForPendingApprovalRuns keeps polling and returns the latest eligible run snapshot across the retry window", async () => {
|
|
const ciRun = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
const laterCiRun = {
|
|
id: 26273463770,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
|
|
const batches = [[ciRun], [ciRun], [ciRun, laterCiRun], [ciRun, laterCiRun]];
|
|
const sleeps: number[] = [];
|
|
let now = 0;
|
|
|
|
const pendingRuns = await waitForPendingApprovalRuns(
|
|
async () => batches.shift() ?? [ciRun, laterCiRun],
|
|
async (ms) => {
|
|
sleeps.push(ms);
|
|
now += ms;
|
|
},
|
|
() => now,
|
|
{ settlingWindowMs: 9_000 },
|
|
);
|
|
|
|
assert.deepEqual(pendingRuns, [ciRun, laterCiRun]);
|
|
assert.deepEqual(sleeps, [3000, 3000, 3000, 3000, 3000]);
|
|
});
|
|
|
|
test("waitForPendingApprovalRuns drops runs that disappear in later polls", async () => {
|
|
const staleRun = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
const survivingRun = {
|
|
...staleRun,
|
|
id: 26273463770,
|
|
name: "CI",
|
|
path: ".github/workflows/ci.yml@main",
|
|
};
|
|
|
|
const batches = [[staleRun], [staleRun, survivingRun], [survivingRun], [survivingRun]];
|
|
let now = 0;
|
|
|
|
const pendingRuns = await waitForPendingApprovalRuns(
|
|
async () => batches.shift() ?? [survivingRun],
|
|
async (ms) => {
|
|
now += ms;
|
|
},
|
|
() => now,
|
|
{ settlingWindowMs: 6_000 },
|
|
);
|
|
|
|
assert.deepEqual(pendingRuns, [survivingRun]);
|
|
});
|
|
|
|
test("waitForPendingApprovalRuns keeps polling until the run set is stable, even when another eligible run appears after the old three-poll budget", async () => {
|
|
const ciRun = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
const laterCiRun = {
|
|
id: 26273463770,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
|
|
const batches = [[ciRun], [ciRun], [ciRun], [ciRun], [ciRun], [ciRun, laterCiRun], [ciRun, laterCiRun]];
|
|
const sleeps: number[] = [];
|
|
let now = 0;
|
|
|
|
const pendingRuns = await waitForPendingApprovalRuns(
|
|
async () => batches.shift() ?? [ciRun, laterCiRun],
|
|
async (ms) => {
|
|
sleeps.push(ms);
|
|
now += ms;
|
|
},
|
|
() => now,
|
|
{
|
|
firstAppearanceTimeoutMs: 30_000,
|
|
settlingWindowMs: 15_000,
|
|
},
|
|
);
|
|
|
|
assert.deepEqual(pendingRuns, [ciRun, laterCiRun]);
|
|
assert.equal(sleeps.length, 10);
|
|
});
|
|
|
|
test("waitForPendingApprovalRuns gives late first appearances their own full settling window", async () => {
|
|
const ciRun = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
const laterCiRun = {
|
|
id: 26273463770,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
|
|
const batches = [[], [], [], [ciRun], [ciRun], [ciRun, laterCiRun], [ciRun, laterCiRun], [ciRun, laterCiRun]];
|
|
const sleeps: number[] = [];
|
|
let now = 0;
|
|
|
|
const pendingRuns = await waitForPendingApprovalRuns(
|
|
async () => batches.shift() ?? [ciRun, laterCiRun],
|
|
async (ms) => {
|
|
sleeps.push(ms);
|
|
now += ms;
|
|
},
|
|
() => now,
|
|
{
|
|
firstAppearanceTimeoutMs: 12_000,
|
|
settlingWindowMs: 9_000,
|
|
},
|
|
);
|
|
|
|
assert.deepEqual(pendingRuns, [ciRun, laterCiRun]);
|
|
assert.deepEqual(sleeps, [3000, 3000, 3000, 3000, 3000, 3000, 3000, 3000]);
|
|
});
|
|
|
|
test("waitForPendingApprovalRuns keeps polling until the first run appears, even after the old short retry budget", async () => {
|
|
const run = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
|
|
const batches = [[], [], [], [], [run]];
|
|
const sleeps: number[] = [];
|
|
let now = 0;
|
|
|
|
const pendingRuns = await waitForPendingApprovalRuns(
|
|
async () => batches.shift() ?? [run],
|
|
async (ms) => {
|
|
sleeps.push(ms);
|
|
now += ms;
|
|
},
|
|
() => now,
|
|
{
|
|
firstAppearanceTimeoutMs: 15_000,
|
|
settlingWindowMs: 6_000,
|
|
},
|
|
);
|
|
|
|
assert.deepEqual(pendingRuns, [run]);
|
|
assert.deepEqual(sleeps, [3000, 3000, 3000, 3000, 3000, 3000]);
|
|
});
|
|
|
|
test("waitForPendingApprovalRuns accepts a configurable longer polling budget before the first run appears", async () => {
|
|
const run = {
|
|
id: 26273463769,
|
|
name: "CI",
|
|
event: "pull_request",
|
|
status: "completed",
|
|
conclusion: "action_required",
|
|
head_sha: "734076155c44e569304856590019cea54506fdab",
|
|
path: ".github/workflows/ci.yml@main",
|
|
pull_requests: [],
|
|
};
|
|
|
|
const batches = [[], [], [], [], [], [run]];
|
|
const sleeps: number[] = [];
|
|
let now = 0;
|
|
|
|
const pendingRuns = await waitForPendingApprovalRuns(
|
|
async () => batches.shift() ?? [run],
|
|
async (ms) => {
|
|
sleeps.push(ms);
|
|
now += ms;
|
|
},
|
|
() => now,
|
|
{
|
|
firstAppearanceTimeoutMs: 18_000,
|
|
settlingWindowMs: 3_000,
|
|
},
|
|
);
|
|
|
|
assert.deepEqual(pendingRuns, [run]);
|
|
assert.deepEqual(sleeps, [3000, 3000, 3000, 3000, 3000, 3000]);
|
|
});
|
|
|
|
test("waitForPendingApprovalRuns stops after the first-appearance timeout when no runs arrive", async () => {
|
|
let calls = 0;
|
|
const sleeps: number[] = [];
|
|
let now = 0;
|
|
|
|
const pendingRuns = await waitForPendingApprovalRuns(
|
|
async () => {
|
|
calls += 1;
|
|
return [];
|
|
},
|
|
async (ms) => {
|
|
sleeps.push(ms);
|
|
now += ms;
|
|
},
|
|
() => now,
|
|
{
|
|
firstAppearanceTimeoutMs: 9_000,
|
|
},
|
|
);
|
|
|
|
assert.deepEqual(pendingRuns, []);
|
|
assert.equal(calls, 4);
|
|
assert.equal(sleeps.length, 3);
|
|
assert.equal(now, 9_000);
|
|
});
|