1 Commits

Author SHA1 Message Date
lefarcen 9cac9d6fc7 fix(collab): stop reporting cancelled team pulls as failures (#7405)
Revert the first-open download indicator and keep the one verified fix the
investigation produced.

The indicator is gone because it was measured, repeatedly, not to work. Against
a live vela Team workspace with two distinct accounts and two isolated daemons
it never rendered once — empty project or 3 MB one, warm data root or cold,
even racing the share. `proactiveContentPull` materializes the content before
the user can open it and wins that race every time, so the window the indicator
was built for does not exist. Its unit specs were green throughout, which is
exactly why they are not kept: they would have locked in coverage for a surface
nobody can reach.

What the investigation did find is that a deliberately cancelled `vela` child
was reported as a failure. `runVelaCommand` marks an abort with
`name: 'AbortError'` / `code: 'ABORT_ERR'` and keeps a separate `timeout`
termination, but nothing downstream read those markers. The proactive pull
scheduler aborts as ordinary control flow — `mergeIntentUpdate` when a higher
published version supersedes the fetch, `clearIntent` when an intent is
superseded or satisfied — so routine version churn logged
`authorized proactive team pull failed closed`, and sent at least one
investigation chasing a fault that never happened.

`isAbortedOperationError` now draws that line at both sinks: the `failed
closed` warning in collab-sync, and the single `onError` consumer that backs
proactive-content-pull's three raise sites (that module is deliberately
import-free, so the distinction belongs at its consumer).

Behaviour is unchanged; this is log correctness only. An aborted intent already
bumped `revision` and re-looped, or was removed outright, so it never reached
the retry/backoff accounting.

The predicate lives in a dependency-free module on purpose. Importing it from
`vela-command.ts` pulled `runtimes/env` + `runtimes/registry` into the route
module graph, where `collab-sync-routes.test.ts` mocks `integrations/vela.js`
with a single export — turning a passing pull into `register_failed`. That
regression was caught only by running the neighbouring suite.
2026-08-25 14:39:50 +00:00