66 Commits

Author	SHA1	Message	Date
open-design-crew[bot]	4908baa4f4	feat(design-systems): ship structured runtime workflow (#6805) ... * feat(design-systems): add structured runtime contract (#6456) * feat(design-systems): add structured runtime contract * chore: retrigger CI for PR 6456 --------- Co-authored-by: xiaoche-hub <298951296+xiaoche-hub@users.noreply.github.com> Co-authored-by: mrcfps <mrc@powerformer.com> * feat(design-systems): resolve structured runtime intents * fix(design-systems): preserve workspace runtime scope * test(design-systems): cover scoped prompt runtime * fix(design-systems): use one component authority * fix(design-systems): preserve run workspace authority * fix(design-systems): honor runtime rollback gate * fix(design-systems): pin run binding authority * fix(runs): reject client-supplied scopes * fix(design-systems): keep user package assets scoped * feat(design-systems): validate generated UI adherence * test(e2e): assert durable reload authority state * fix(design-systems): reject non-executable adherence evidence * fix: harden design system adherence validation * fix(design-systems): validate JSX selectors structurally * fix(design-systems): close adherence input gaps * chore(nix): refresh pnpm dependency hashes * chore(ci): retrigger design system validation * fix(daemon): bound design system artifact reads * fix(design-systems): bridge Codex runtime tools * docs(codex): clarify shell environment policy --------- Co-authored-by: open-design-crew[bot] <299007234+open-design-crew[bot]@users.noreply.github.com> Co-authored-by: xiaoche-hub <298951296+xiaoche-hub@users.noreply.github.com> Co-authored-by: mrcfps <mrc@powerformer.com>	2026-08-13 09:02:20 +00:00
YOMXXX	d5fd790659	fix(deps): patch Docker runtime CVE floors (#6733)	2026-08-12 06:44:48 +00:00
Amy	a338a13aab	test(ci): harden Functional E2E and daemon release gates (#6708) ... * test(e2e): harden coverage and runtime isolation * test(e2e): gate prerelease on full functional suite * test(daemon): enforce prerelease coverage * test(daemon): stabilize full-suite fixtures Generated-By: looper 0.11.8 (runner=fixer, agent=codex) * test(e2e): preserve interaction regression coverage Keep deck navigation subject to Playwright actionability checks and restore the current rail updater/composer stacking witness as an explicit expected failure. Generated-By: looper 0.11.8 (runner=fixer, agent=codex) * fix(ci): close conformance validation gaps Generated-By: looper 0.11.8 (runner=fixer, agent=codex) * test(e2e): restore MCP snippet style guard Restore the browser-computed style witness that was over-deleted when the OAuth flow moved to Integrations, and navigate through the current Settings MCP server entry.\n\nGenerated-By: looper 0.11.8 (runner=fixer, agent=codex) * fix(ci): close directive and job-boundary gaps Compare normalized MUST_FIX directives as sets so identical multi-item rounds remain weak debates, and bound workflow topology assertions to their immediate sibling jobs.\n\nGenerated-By: looper 0.11.8 (runner=fixer, agent=codex)	2026-08-11 08:31:14 +00:00
open-design-release-bot[bot]	d1f5e1f2fb	chore(release): bump main to 0.18.2 ahead of stable 0.18.1 (#6588) ... Co-authored-by: open-design-release-bot[bot] <open-design-release-bot[bot]@users.noreply.github.com>	2026-08-10 04:53:24 +00:00
lefarcen	356c8c364f	feat(workspace-team): team workspaces, shared resources, workspace-scoped billing, and the #5517 redesign (#6142) ... * fix(web): scope plugin URL imports to workspace * test(web): cover billing interest remount lifecycle * feat(packaged): enable the workspace-team transport for test-profile builds The vela test backend now serves the workspace-team API, so a packaged build baked with the test AMR profile should drive team projects / collab / resource sharing there instead of leaving them dormant. Replace the single feature-test equality check with a profile -> vela web origin map so adding a backend is one entry, and keep every unlisted profile (prod above all) off. * test(daemon): cover billing catch-up after SSE reconnect * fix(collab): surface and start first materialization when opening a shared project QA P0: a brand-new member on a fresh install joins someone's workspace, opens a project from it, and sees no loading state and no files — content only appears on a SECOND open, much later. Two defects, both on the first `/collab/status` request that opening a shared project makes. 1. No pull is started. The daemon's self-materialization block was gated on `callerIsOwner`, so a non-owner member got the placeholder record registered and nothing else. The web's auto-pull is gated on `publishedVersion` advancing past its cursor, and a fresh daemon's first status response cannot carry a published head: `collab.publishedVersion()` reads an in-process map that has never been written, and the real hub head is fetched fire-and-forget into `headEnrichmentCache` for a LATER poll to consume. Materialization therefore arrived only whenever a proactive lane (hub push / reconnect catch-up / the 30s recovery floor) next fired — the "second open" the report describes. 2. No download state is shown. `useProjectCollab.downloadPending` — which picks DesignFilesPanel's "Syncing files from the team…" over its empty state and create-a-file CTAs — reads only `publishedVersion > cursor`, `contentTransferState`, and an in-flight pull. All three are blank on that first response, so the member was shown an empty project inviting them to start creating over content that was still on its way. The fix makes the placeholder stamp the load-bearing signal on both sides: - `materializePlaceholderOnOpen` (routes/collab-sync.ts) replaces the owner-only block: any viewer opening a shared project whose only local record is an unmaterialized placeholder starts its pull on that same request, through the same coalesced flow. The retracted-share heal in its catch stays owner-only — a member who hits the hub tombstone has merely lost access and must not unshare anyone's project. - `/collab/status` reports `awaitingFirstMaterialization`, a purely local, synchronous fact that needs no hub round-trip and is therefore available on the very first response. `od collab status` prints it too. - `localFilesAreNotTheContentYet` (useProjectCollab.ts) makes it always download-pending, bypassing the member-only `shouldAutoPull` gate: whether the local files are the content is a fact about the record, not about who may pull it, so the owner of an unmaterialized placeholder (the reinstall case, recvqzaDvUU6B3) stops seeing the same empty state too. Red evidence: all six new specs fail on origin/feat/workspace-team @ 793d7b92c — the first status response reported `awaitingFirstMaterialization: undefined` with publishedVersion/materializedVersion/contentTransferState all null, `beginContentTransfer` was never called for a member's first open, and `downloadPending` was false for both the member and the owner. * chore(packaged): inject the vela web origin at build time, not source This repository is public. Commit 319cb42b3 added a profile -> vela web origin table to apps/packaged/src/sidecars.ts, which put an internal environment's hostname into product source and would have published it on merge. The same hostname had also reached apps/web/src/runtime/amr-guidance.ts as a new profile row. Internal AMR environments are not public (one of them fronts a Stripe sandbox), so their origins now travel the same build-time path POSTHOG_KEY already uses: release-beta.yml env (per-profile secret) -> tools-pack config (OD_VELA_WEB_URL) -> open-design-config.json (velaWebUrl) -> packaged config -> daemon spawn env (OD_VELA_WEB_URL) -> GET /api/integrations/vela/status (consoleOrigin) -> web runtime console links The workspace-team gate keeps its meaning and gets stricter: it now needs an allowlisted AMR profile AND an injected origin. `prod` can never satisfy the profile half, so a stable build stays dormant however it is configured, and a feature-test/test build whose secret is unset stays dormant too rather than pointing the transports at an unknown backend. A build with no secret configured therefore ships with workspace-team silently off — the same failure mode as a fork build without POSTHOG_KEY, and the safe direction for an unreleased feature. apps/packaged/tests/source-origins.test.ts is a standing guard: every absolute URL literal under apps/packaged/src must resolve to a publishable host, so the next backend origin cannot be hardcoded there either. Secrets required for a workspace-team dogfood build: VELA_WEB_URL_FEATURE_TEST, VELA_WEB_URL_TEST. * test(e2e): follow the #5517 plugin-details route in the visual capture `captures the home plugin use staged surface` has been failing on this branch since before the main merge. It was written against the pre-#5517 UI: clicking a marketplace card opened a role="dialog" details overlay with a per-slug `plugin-details-use-<id>` action. #5517 made plugin details a full-page route — `openCardDetail` calls navigate({ kind: 'marketplace-detail' }) for plugin records, rendering `PluginDetailView` at /marketplace/<id> whose Use control is a single `plugin-detail-use` button. Per the product rule that the accepted feature-branch UI is the source of truth, the test follows the route instead of the UI being changed back. Asserting the route alone was not enough: the detail surface refetches the record from /api/plugins/<id>, which the visual fixture never mocked (it mocks the list, */preview and */apply), so the route rendered its "Failed to load plugin: HTTP 404" branch. configureVisualPage now serves the single-plugin GET from the same VISUAL_PLUGINS fixture. The capture asserts the Use button rather than the `plugin-detail` shell because the shell also renders for the loading and load-failed states. * fix(packaged): restore masked CLI icons (#6154) * Sync local workspace-team batch: UI polish, popover simplification, update-reminder progress (#6156) * UI polish batch: import-dialog cleanup, settings toast placement, tab chrome fixes - Plugin/skill import dialog: drop per-card icons, left-align card content - Settings page: center the autosave pill under the top nav - Avatar model menu: soften the pinned footer divider - Workspace tabs: pinned entry tab always reads as Home; remove tab-search button and its popover - Model picker: wider row gap in the two-pane browse popover - Community header: unpin (scrolls with content) - New update-reminder dialog assets and strings - Keep entry-settings-button as the signed-out settings entry (e2e contract); align NextStepActions with the navPlugins key rename * Update reminder: simulate in-place download progress instead of linking out The strip's confirm now runs a staged progress state ('updating') with an eased fake download bar, then marks the version updated — replacing the jump to the GitHub releases page. * test(web): retire AvatarMenu account-row suites after the popover simplification The composer popover was reduced to a model picker (2026-07-24): the Open Design account row — plan badge, balance, wallet fallback, upgrade/console links — no longer renders there, so the nine suites asserting that surface (including the workspace-balance and billing-permission gates that landed upstream meanwhile) can no longer pass. Drop them and recast the remaining account-row test as the guard for the new invariant: a signed-in AMR status must render no account UI in the popover. Also drop the stale onClose prop from the new upstream sign-out-confirm test; the rail no longer takes one. * Design-systems toast: anchor to the pane's top edge, pill radius * Update reminder strip: progress ring on the button, percent face While updating, the collapsed strip no longer stacks a label + bar above the rocket button. Progress draws as a brand-green ring hugging the round button's edge (5px band reserved so the button never shifts), and the button face swaps the rocket for the bare percent — 'N%' while downloading, 完成 (updater.done) at 100. The full 正在下载更新 N% label stays reachable via the hover bubble and the ring's aria-label. Demo payload version bumps to 1.4.6 so the once-per-version card re-arms. * fix(web): restore design kit section spacing (#6155) * fix(web): carry the plugin back to Home when Use runs from the detail route Product call: using a plugin from the full-page detail route should land on Home with that plugin already selected and its brief pre-filled, exactly like the marketplace card's "Try it". It did not. `PluginDetailView.onUse` applied the plugin, kept the result in local state, and navigated home. `App` renders that route outside `EntryShell`, so the navigation unmounted the holder and dropped both the plugin and the brief — Home came up empty. The "redirected to Home with the brief pre-filled" note under the button could never be seen either, since the navigation fired immediately; it is removed rather than left lying. Reuses the existing channel instead of adding a parallel one: onUse now publishes the same `createPluginUseHandoff` payload "Try it" produces, and Home's existing pendingPluginUseHandoff path applies it unchanged. The handoff is parked in module scope — not on `window` — so it survives the unmount, and `EntryShell` claims it in a lazy state initializer so it arrives in the same commit as the mount. Reads are destructive, so a handoff applies once and does not re-fire on the next visit to Home. Red first: PluginDetailView.use-handoff.test.tsx fails on the unfixed code at the handoff assertion (navigation and the failure path already passed), and goes green with this change. The e2e visual capture that asserts home-hero-active-plugin should follow without weakening its assertion. test(e2e): match the settings surface in both #5517 presentations openSettingsDetailsFromHeader still waited on `.modal-settings[role="dialog"]`. #5517 routes the entry's settings to /settings, where SettingsDialog renders in presentation="page" mode with `role="region"`, so that selector never matched the page presentation: an already-open settings surface looked absent and the helper fell through to hunting for entry triggers that surface does not carry, failing 16 captures on one line. Reuses `settingsSurface` from amr.ts — the existing bare `.modal-settings` matcher both presentations share — rather than adding a third local variant. That helper also documents why the `role="dialog"` fallback was actively wrong: AvatarMenu is a dialog too, so it could resolve to the account menu. * test(e2e): open the nav rail before reaching for entry settings The bare-`.modal-settings` change alone did not move the settings-workspace lane: all 16 captures still died on `.settings-icon-btn`, because the failure happens before the surface selector matters. None of the four triggers was ever visible. amr.ts already documents why. #5517 moved the entry settings chip into the nav rail footer, and a collapsed rail is `inert` + `aria-hidden`: the chip is present but invisible to `getByRole`, and even a programmatic `element.click()` is a no-op. `openSettingsDialog` expands the rail first (`ensureEntryRailOpenIfPresent`), clears loading, dismisses the privacy dialog, matches the surface with the shared bare class, and ends its trigger chain on the settings aria-label instead of `.settings-icon-btn`, which the entry surface does not carry. It also clicks `entry-settings-open-details`, so it is a superset of the local copy. So `openSettingsDetailsFromHeader` now delegates to it and keeps only its name, leaving exactly one settings opener instead of a third variant. * test: realign the suites #6156 outpaced, and reach Settings from a project #6156 (4e3161751) landed a UI batch whose test fallout was only partly handled. Four Vitest files and four e2e call sites still describe the surface as it looked before it, and the Playwright settings opener never had a trigger that exists once a project is open. Vitest — the assertions now read the surface that shipped: - community-view: the type tabs traded their `<small>` count badges for type icons, so `readFacets().badge` was `NaN`. Counts move to a new `readFacetCardCounts()` that drives each tab and counts the grid — the same array the badges were derived from, so the catalogue-fidelity guard (including "never grids more than the whole catalogue") survives the badge's removal rather than being dropped. - home-logo-assets: the rail's signed-out brand header is gone (with no cloud identity the rail starts at the search box), so it can no longer carry `od-brand-glyph`. Keeps the guard that still means something: it must never fall back to the retired raster app icon. - acceptance-visual-fixes: recvq4iEq1Esno's fix is intact — page mode still hides only `.settings-chrome-btn`, leaving the autosave pill visible. #6156 re-added the bare `.settings-page-shell .settings-chrome` selector purely to centre that pill under the top nav, so assert the invariant the row is about (no page-mode `display: none`) instead of the selector's absence. - FileViewer: the new `artifact-preview-first-load` cover is a `role="status"` of its own, so `findByRole('status')` had become ambiguous. Scope the success assertion to the toast. e2e — `entry-nav-settings` no longer exists anywhere in `apps/web/src`; the rail item carries `entry-settings-button`. #6156 renamed it and updated entry-chrome-flows' two `toHaveCount(0)` assertions but not the four places that click or await it (critical-smoke, entry-topbar x2, entry-chrome-flows x2). `openSettingsDialog` also only ever knew entry-shell triggers, all of which live on Home. From a project every one of them is absent — and `EntrySettingsMenu` and `AppChromeHeader`'s `SettingsIconButton` are both unrendered — so the surface never opened and the failure surfaced as a missing `.modal-settings`. Add the project surface's real entry: the composer model popover's pinned `avatar-open-execution-settings`, with the topbar switcher's `inline-model-switcher-open-settings` as a second route. Not addressed here, deliberately: #6156 also deleted the `settings-general-field` block that rendered `AppearanceSection`, orphaning the component. That removes the product's only System/Light/Dark control (the rail's account menu dropped its theme row *because* Settings owned it), so the 11 `SettingsDialog.execution` appearance failures are reporting a capability loss, not a stale expectation. Restoring it is a product call, so those tests are left red rather than weakened. * test(e2e): finish the popover the settings chain opens on a project surface `openSettingsDialog`'s trigger chain ends on OPEN_SETTINGS_LABEL, which matches `Account & settings` — and that is `avatar.title`, the label on AvatarMenu's own trigger. So on a project surface the chain does find something and clicks it, but what opens is the composer's model popover, not Settings. The follow-through step then looked only for `entry-settings-open-details`, which #5517 left unrendered, so the run gave up with a missing `.modal-settings` after three identical attempts. Widen the follow-through to the two rows that actually route to Settings from a project — AvatarMenu's pinned `avatar-open-execution-settings` and the topbar switcher's `inline-model-switcher-open-settings` — so whichever popover the first click opened gets finished. * test(e2e): pin the AMR selection assertion to the agent card With Settings actually opening from a project surface again, the surface-wide `/Open Design/i` in amr-logout-requires-relogin resolves to the sidebar's "Open Design MCP" `settings-nav-item` — which carries no `aria-pressed` — not to the AMR agent card's select button. The looseness was invisible while the surface never opened. Read the toggle through `settings-agent-card-amr` instead, so the assertion names the thing the test is about: AMR stays the selected agent. * test(e2e): prove Settings opened via its section nav, not a heading probe `prepareVisualSettingsDialog` gated on a heading matching /Settings|General|Execution mode/. Now that the surface opens from a project it lands on the execution section, whose heading reads "Models & providers" — and the surface's own <h2> is consumed as its accessible name via aria-labelledby anyway, so the probe could not match in either presentation. Assert `settings-nav-execution` instead, which is what critical-smoke already uses for the same purpose and holds for both the modal and the routed page. * test(web): retire the theme/appearance cases the product cut Product decision (2026-07-28), verbatim: 「主题设置不要了,因为 workspace 功能不 支持暗色主题,要干掉,并且之前用户如果设置了暗色主体,需要强制改成明亮色主题」 So #6156 deleting the `AppearanceSection` render site was the right direction, and the NON-ALIGNMENT #9 note that argued for keeping the segmented control as the product's last "follow system" entry point is formally overturned. These cases are retired because the capability is gone by decision — NOT to turn CI green. The source-side removal (orphaned `AppearanceSection`, onboarding light/dark toggle, `settings.appearance*` keys, `trackSettingsAppearanceClick`, plus forcing stored dark/system back to light for existing users) lands separately on `fix/remove-theme-force-light`. Deleted (8) — their whole subject was theme or the accent it carried: - offers the theme segmented control, and System leaves the document theme unset - applies the stored default accent color even though the picker is gone - writes the picked theme to the document and autosaves it - live previews the configured theme on open, and System leaves no explicit document theme - reverts an unsaved appearance preview back to the saved appearance when the dialog closes - persists System mode explicitly and preserves accent variables without an explicit document theme - keeps a stored non-default accent applied and carries it through an autosave - localizes the theme controls in Chinese Nothing was left behind as a loose "still renders something" assertion, and no live coverage went with them: the close-button/`onClose` path the revert case also touched is already covered at five other call sites in this file. Kept (3) — theme was only the vehicle, the subject is still shipping. Each now rides the notifications completion-sound toggle, seeded on so the single click is a real state change (the pills no-op when clicked in their current state): - reconciles the open settings draft when the parent agent CLI env changes — the only integration proof that `reconcileAmrModelChoice` / `reconcileAmrProfileEnv` actually run through the real draft on autosave; its two siblings are pure unit tests and do not cover that path. - drops a pending autosave when explicit onboarding reset unmounts Settings — subject is the pending-autosave drop and the draft the reset carries. - still autosaves an unrelated edit that lands during a silent-update save — subject is autosave bookkeeping (success must only advance autosaveLastSavedRef for allowSilentUpdates). The enclosing block is renamed 'SettingsDialog draft reconciliation' since it no longer describes appearance, and its document theme/accent teardown is dropped — nothing in it writes those any more. 144/144 green. * test(e2e): realign the visual workspace captures with the narrowed surfaces Three deliberate narrowings shipped without this Playwright lane following, so eight captures were driving UI that no longer renders. All eight are stale fixtures; none was a regression. - `ef9c8cd8b` made the home top-bar `InlineModelSwitcher` `compact`, and `EntryShell` (its only call site) always passes the flag. In compact mode the popover is just the active agent's model radio list plus the route to 設定 → 執行; the mode segmented control, agent grid, account block, and both searchable dropdowns live in the non-compact branches. `68cecac1c` records that product confirmed this narrower shape, so acceptance #40 ("home 页不能 切换 cli 了") is working as designed. - `4e3161751` (#6156) removed the Open Design account row from `AvatarMenu` (plan badge, balance, wallet fallback, upgrade/console links) and retired the nine equivalent Vitest suites — but not these. - `56b538aa4` moved the design-system picker out of the staged-context bar, so `staged-contexts` is no longer unconditionally mounted. Where a surface still ships, the capture follows it and the assertion got sharper rather than looser: staged contexts now stages a real attachment and names the chip; the topbar/avatar captures assert the surviving model picker plus the *inverse* invariant (no account block, no upgrade button, no balance), gated on a counted `vela/status` request so a negative cannot pass by racing the fetch. `:57` additionally pins `inline-model-switcher-mode-daemon` at count 0, so re-mounting the CLI console on Home fails here again. `:167` (topbar BYOK model dropdown) is deleted: in compact mode it would re-capture the identical popover as `:141`, which is a duplicate screenshot rather than coverage. `:141` absorbed its guard. `:244` (avatar reasoning readout) turned out never to have passed — not a #6156 casualty. `VISUAL_CLI_AGENTS`' codex entry declares `models` only, while `AvatarMenu` draws the readout solely for agents reporting `reasoningOptions`, so it has been red since `68cecac1c` authored it. Fixed by declaring `reasoningOptions` on a test-local codex fixture, matching what the real daemon reports (`apps/daemon/src/runtimes/defs/codex.ts:164`). Nothing was dropped without a verified live home elsewhere in the same CI lane or in Vitest: the AMR plan/balance/upgrade card at `visual-settings.test.ts:30`, the searchable dropdowns at `visual-settings.test.ts:93`/`:156`, the upgrade attribution URLs in `InlineModelSwitcher.test.tsx:585` and `AvatarMenu.test.tsx:283`, the "no account row" invariant at `AvatarMenu.test.tsx:528`, and real staged-context chips in `project-management-flows.test.ts`. The one assertion with no surviving home is the Open-Design-first agent ordering, whose grid no longer renders anywhere; that is called out in the test comment rather than silently lost. * test(e2e): give the AMR upgrade capture a billing-capable workspace `settings-agent-card-amr-upgrade` stopped rendering for this capture because `amrCardCanUpgrade` (SettingsDialog.tsx:4651) now also requires `workspaceContext?.permissions?.canManageBilling` — this branch's workspace-scoped billing work, i.e. the feature #6142 exists to ship. The gate is correct; the fixture was not representing anyone entitled to pass it, since `mockSignedInVelaAccount` establishes a Vela session but no workspace context. Stub `/api/workspace/context` with a personal-owner context inline in this one test rather than widening `mockSignedInVelaAccount`, which visual-workspace shares. The assertion is unchanged — the upgrade entry is a real capability for billing-capable members, so the fixture represents one instead of the assertion being relaxed. Verified the stub does not quietly satisfy the three assertions that already passed: `planId: null` keeps `resolvePlanTier` falling through to `plus`, and billing still 404s so the balance stays `$247.51`. Expect one legitimate baseline diff on `visual-settings-open-design-account`: the rail now renders signed-in workspace chrome, which is the only state in which the upgrade entry exists at all. * test(e2e): leave projects through shipping chrome, and reach /projects reliably Two dead locators and one under-budgeted wait, all test-side. `openNewProjectModal` (rail.ts) probed `entry-nav-new-project` then `entry-nav-projects`, both deleted from EntryNavRail by the #5517 redesign (`b55f17169`, `f16075f7e`) — `onNewProject` is still destructured there but has zero call sites. Its body is byte-identical to main, where both testids exist, so main takes the rail path and never reaches the fallback this branch always hits. The live affordance is `designs-new-project` / `designs-empty-new-project` in DesignsTab, inside `entry-view-projects`; `/projects` has no UI entry at all (entry-chrome-flows:373-382 already documents that and routes directly). The fallback then failed for a second reason: `entry-view-projects` does ship (EntryShell.tsx:1579) and `/projects` does route to it, but it was asserted on the 10s default budget right after `waitUntil: 'domcontentloaded'`. `apps/web` mounts `src/App` via `dynamic(..., { ssr: false })`, so domcontentloaded fires while only the boot shell exists — every suite that does this correctly waits out `Loading Open Design…` with `T.long` first. Now routed via `history.pushState` + `popstate` (the client router listens) instead of a full reload, boot shell waited out, and both the view and the create button given `T.long`. `ensureRailOpen` was also called unconditionally, but it ends in a hard `expect(workspace-home-rail-toggle).toBeVisible()` and that testid only renders for `isPinned && active` (WorkspaceTabsBar.tsx:1474-1510) — from inside a project it does not exist, so the helper hard-failed on a control this flow never needed. Now best-effort and gated on `.entry`, kept only so the `visual-new-project-modal` baseline does not churn. `real-daemon-run.test.ts:547` hung on `/back to projects/i`, which matches nothing on a project surface: `AppChromeHeader` owns that aria-label but is no longer mounted anywhere, and ChatPane's top-left slot resolves `onCollapse ?? onBack` while ProjectView passes both, so it is always `chat-collapse-toggle` (deliberate, `884ed1085`). Replaced with a local `leaveProjectForEntry` that clicks the pinned entry tab — the shipping way out — so the isolation journey still leaves through real chrome instead of a URL jump. Dropped `getActionablePoint` with its only consumer. Removing the reload from ~25 call sites across 15 suites was audited against the stub-order-sensitive ones (settings-media-providers, new-project-ds-picker-*, api-empty-response, visual-entry); all install routes before their first navigation. Correcting my own earlier misattribution: `.ws-tab` / `.ws-tab-label` are FileWorkspace's in-project file strip and are fully intact, `role="tab"` and file-name labels included. #6156 rewrote WorkspaceTabsBar, which renders `.workspace-tab` / `.workspace-tab__label` — a different component. Upload→tab is also intact (`FileWorkspace.uploadFiles` still calls `openFile`). Five of those six failures merely routed through the broken helper above; the sixth was the dead back-button. No `.ws-tab` assertion was rewritten. * fix manual edit across workspace pages (#6160) * fix(collab): keep process-local presence alive when the collab transport is off (#6170) `createVelaCliCollabClientFromEnv` returns `null` unless the run opted into the vela-cli collab transport, but `server.ts` wired the presence routes with an object literal of arrow functions closing over that client. A literal is unconditionally truthy, so `registerCollabPresenceRoutes` always saw a `cloud` dependency: its `deps.cloud ?? null` could never resolve to `null`, the process-local `presence.present()` fallback became dead code, and every presence request that reached the cloud branch dereferenced `null` and was answered `502 collab_presence_unavailable`. `POST /api/projects/:id/presence/leave` carries no shared-project precondition, so it failed on any project id in any run without the transport — every stable/prod packaged build (the packaged workspace-team env is gated to the `feature-test`/`test` AMR profiles) and every plain `tools-dev` run. `server.ts` is `@ts-nocheck`, so the null dereference was invisible to `pnpm typecheck`. Route the dependency through `createCollabPresenceCloudClient`, which lives in the checked route module and states the invariant: a `cloud` dependency exists if and only if a transport exists. Removing its guard is now a typecheck error, so the bug class cannot come back at the construction site even while `server.ts` stays unchecked. * fix(web): scope desktop vibrancy to macOS (#6171) * fix(web): remove the theme setting and force every install back to light (#6168) Product removed theme selection: the workspace surfaces shipped for team workspaces have no dark tokens, so dark mode renders a broken app. Deleting the picker is not sufficient on its own. Every install that ever opened it still has `theme: 'dark'` — or `'system'`, which resolves dark on a dark OS — persisted in localStorage, and a stored value does not move when the default does. So the theme is now coerced on READ, at all three points a persisted value can reach the document: - `loadConfig()` funnels `parsed.theme` through `resolveAppTheme()` and marks the config migrated so the coerced value is written back once. - `applyAppearanceToDocument()` stamps `data-theme="light"` unconditionally. The attribute must be PRESENT, not merely non-dark: every dark CSS rule is gated on `html:not([data-theme])` / `html:not([data-theme="light"])`, and every JS theme reader (shiki, ConnectorLogo, SketchEditor, TerminalViewer, connectorBrandColor, MentionNode) falls back to `prefers-color-scheme` only when the attribute is absent. - The pre-hydration inline script in `app/layout.tsx` stamps light before React mounts, outside its try/catch so a throwing storage read still leaves the attribute set. Electron's `themeSource` defaults to `system`, which colours everything the web layer does not own (macOS vibrancy glass, native menus/dialogs) on a dark-mode Mac — including the splash, before the renderer's appearance IPC lands. It is now pinned to light before the first window exists. Removed surfaces: - `AppearanceSection` in SettingsDialog, orphaned by #6156 (zero call sites), together with its `settings-general-block--appearance` styles. Its docblock claimed the control was "deliberately kept … NON-ALIGNMENT #9"; that decision is superseded, so the comment goes with the code. - The onboarding welcome page's sun/moon toggle — the last reachable theme writer — and the `onThemeChange` prop chain behind it (App → EntryView/ProjectView → EntryShell → OnboardingView). - The orphaned theme row in EntrySettingsMenu and its styles. - i18n keys `settings.appearance`, `settings.appearanceHint`, `settings.themeSystem`, `settings.themeLight`, `settings.themeDark` across `types.ts` and all 19 locales. - Analytics `trackSettingsAppearanceClick`, `SettingsAppearanceClickProps`, and the `settings_popover` `appearance` element. `'appearance'` survives only as a legacy settings deep-link token that `normalizeSettingsSection` folds into General, so an old link is not a type error. Red-first: tests/state/force-light-theme.test.ts and tests/components/theme-settings-removed.test.tsx were written against the unmodified branch and went red (11 failing) before any source change. * fix(web): make the update surfaces read real data (#6163) * fix(web): make the update surfaces read real data #6156 (4e3161751) shipped two update surfaces whose every field was invented. `EntryShell` held a private `updateReminderStage` machine keyed on a literal `'1.4.6'` (the app ships 0.16.1), the rocket's confirm ran a 200ms `setInterval` easing a fake bar toward 100% and then wrote "updated" to localStorage, and the cover dialog listed three hardcoded English notes past i18n over a committed 432 KB JPEG. Nothing in that path made a single network, IPC or daemon call — a user who clicked "立即更新" watched a progress ring finish and got no update. Both surfaces now sit on the real machinery that already existed: The cover dialog becomes the post-update highlights surface and REPLACES the bottom-right `WhatsNewPopup` card rather than coexisting with it. Cover art, release headline, bullets and link all come from the hosted highlights document via `/api/whats-new`; the title states the running version from `useAppVersion()` (`/api/version`). It keeps that card's show gate verbatim — once per highlight `id`, only with content, only on the home surface after the app returns on a new version — and its existing analytics (`whats_new_popup` surface-view / click). Its footer is close + open-release; there is no "cancel / update now", because reporting what already shipped is all this surface does. Bullets come from a new `whatsNewNotesFromBody`, which splits the document's `body` per line and strips operator list markers. The rocket keeps its look and becomes the real updater's ready indicator in the bottom-left rail footer, replacing that indicator's arrow glyph. It is gated on the updater's own `shouldShowControl` (installer downloaded and never opened, desktop only) and still drives `openUpdaterInstaller` → `quitAfterUpdaterInstallerOpen` through the untouched panel, watchdog and restart-safety preflight. The progress ring and percent face are gone on purpose: the indicator only exists once the download has finished, so any percentage it drew would be invented. Deleted: `lib/update-reminder.ts`, `UpdateReminderDialog.tsx` and its module CSS, `public/update-reminder-cover.jpg`, the now-dead `entry-updater-menu__button/__glyph/__progress` rules, and the unused `accountNotice` rail slot. The three `updateReminder.*` i18n keys and the orphaned `whatsNew.dismissAria` are replaced by one `whatsNew.updatedTitle` across all 19 locales. A source-level guard (`tests/update-surface-real-data.test.ts`) pins the invariant that outlives the deletion: no quoted `x.y.z` and no `setInterval` in the update surfaces, and the placeholder module and cover art stay gone. * fix(web): name the release-notes destination on the what's-new CTA Product review of the five open calls closed all five; only the CTA copy changes. The button opens the release notes, so it now says so — 「查看更新说明」 in Chinese (product's wording, verbatim), with the other 18 locales aligned on "view the release notes" instead of inheriting the old "see what's new" tease. `whatsNew.cta` had exactly one consumer left (the dialog) once it replaced the bottom-right card, so the key is repurposed in place rather than forked. The other four calls were approved as implemented, and two of them overturn conventions the old comments still asserted, so those comments are synced: - `lib/whats-new.ts` documented the toast's deliberate Escape exemption (Escape hid the card WITHOUT spending the highlight). As a focus-trapping modal that exemption is retired — every close path marks seen — and the docblock now says which paths and why. - `contracts/api/whats-new.ts` described `title` as generic copy, `imageUrl` as an image "beside the copy", `body` as prose, and `linkUrl` as the "See what's new" link. The dialog reads them as headline / top-inset cover / one-bullet-per-line / release-notes link, so each field now documents the role it actually plays. Comment-only; no shape change. * fix(web): never state the placeholder version on the what's-new dialog Review catch (nettee, #6163): `useAppVersion()` reads /api/version at runtime, so it necessarily boots on `APP_VERSION_PLACEHOLDER` and resolves a round-trip later. This dialog rendered as soon as /api/whats-new resolved and printed the hook unconditionally — so a highlights fetch that won that race painted "Open Design 0.0.0 is here" on first frame. An invented version string, on the one surface this PR exists to make truthful. The new suite could not see it because it mocked the hook to an already-resolved value. Fixed by falling back rather than gating the whole render: gating would delay the dialog behind a second round-trip on slow networks, while the highlights document already carries the running version in its `version` field — the daemon stamps it for display (see contracts/api/whats-new.ts), which is what fed the old bottom-right card's eyebrow. So `statedAppVersion()` prefers the resolved hook, falls back to the document, and returns null when neither can name one; on null the dialog waits, because highlights are worth nothing under a headline that lies. The same derived value feeds the title AND every `app_version` prop, so analytics cannot ship the placeholder either. `APP_VERSION_PLACEHOLDER` moves out of ./provider into a new leaf analytics/app-version.ts alongside an `isResolvedAppVersion()` predicate, so a surface that must not PRINT a placeholder can test for it without importing the analytics client. The provider keeps its own use of the constant. Regression tests, red before this commit (`.red-evidence-version-race.txt` reproduces nettee's exact string, `expected 'Open Design 0.0.0 is here…' not to contain '0.0.0'`): the placeholder never paints while /api/version is in flight, it never reaches the surface-view analytics, the title switches to the running version once the hook resolves, and a document with no usable version waits instead of inventing one. The suite's provider mock is now a mutable holder so both sides of the race are reachable. Also caught by this PR's own source guard: quoting the literal in a docblock tripped it, so the comment names the constant instead. * test(e2e): unmask the AMR runtime lane and repair the visual settings/workspace captures (#6174) Three fixture defects, each verified by running the lane rather than reading it. - amr-run-failure-recovery.test.ts was still `mode: 'serial'`. A second `describe.configure({ timeout })` cannot clear it — configure only overwrites the keys it is given — so one failure skipped the eight cases behind it and the lane reported them as "did not run". e2e/AGENTS.md forbids serial groups outright. - configureVisualPage's `**/api/**` catch-all (added by #6126, which is on main) answered `/conversations` with 404. ProjectView mounts ChatPane only once a conversation resolves, and both listConversations and createConversation swallow a non-ok response, so the project opened with no conversation and no error, ChatPane never mounted, and every capture that enters the workspace died on `chat-composer` not existing. Supplies the conversation boundary the catch-all closed without replacing. - The BYOK tab is named "API providers" since #5971 renamed `settings.modeApiMeta`; `getByRole('tab', { name: 'BYOK' })` matched nothing and three captures hung until the test timed out. The topbar BYOK capture also left `[MOCK_AGENT]` installed, contradicting its own "a BYOK config has no local agent" premise: an installed agent wins the popover and renders its model radiogroup instead of the BYOK rows. Co-authored-by: lefarcen <ontf116@gmail.com> * Home shell productization batch: message center, What's-new on release data, update-reminder & updater popup restyle (#6162) * UI polish batch: import-dialog cleanup, settings toast placement, tab chrome fixes - Plugin/skill import dialog: drop per-card icons, left-align card content - Settings page: center the autosave pill under the top nav - Avatar model menu: soften the pinned footer divider - Workspace tabs: pinned entry tab always reads as Home; remove tab-search button and its popover - Model picker: wider row gap in the two-pane browse popover - Community header: unpin (scrolls with content) - New update-reminder dialog assets and strings - Keep entry-settings-button as the signed-out settings entry (e2e contract); align NextStepActions with the navPlugins key rename * Update reminder: simulate in-place download progress instead of linking out The strip's confirm now runs a staged progress state ('updating') with an eased fake download bar, then marks the version updated — replacing the jump to the GitHub releases page. * test(web): retire AvatarMenu account-row suites after the popover simplification The composer popover was reduced to a model picker (2026-07-24): the Open Design account row — plan badge, balance, wallet fallback, upgrade/console links — no longer renders there, so the nine suites asserting that surface (including the workspace-balance and billing-permission gates that landed upstream meanwhile) can no longer pass. Drop them and recast the remaining account-row test as the guard for the new invariant: a signed-in AMR status must render no account UI in the popover. Also drop the stale onClose prop from the new upstream sign-out-confirm test; the rail no longer takes one. * Design-systems toast: anchor to the pane's top edge, pill radius * Update reminder strip: progress ring on the button, percent face While updating, the collapsed strip no longer stacks a label + bar above the rocket button. Progress draws as a brand-green ring hugging the round button's edge (5px band reserved so the button never shifts), and the button face swaps the rocket for the bare percent — 'N%' while downloading, 完成 (updater.done) at 100. The full 正在下载更新 N% label stays reachable via the hover bubble and the ring's aria-label. Demo payload version bumps to 1.4.6 so the once-per-version card re-arms. * Home shell productization batch: message center in the account menu, What's-new on real release data - Message center: entry moves into the account menu under 设置 (bell row); MessageCenter becomes controllable (hideTrigger + open/onOpenChange + onUnreadCountChange) and mounts persistently in EntryNavRail so unread polling survives the hover menu; unread shows as a red dot on the account avatar (and on the menu row); avatars go from squircle clip to 8px rounded squares; panel filter segmented control and mark-all-read go pill-radius. - What's-new: the post-update highlights card now wears the shared release-dialog shell (cover / title / dotted notes / pill footer) while keeping its REAL /api/whats-new data source, show-once-per-id timing, soft-hide Escape/backdrop semantics, and analytics. The demo-payload update-reminder dialog and its simulated download no longer trigger; the stage machine and progress strip stay for the real updater-feed wiring. - Rail chrome: brand logo and the in-rail collapse control are gone — the rail starts at the search box and folding lives in the pinned Home tab's toggle; the signed-out cloud tip bottom inset now matches its sides. - Brand picker (modal variant): side-nav split — search + vertical category nav left, a roomy 2-up borderless gallery right, content flush to the column line with hover fill/ring bleeding past it; logo tiles lose their boxed edge; selected template chip and the composer mode pill share the same selected ring, with the mode glyph optically matched at 13px. - Tab launcher: rows are icon + label only (descriptions dropped) with a rotating four-hue icon palette; the 新建空白页面 entry is paused behind ENABLE_BLANK_PAGE_WORKSPACE_ENTRYPOINT and its PageCreator suites skipIf on the same switch. - Move-to-team confirmations: extracted MoveToTeamConfirmDialog, no backdrop blur (dim only), and the confirm keeps its brand-green label through the mention-home ink-pill restyle in every interaction state. - Publish CTA: hover inverts to ink fill with brand-green icon + label. - Plus assorted in-progress workspace polish (composer, viewer, settings, model icons) riding the same branch iteration. * Restyle the updater ready popup to the update-reminder dialog language Cover art on top (compressed 1296x555 jpg, natural aspect), the orange accent icon tile removed, secondary action as a soft white pill and the install CTA as a black pill with brand-green ink, and a stacked footer so the silent-update checkbox keeps a full-width single line instead of wrapping beside the widened pills. * Signed-out rail: message-center entry under 设置 The signed-out rail has no account menu (where the 消息中心 row lives when signed in), which left the message panel with no opener at all. The rail item carries the unread dot. * Composer row: pin chip glyphs against flex shrink The row-wide min-width: 0 that lets chip labels ellipsize also let SVG glyphs absorb the squeeze — a hard-narrowed pane rendered the design-system palette icon tiny. Chips still shrink; their icons keep natural size. * Bind Community Remix projects to the current workspace Addresses mrcfps' review thread on apps/web/src/App.tsx:3303. Product reproduction: 「通过 remix 后的方案, 不出现在我当前 workspace 里的 草稿了」 — stable repro in a team workspace. `duplicatePluginAsProject` only sends the workspace/member identity headers when its third `workspaceContext` argument is supplied, and the daemon's `authorizeCreatedProjectWorkspace` deliberately reads a COMPLETELY headerless create as a legal legacy/anonymous caller — `bindCreatedProjectToWorkspace` is a no-op for a null context. Both remix call sites this PR adds (App.tsx's standalone /community branch and EntryShell's community tab) omitted the argument, so a remix performed inside a team workspace produced a project bound to no workspace at all and therefore invisible to every workspace view. Same enforceWorkspaceProjectMutation / created-project bypass class as c0bce3b8f, fixed the same way: thread the already-resolved workspace context that both files already hold, through the repo's existing `resolvedWorkspaceContextForWrite` seam so an unresolved or unavailable authority fails closed instead of silently creating an unbound orphan. The second half of the review note — the follow-up `patchProject` whose `null` was ignored — was a consequence of the same root cause: with the project unbound, `enforceWorkspaceResourceMutation` finds no workspace row for the caller's workspace and 403s the pendingPrompt seed, so the template prompt was dropped too. Both requests now share one resolved authority, so they can never disagree about which workspace they are acting in, and a still-null result is reported instead of swallowed (without creating a second project, which is what routing it through the existing catch would do). Red spec first: apps/web/tests/components/community-remix-workspace-binding.test.tsx drives both call sites in a team workspace against a fetch stub that reproduces the daemon's create-then-bind contract. Red before this change (the create carried no workspace headers, the project stayed unbound, and the seed PATCH 403'd), green after. * Cover the refused-prompt-seed branch of the Community Remix fix Second half of mrcfps' review ask on the same thread: prove what the flow does when the follow-up `patchProject` still returns null after the binding fix. The remaining null shapes are genuine transient refusals (daemon down, membership revoked mid-flight, workspace locked between the two requests). By then the copied project is real and bound, so the flow deliberately does NOT fall into its own catch — that path creates a second, prompt-only project and would strand the copy. It keeps the user on the remix and reports the dropped seed. This case pins that: user lands on the remixed project, no second project is created, and the failure is surfaced rather than swallowed. * Re-anchor three style specs on the dogfooded UI `Web workspace tests` went red on this branch because three CSS specs still described the pre-dogfood layout the restyle replaced. Each one is re-pointed at what shipped, keeping the invariant it was written to protect: - `acceptance-visual-fixes` (recvpYDfW12NBu): the preset-thumbnail fix is the resting `scale(1.15)` framing transform, which is intact. Its hover partner went away with the family-wide cover-zoom removal (2026-07-27), so the spec now asserts the framing zoom on both media surfaces and separately locks the hover rules out — re-adding one would resample the covers soft again. - `mention-popover`: the filter strip scrolls on one line instead of wrapping to a second row. The "no clipped labels" half of the contract is unchanged and still asserted (pills hold natural width, labels stay `nowrap`). - `settings-polish`: the updater popup footer stacks the silent-update checkbox above a 50/50 action row. Long en labels must still wrap inside the checkbox column rather than overflow the panel, which the spec keeps checking. * Return message-center focus to the rail opener that owns it `hideTrigger` handed the message-center entry point to the rail but left the component's internal `triggerRef` unattached, so `closePanel()` restored focus to nothing. Opening focuses the portaled dialog, so every close — button, backdrop, Escape, notification-settings — unmounted the focused node and dropped keyboard focus to the document. Both external openers also failed to advertise the dialog they own. `MessageCenter` now takes a `returnFocusRef`: the host that hides the built-in bell owns the duty that button used to serve. `EntryNavRail` points it at a control that is still mounted after the close — the account trigger on the signed-in branch, because the hover menu unmounts the 消息中心 row before the panel opens, and the rail item itself when signed out. Both openers carry `aria-haspopup="dialog"` and the live `aria-expanded`. Red first: `EntryNavRail.message-center-entry.test.tsx` opens from each entry, closes with Escape and with the close button, and asserts focus lands back on the host control. All four cases failed before this change. * Carry the menu popup contract onto the composer quick pills The 插件 / 设计百宝箱 pills open the standalone `role="menu"` popovers in ChatComposer, but they arrived without the contract of the ComposerPlusMenu rows they replaced: no `aria-haspopup` / `aria-expanded`, no Escape handler, and no focus return. Keyboard and screen-reader users could not tell a popup was open, and Escape pressed while focus sat in the plugin search did nothing. The pills live in ChatPane while the popovers live in ChatComposer, so the state is plumbed both ways rather than duplicated: - `onStandalonePanelChange` reports which popover is open, and each pill carries `aria-haspopup="menu"` plus its own `aria-expanded` — the same pair `ComposerPlusMenu` already puts on its trigger. No `aria-controls`: that surface does not use one, and this is not the place to invent a second convention. - `openDesignToolbox` / `openPluginsPanel` take the opening pill as the return-focus target. Both popovers move focus inside themselves, so a dismissal has to hand it back, and the pill is the control the user came from. - Escape closes through a document-level handler, mirroring ComposerPlusMenu's. `dismissStandalonePanels` is deliberately only wired to the dismissal paths (Escape, backdrop). Picking a plugin or an action keeps the plain setters, because those hand focus to the composer input and pulling it back to the pill would fight that. No interaction changes: hover-open, the shared close timer, pill-to-popup pointer travel and every selection path behave exactly as before. Red first: `tests/components/ChatPane.quick-pill-popup-contract.test.tsx` runs both pills through advertise / expand / Escape-from-inside / backdrop-dismiss and asserts focus lands back on the pill. All six cases failed before this change. --------- Co-authored-by: lefarcen <935902669@qq.com> * Converge the visual Design Files prelude instead of clicking once (#6181) `Playwright visual (settings-workspace)` went red on `[P2] captures the settings BYOK surface` with a 10s `aria-selected` timeout: the Design Files tab sat at `false` for all 23 polls with nothing re-clicking it. Seven other captures run this identical prelude and passed, including the two neighbouring BYOK cases. The defect is in the oracle, not the product. `prepareVisualWorkspaceFileList` decided **once** whether to click — one instantaneous `isVisible()` probe of a file row — and then asserted a state nothing retries. Any interleaving where the workspace's own tab reconciliation lands around that single click leaves the assertion permanently unsatisfiable for that attempt, and the lane runs `OD_PLAYWRIGHT_FULLY_PARALLEL=1` with `retries: 0`, so it reports as a hard failure rather than a flake. `activateVisualDesignFilesTab` now converges on the goal state via `toPass`, driving off `aria-selected` directly rather than through the file-row proxy — the guard and the assertion were about different things even though FileWorkspace derives both from one `activeTab === DESIGN_FILES_TAB` expression. Repeat clicks are safe: the tab's handler is `setPersistedActive(DESIGN_FILES_TAB)`, which is idempotent. Why this is not a product regression from #6162: nothing in it touches tab selection, tab persistence, or row visibility. Its only `design-files.css` change deletes the hover cover-zoom, which cannot affect visibility, and a diff of `apps/web/src` for `localStorage|activeTab|openTabs|restoreTab` comes back empty. The lane's one green run before this failure (`4a6653186`, the #6174 repair of the unrelated #5971 BYOK rename) is the whole basis for calling the baseline clean. Scope is the visual lane only — every caller is in `visual.ts` or `visual-*.test.ts`, so the UI P0 lanes are untouched. * fix(web): explain the AMR workspace-scope block instead of a dead send button (#6178) An Open Design Cloud project run requires a resolved personal/team workspace authority (21f452ffe). Failing closed there is correct and stays. Failing closed SILENTLY was the bug: the send button went grey with no reason on screen and no way out, while Home's equivalent dead end (checkAmrBalanceGate -> AmrBalanceDialog reason `signed_out`) hands the user an in-app sign-in. e2e/ui/amr-logout-requires-relogin.test.ts exists to protect exactly that route, which a disabled composer can never reach. Adds a classifier (`amrWorkspaceScopeBlock`) that turns "gate closed" into the remedy that clears it, and a composer-adjacent notice that renders it: signed_out — the same AmrLoginPill action and `chat.amrBalanceGate.signInCta` copy Home's balance gate uses, so one identical action clears it from either surface. unresolved — a re-read of the project's workspace authority, exposed as `ProjectWorkspaceScopeState.revalidate`. An account action would be a guess. The gate itself is untouched: `projectRunWorkspaceScopeReady` never consults the classifier, and the `disabled: true` invariant stays asserted. * test(updater): join the installer-reinstall floor across release and client (#6167) * test(updater): join the installer-reinstall floor across release and client A payload update never replaces the Electron outer shell, so a release whose shell changed can only reach an old install through the installer. The `control.launcher.version.{min,url}` floor is the one mechanism that forces that, and it spans three owners: tools/release resolves the channel policy, the feed carries it, and the desktop updater enforces it against the physically installed outer version. Every side had unit coverage; nothing joined them, so the only place a break in the chain would surface was a release publish. Adds six specs to the already-allowlisted packaged-launcher cross-boundary suite, driving the real release-side resolver into a real feed and then into a real packaged update check: - an outer below the floor takes the installer, not the payload, and the launcher pointer proves nothing was adopted; - the floor is judged by the installed outer rather than the payload it is running (two installs on the same payload, only the stale shell diverted); - an unreadable installed outer fails closed as `outer-version-unreadable` with no installedVersion to render; - a launcher schema beyond this client diverts on the ABI axis alone; - with no floor configured a below-floor outer still swallows the payload, which is why a shell-changing release must set the repo vars deliberately; - a floor above the release version stays refused. Falsifying `remoteRequiresReinstall` to compare against `config.currentVersion` -- the semantics the released 0.15.1/0.16.1 shells actually ship -- turns two of these red, including the unreadable case being mislabelled as below-min. Also pins the floor's operational shape against real channel version formats: a bare stable floor sorts above every same-base `-beta.N`/`-preview.N`/ `-prerelease.N`, so inheriting it into those lanes hard-fails their publish. The specs name that trap and pin the one-explicit-pair-per-lane configuration that avoids it. * test(updater): drive the reinstall floor on Windows too, off the real outer Review (nettee) caught these specs running macOS only: the feed described `platforms.mac`, the payload writer built a `.app`, and the updater config was pinned to arm64/darwin. So `resolveInstalledOuterVersion`'s Windows branch — `dirname(launcherLaunchPath)/resources/open-design-config.json`, a different lookup from the mac bundle path — and the `installer` artifact shape never ran. Since the installs most exposed to a shell/payload mismatch are the oldest ones, leaving Windows uncovered left the half most likely to break unguarded. The specs now run through `describe.each` over a per-platform target table carrying the launch-path shape, outer-config location, installer artifact key, and payload extractor. They also stop using `OD_UPDATE_INSTALLED_VERSION`. That override returns before the platform branch it was supposed to exercise, so it was masking the code under test. Each scenario now materializes a real installed outer package at the real per-platform location and lets the updater read the version off disk — which also makes the unreadable-outer case genuinely unreadable rather than simulated. Falsifying the Windows lookup (collapsing it into the macOS path) fails exactly the two Windows specs that depend on reading a real installed version, while all twelve macOS and publication-policy specs stay green. * fix(web): partition the workspace plan nameplate like the wallet (#6182) A workspace Vela Web shows as 免费 rendered as 专业版 Plus in the client's account menu, while the 额度 row in the same card correctly read $0.00. Money and plan travelled different paths. `GET /api/workspace/billing` returns three independently scoped things, and only two of them are about the workspace: `workspaceBalance` / `workspaceSnapshot` are proven for the exact workspace + member, while `summary` is the caller's VELA ACCOUNT billing (`workspaceId: null` by contract; the daemon reads it with one unscoped `fetchBilling()` regardless of `?workspaceId=`). The rail's plan nameplate read `response.summary` raw, so an account holding a personal Plus reported `plus` in every workspace — a value that cannot change when the workspace changes, because it was never about the workspace. `workspaceBillingSummaryForContext` makes the partition key explicit, the same `workspaceId` + `workspaceMemberId` pair money already uses: - personal workspace — the account IS the scope, summary passes through; - team workspace — plan comes from the context-authorized snapshot, and the account tier may stand in only when it is itself team-namespaced, since a personal tier cannot name a team workspace's plan. That last clause keeps the 飞书 P0 fix intact: B omits planId/billingState for a non-owner and `workspaceSnapshot` is an additive capability, so a team-namespaced account tier is the only surviving evidence that a paying MEMBER's team is subscribed. `useWorkspaceBilling` is now this projection over the ambient context, and EntryShell / SettingsDialog consume it instead of the raw summary. No interaction, layout, or copy changes. * Revert "fix(web): explain the AMR workspace-scope block instead of a dead send button (#6178)" (#6184) This reverts commit ea259eb402. * fix(daemon): resolve an unbound project against the caller's current workspace (#6185) * fix(daemon): resolve an unbound project against the caller's current workspace Every project must resolve to a workspace; when the project itself has no binding, the workspace is the one the caller is currently acting in. There is no other candidate. `GET /api/projects/:id/workspace-scope` read only the persisted `workspace_projects` row and the membership directory — never the request's `x-od-workspace-*` identity — so a project with no row answered `unbound` for every caller forever. `unbound` makes `projectWorkspaceScopeAuthorizesAmr` false, which disabled the chat composer's send button for an Open Design Cloud run on that project permanently, with nothing the user could do to clear it. #6178 wrote user-facing copy for that state instead of fixing it (reverted in #6184). `resolveProjectWorkspaceScopeForCaller` wraps the existing resolver instead of branching inside it, so `resolveProjectWorkspaceScope` stays byte-identical and the bound path is provably untouched. The fallback re-enters that resolver with a synthetic binding naming the caller's own workspace, so the resulting `workspaceMemberId` comes from the membership directory and never from the request header: a caller can only select among workspaces their signed-in identity is genuinely an active member of, and anything the directory cannot confirm degrades back to `unbound` rather than to `unavailable` on a workspace the project was never bound to. Two cases keep today's behavior, both pinned by spec: unavailable — all three of its return sites. A project pinned to workspace X read by a member of Y answers X. The scope carries `workspaceMemberId`, the wallet that pays for the project's runs; resolving to Y would bill Y for X's project. Reachable because `GET /api/projects/:id` has no workspace gate, so a deep link or a workspace switch lands there. no caller identity — signed out, or a plain curl, has no current workspace to fall back to, and inventing one is worse than answering "none". The fallback deliberately does not persist a binding. `reconcileUnboundProjectBeforeMutation` was the preferred shape going in and is wrong here: its own docblock is explicit that a passive read must not hand out ownership just because it ran first, and this endpoint is a GET. Writing a row from it would let whichever workspace opened the project first claim authorship on no user intent, and would race two clients in different workspaces. * fix(web): stop pre-emptively blocking an AMR send that has a wallet An Open Design Cloud run is billed to the CALLER's own wallet, so the only defensible client-side veto is "there is no billing principal at all". The gate instead required THIS PROJECT's workspace scope to resolve, and blocked the send whenever it did not: an unbound project, a membership-directory read that transiently failed (offline / 504 / timeout all collapse into one `ok: false` upstream), a workspace that is billing_past_due or locked, or a team the caller has since left. In every one of those the user is spending their own quota. It is also not the enforcement point. Real enforcement is server-side — the daemon's `WORKSPACE_CONTEXT_REQUIRED` 401 plus vela's own billing check. The client gate could only convert a request the server would have answered into a dead, unexplained button, which is strictly worse than an honest server error. It arrived as 21f452ffe, whose entire message is "fail closed on unresolved workspace authority" with no body and no stated product requirement. `workspaceIdentityCanBillAmr` names the invariant on the identity read, and the gate now admits either witness of a billing principal: that identity, or a project scope that already resolves to an explicit personal/team principal. Strictly a widening — every state it newly admits was previously blocked, and nothing previously admitted becomes blocked. Deliberately NOT treated as "no wallet": loading — the identity read holds no answer yet. Reporting "signed out" on a frame that has not heard back is the bug shape this replaces. failure 'unavailable' — a transient outage taught us nothing about the user. failure 'unsupported' — an old daemon with no workspace endpoint keeps its legal pre-workspace behavior. A genuinely signed-out caller — a settled, authoritative read that came back with no workspace — stays blocked: there is no wallet, so the run cannot be billed and cannot succeed. No UI, no notice, no copy: #6178 wrote copy for this dead end instead of removing it, and #6184 reverts that. This removes the dead end. * fix(web): point every console entry at /dashboard, drop the wallet target (#6165) * fix(web): point every console entry at /dashboard, drop the wallet target Product ruling: there is no wallet page in the console's information architecture any more. Balance, manual top-up and the auto-recharge policy were all rehomed onto the console dashboard (vela #1055), so every entry that used to open `/wallet` now dropped users on a surface the product no longer navigates to. Retargets all of them: - `AMR_CONSOLE_URL` / `DEFAULT_AMR_RECHARGE_URL` and the per-profile console map (prod / test / local) now resolve `/dashboard`, keeping the `?source=open_design` attribution param. - `teamConsoleUrl`'s `billing` section — the team account menu's 「额度 $0.00」 row — is a plain dashboard visit. - `teamConsoleUrl`'s `plans` section, `amrPlansUrlForProfile` and `amrPlansUrlForWorkspace` — the free-tier 「升级」 button and every other Upgrade affordance — send `billing=plan` instead of the wallet page's `view=plans`. - `amrWalletUrlForWorkspace` is renamed `amrConsoleUrlForWorkspace` so the name matches where it now points. `billing=plan` is the console's one state-aware upgrade intent: its dashboard resolves it against the workspace's real subscription state, so a personal owner lands on the personal plan modal — the dialog the console's own 「升级订阅」 hero button opens, which is what product asked the free-tier 「升级」 button to reach — while a team owner still gets checkout or change-plan. The team `upgrade` section keeps sending its more specific `billing=checkout` hint, but that is now only a hint: powerformer/vela#1127 makes the console fall back to the dialog that actually matches, so a stale `hasActivePlan` can no longer strand the user on a bare Overview page (recvpSQKna0LwR). Comments carrying earlier live-verification findings are updated wherever this change invalidated them, rather than left contradicting the code. No new user-facing copy, so no locale changes: the affected labels are all action-named (「充值」/「升级套餐」), never destination-named. * fix(daemon): retire the wallet target in the AMR recharge link too The daemon builds its own recharge URL for AMR balance failures — it lands in the failure message and in `actionUrl`, which the client renders as the chat error card's clickable link — and it still pointed at the console's retired wallet page. Same product ruling as the client-side retarget: balance and manual top-up report on the console dashboard now (vela #1055), so this link has to go there. Every existing assertion in `vela-errors.test.ts` referenced the constant symbolically, so all of them would have kept passing while the link sent users to a surface the product no longer navigates to. Added one that pins the literal, which is the red spec for this change. Also retargets the two e2e assertions that pinned the old destination (`e2e/tests/amr/insufficient-balance.test.ts` on the daemon's emitted URL, `e2e/ui/visual-workspace.test.ts` on the avatar upgrade link's `view=plans`), and the web-side fixtures that mimic the daemon's emitted string so they stop documenting a URL it no longer produces. * chore(release): bump feat/workspace-team to 0.16.2 (#6188) The published beta feed is self-inconsistent: metadata.json carries baseVersion 0.16.1 alongside betaVersion 0.16.2-beta.144, because 0.16.2-beta.144 was published with an explicit release_version override while every manifest on this branch still said 0.16.1. Every subsequent beta build now fails its own consistency check: [release-beta] beta metadata.json baseVersion 0.16.1 does not match betaVersion 0.16.2-beta.144 `force` does not help — it only waives "base must exceed latest stable", not the baseVersion/betaVersion match. Raising the branch's base version to 0.16.2 makes the next beta (0.16.2-beta.145) consistent with its own metadata, and removes the need to pass force at all. Same 18 manifests the release bot touched in 23f9fcaac; test fixtures that mention 0.16.1 as data are left alone, as that commit also left them. Co-authored-by: lefarcen <ontf116@gmail.com> * fix(collab): keep a project's "last changed" time out of sync's hands (#6189) A member who opened the client hours later and pulled a shared project saw 「刚刚更新」 on a project nobody had touched, and the home 最近项目 strip kept rendering the previous workspace's cards for a beat after switching workspaces. Two independent defects, both reported by the product owner on a packaged client. 1. `projects.updated_at` (and the `workspace_projects.updated_at` the project list folds into it with `MAX`) is what the project card shows and what the list sorts by, so it must answer "when did a person last change this project's conversations, files, or name". Sync was answering it too: `materializePulledTeamMirror` carried the origin's timestamp into the project row but not into the binding it wrote in the same transaction, so `MAX` surfaced the pull's own clock on EVERY pull. Four more sync writers had the same shape. `SYNC_KEEPS_UPDATED_AT` names the invariant and the sync paths now either carry the origin's time or keep the row's existing answer. 2. A loaded project list describes exactly one workspace identity, so leaving that workspace invalidates it. The re-list on switch runs in an effect — after the commit — so the browser painted workspace A's cards under workspace B's identity first. The list is now dropped during the render that first observes the new scope, so no frame shows another workspace's projects. No extra request: the refetch already existed and was already keyed on the resolved workspace. Co-authored-by: lefarcen <ontf116@gmail.com> * fix(web): key every workspace read cache on who is asking (#6198) `coalesced-get` and `shared-cancellable-get` are CACHES (1s share window), not just in-flight dedupers, so a key that omits the caller's identity hands the previous workspace's answer to the next one — and an in-flight entry is joined with no window at all. Three reads were keyed on a constant: - `useTeamMembers` — `'workspace-members'`. `GET /api/workspace/members` answers for whichever workspace the DAEMON is active in and reads nothing off the request, so the roster is a per-workspace answer with no per-workspace URL. A leaked roster renders the previous workspace's teammate name on project cards (`RecentProjectsStrip.resolveCreator`). Now keyed on the workspace identity, which also makes the hook re-read on a switch instead of waiting out its 15-60s poll, and a late read for the identity the user left no longer overwrites the newer roster. - `useWorkspaceContext` — `'workspace-context'`. This is the read that ESTABLISHES the identity, so it cannot be keyed on the identity it fetches and has no workspace argument to borrow (the switch is a separate `PUT /api/workspace/active`). It is keyed on the identity GENERATION instead: one token per deliberate identity change, so a single broadcast heard by a dozen mounted consumers still collapses to one request, while two switches inside `forceCoalescedGet`'s 250ms burst window stop being mistaken for one. - `useProjectWorkspaceScope` — `project-workspace-scope:<id>`. The scope carries the `workspaceMemberId` that pays for the project's runs, so a shared key serves one member the wallet of another. The same read also fetched HEADERLESS, which made #6185's daemon fallback unreachable: `GET /api/projects/:id/workspace-scope` resolves an unbound project against the caller's current workspace, but only when the request carries the caller's `x-od-workspace-*` identity. It now sends `workspaceProjectHeaders`, the same set every other workspace-aware project read uses — and waits for the caller's own identity to settle first, so a project open still costs one request instead of a wrong headerless one followed by a corrected one. * fix(collab): carry B's workspace name for personal workspaces too (#6199) B names EVERY workspace, personal included: vela's CurrentWorkspaceContext requires `workspaceName`, derives "«owner»'s workspace" for an unnamed personal one (vela #964), and an owner may rename it outright. The daemon read that field and then threw it away unless the workspace was a team, because the only name on WorkspaceCollabContext was `teamName`. The switcher's collapsed label therefore had nothing real to show for a personal workspace and fell back to a hardcoded English "Personal workspace" until the user opened the dropdown and the separate workspace-directory read landed. Adds `workspaceName` to the context contract and carries it for both workspace types, in the vela mapping and in the directory-item synthesis. `teamName` stays team-only: it is the team switcher's field and doubles as an "is a team" signal, so nothing may start reading it for a personal workspace. The web side consumes the context the shell already holds at startup, so the label is correct on first paint and NO new request is added — the diff adds zero fetch call sites. The dev provider parses `workspaceName` too so the dev/demo lane can drive a personal workspace's label the way B does. Note this is not what the reported screenshot shows: there, B's real name for that workspace IS the literal "Personal workspace", because an in-place team upgrade flips the default workspace's stored type to 'team' and vela's owner-derived naming then no longer applies. That half is upstream. Co-authored-by: lefarcen <ontf116@gmail.com> * fix(web): stop offering 升级 at the top plan tier (team_max) (#6205) A 团队版 Max workspace is the top of the ladder — nothing is above it — but both upgrade entry points still showed 「升级」, and clicking it could only reopen the plan the user already holds. The two surfaces got there two different ways, and neither shared a rule: - The account menu's billing card gated on `billingUpgradeUrl && canManageBilling` — a destination check and a permission check, with no TIER check at all. Every tier saw the button. - The Settings AMR card asked a personal-ladder question (`canUpgradeVelaPlan`) about `amrCardStatus.account.plan` — vela's ACCOUNT-scoped login projection, which reports `free` for a user whose entitlement is held by a team workspace. So a team_max owner measured as "free" and got the button, while the PlanBadge beside it correctly read Max off the workspace-resolved tier. Both now ask one predicate, `canUpgradeFromPlanTier`, about the same resolved tier each surface already LABELS, so the button can never contradict the nameplate next to it. Team and personal tiers are two ladders, so the predicate reads the team-namespaced id whole instead of stripping the prefix and asking a personal question. Per the product ruling — 「个人档位都是要显示可升级的, 最顶的就是团队 max」 — personal `max` keeps the affordance: that user can still move onto a team plan, and vela #1146 deliberately routes their click to the Team upgrade dialog. Only `team_max` loses it. Destination logic (`workspaceUpgradeUrl` / `amrPlansUrl`) is untouched; this only decides whether the affordance renders. No copy, no new i18n keys. * fix(web): keep Send alive after using a community template (#6206) Clicking 「使用」 on a community template seeds the template's own brief into the composer and binds the template as the run's driver. For a template whose `od.inputs` are `required: true` with no `default` -- the real `example-html-ppt-pitch-deck` ships three such fields -- the bind left `active.inputsValid` false, and `submitDisabled` folded that into the send button. The user saw a full prompt next to a permanently dead Send whose tooltip still read "type something to run". Typing did not help: the gate was never about the prompt. Those fields have no input surface on that path. #3645 removed the Home composer's inline plugin-inputs form, and the template's query carries no `{{...}}` placeholders, so prompt -> inputs write-back cannot reach them either. A gate on values the user cannot supply anywhere is a dead end, not a guard. Narrow it to where it is actionable: `requiredInputsAreUserFillable` keeps the gate when the media composer renders the fields as controls, or when the tracked query template actually names the missing field as a `{{placeholder}}` that editing the prompt writes back. A tracked template alone is not enough -- re-applying a plugin without an explicit template derives one from the manifest, placeholders or not, which is the shape a reload lands in. The daemon stays the authority: `validateInputs` still throws MissingInputError. Since the seeded path no longer pre-empts the send, its rejection now reports the fields it rejected instead of a generic "Failed to apply", reusing the existing pre-submit wording. * fix(collab): give every created project a workspace home (#6201) * fix(collab): give every created project a workspace home A project created with no `x-od-workspace-*` headers got no `workspace_projects` row and still returned 200, so nothing surfaced the loss. `GET /api/projects/:id/workspace-scope` then answers `unbound`, which strips the workspace off the run request (`ProjectView`'s `projectRunWorkspaceContext` -> an Open Design Cloud run nothing can bill) and blanks the balance/plan area while that project is open (`AvatarMenu`). The same orphan is also denied its first run outright by `enforceWorkspaceResourceMutation`. Headerless creates are not anonymous callers asserting "no workspace" — they are callers that could not say which workspace they meant: `od project create` and the MCP `create_project` tool mint no headers at all, the web duplicate / design-system-copy / plugin-share paths read a ref that drops the context's `loading` flag, and Orbit + scheduled routines have no request to read headers from. So a create that names no workspace now binds to the one this daemon is signed in to, read through `workspaceContext.lastKnown()` — zero-network, synchronous, no failure mode. A daemon that has resolved no workspace still binds nothing, which keeps `unbound` correct for the signed-out single-player user. Six creation paths were writing no binding at all, not merely skipping it when headerless: the plugin share-project task, Orbit run projects, scheduled routine projects, the library capture-as-page exit, the project-location scan importer, and the `ds-*` project backing a design system's editing workspace. All six now bind. Deliberately unchanged: the collab pull's register-on-pull and shared-project placeholder. Those are a teammate's shared project, whose correct binding is written by `materializePulledTeamMirror` with `visibility: 'team'`; claiming them into the reader's ambient workspace as personal would misattribute someone else's resource. No creation path gains a new failure mode. `createdProjectWorkspaceHome` never refuses — a partial or denied header identity degrades to the ambient workspace rather than turning a working 200 into a 4xx. On the web side `createPluginShareProject` was the one create in `state/projects.ts` with no `workspaceContext` parameter at all, so it sent no workspace identity ever. It now forwards the context when known, best-effort — deliberately not `resolvedWorkspaceContextForWrite`, which throws while the identity read is in flight and would add a new block to a path that works today. * fix(collab): verify an asserted workspace before persisting it `createdProjectWorkspaceHome` resolved a created project's workspace with `resolveCreatedProjectWorkspace`, which only PARSES headers. It trusted the caller-provided member status and permissions and never checked that the workspace/member pair exists in the membership directory or agrees with the daemon's last-known state. `x-od-workspace-*` headers are an unauthenticated hint, so any local caller — the `od` CLI, a plain curl, a compromised page — could assert an arbitrary pair and get a project bound to a workspace it has no membership in, with a fabricated `createdByWorkspaceMemberId`. "Do not fail the create" and "trust unverified input" are not the same constraint. The helper now VERIFIES, then DEGRADES — never rejects, never trusts: 1. asserted identity that verifies -> bind to it 2. asserted identity that does NOT -> bind to the daemon's ambient verify, including an unreadable workspace instead, or leave authority ("cannot confirm") the project unbound 3. nothing asserted -> ambient, as before Creation still never answers 4xx, so the six previously-never-bound paths keep binding and a signed-out daemon still creates usable local projects. An unverifiable claim is simply never written as fact. Verification is not re-implemented. It is `authorizeCreatedProjectWorkspace` — the same directory lookup `POST /api/projects` gates on, which also returns the DIRECTORY's authoritative context rather than the caller's claimed one — plus `withLastKnownMembership`, the same cross-check the mutation gates apply (now exported rather than copied). Only the failure behavior differs: they refuse, this degrades. An absent directory fetcher remains `authorizeCreatedProjectWorkspace`'s own documented local/dev compatibility path, not a second weaker definition of verified. Route modules now take one `CreatedProjectWorkspaceResolver` dep instead of re-threading the three authorities, so there is a single notion of "verified" per daemon. * test(daemon): drive brand routes through the created-project workspace resolver The brand harness constructed `registerBrandRoutes` without the new `resolveCreatedProjectHome` seam, so the binding became a no-op and "binds a freshly extracted brand project into the caller's ACTIVE team workspace" went red. Inject the same production resolver `server.ts` builds, in its no-directory (local/dev) configuration, so the test keeps asserting the product behavior through the real seam instead of a header-trusting shortcut. --------- Co-authored-by: lefarcen <ontf116@gmail.com> * fix(web): move the update-ready rocket above the rail account row (#6208) * fix(web): move the update-ready rocket onto the rail account row #5517 removed the entry topbar and parked the updater host in the rail footer, which put the green rocket on its own line UNDERNEATH the account row — bottom-left, detached from the identity it belongs to. Product reported it from a real client: the rocket belongs at the right edge of the name + plan wordmark line. Move the mount instead of nudging it with CSS: the rail now owns the updater host through an `updaterSlot` prop and renders it inside the account row (`.entry-nav-rail__account-row`), as a SIBLING of the account trigger so it never steals the account-menu click target. The rail footer stays as the fallback home for the signed-out shell, which has no account row to ride, so the rocket's appearance conditions are unchanged. Same change also un-clips the 「更新已就绪」 prompt. The host is pinned to the bottom of the rail, so a `top: 0` panel grew downward off the bottom of the window and the copy was cut off mid-sentence. Anchor its BOTTOM edge to the host instead, the same way `.entry-help-popover` already does for the same reason. Side effect worth having: the rail no longer grows a 52px footer strip the moment an update lands, so the account row stops jumping. * fix(web): put the rocket ABOVE the account row, right-aligned Placement correction. 「放到名字啥的上面的右侧」 was read as "on the name row, right side"; product clarified 「应该是在名字那个横条的上方,靠右对齐」 — the rocket gets its own right-aligned strip ABOVE the identity row, not a slot inside it. The strip (`.entry-nav-rail__account-updater`) is mounted unconditionally so it stays the account trigger's immediately-preceding sibling, and carries `:empty { display: none }` so an idle rail reserves no height for it. That rule is load-bearing: without it every user without a pending update would get a blank 34px row plus the container's 6px gap pushing the account area up — a worse regression than the placement it fixes. Measured in a real browser at 1280x900: the account trigger sits at y 850-884 in BOTH states, so nothing shifts. Everything else from the first commit stands: the rail owning the host via `updaterSlot` instead of an opaque `footerExtra`, the sibling-not-child relationship to the trigger (now moot in the best way — a strip above the row cannot be button-in-button), the `bottom: 0` panel anchoring that un-clips 「更新已就绪」, and the footer fallback for the signed-out shell. * fix(web): stop the home model list offering picks the chip cannot honor (#6209) On the Home composer, clicking a model in the chip's compact list did nothing — the chip kept showing the previous model. The compact list rendered `currentAgent.models` raw, so a model above the caller's plan (`enabled: false`, straight from `vela model list --json`) appeared as an ordinary selectable row. Clicking it wrote the pick to config, `normalizeAgentModelChoice` reported the plan fallback instead, and the re-normalization effect in `InlineModelSwitcher` persisted that fallback — so the chip snapped back with no explanation, and the user's previous pick was overwritten by the default in the process. The sibling surface (`AvatarMenu`, the project composer's model list) had already hand-rolled `agent.id === 'amr' && model.enabled === false` for this. Copying the rule per surface is what let the newest list drop it, so this introduces one definition instead: `agentModelIsSelectable`, defined to be at least as strict as `normalizeAgentModelChoice` (pinned by a test) so a gated row can never be a pick the config would revert. Both surfaces now ask it, and every model write inside `InlineModelSwitcher` — the compact list and the execution-settings picker — goes through a single `applyAgentModel` sink that asks the same question, leaving no second path for a future list to bypass. Locked rows now read as locked: dimmed, `aria-disabled`, a lock glyph, the existing `settings.amrModelUpgradeHint` reason, sorted below the available models, and a click routes to the plans page instead of silently doing nothing. * fix(collab): verify the asserted workspace before claiming an orphan project (#6213) * fix(collab): verify the asserted workspace before claiming an orphan project `reconcileUnboundProjectBeforeMutation` claims a project this daemon has never bound to ANY workspace into the current mutating request's workspace, so a true orphan is not denied its first mutation by `enforceWorkspaceResourceMutation`'s `!row -> false` rule (recvqbhor3pai2). It resolved that workspace from `workspaceProjectContextFromRequest(req)` — header PARSING with no authority check — and stamped `createdByWorkspaceMemberId: ctx.workspaceMemberId` from the same headers. `x-od-workspace-*` is an unauthenticated hint any local caller can forge, so a plain curl could claim someone else's orphaned project into a workspace it has no membership in AND install itself as the author. Authorship is the dangerous half: `workspaceResourceAccess` derives `selfCreated` from it, and that bit is what grants a non-privileged member mutation rights over the row. Both the workspace and the authorship now come from `resolveCreatedProjectHome` — the same verify-then-degrade resolver #6201 introduced for created projects: - asserted identity VERIFIES against the membership directory -> claim it, attributed to the DIRECTORY's member id, not the header's; - it does NOT verify (foreign, inactive, permissions disagree, last-known says removed, or the authority is unreadable so it cannot be confirmed) -> claim the daemon's own ambient workspace instead, attributed to that verified session's member id; - neither available -> write nothing, and let the pre-existing gate answer. The `null`/`'missing'` early return is unchanged and load-bearing, which is why this does not reuse `createdProjectWorkspaceHome`'s own third branch: the mutation gate's HEADERLESS branch answers 401 as soon as any row exists for the resource, so claiming on a request that asserts nothing would convert a working headerless mutation into a 401. A verified caller is unaffected — `workspace-projects.test.ts`'s recvqbhor3pai2 regression case still passes unchanged. A caller that cannot prove membership over a never-claimed project is now refused by that pre-existing gate instead of being let through on a binding it had just invented for itself; #6201's e2e case is updated to assert the persisted binding rather than the mutation's status, since both outcomes satisfy the property it pins. * fix(collab): persist only an asserted-and-confirmed workspace on an orphan Review follow-up (mrcfps). `resolveCreatedProjectHome` is not a pure verifier: by contract a foreign, inactive, removed, or unconfirmable assertion degrades to `workspaceContext.lastKnown()`. Reconciliation then persisted that ambient context onto a PRE-EXISTING orphan before the mutation gate had rejected the asserted caller — and the `getWorkspaceProjectByProjectId` guard one line above makes that write sticky, so the rightful verified workspace could never reconcile it afterwards. A forged request, or a legitimate one during an authority outage after the active workspace changed, would permanently mis-file the project. Creation and reconciliation are not the same risk, which is the distinction the original patch missed. Putting a BRAND-NEW project in the ambient workspace takes nothing from anyone — that is #6201 and it stays. Putting an EXISTING orphan there may take it from the workspace it actually belongs to. So a degraded ambient authority is persisted only when it names the very pair that was asserted. Verified assertions resolve to the asserted pair by construction (the directory lookup is keyed on it), so they are unaffected; outage continuity still works for the ordinary legitimate caller, whose client took its headers from this same daemon and therefore agrees with it; a mismatch writes nothing at all. Not in tension with 「所有 project 都应该能找到 workspace」: the display-side fallback (#6185) already renders an unbound project inside the caller's current workspace, so nothing reads as "unknown". The binding row is a separate, durable fact and stays conservative. Adds the fixture-matrix case the review asked for — a populated but DIFFERENT ambient workspace, asserting the orphan stays unbound. The mock authority's `/current` is now flippable so the fixture can create a true orphan while ambient is absent and then populate ambient deterministically through `GET /api/workspace/context`, rather than depending on a poll tick. --------- Co-authored-by: lefarcen <ontf116@gmail.com> * fix(web): use neutral Windows app background (#6218) * fix(collab): let a headerless caller mutate its own daemon's project (#6216) * fix(collab): let a headerless caller mutate its own daemon's project `enforceWorkspaceResourceMutation`'s headerless branch answered 401 WORKSPACE_CONTEXT_REQUIRED as soon as ANY `workspace_projects` row existed for the resource. That was survivable while headerless creates left projects unbound. #6201 made every created project get a workspace home, so the two rules combined into a project its own creator cannot touch: od project create -> 200, and now writes a binding od project duplicate -> 401 The `od` CLI never sends `x-od-workspace-*` — only `od workspace …` builds those headers — so this is not an edge case for it. It is every CLI mutation of every project the CLI created, which breaks the embeddability contract `AGENTS.md` makes the CLI responsible for. Reproduced end to end through the real binary against a daemon-only process (`od daemon start --headless`, no web, no browser). INVARIANT, now named in `headerlessMutationAllowed`: every mutation resolves to a workspace identity. A request that ASSERTS one is judged on that assertion; a request that asserts NOTHING is the local daemon's own signed-in user and is judged as that identity. Being unable to name a workspace is not the same as having no standing in one — the same "nothing asserted -> ambient" fallback the create path already applies, so the gate and the creation paths finally agree about what a headerless caller is. Verified the ambient identity is available without any UI: a daemon-only process resolves it from the vela session on disk, and `GET /api/workspace/context` answers fully in that state. The `ambientWorkspaceId` in `collab/workspace-hub-subscriptions.ts` is unrelated — it is SSE subscription bookkeeping fed from the disk-persisted selection store, not an authorization input. Deliberately NOT weakened: `authorizeCreatedProjectWorkspace` still refuses to let ambient stand in for an explicitly CLAIMED pair, and `resolveProjectWorkspaceScope` still resolves a persisted binding without consulting ambient. Both govern cases where something WAS asserted; headerless is the third case. What stays refused, because the original branch protected something real (recvqbeDjAsejl / recvqbklNGDqYY, spec 04 §10): a resource bound to a workspace the daemon is not currently in; a resource the daemon's own identity may not mutate anyway (the same `workspaceResourceMutationAllowed` computation runs); and everything when the daemon has no signed-in identity to resolve. With no ambient wired the branch is byte-identical to before. The ambient snapshot type moves down into `collab/workspace-resource-mutation.ts` so the gate and the creation paths cannot drift into two notions of "the daemon's own workspace"; `created-project-workspace.ts` re-exports it and now reuses the shared context builder instead of its own copy. * test(e2e): pin that signed out, visible equals unbound equals mutable 「未登录也可以用自己 cli 修改未登录态下的那些 project, 这个一定要保证, 不然就是 P0 事故」 A signed-out client can only SEE unbound projects: the no-scope catalog (`routes/project/index.ts:2432-2443`) reads no `x-od-workspace-*` at all and joins through `listUnboundProjects`, so a project any workspace has claimed never leaks to a caller with no identity to check it against (spec 04 §10). This pins the other half of that set — everything visible while signed out stays WRITABLE. The case runs against a daemon with NO vela session at all, not merely a request without headers, creates its draft in that same signed-out state (the real user sequence), asserts the draft is listed by the no-scope catalog, then renames it, duplicates it, and duplicates it again through the real `od` binary. It holds only because `headerlessMutationAllowed` short-circuits on "no row anywhere" BEFORE it asks for an ambient identity, so it is mutation-tested against that ordering rather than written red-first: moving the short-circuit after the ambient check turns it red with `expected 401 to be 200`. * fix(collab): make the delete side effect use the gate's own context Review follow-up (mrcfps). Allowing a headerless caller to mutate a project the daemon's own identity owns made a latent inconsistency reachable: `DELETE /api/projects/:id` re-derived its context with `workspaceProjectContextFromRequest(req)`, which is null for a headerless caller, so `requestTeamVisibility(..., 'personal')` was skipped while `dbDeleteProject` still ran. The owner's local row and directory disappeared and the hub kept serving the resource, so teammates went on seeing a project that no longer existed — a cross-client data-consistency bug, worse than the 401 this branch set out to fix. Threading the context, not narrowing the capability: `effectiveWorkspaceProjectContext` names the identity a mutation actually acts under — asserted when the request carries one, ambient when it does not — and its docblock states the invariant that any SIDE EFFECT must read from it rather than re-deriving from headers, or the effect disagrees with the gate that permitted it. The delete now uses it. The no-context case becomes a refusal rather than a silent skip. It is unreachable while the gate is intact (a team-bound row is admitted only for an asserted identity or a matching ambient one), but falling through is what produced a local-only delete of a still-shared project, so a future gate change must not be able to reintroduce it quietly. Audited every other capability this branch newly admits for a headerless caller. Delete was the only one: `/move` and both share/unshare routes each guard with their own `if (!ctx) return sendMissingWorkspaceContext(res)` so headerless never reaches their hub work, and the upload route's `workspaceProjectContextFromRequest(req) !== null` only shapes a 404 for a missing project. Rename/duplicate/writeFiles/comment have no hub side effect. Adds the requested route regression to `tests/routes/project-delete-unshares-team-share.test.ts`: real route, real collab runtime, mutable fake hub, no request headers, `workspaceContext.lastKnown()` populated — asserting the unpublish and catalog removal happened and the project is gone locally only after. Plus the other half: with no ambient identity either, the delete is refused and nothing is destroyed. Mutation-tested — restoring the header re-derivation turns the first red with "expected 0 to be greater than 0". --------- Co-authored-by: lefarcen <ontf116@gmail.com> * fix(web): draw the team wordmark for every tier of a team plan (#6219) The account row of a team workspace showed the PERSONAL Plus wordmark. Product ruling: 「团队版的订阅，这里应该都显示 team 的标识」…「产品期望团队从 free 到 max，徽标都显示 team 的那个，个人的还是维持现状不要动」. The badge names the plan FAMILY, not the tier inside it, and it got that wrong from both ends. `planBadgeTierForLabel` asked `plus` / `pro` / `max` BEFORE `team`, and B namespaces team ids by EMBEDDING the personal tier word — so `team_plus` matched `plus` and the `team` branch was reachable only from a bare `team` id, the one team tier that happened to work. The free team tier missed from the other side: B reports an unsubscribed workspace with a null `planId` and an empty `membershipTier`, an id no different from a personal free account, so no id can name it. `planBadgeTierForWorkspace` states the whole rule once, and both surfaces read it — the rail's account row and the Settings CLI card, which the owner requires to move together (「设置中的这里应该一样的逻辑」). Team-namespaced ids go through the shared `isTeamPlanTier`, so the badge cannot drift from the other team gates; `workspaceType === 'team'` covers the free tier that no id can express. The plan LABEL is untouched, deliberately: it answers a subscription question, every user-created workspace in B is team-typed, and reading one as the other is #146. 免费 beside the `team` wordmark is now the intended pairing — the family is team, the subscription is not paid. No interaction, layout, sizing, artwork, or copy changes; no new i18n keys. * fix(collab): warm the workspace-scoped digest faces on switch and reconnect (#6222) Every workspace-scoped cache in the daemon keys on the active workspace, so the instant the user switches, `catalog` and `members` are both a miss and the FIRST consumer in the new workspace refills them inline on its own request path (`createPersistentSyncCache` fetches synchronously on a miss). The cost is the same either way; the only question is who waits for it. A switch is a user action followed by idle time, so paying it there is free — paying it inside the first project load or agent run is not. `PUT /api/workspace/active` now announces a CONFIRMED switch through a new fire-and-forget `onWorkspaceSwitched` seam, and the daemon warms the two faces from it. The announcement deliberately does not fire for a rejected or rolled-back switch: warming there would refill the caches against a workspace this daemon just refused to move to. Warming goes through the cache functions, never their underlying fetchers. `createSwrCache`'s read returns `entry.inflight ?? refresh(key)`, so a warm that races the very consumer it is protecting joins that consumer's request instead of issuing a second one. No request is added that would not otherwise be made. Second half, same root cause: on hub reconnect the gap-closing catch-up read the team-project and member lists THROUGH those same caches, so an entry that settled just before (or during) the disconnect still counted as fresh, the diff concluded "nothing changed", and the one cycle meant to close the gap emitted nothing — the client stayed stale until an unrelated read happened to miss. Reconnect now drops those two entries first, and `pollOnce` joins the in-flight refresh that starts, so the pair still costs one fetch per face. Co-authored-by: lefarcen <ontf116@gmail.com> * fix(daemon): split AMR workspace proof failure from proof refusal (#6221) An AMR run died in preflight with "its persisted workspace <id> is unavailable for the signed-in member". Two causally unrelated situations shared that one error and one outcome: a directory that answered and genuinely listed no active membership, and a directory that could not be read at all. The `.catch` swallowed a read failure into `{ ok: false, items: [] }`, so a transient vela blip made a user's own project unrunnable — and nothing downstream could tell the two apart. Refusal now fails closed under `ProjectWorkspaceScopeRefusedError` (`PROJECT_WORKSPACE_SCOPE_REFUSED`); an unreadable directory is retried with bounded backoff and, if it still cannot be reached, the run proceeds with no workspace, i.e. on the caller's own account wallet. That is a product decision recorded in the docblock: a hard failure is worse than a mis-attributed personal charge. The reverse direction, charging a personal run to a team wallet, stays impossible — no fallback selects another workspace, and a proven non-membership still refuses. The decision was also invisible: a full diagnostics export carried no directory-fetch line, no run-id in the daemon log, and only a generic AGENT_EXECUTION_FAILED plus prose. Every branch now reports a closed-union outcome to the daemon log, the run record (via `ApiError.details`, leaving the wire error code unchanged) and telemetry. * fix(comments): preserve rejected mutations * fix(comments): preserve partial send results * fix(web): keep workspace-scoped data fresh across account and workspace changes (#6225) * fix(web): keep workspace-scoped data fresh across account and workspace changes Three defects in one family — workspace-scoped data in the web client going stale or being read under the wrong identity. 1. The workspace switcher's module-level directory cache had no invalidation. `/api/workspace/directory` answers "which workspaces can the SIGNED-IN ACCOUNT see", but nothing cleared the cache on an account change and `resetWorkspaceDirectoryCache` had no production caller — so signing in as a different account kept the previous account's workspace names on screen, and kept them confidently, since a non-empty cache also suppresses the loading state. The cache is now served only to an identity that can claim it, by membership id, which keeps the flash-free reopen it exists for. The `coalescedGet` key is identity-scoped for the same reason. 2. App.tsx read `/api/skills` without the caller's workspace headers and never refetched on a workspace switch. The daemon is fail-closed on a missing `x-od-workspace-id`, so a headerless read is not the unfiltered list — it is the list with every workspace-claimed skill removed, including the ones claimed by the workspace the user is in. Skills now get the identity headers and the same workspace-keyed refresh design systems already had. Launch still spends exactly one `/api/skills` request: the read moved from the boot pass to the workspace-keyed effect rather than being added alongside it. 3. `PUT /api/workspace/active` already returns the post-switch context, from the same producer `GET /api/workspace/context` serves and only after the daemon agrees the switch happened. The client parsed that body, discarded it, and made every consumer re-read the same data. The shell is now seeded from the response; the refresh broadcast still fires, because `useProjectWorkspaceScope` listens to it and passive tabs cannot be seeded. Switch path: 2 requests -> 1. * fix(web): discard workspace-scoped reads that land after the identity moved Review follow-up on #6225 (PerishCode, two threads — both real). Keying a read by identity stops the wrong identity being SERVED a cached answer. It does nothing about the other direction: a read issued for identity A resolves later, and by then the caller may be identity B. Committing that late answer restores A's data under B — the same staleness this PR removes, arriving through the back door. A workspace switch is precisely when one read is in flight and another starts, so reverse-order completion is reachable, not exotic. Both sites now use one mechanism, `beginWorkspaceScopedRead`: capture the identity the read is issued FOR, request with that captured context, and compare against a ref before any commit. Its docblock states the invariant and the two rules that make it hold (request with the captured context so request and guard cannot disagree; compare against a ref, never a closed-over prop, which would always match and guard nothing). It is the cross-component form of the `requestEpochRef` ordering guard `useWorkspaceContext` already applies to its own read. - `refreshSkills` and `handleSkillsChanged` (App.tsx): a slow read for the workspace the user left no longer overwrites the current catalog. The registry-ready gate is intentionally skipped on a discarded response — it is not an answer about the current identity, and the newer read marks it. - `loadWorkspaceDirectory` (EntryNavRail.tsx): an in-flight account-A read that lands after the rail moved to account B no longer repopulates either the module cache or the visible list. This was the sharper of the two, because it wrote into module scope and so persisted past the render that caused it. Request counts are unchanged (startup 4, switch 1): the guard discards responses, it does not issue requests. * fix(web): make computing a workspace identity total, and key the skills trigger on it Fixes the `Web workspace tests` failure 886f11b24 introduced. CI reported all 555 files and 5583 tests PASSING and still exited 1: Unhandled Rejection TypeError: Cannot read properties of undefined (reading 'canShareProjects') ❯ workspaceIdentityCacheKey src/collab/useWorkspaceContext.ts:112:32 ❯ beginWorkspaceScopedRead src/collab/useWorkspaceContext.ts:159:20 ❯ src/App.tsx:1770 ❯ src/App.tsx:1799 ❯ commitHookEffectListMount originating in tests/components/App.amr-plan-tier.test.tsx `workspaceIdentityCacheKey` dereferenced `context.permissions` unguarded. That survived while it was only called during render (a throw there fails loudly, in the right place) and inside `fetchSkills`'s own try/catch. 886f11b24 put it behind `beginWorkspaceScopedRead` in an async function launched with `void refreshSkills()`, so a partial context turned a synchronous programming error into an unhandled rejection — invisible to every assertion, fatal to the process. `permissions` is required on the contract, but API JSON reaches these objects through an unchecked cast, so a partial context is reachable at runtime and not only in fixtures. Computing an identity must therefore be TOTAL: a partial context is its own cache partition, never an exception. Second, independent defect, found while fixing the first: the skills trigger was keyed on `workspaceId` while the commit guard compares the full identity digest. A guard that discards without guaranteeing a successor is worse than the staleness it replaced — two accounts in one shared team workspace differ only by membership, so account A's pending read would be discarded for B while the unchanged workspace id suppressed B's replacement read, leaving the functional registry loading forever. The trigger now uses the same digest the guard compares, so every transition that invalidates a response also starts its successor. Both are covered by tests that go red without the fix: - tests/collab/workspace-identity-key-is-total.test.ts (new) — identity is total for null, partial and complete contexts, including a late commit-time guard. - tests/components/App.skills-workspace-scope.test.tsx — a member-id-only change must start AND complete a successor read. --------- Co-authored-by: lefarcen <ontf116@gmail.com> * feat(landing): publish current pricing snapshot * fix: durably deliver enterprise leads * test(web): update ProjectView comment-status suites to the workspace-scoped signature (#6233) `feat/workspace-team`'s `Web workspace tests` lane is red at the branch tip: 3 files / 4 tests, all comment-status assertions. Not a flake and not attributable to any open PR — I had to prove twice while landing #6225 that a red lane was inherited rather than mine, which is the cost a red base imposes on every downstream PR. Cause: `1c15574c2 fix(comments): preserve rejected mutations` gave `patchPreviewCommentStatus` a fifth argument — the acting workspace context — so the daemon can authorize the mutation (`routes/project/comments.ts`, same commit). It updated `FileViewer.test.tsx` and added `registry.test.ts` coverage but left three `ProjectView.*` suites on the four-argument signature. The tests were stale, not the code. Checked before editing, because "update the tests" is the wrong move if the assertions were right: - Every asserted call still happens, unchanged. The failures are pure arity mismatches: `api-empty-response` expects `(…, 'failed')` and receives `(…, 'failed', null)`; likewise `needs_review` in run-cleanup and `applying` in run-isolation. No status transition changed. - `1c15574c2` shipped the new contract WITH tests — `describe('preview comment scoped mutations')` asserting `x-od-workspace-id` reaches the PATCH. The fifth argument is deliberate and covered. - The parameter is optional and additive; headers are spread only when a context is present. Also restores two assertions that had gone silently vacuous. A four-argument matcher cannot match a five-argument call, so `run-isolation`'s two `not.toHaveBeenCalledWith` assertions could never match once the signature grew and passed unconditionally — coverage actively lost, not merely failing. Both pass with the correct arity, which independently confirms the new code does not write `needs_review` after a canceled+done run and does not reset a queued send's own comment to `open`. The fifth argument is matched as an explicit `null` rather than `expect.anything()`, which rejects null/undefined and would have re-broken the positive assertions and re-vacuated the negative ones. Tests only — no source file is touched. Co-authored-by: lefarcen <ontf116@gmail.com> * fix(collab): make the local pin the only workspace-selection truth (#6230) * test(collab): pin the one-account-two-clients workspace scope behaviour Executable evidence for the account-level Active Workspace investigation. Models vela exactly as its source behaves at origin/main 2155a969f: - active_workspace_selections is keyed by app_user_id alone (db/schema/public.hcl:792), so an account has exactly ONE selection. - GET /api/v1/workspaces/current discards a ?workspaceId= hint (services/api/src/workspaces/routes.ts:166-176, and vela asserts it by name in services/api/test/workspaces-personal.test.ts:480). - GET /api/v1/workspaces is scoped by app_user_id, not by the selection. What it establishes: OD's local pin DOES hold against a competing client (resolvePinnedWorkspace), so the switch does not 404. The damage is that the losing client's context degrades to a directory synthesis - planId null and a 0/0 seat summary, which derives isSeatFull: true - and its context read gains a second, fallible round-trip the winning client never makes. No behaviour change. * fix(collab): make the local pin the only workspace-selection truth Picking a workspace is a local action, but `PUT /api/workspace/active` gated it on mutating ACCOUNT-scoped state in vela: it PUT the account-level active workspace first and failed the user's click with 502 `workspace_switch_rejected` when that write did not take, then rolled back both the local pin and the backend switch if the follow-up context read disagreed. That backend row is keyed by app user alone, so it can only ever name ONE workspace for an account. One account routinely runs several clients in different workspaces, so every switch yanked the other clients' server-side scope, and whichever client did not write the row last was answered for the wrong workspace — forcing OD to synthesize its context from the membership directory, which carries no billing plane. That client saw planId null and a 0/0 seat summary, and a 0/0 summary derives isSeatFull: true, so a workspace with free seats read as FULL and blocked inviting. It also turned that client's context read into two round-trips, the second of which could blip and leave it with no context at all. vela #1179 (1ba3eebcb, deployed to test 09:57Z) taught `GET /api/v1/workspaces/current` to honour `x-vela-workspace-id`, the per-request workspace scope vela already accepted on its resource plane, billing scope routes and the Link gateway. So: - `fetchCurrent` sends that header and drops the `?workspaceId=` query param, which vela ignores by design and asserts it ignores — it only ever made this call look scoped. - `PUT /api/workspace/active` no longer calls vela. The membership directory it already reads is the authorization; once that confirms an active membership the switch cannot fail, so the 502 gate and the rollback are gone along with `selectWorkspace` and `putCurrentWorkspace`. - An unconfirmed context read is no longer treated as a refusal: the route answers from the directory entry it already validated instead of reverting the user's choice, mirroring the invariant `resolvePinnedWorkspace` already follows in the same module. Verified against the deployed test backend, GETs only: an explicit workspace returns that workspace (not the account row), a workspace the caller is not a member of is refused 404 `workspace_member_required`, and both an absent and a blank header keep the previous account-level behaviour. The URL query hint is still ignored. vela's `active_workspace_selections` table and its write path are left alone; deprecating it is a separate decision and #1179 kept omitting the header backward compatible. Two comments that asserted the now-false invariant are corrected. * fix(collab): never answer a switch with a workspace the pin no longer holds Review catch (mrcfps): `workspaceContext.current()` is not a passive read. The vela provider's `resolvePinnedWorkspace` does its OWN fresh directory lookup and, when that confirms the pinned workspace is gone, clears the pin and re-pins a recovery workspace so a removed member is not locked out of everything. The route's directory read can meanwhile have been served from its 5s cache and still list that workspace. The previous branch state read `context.workspaceId !== workspaceId` and treated the provider's recovery as a merely-unconfirmed read, synthesized the stale cached entry, and returned 200 claiming the requested workspace while `activeWorkspace.get()` had already become the fallback. That shipped this PR's own thesis — the local pin is the only selection truth — as a violable invariant, and the user-visible symptom is the switch appearing to succeed and then snapping back on the next context poll. The pin is now re-read AFTER `current()` resolves. If the provider moved it, the route reports `404 workspace_no_longer_available` for the workspace the user asked for, never claims it, and does not warm its caches. The recovery pin is deliberately left in place: reverting it would restore the very "signed out of every workspace" state it exists to prevent. The directory entry that authorizes the switch is also now required to be a LIVE membership (`memberStatus === 'active'`, lifecycle not deleted) — the same predicate the provider uses. Matching on id alone let a listed-but- removed membership authorize a switch AND get synthesized into the response. Tests wire the real provider against the production cached directory fetcher over one shared pin store, exactly as server.ts does, so the cached and fresh reads genuinely disagree. Disabling the new pin re-read turns "never claims a workspace the pin no longer holds" red and nothing else. --------- Co-authored-by: lefarcen <ontf116@gmail.com> * fix landing pricing controls * fix(daemon): resolve the AMR scope-telemetry app version in its own scope (#6240) Every AMR run in 0.16.2-beta.148 died at spawn with `spawn failed: appVersionForCapture is not defined`. `appVersionForCapture` is a local of `createFinalizedMessageTelemetryReporter`. #6221's `amr_workspace_scope_resolved` capture called it from `startChatRun`, ~7,500 lines and one function away, so the name resolved to nothing. The callback runs while building the agent's launch env, inside the spawn `try`, so the ReferenceError surfaced as the generic AGENT_EXECUTION_FAILED spawn failure for 100% of AMR runs. `design.getAppVersion` is the accessor that scope actually has, and it is the same one the unreachable helper falls back to, so the reported value is unchanged. A scope guard covers the class rather than the instance: it runs the checker over `server.ts` with `@ts-nocheck` stripped and fails on any identifier that reaches runtime unbound. It flagged one sibling, fixed here too — the critique orchestrator's `skill` label read `effectiveSkillId`, a local of `composeDaemonSystemPrompt`. A `typeof` guard on an undeclared name does not throw, so instead of crashing that label has silently been `undefined` for every run since #1485. `@ts-nocheck` on `server.ts` is the enabling condition for both: an undefined identifier in this file reaches users without any tool objecting. Removing it is a separate project — 29 daemon files carry it. * fix(web): isolate workspace identity snapshots * test(e2e): move the server.ts identifier-scope guard into the merge gate (#6244) `apps/daemon/tests/server-identifier-scope.test.ts` landed with the 0.16.2-beta.148 AMR spawn fix (#6240) but protected nothing: `ci.yml`'s "Daemon workspace tests" step runs exactly one file (`tests/project-watchers.test.ts`), so no other daemon suite executes in any workflow. The guard sat outside every merge-gate lane. Widening the daemon lane is not available as a local fix — that exact command string is pinned by `workflowRunsOnlyAllowedDaemonTest` in `scripts/check-certain-exempt-consumption.ts`, which conditions the `trae-cli.test.ts` docs-consumption exception on the lane running nothing else. Touching it is a coupled scope-policy change. So host the guard where a lane already runs and the wiring is itself guarded: - Any change under `apps/daemon/src/` matches `certain-daemon-core` (`scripts/scopes.ts`), whose effects include `ui_p0_validation_required`; `run_e2e_vitest` is `isFull || web_tests_required || ui_p0_validation_required`. A `server.ts`-only change therefore arms `E2E Vitest` even at the merge queue's `certain` threshold, and an unresolved file list escalates fail-closed to full. - The `daemon core boundary` guard (`scripts/lib/guard/scope.ts`) asserts `ci.yml` still contains both `run_e2e_vitest == 'true'` and `pnpm --filter @open-design/e2e test`, and runs in the always-on policy floor — so the premise cannot rot silently. The check only ever reads `server.ts` as text (no daemon boot, no fixtures), and reading another app's tree as a repository resource is what root `AGENTS.md` sends to `e2e/tests/` — the same reason `e2e/tests/critique-coverage.test.ts` lives there. Behavior is unchanged, including both self-checks that keep the guard from going vacuous. Verified red on the pre-#6240 `server.ts`: exit 1 naming `appVersionForCapture (line 9261)` and `effectiveSkillId (lines 9657/9658)`; green (exit 0) on the fixed file. * fix(collab): align unbound project mutation identity (#6231) * fix(web): name the caller when a run starts before its project scope resolves Sending the 「水面焦散」 example prompt from Home failed instantly on a team workspace: daemon 401: {"error":{"code":"WORKSPACE_CONTEXT_REQUIRED","message":"workspace context is required"}} with `run_id: n/a`, because the refusal lands before the run is created. That string is produced in exactly one place in the repo — the `!createResp.ok` branch of the `POST /api/runs` create fetch in `providers/daemon.ts` — so the refused call is run creation, gated by `enforceWorkspaceResourceMutation ('project', …)`. The cause is client-side. Home creates the project WITH the caller's workspace headers, so #6201 binds it to the team workspace; the follow-on auto-send then went out with NO headers, because it took its identity from the PROJECT's workspace scope — an async read still in flight when the auto-send fires (its gate is `messagesInitialized` + `activeConversationId`, never the scope). Every other project write in `ProjectView` (`patchProject`, `uploadProjectFiles`, the comment mutations) already asserts the caller's own context; run creation was the one write that did not. INVARIANT, now named in `runWorkspaceIdentity`: a send names its caller while the project's binding is still UNREAD, and never overrides an answer the daemon actually gave. Deliberately not a blanket `?? caller` — every answered or failed state keeps asserting nothing, because for them a headerless request is judged on daemon-owned state while an asserted one is judged on client-controlled headers: - `unbound` — `headerlessMutationAllowed` short-circuits on "no row anywhere" BEFORE asking for an identity, so asserting would turn a working 200 into a 403 and break 「未登录也可以用自己 cli 修改未登录态下的那些 project」. - `unavailable` — the daemon's `resolveProjectWorkspaceScope` returns this both for an unreadable directory AND for a directory that answered with no active membership, i.e. a proven "you were removed". - a FAILED scope read — this identity also picks the wallet the AMR pre-run balance gate prices against, and guessing the caller's team wallet with the binding unknown blocks a send the daemon would have answered (the dead button 21f452ffe undid). Second consequence of the same null, fixed by the same one-liner: with no resolved scope, `checkAmrBalanceGate` was called with `undefined` and priced the run against the ACCOUNT wallet instead of the team's. The red spec observes that directly rather than arguing it. `ProjectView.run-isolation.test.tsx` mocks `useProjectWorkspaceScope` with a hand-written factory that enumerates every export, so the new export is added there too — without it, adding one export breaks all 64 tests in that file with "not a function" at render. * fix(web): narrow the run-identity fallback to a project's first unread binding Review catch (nettee): keying the fallback on `loading` served two opposite situations, because `useProjectWorkspaceScope`'s trailing transition guard re-enters `{ loading: true, scope: null }` whenever the resolved caller identity stops matching — and every workspace switch does that: - first read, nothing known -> the caller is the only identity available - revalidating a KNOWN binding -> the caller's current workspace is a guess that contradicts an answer we already have So a send issued during a workspace switch asserted the workspace the user had just moved TO for a project still bound to the one they moved FROM. Both consumers break, and differently: `POST /api/runs` can 403 because `enforceWorkspaceResourceMutation` still finds the project row under the old workspace, and `checkAmrBalanceGate` preflights the new workspace's wallet — worse than the `undefined` this fix was written to remove, because a wrong wallet looks like a real answer. `ProjectWorkspaceScopeState` now carries `initialLoadPending`, reported by the hook rather than inferred from `loading`: true from mount until the first settled answer (a scope OR a failure) for the current `projectId`, false for that project's whole lifetime afterwards, and reset when `projectId` changes because a different project genuinely has not been read. `runWorkspaceIdentity` keys the fallback on that bit alone, and its docblock names which of the two loading reasons it serves so the distinction cannot erode. The field is required, not optional, so every construction site has to state which case it is. Two pre-existing assertions in `useProjectWorkspaceScope.test.tsx` now document the distinction they always exercised: a project A->B rerender reports pending (B is unread), while a same-project identity change reports not-pending — the exact window this fixes. * fix(collab): align unbound project mutation identity Allow an identified caller to mutate a project that no workspace has claimed, matching the existing headerless and unbound-resource behavior without persisting a new binding. Name the caller on Home auto-send while keeping AMR preflight scope derivation unchanged. * fix(web): refresh the settled run billing scope Track the project billing context in both callbacks that read it so an auto-send after scope settlement cannot preflight through a stale unscoped closure. Add a regression whose run identity stays referentially stable while the billing scope changes. * fix(web): stop asserting disproved run scope * fix(web): guard workspace-scoped catalog reads (#6249) * fix(web): guard workspace-scoped catalog reads * fix(web): guard remaining plugin catalog races * fix(web): align design catalog guard scope * fix(landing): show introductory team totals * fix(daemon): label critique with project skill (#6251) * fix CI scopes across file renames (#6252) * fix(ci): preserve scopes across renames * fix merge queue rename ceiling detection * test raw merge compare responses * fix(landing): make contact sales KV canonical * fix(web): preserve Cloud sign-in during outages (#6274) * fix(collab): allow shared project viewer comments * fix(web): keep readonly comment creation available * feat(web): personal/team project labels + collapse chat for shared non-owners (#6294) * feat(web): rename sidebar project lists and collapse chat for shared non-owners Workspace home left rail now labels personal vs team project lists ("Personal projects" / "Team projects", 个人项目 / 团队项目) across all locales. Opening a confirmed shared team project that the viewer did not create defaults the chat pane to collapsed so the design is primary; owners and personal projects keep chat open, and expanding chat stays sticky for the visit. * fix(web): use effective ownership for shared non-owner chat default Default-collapsed chat was latching on raw isOwner, so a catalog-confirmed owner whose collab status was still missing ownerMemberId looked like a non-owner and permanently collapsed chat. Expose isEffectiveOwner and isSharedNonOwner from useProjectCollab (catalog + session-created + status) and gate the sticky collapse path on the confirmed non-owner signal only. * fix(web): stop narrow chat error cards stacking titles vertically (#6295) Move the long Open Design Cloud switch CTA into UserActionCard footer actions (same shell as run-recovery), add a card-width container query so head actions reflow when ChatPane is narrow, and soften title wrapping so CJK copy no longer renders one character per line. * fix(workspace): make resource authority explicit (#6287) * fix: make workspace authority explicit across resources * fix(web): keep new team projects writable during scope load * fix: close workspace authority review gaps * fix(web): retry rejected project auto-send * fix: propagate workspace scope to project consumers * fix: cache project read workspace authority * fix(web): stabilize project scope revalidation * fix: cache project collaboration status authority * fix: cache collaboration status owner reads * fix: revalidate media wait tool authority * fix: rehome member comments on local threads * fix(web): stabilize project resource authorization * fix(web): prioritize settled project authority * fix(web): consume queued home auto-send handoffs * fix: revalidate dirty comment pulls * fix: isolate mutation authority reads by session * fix: cache project presence read hot path * fix(web): stop unauthorized project background writes * fix(web): require settled scope for project background work * fix(web): scope remaining project reads by workspace * fix(web): scope remaining project resource consumers * fix(web): partition project caches by full authority * fix(daemon): pin run workspace billing scope * fix(daemon): lease workspace read authority * fix(daemon): keep presence reads on the hot path * fix(web): refresh deck thumbnails across workspace scope * fix(daemon): revoke stale unshared team mirrors * perf(daemon): cache stale mirror read guards * fix(web): gate deep-link reads on project workspace * fix(web): keep deep-linked project tab scoped * fix(web): preserve project routes during onboarding * fix(web): keep project previews warm across file-list toggles * perf(daemon): refresh presence without cold reads * fix(web): keep retained preview iframes connected * fix(web): reuse exact HTML thumbnail sources * fix(web): settle read-only empty project chat * fix(daemon): scope CLI run transports by workspace * test(web): align preview cache refresh semantics * fix(web): require positive shared viewer ownership proof * fix preview auto-fit measurement feedback * preserve preview fit during annotation freezes * preserve preview measurement semantics on refresh * stabilize preview overflow measurement test * test design systems move exclusively to team * fix design systems move exclusively to team * test shared project title scope convergence * test(daemon): cover project command workspace scope * fix(daemon): scope project command transports * fix shared title test project state type * fix(daemon): preserve shared project catalog title * fix(daemon): keep foreign mirrors creator-unattributed * fix(web): recover first shared project conversations * fix(web): fence conversation recovery generations * test(web): verify conversation recovery cleanup fence * UI polish batch: cloud sign-in, onboarding, composer menu (#6281) * UI polish batch: cloud sign-in, onboarding, composer menu Sign-in surfaces (rail callout, balance-gate dialog, onboarding) had drifted from the visual system and lost some redundant chrome; this batch tightens them up alongside a couple of composer/design-files reorganizations that were sitting in the same working tree: - Rail's signed-out callout: reorder copy above the login pill, give the pill an icon + accent-green label, restore the Escape hatch the pill had before it lost its close affordance. - AmrBalanceDialog (insufficient-balance / signed-out gate): add a full-bleed art banner above the copy, drop the now-redundant icon badge, tighten spacing/shadows to match. - Onboarding cloud landing: switch from a single centered column to a two-column layout (form pane + full-bleed art panel), move the language switcher into the footer, swap the local-CLI/BYOK links for icon Buttons, and add a dismiss control to the activation-retry hint. - Composer "+" menu: fold 插件/设计百宝箱 back in as hover-expand submenu rows instead of standalone quick pills above the input. - Design files panel: move new-document/upload actions out of the always-visible toolbar into the empty-state actions only. - Message center: drop the redundant header close button (backdrop click and Escape still dismiss it) and restyle the list from bordered cards to a divider-separated list. - New `key` / `robot` / `translate` / `arrow-right` icons; language menu switches from the `languages` glyph to `translate`. - Tab launcher popover reverts to the glass material; language dropdown gets a max-height + scroll so long lists don't blow out the popover. Rebased the composer-quick-pill removal onto this branch's own accessibility work on those pills (opener-based focus return via `ComposerStandalonePanel`) rather than reverting it — the "next step" card still drives the same standalone-panel API, just without a pill to hand focus back to. Also updated/removed the tests that pinned the now-removed surfaces (quick-pill popup contract, message-center close button, onboarding top bar, design-files toolbar upload trigger) so none of this lands with a newly-red suite. * perf(web): optimize onboarding cloud artwork * fix(web): invalidate project file reads after mutations * fix(web): disable readonly project starter mutations * fix(web): preserve focus for standalone composer panels * test(e2e): require explicit workspace scope * fix(web): invalidate file reads on project events * test(e2e): seed explicit settings workspace * test(e2e): align manual edit with current inspector * fix(web): refresh deployments when share opens * test(e2e): follow composer design system entry * fix(web): keep local project creation workspace-independent * fix(web): preserve scoped auth recovery state * test(e2e): follow current entry settings flows * fix(web): preserve AMR retry across settings * test(e2e): model explicit personal workspace recovery * test(e2e): stabilize AMR logout settings recovery * fix(projects): return workspace scope on create --------- Co-authored-by: lefarcen <935902669@qq.com> * fix(workspace): preserve scoped projects after main sync (#6320) * fix(daemon): surface AMR OpenCode stall context (#6040) * fix(daemon): surface AMR OpenCode stall context * fix(daemon): accept runtime-omitted OpenCode diagnostics Generated-By: looper 0.11.0 (runner=fixer, agent=codex) * fix(ci): make static gate runner-independent (#6039) --------- Co-authored-by: PerishFire <39043006+PerishCode@users.noreply.github.com> * test(e2e): parallelize restoration group (#6169) * test(e2e): parallelize restoration group * test(e2e): identify conversations from persisted prompts Generated-By: looper 0.11.0 (runner=fixer, agent=codex) * test(e2e): wait for conversation persistence --------- Co-authored-by: Looper <looper@noreply.github.com> * feat(landing-page): sharpen the Codex agent page for "codex ui" intent (#6200) The /agents/codex-design/ page ranks #1 for "codex design" but only ~6th with a 1.3% CTR for "codex ui", a query that grew from 30 to ~90 daily impressions this month. A live SERP check shows the intent is mostly "build UI with Codex" (our intent), with a minority looking for the Codex app's own interface. - Retitle to "Codex Design: Build UI with OpenAI Codex" (title + H1). - Lead the frontend section with the query phrase and an answer-shaped opening paragraph, so the section is extractable for AI answers. - Add a disambiguation paragraph separating the Codex app's own UI from the UI you build with Codex, and route the former back to the main line. - Add two FAQ entries covering both readings; they also feed the FAQPage schema, which already earns a text snippet on this query. Applied across all 11 shipped locales (en, zh authored; the other nine translated with the page's terminology preserved). Co-authored-by: Joey <236967869+joeylee12629-star@users.noreply.github.com> * Add Clone Audit plugin (#5687) * Add Clone Audit plugin * Update open-design.json * fix: make clone audit skill reusable * fix: sanitize clone audit provenance path * fix(e2e): bound tools-dev runtime lifecycle (#6204) * test(e2e): refresh full-pool UI fixtures (#6211) * fix(web): allow skipping required chat questions (#6177) * fix(web): allow skipping required chat questions * fix(web): auto-skip unanswered chat questions --------- Co-authored-by: xiaoche-hub <298951296+xiaoche-hub@users.noreply.github.com> * docs(tools-pack): add build cache contract (#6207) * docs(tools-pack): add build cache contract Document the tools-pack build-graph cache as a contract: the exact-match acceptance model, determinant rules, materialization-time parameters, the signing boundary, and fail-closed confidence grading. The rules come from an audit of all 11 cache nodes. Two are written down because nothing currently enforces them: a node key must carry the key of every upstream node it consumes, and a node key must not restate a list that already exists as a constant. Known low-confidence points are declared explicitly so fail-closed grading stays checkable rather than becoming a verbal convention. * docs(tools-pack): clarify cache materialization exceptions Generated-By: looper 0.11.2 (runner=fixer, agent=codex) * docs(tools-pack): document NSIS base version scope Generated-By: looper 0.11.2 (runner=fixer, agent=codex) --------- Co-authored-by: Looper <looper@noreply.github.com> * docs(landing-page): add 0.16.0 release post, localize and re-cover 0.15.1 (#6236) * docs(landing-page): localize 0.15.1 post, fix its cover, add 0.16.0 release post The 0.15.1 blog post shipped English-only and with an off-brand cover: a Fauvist oil painting overlaid with large display type, which reads nothing like the warm editorial illustrations every other release post uses. It also pointed `socialImage` at a 309KB JPEG while a WebP sat unused beside it. Regenerate the cover in the established house style (cream paper ground, sage/terracotta watercolour washes, pencil sketch resolving into a calm product surface), drop the stray JPEG, and add the full ten-locale i18n block so /zh/, /ja/, /ko/, /de/, /fr/, /ru/, /es/, /pt-br/, /it/ and /tr/ read in their own language instead of falling back to English. Also add the missing 0.16.0 "Reliable Delivery" post with a cover plus two inline figures in the same style, localized across the same ten locales. The 0.16.1 patch is a single preview fix, too thin to carry its own page, so it lands as a closing section of the 0.16.0 post and the download CTA points there. * docs(landing-page): fix doubled apostrophes and locale copy in release posts Three defects surfaced reviewing the localized bodies. The French, Italian and Turkish bodies rendered every apostrophe twice — "aujourd''hui", "all''interno", "0.16.1''i". The `''` escape belongs to single-quoted YAML scalars, but `bodyHtml` is a block scalar, where content is literal. 173 occurrences across the two posts. Korean used Japanese corner brackets and Brazilian Portuguese and Turkish used French guillemets. All three take curly double quotes. The Chinese copy read as translation rather than prose. "标签" opens the release line as a UI label, not a version tag; "抢画框", "编辑策展位" and "安静修复" are literal renderings that say nothing in Chinese; "画廊" is not the term the product itself uses for a gallery, which keeps the English word. The tag fix also lands on 0.10.0 through 0.15.0, which share the phrasing — leaving the series half-corrected would read worse than either state alone. * docs(landing-page): drop the leading tag word from release post openings Every release post opened with the word for a git tag before the version identifier — "Tag open-design-v0.16.0", "Etiqueta …", "タグ …", and in Chinese "标签", which reads as a UI label rather than a version. The word carries no information the identifier does not already carry, and in several languages it lands as a category noun the sentence never uses again. Drop it across all nine release posts and every locale, in both the summary and the opening line, leaving the version identifier to open the dateline. Spanish and Brazilian Portuguese lose the feminine agreement that referred back to the removed noun; Turkish loses the trailing "etiketi" apposition for the same reason. * docs(landing-page): correct the 0.16.1 interval in the 0.16.0 post 0.16.0 was published 2026-07-22 14:42 UTC and 0.16.1 on 2026-07-23 16:11 UTC — 25.5 hours apart. "Two days later" overstated it, and the same wording had been carried into all ten localized bodies, so every published route repeated it. --------- Co-authored-by: Joey <236967869+joeylee12629-star@users.noreply.github.com> * feat(integrations): add the local Open Design Cloud flow for Codex (#6055) * feat(daemon): expose Vela login through CLI and MCP * feat(mcp): add interactive local brief card * feat(packaged): bootstrap local MCP headlessly * feat(daemon): secure local BYOK credential profiles * feat(cli): manage secure BYOK profiles * feat(web): store BYOK keys in secure profiles * fix(runs): deduplicate cloud generation requests * feat(daemon): add end-to-end plugin observability * fix(pack): include native PTY runtime in desktop packages Lazy-load node-pty in the daemon so missing native binaries only disable Terminal and interactive Keychain operations instead of crashing startup. Ship and validate target prebuilds in macOS and Windows packages. Repair the macOS spawn helper before signing, and invalidate stale Windows packaging caches. Cover the packaged PTY path in macOS and Windows smoke tests. Require Vela CLI for every beta desktop build target. * fix(mcp): localize and stabilize plugin briefs Keep collect and confirm on one MCP Apps card, report intrinsic size changes, and remove the fragile widget-state fallback. Localize brief forms, summaries, status, and public errors from the current request or Host locale while preserving stable protocol ids and selections. Keep internal runtime identifiers out of user-facing MCP guidance. * fix(packaged): register live Studio URLs with daemon Register the packaged web sidecar loopback origin over namespace-scoped daemon IPC after dynamic binding. Invalidate install-info by the live web port and remove the second MCP URL cache so run and project responses use the current Studio address. Validate loopback origins and cover registration, rebind, and cache refresh. * fix(mcp): stabilize brief confirmation lifecycle Keep confirmed briefs locked after Host publication failures and retry only the cached follow-up message instead of confirming twice. Replace blank initialization with a compact loading state, accept immediate and delayed tool results, and bump the MCP Apps resource to v3 so Codex does not reuse the stale card. Add an executable JSDOM Host bridge harness covering double-submit, publication retry, delayed results, and repeated draft notifications. Validated with the full daemon suite, workspace typecheck, and guard. * fix(mcp): prevent brief app resize feedback loops Replace the self-observed intrinsic-height loop with deduplicated body measurements so Codex MCP app iframes do not repeatedly resize themselves and fail sandbox startup. Bump the brief resource URI to v4 to avoid cached v3 cards and cover the regression with the focused brief-app spec. Validated with daemon tests/build, workspace guard/typecheck, a verified beta DMG, and a direct packaged MCP resource smoke. * fix(mcp): use the final Open Design plugin identity Make open-design the only accepted external plugin ID across MCP tools, run attribution, artifact version origins, and telemetry. Rename the Brief MCP App resource to v5 and reject the unpublished old ID instead of aliasing it. Validated with 171 daemon tests, 5 web tests, daemon/web typechecks, and guard. * chore(pack): bump Vela CLI to 0.0.27 * chore(nix): refresh pnpm dependency hashes * fix(mcp): honor host and plugin request contracts Respect independently advertised MCP Apps capabilities and prefer the Codex-native follow-up bridge so confirmed briefs render as readable user turns instead of context-only messages. Bump the brief resource to v6 to invalidate stale cards.\n\nMark Vela login and account probes as open-world interactions, and require stable request IDs for attributed generation so lost responses cannot create a second logical run. * fix(cli): support keyless BYOK profiles Add an explicit --no-api-key save mode for local and self-hosted providers while keeping credential-bearing profiles stdin-only. Reject missing or conflicting credential modes and cover both paths in the CLI tests. * fix(pack): replace headless owner when desktop opens Advertise headless packaged runtimes as having no visible window, then shut them down before a normal desktop launch continues instead of treating SHOW as a successful focus. Validated with the focused packaged headless and launcher lifecycle tests (20 passed). * fix(pack): clean up failed headless startup Acquire the headless identity, sidecars, and IPC server through one failure-atomic lifecycle so later bootstrap errors close every previously acquired owner in reverse order. Cover MCP-install and web-identity publication failures; validated with 22 focused tests and the packaged typecheck. * fix(byok): remove raw provider request contract Expose only daemon-owned BYOK profile references from shared run types and the web transport, while retaining the daemon's fail-closed rejection for legacy or untyped raw credential payloads. Validated with 76 web provider tests plus web and contracts typechecks. * fix(daemon): preserve interrupted run idempotency Hydrate queued or running durable requests as DAEMON_RESTARTED failures before idempotency reuse, preserving the original request and workflow mappings instead of creating a second cloud operation. Share the restart transition with boot reconciliation and expose synthetic terminal events to reattaching clients. Validated with 48 focused tests and the daemon typecheck. * fix(byok): roll back failed credential metadata writes Snapshot secure-store values before mutation and compensate create, update, and delete operations when profile metadata cannot be persisted, preventing orphaned or lost credentials. Validated with nine focused credential-service tests and the daemon typecheck. * fix(web): reconcile selected BYOK profile metadata Treat the daemon's selected secure profile as authoritative for protocol, endpoint, model, and API version so CLI profile edits cannot leave the browser showing stale execution settings. Validated with 66 config tests and the web typecheck. * fix(byok): migrate legacy credentials before cleanup Import each supported legacy browser credential into a stable daemon-owned secure profile before removing plaintext copies. Keep the original browser record on secure-store or unsupported-provider failures and surface a Settings recovery path. Cover successful migration, duplicate projections, and injected secure-backend failure while preserving existing Bedrock downgrade behavior in memory. * fix(byok): secure Windows profiles with DPAPI Dispatch native Windows BYOK profiles to a CurrentUser DPAPI backend rooted under the resolved daemon data directory. Secrets enter PowerShell only through stdin, encrypted blobs stay separate from non-secret profile metadata, and API responses remain secret-free. Add platform dispatch coverage, a Windows-only real DPAPI round-trip test, and the packaged Windows smoke path for create, resolve, response-redaction, and delete behavior. * fix(web): preserve config writes during hydration * fix(byok): persist secure credentials across entry flows * test(byok): cover secure onboarding persistence --------- Co-authored-by: Cheems <94773058+itscheems@users.noreply.github.com> Co-authored-by: lefarcen <935902669@qq.com> * test: strengthen E2E coverage and fixtures (#6150) * test: strengthen e2e coverage and fixtures * test: allow artifact route when starting conversation * test: keep e2e count assertions stable Use the shared stable-count helper for no-request and duplicate-event windows so delayed async events cannot escape the assertions. Generated-By: looper 0.11.0 (runner=fixer, agent=codex) * fix: add e2e assertion import extension Use the explicit runtime extension required by the e2e NodeNext typecheck.\n\nGenerated-By: looper 0.11.0 (runner=fixer, agent=codex) * fix: preserve design system provenance and settle e2e assertions Keep disabled design systems available to project recovery and provenance while filtering only runtime injection. Make hover and cancellation checks observe their full settled windows. Generated-By: looper 0.11.2 (runner=fixer, agent=codex) * test(e2e): preserve unique restoration run IDs Pass the restoration fixture's run ID prefix through routeSuccessfulRuns so each mocked request receives a distinct run identity. Generated-By: looper 0.11.2 (runner=fixer, agent=codex) * test(e2e): stabilize agent and async count fixtures Route restoration agent requests through the shared JSON and SSE fixture, capture autosave baselines after a quiet period, and observe onboarding cancellation for a bounded stable window.\n\nGenerated-By: looper 0.11.2 (runner=fixer, agent=codex) * fix: honor disabled design systems in daemon runs Filter disabled persisted project selections at prompt and analytics boundaries, and keep restoration run fixtures unique.\n\nGenerated-By: looper 0.11.2 (runner=fixer, agent=codex) * test(e2e): shorten cancellation duplicate check Generated-By: looper 0.11.2 (runner=fixer, agent=codex) * fix(daemon): continue stalled post-tool sessions (#6237) * fix(daemon): continue stalled post-tool sessions * fix(daemon): separate post-tool continuation budget Generated-By: looper 0.11.1 (runner=fixer, agent=codex) * fix(daemon): preserve retry telemetry budget Generated-By: looper 0.11.1 (runner=fixer, agent=codex) * fix(daemon): align retry failure telemetry Generated-By: looper 0.11.1 (runner=fixer, agent=codex) * fix(tools-pack): carry workspace build key into tarballs (#6235) * fix(amr): recover late login failures and trace auth stages (#5986) * fix(amr): recover late login failures and trace auth stages * fix(amr): preserve scoped cancel attempt IDs Generated-By: looper 0.11.1 (runner=fixer, agent=codex) * fix(amr): defer unsupported Vela auth stages Generated-By: looper 0.11.1 (runner=fixer, agent=codex) * fix(amr): narrow fallback telemetry to shipped Vela Generated-By: looper 0.11.1 (runner=fixer, agent=codex) * fix(amr): preserve live login after stale cancel Generated-By: looper 0.11.1 (runner=fixer, agent=codex) * fix(amr): preserve cancel during login startup Retain cancellation intent when a provisional cancel races the delayed canonical login response, then cancel the canonical attempt before polling can begin. Generated-By: looper 0.11.1 (runner=fixer, agent=codex) * fix(amr): rejoin newer login after startup cancel Generated-By: looper 0.11.1 (runner=fixer, agent=codex) * fix(amr): preserve cancel across web login starts Generated-By: looper 0.11.1 (runner=fixer, agent=codex) * fix(amr): retain cancel when status refresh fails Generated-By: looper 0.11.1 (runner=fixer, agent=codex) * fix(amr): cancel onboarding status preflight Treat cancellation before an auth attempt exists as a local preflight cancel so a delayed status response cannot start login.\n\nGenerated-By: looper 0.11.1 (runner=fixer, agent=codex) * ci: constrain Actions cache writes (#6270) * fix(tools-pack): carry workspace build key into tarballs * ci: constrain Actions cache writes * fix(daemon): auto-mint assistantMessageId when clients omit pin (#6107) * fix(daemon): auto-mint assistantMessageId when API clients omit it Web always supplies assistantMessageId. Headless/MCP/eval clients that already send conversationId but omit the pin left lastMessageId null and skipped multi-turn native session resume (missing_cursor). Mint the id server-side whenever a conversation is bound and the client did not, and seed the user message the same way the old MCP-only path did. * fix(daemon): validate conversation ownership before omit-pin seed Reorder project-ownership checks before minting assistantMessageId and seeding the user prompt so cross-project omit-pin requests cannot corrupt foreign chats. Make ChatRunCreateRequest.assistantMessageId optional and expose conversationId/assistantMessageId on McpRunCreateRequest with contract tests for the omit-pin shape. Generated-By: looper 0.11.1 (runner=fixer, agent=grok-build) * fix(daemon): reject missing conversation before omit-pin mint Return CONVERSATION_NOT_FOUND when a client supplies a stale or mistyped conversationId so omit-pin does not mint an unpersisted assistantMessageId and plugin snapshot resolve does not FK-crash with a 500. Generated-By: looper 0.11.1 (runner=fixer, agent=grok-build) * fix(daemon): seed latest turn and fallback-bound user prompts Prefer currentPrompt over full message transcripts when seeding omit-pin user turns, and still seed after conversationId fallback when the client already supplied assistantMessageId. Generated-By: looper 0.11.1 (runner=fixer, agent=grok-build) * fix(daemon): preserve attachments on omit-pin seeded user turns Copy request attachments and commentAttachments into the server-seeded user message so omit-pin/headless clients keep chips and annotation context after conversation reload. Generated-By: looper 0.11.1 (runner=fixer, agent=grok-build) * fix(daemon): treat empty currentPrompt as authoritative omit-pin seed Attachments-only ChatRequest turns send currentPrompt as '' while message is the flattened transcript. Prefer any string currentPrompt, including empty, so seeded user rows keep empty content and do not duplicate history. Generated-By: looper 0.11.1 (runner=fixer, agent=grok-build) * fix(daemon): seed turn metadata and bump project activity on omit-pin Persist sessionMode, runContext, and appliedPluginSnapshot on omit-pin seeded user turns so reload/retry keep applied context. Call updateProject after seed so listProjects reorders headless/API activity like PUT /messages. Generated-By: looper 0.11.1 (runner=fixer, agent=grok-build) * fix(daemon): require projectId for bound conversation ownership Reject POST /api/runs when conversationId is present but projectId is missing or non-string, so omit-pin cannot seed messages without owning project context. Cover both early and post-fallback ownership checks. Generated-By: looper 0.11.1 (runner=fixer, agent=grok-build) * fix(daemon): preserve slideIndex and BMP kind on omit-pin seeds Keep deck annotation slideIndex and classify .bmp as image when seeding user messages for clients that omit assistantMessageId. Generated-By: looper 0.11.1 (runner=fixer, agent=grok-build) * fix(daemon): seed empty message when omit-pin has attachments When currentPrompt is unset and message is empty, still seed the user turn if attachment metadata is present so chips/annotations survive reload. Generated-By: looper 0.11.1 (runner=fixer, agent=grok-build) * fix(daemon): seed omit-pin chat content from original request Plugin resolution may rewrite meta.message with a rendered scenario brief for the run; persist requestBody currentPrompt/message for the user turn so the internal brief is not shown as chat content. Generated-By: looper 0.11.1 (runner=fixer, agent=grok-build) * fix(web): persist browser preview viewport (#4899) * fix(daemon): honor Kiro ACP turn completion (#6268) * fix(daemon): isolate plugin-started Local Codex runs (#6273) Disable Codex plugins only for externally attributed Open Design Plugin runs so Local Codex cannot recursively enter collect_brief or Cloud login. Preserve normal Local Codex plugin loading and the existing operator-wide override. Validated with the focused runtime args suite, workspace typecheck, guard, and an isolated source smoke that produced a valid artifact without Cloud login. Co-authored-by: Cheems <94773058+itscheems@users.noreply.github.com> * fix(landing): accept signed Vela team plan leads (#6283) * fix: durably deliver enterprise leads * fix(landing): make contact sales KV canonical * feat(prompts): introduce on-demand discovery in SP v2.0 (#6223) * feat(prompts): introduce on-demand discovery in SP v2.0 * fix(prompts): prevent nested deck label overlap * fix(plugins): stabilize od-default task routing * fix: address prompt and deck audit regressions * fix(prompts): restore plan mode precedence * fix(daemon): accept all form answer headers --------- Co-authored-by: bone3deep1962-collab <bone3deep1962@gmail.com> * fix(web): surface BYOK migration validation errors (#6280) * fix(web): surface BYOK migration validation errors Preserve structured daemon errors during legacy credential migration and reserve offline guidance for fetch failures. Keep legacy browser credentials until migration succeeds, and cover HTTP validation, malformed responses, and network failures. Validated with focused web tests, web typecheck, workspace guard, and workspace typecheck. * fix(web): stabilize BYOK persistence error telemetry Map secure-profile HTTP and network failures to semantic error codes before emitting settings_byok_test_result, while preserving existing fallback behavior for unrelated connection-test errors. Validated with the complete web test suite, web typecheck, workspace typecheck, guard, and git diff --check. --------- Co-authored-by: Cheems <94773058+itscheems@users.noreply.github.com> * fix(ui): improve dark-mode contrast for off-state toggles (#5825) * fix(ui): improve dark-mode contrast for off-state toggles The default off-state track uses --border-strong (#c9d0da light / #46433c dark). In dark mode #46433c is only ~5% lighter than the --bg-subtle (#252321) panel behind it, making the toggle nearly invisible when off and users unsure of the control state. Bump the off-state track to #6b6862 with a subtle inset border, and add a thin outline to the white thumb so it stays visible against the (now lighter) track. On-state already uses --text (#e8e4dc) and is left unchanged. Applies to both .toggle-row (used by speaker-notes toggle in the deck tab) and .compact-toggle (used by SurfaceOptions toggles). Hover lift gives an additional interactive affordance. Fixes #5298 * fix(ui): fix two dark-mode toggle blocking issues from review Two correctness issues called out by mrcfps: 1. System dark theme never gets the contrast fix — the default "system" theme mode removes [data-theme] and falls back to @media prefers-color-scheme. Added a parallel block scoped to html:not([data-theme]) inside @media (prefers-color-scheme: dark). 2. Hover override wins over on-state — .compact-toggle:hover and .toggle-row:hover have higher specificity than .on variants, so hovering an ON toggle dropped its track from bright var(--text) to #75726c. Changed to :not(.on):hover so the hover lift only applies when off, leaving the on-state always bright. Both applied to both selector paths (explicit data-theme and system dark). * fix(web): keep Azure deployment names editable (#6034) * chore(plugin-previews): refresh baked preview manifest (#6293) Co-authored-by: open-design-bot <bot@open-design.ai> * fix(byok): withdraw Windows DPAPI backend (#6308) * fix(byok): withdraw Windows DPAPI backend * fix(byok): clean up retired Windows secret blobs Generated-By: looper 0.11.2 (runner=fixer, agent=codex) --------- Co-authored-by: Looper <looper@noreply.github.com> * fix(web): dismiss stale todo after continuation starts (#6307) * fix(web): preserve shared project update timestamps * fix(web): reconcile shared timestamps on home * fix(web): preserve workspace scope in preview assets * fix(collab): avoid unscoped shared cover requests * fix(web): avoid double-wrapping preview assets * fix(web): preserve first prompt across project refresh * test(web): target the active shared project card * test(web): keep empty BYOK profile type-safe * test(e2e): require explicit workspace scope * fix(web): finish scoped preview hydration * test(e2e): align manual edit with current inspector * fix(web): reconcile files after event stream readiness * fix(web): keep local project creation workspace-independent * fix(web): preserve scoped auth recovery state * test(e2e): assert explicit Personal workspace scope * test(e2e): preserve visual AMR account fixture * test(web): await scoped cover source * UI polish batch: cloud sign-in, onboarding, composer menu (#6281) * UI polish batch: cloud sign-in, onboarding, composer menu Sign-in surfaces (rail callout, balance-gate dialog, onboarding) had drifted from the visual system and lost some redundant chrome; this batch tightens them up alongside a couple of composer/design-files reorganizations that were sitting in the same working tree: - Rail's signed-out callout: reorder copy above the login pill, give the pill an icon + accent-green label, restore the Escape hatch the pill had before it lost its close affordance. - AmrBalanceDialog (insufficient-balance / signed-out gate): add a full-bleed art banner above the copy, drop the now-redundant icon badge, tighten spacing/shadows to match. - Onboarding cloud landing: switch from a single centered column to a two-column layout (form pane + full-bleed art panel), move the language switcher into the footer, swap the local-CLI/BYOK links for icon Buttons, and add a dismiss control to the activation-retry hint. - Composer "+" menu: fold 插件/设计百宝箱 back in as hover-expand submenu rows instead of standalone quick pills above the input. - Design files panel: move new-document/upload actions out of the always-visible toolbar into the empty-state actions only. - Message center: drop the redundant header close button (backdrop click and Escape still dismiss it) and restyle the list from bordered cards to a divider-separated list. - New `key` / `robot` / `translate` / `arrow-right` icons; language menu switches from the `languages` glyph to `translate`. - Tab launcher popover reverts to the glass material; language dropdown gets a max-height + scroll so long lists don't blow out the popover. Rebased the composer-quick-pill removal onto this branch's own accessibility work on those pills (opener-based focus return via `ComposerStandalonePanel`) rather than reverting it — the "next step" card still drives the same standalone-panel API, just without a pill to hand focus back to. Also updated/removed the tests that pinned the now-removed surfaces (quick-pill popup contract, message-center close button, onboarding top bar, design-files toolbar upload trigger) so none of this lands with a newly-red suite. * perf(web): optimize onboarding cloud artwork * fix(web): invalidate project file reads after mutations * fix(web): disable readonly project starter mutations * fix(web): preserve focus for standalone composer panels * test(e2e): require explicit workspace scope * fix(web): invalidate file reads on project events * test(e2e): seed explicit settings workspace * test(e2e): align manual edit with current inspector * fix(web): refresh deployments when share opens * test(e2e): follow composer design system entry * fix(web): keep local project creation workspace-independent * fix(web): preserve scoped auth recovery state * test(e2e): follow current entry settings flows * fix(web): preserve AMR retry across settings * test(e2e): model explicit personal workspace recovery * test(e2e): stabilize AMR logout settings recovery * fix(projects): return workspace scope on create --------- Co-authored-by: lefarcen <935902669@qq.com> * test(e2e): lock design system team partition * fix(workspace): stabilize scoped project lifecycle * test(e2e): stabilize retained workspace transitions * fix(workspace): retain exact scope through transient outages * test(workspace): lock outage identity boundaries --------- Co-authored-by: Ray Xi <2667192167@qq.com> Co-authored-by: PerishFire <39043006+PerishCode@users.noreply.github.com> Co-authored-by: Looper <looper@noreply.github.com> Co-authored-by: Joey-nexu <joeylee12629@gmail.com> Co-authored-by: Joey <236967869+joeylee12629-star@users.noreply.github.com> Co-authored-by: bestthanapon <thanapon.suwannasuk@gmail.com> Co-authored-by: open-design-crew[bot] <299007234+open-design-crew[bot]@users.noreply.github.com> Co-authored-by: xiaoche-hub <298951296+xiaoche-hub@users.noreply.github.com> Co-authored-by: Cheems <94773058+itscheems@users.noreply.github.com> Co-authored-by: Amy <58060647+AmyShang-alt@users.noreply.github.com> Co-authored-by: Marc Chan <mrc@powerformer.com> Co-authored-by: _HDCoder <2728073932@qq.com> Co-authored-by: bone3deep1962-collab <bone3deep1962@gmail.com> Co-authored-by: Nicholas-Xiong <2482929840@qq.com> Co-authored-by: mehmet turac <mehmetturac@gmail.com> Co-authored-by: open-design-release-bot[bot] <295937643+open-design-release-bot[bot]@users.noreply.github.com> Co-authored-by: open-design-bot <bot@open-design.ai> Co-authored-by: CHENGLONG WANG <honam884844@gmail.com> * fix(workspace): seed dashboard workspace input * test(workspace): cover live dashboard workspace input * fix(workspace): backfill legacy workspace names * test(e2e): harden workspace collaboration coverage (#6312) Harden Workspace collaboration authority, lifecycle cleanup, and browser coverage.\n\nRetry an expired authorized Team-project pull exactly once with a fresh receipt while preserving fail-closed scope, version, cleanup, and final freshness checks. Align the fake Vela receipt lifetime with the real two-second contract and use scalable E2E timeouts. * fix(workspace): refresh dashboard input on switch * fix(viewer): avoid inert attribute warning * fix(chat): preserve user turn ordering * fix(workspace): stop retracted Team plugins immediately (#6335) Prevent stale Team-plugin listings, materializations, and delayed positive hub reads from reactivating a resource after retraction. Preserve independent Personal plugins with the same manifest ID and keep Team members able to share their own resources. Add deterministic regression coverage for cache invalidation, binding lifecycle, and the superseded-positive activation race. * fix(workspace): harden Vela billing proxy boundaries (#6348) Reject invalid wallet balances without overwriting valid cache state, validate normalized proxy paths and Workspace scope, strip hop-by-hop headers, and tear down upstream requests on disconnect. Keep team Workspace scope fail-closed when Connection nominates the protected header. * fix(web): tolerate unnamed workspace directory rows (#6349) Preserve a verified explicit Workspace context when legacy directory rows omit the display-only workspaceName field. Keep exact-row name backfill when a non-empty name is present, without inferring authority from active or default Workspace state. * fix(workspace): enforce exact project-list scope * fix(workspace): show team design systems in pickers * fix(web): reserve image cards while thumbnails load * fix(web): keep home creation types ready during refresh * test(e2e): align Windows beta smoke with installer * perf(web): start team catalog from exact directory identity * fix(web): refresh revoked workspace context * fix(web): order collaboration presence refreshes * fix(amr): prefer selected Vela OpenCode companion * fix(web): isolate collaboration presence sessions * fix(web): parallelize scoped project route bootstrap * perf(daemon): cache workspace project list authority * fix(web): preserve project-open connection budget * test(web): preserve memory toast exports in app mock * fix(web): preserve exact project opening scope * fix(daemon): coalesce scoped comment pulls * fix(daemon): retry team comment relay delivery * fix(daemon): atomically queue comment relay writes * fix(collab): show team comments across local conversations * fix(daemon): preserve catalog-only projects on unshare * fix(collab): close comment realtime catch-up gaps * docs: add workspace team rollout runbook * fix(collab): retry failed Team project shares * fix(workspace): isolate personal projects in recent lists * fix(daemon): isolate personal design systems * fix(workspace): authorize runs before plugin snapshots * test(daemon): align workspace retry contracts * fix: isolate plugins and skills by workspace member * fix(workspace): scope design systems in run prompts * fix(workspace): gate runs before plugin resolution * fix(daemon): namespace team design system bindings * fix: close plugin and skill scope leaks * test(collab): cover project-scoped comment actions * fix(workspace): scope project resource selection * fix(workspace): preserve personal design system reads * fix(workspace): authorize scoped run resources first * fix(workspace): keep project design systems scoped * fix(types): carry design system member scope * fix(billing): scope personal balances by workspace * fix(workspace): preserve unbound local design systems * fix: resolve team design systems by canonical binding * fix(workspace): invalidate nested project catalog cache * fix: keep team design system runs canonical * perf: batch durable comment relay delivery * fix: cancel stale local comment relays * fix(web): preserve scoped project display snapshots * fix(web): synchronize project rename projections * perf: reuse request-scoped workspace authority * test: enforce personal project creator ownership * fix(web): wait for project workspace authority * fix(daemon): invalidate team project caches before signaling * fix(web): order targeted project metadata refreshes * fix(workspace): preserve team catalog on outages * fix(web): isolate catalog display across accounts * fix(web): scope extension marketplace catalogs * fix(web): order broad team catalog refreshes * fix(web): scope home plugins to workspace identity * fix(web): isolate plugin views by workspace identity * fix(web): polish sign-in and composer focus * fix(web): preserve scoped project state after team moves * fix(workspace): enforce scoped design and billing identity * test(e2e): align workspace flows with scoped bootstrap * fix(collab): drain newer comment revisions promptly * test(e2e): keep owner actions after workspace lock * fix(web): converge project renames across scoped lists * fix(web): preserve pending projects across view changes * fix(web): restore preview runtime after activation * test(e2e): align workspace scope assertions * test(web): cover hidden stream recovery * fix(web): update deep-link project titles after rename * fix(collab): retry project metadata propagation * fix(web): preserve legacy design system logos * fix(web): wait for activated preview bridge * fix(design-systems): isolate team resource storage * fix(plugins): reject team mirror mutations * fix(web): partition extension catalogs by workspace * fix(skills): isolate team mirrors by workspace * fix(plugins): keep local share projects unscoped * fix(web): retry preview state capture during activation * test(e2e): scope project workspace fixtures explicitly * feat(collab): coordinate team resource invalidations * fix(collab): emit team resource changes after sync * fix(web): invalidate project lists after updates * fix(web): serialize project renames by scope * fix(collab): preserve team project comment anchors * fix(web): refresh shared resources after remote changes * fix(collab): materialize team projects before rename * fix(web): keep workspace catalogs current * fix(web): close catalog and credential races * test(workspace): harden team workflows and packaged deep links (#6358) * test(workspace): harden team workflows and deep links * fix(packaged): deliver hot invite deeplinks Generated-By: looper 0.11.7 (runner=fixer, agent=codex) * fix(workspace): catch up team resources safely Generated-By: looper 0.11.7 (runner=fixer, agent=codex) * fix(workspace): invalidate resource catch-up changes Generated-By: looper 0.11.7 (runner=fixer, agent=codex) * fix(workspace): catch up shared resource changes Generated-By: looper 0.11.7 (runner=fixer, agent=codex) * fix(packaged): preserve fallback invite deeplinks Generated-By: looper 0.11.7 (runner=fixer, agent=codex) * fix(workspace): hide retracted team skills Generated-By: looper 0.11.7 (runner=fixer, agent=codex) * test(e2e): align workspace CI fixtures with route bootstrap * fix(collab): complete design system reconnect adoption * feat(analytics): track Workspace interactions (#6397) * feat(analytics): track Workspace interactions * fix(analytics): dedupe community page views --------- Co-authored-by: elifive555555 <296440099+elifive555555@users.noreply.github.com> * fix(daemon): preserve team comments across conversations * fix(collab): keep presence rosters converged * fix(comments): preserve routed comment anchors * fix(workspace): reconcile team project renames * fix(collab): preserve member directory last-good state * perf(collab): start scoped Team presence before status * fix(comments): keep relay anchors internal * perf(collab): warm presence from daemon cache * perf(collab): cancel obsolete cold status polls * fix: fence presence sessions against late heartbeats * perf(collab): share team member roster scheduling * fix(collab): preserve roster store through strict replay * perf(collab): retain workspace member directory stores * fix(collab): resolve presence identities from team directory * fix(collab): hide unresolved presence identities * fix(collab): prefer directory presence names * perf(web): preload workspace member directory * test(collab): preserve no-leave lifecycle contract * fix(web): preserve personal workspace presence after share * fix(web): refresh covers after team materialization * fix(web): refresh files after team materialization * fix(web): gate shared file reads on project authority * fix(web): preserve workspace folder action sizing * ci(e2e): split project-workspace UI P0 shard into project-workspace + project-collab project-workspace pins workers=1 by design (deliberate, not incidental — see e2e/AGENTS.md's UI test stability rules on cross-file worker carry-over), so its 7 files ran fully serially: ~26min wall time in recent merge-queue runs, the longest pole in the ui_p0 matrix by a wide margin over its 10-13min siblings. workspace-multi-client-collab.test.ts alone (spins up two isolated client/daemon runtimes per case) accounted for ~10 of those minutes. Carving it and workspace-keyboard-flows.test.ts into a new project-collab shard — still workers=1, still one file at a time — lets the two halves run as separate concurrent CI jobs instead of one long serial chain, without touching the single-worker-per-shard isolation the pin exists for. Updates the topology guards that pin the exact matrix shape so the split doesn't drift silently: DAEMON_RUNTIME_DEFINITION_MATRIX_NAMES (scopes.ts), the full/candidate matrix name guards (guard/scope.ts), and the fixed expectations in scopes.test.ts / packaged-smoke-workflow.test.ts. Validated: pnpm guard (UI P0 shadow contract + CI topology checks pass), pnpm typecheck (all workspaces), and the two topology test files (107/107 passing). * fix(collab): revoke unshared team project mirrors * fix(web): preserve unbound project authority across workspace changes * fix(web): pair scoped raw queries with headers * test(e2e): pin writable scope for project actions * test(web): cover Personal authority recovery after reload * test(web): await version preview readiness * fix(workspace): scope brand design system resources * fix(workspace): materialize owner team design systems * fix(web): fence design system reads by generation * fix(web): propagate brand read generations * fix(web): preserve workspace project visibility * fix(preview): retain scope for runtime relative assets * fix(web): explain design system delete denial * fix(daemon): bound team resource prewarm scopes * fix(daemon): recheck prewarm lease after queue * fix(web): stabilize transient presence roster gaps * chore(pack): pin Vela CLI 0.0.28 * fix(workspace): move design system project with team share * fix(workspace): gate linked unshare on live authority * fix(workspace): ensure backing project before design share * fix(web): scope srcdoc preview assets * perf(web): mint preview scope only for srcdoc * perf(web): reuse srcdoc preview scope * chore(nix): refresh pnpm deps hashes for vela-cli 0.0.28 pnpm-lock.yaml moved @powerformer/vela-cli from 0.0.27-test.7 to 0.0.28, but nix/pnpm-deps.nix was not regenerated, so `nix flake check` failed with a fixed-output hash mismatch for both the daemon and web derivations. Hashes taken from the Nix-reported expected values in CI run 30933223422 (nix is not available on this machine to run `pnpm nix:update-hash` locally); the merge of origin/main did not touch pnpm-lock.yaml, so those values still describe this tree. * chore(ci): retrigger workspace-team validation The previous ci run for this branch sat pending with zero dispatched jobs; cancelling it and pushing an empty commit re-enters the ci-6142 concurrency group from a clean slot. * perf(web): skip preview mint for authored base * fix(collab): preserve presence through lease gaps --------- Co-authored-by: Ray Xi <2667192167@qq.com> Co-authored-by: CHENGLONG WANG <honam884844@gmail.com> Co-authored-by: lefarcen <ontf116@gmail.com> Co-authored-by: PerishFire <39043006+PerishCode@users.noreply.github.com> Co-authored-by: Looper <looper@noreply.github.com> Co-authored-by: Joey-nexu <joeylee12629@gmail.com> Co-authored-by: Joey <236967869+joeylee12629-star@users.noreply.github.com> Co-authored-by: bestthanapon <thanapon.suwannasuk@gmail.com> Co-authored-by: open-design-crew[bot] <299007234+open-design-crew[bot]@users.noreply.github.com> Co-authored-by: xiaoche-hub <298951296+xiaoche-hub@users.noreply.github.com> Co-authored-by: Cheems <94773058+itscheems@users.noreply.github.com> Co-authored-by: Amy <58060647+AmyShang-alt@users.noreply.github.com> Co-authored-by: Marc Chan <mrc@powerformer.com> Co-authored-by: _HDCoder <2728073932@qq.com> Co-authored-by: bone3deep1962-collab <bone3deep1962@gmail.com> Co-authored-by: Nicholas-Xiong <2482929840@qq.com> Co-authored-by: mehmet turac <mehmetturac@gmail.com> Co-authored-by: open-design-release-bot[bot] <295937643+open-design-release-bot[bot]@users.noreply.github.com> Co-authored-by: open-design-bot <bot@open-design.ai> Co-authored-by: shangxinyu1 <shangxinyu@refly.ai> Co-authored-by: elifive555555 <296440099+elifive555555@users.noreply.github.com>	2026-08-05 08:31:54 +08:00
open-design-crew[bot]	809d45f27c	feat(integrations): add the local Open Design Cloud flow for Codex (#6055) ... * feat(daemon): expose Vela login through CLI and MCP * feat(mcp): add interactive local brief card * feat(packaged): bootstrap local MCP headlessly * feat(daemon): secure local BYOK credential profiles * feat(cli): manage secure BYOK profiles * feat(web): store BYOK keys in secure profiles * fix(runs): deduplicate cloud generation requests * feat(daemon): add end-to-end plugin observability * fix(pack): include native PTY runtime in desktop packages Lazy-load node-pty in the daemon so missing native binaries only disable Terminal and interactive Keychain operations instead of crashing startup. Ship and validate target prebuilds in macOS and Windows packages. Repair the macOS spawn helper before signing, and invalidate stale Windows packaging caches. Cover the packaged PTY path in macOS and Windows smoke tests. Require Vela CLI for every beta desktop build target. * fix(mcp): localize and stabilize plugin briefs Keep collect and confirm on one MCP Apps card, report intrinsic size changes, and remove the fragile widget-state fallback. Localize brief forms, summaries, status, and public errors from the current request or Host locale while preserving stable protocol ids and selections. Keep internal runtime identifiers out of user-facing MCP guidance. * fix(packaged): register live Studio URLs with daemon Register the packaged web sidecar loopback origin over namespace-scoped daemon IPC after dynamic binding. Invalidate install-info by the live web port and remove the second MCP URL cache so run and project responses use the current Studio address. Validate loopback origins and cover registration, rebind, and cache refresh. * fix(mcp): stabilize brief confirmation lifecycle Keep confirmed briefs locked after Host publication failures and retry only the cached follow-up message instead of confirming twice. Replace blank initialization with a compact loading state, accept immediate and delayed tool results, and bump the MCP Apps resource to v3 so Codex does not reuse the stale card. Add an executable JSDOM Host bridge harness covering double-submit, publication retry, delayed results, and repeated draft notifications. Validated with the full daemon suite, workspace typecheck, and guard. * fix(mcp): prevent brief app resize feedback loops Replace the self-observed intrinsic-height loop with deduplicated body measurements so Codex MCP app iframes do not repeatedly resize themselves and fail sandbox startup. Bump the brief resource URI to v4 to avoid cached v3 cards and cover the regression with the focused brief-app spec. Validated with daemon tests/build, workspace guard/typecheck, a verified beta DMG, and a direct packaged MCP resource smoke. * fix(mcp): use the final Open Design plugin identity Make open-design the only accepted external plugin ID across MCP tools, run attribution, artifact version origins, and telemetry. Rename the Brief MCP App resource to v5 and reject the unpublished old ID instead of aliasing it. Validated with 171 daemon tests, 5 web tests, daemon/web typechecks, and guard. * chore(pack): bump Vela CLI to 0.0.27 * chore(nix): refresh pnpm dependency hashes * fix(mcp): honor host and plugin request contracts Respect independently advertised MCP Apps capabilities and prefer the Codex-native follow-up bridge so confirmed briefs render as readable user turns instead of context-only messages. Bump the brief resource to v6 to invalidate stale cards.\n\nMark Vela login and account probes as open-world interactions, and require stable request IDs for attributed generation so lost responses cannot create a second logical run. * fix(cli): support keyless BYOK profiles Add an explicit --no-api-key save mode for local and self-hosted providers while keeping credential-bearing profiles stdin-only. Reject missing or conflicting credential modes and cover both paths in the CLI tests. * fix(pack): replace headless owner when desktop opens Advertise headless packaged runtimes as having no visible window, then shut them down before a normal desktop launch continues instead of treating SHOW as a successful focus. Validated with the focused packaged headless and launcher lifecycle tests (20 passed). * fix(pack): clean up failed headless startup Acquire the headless identity, sidecars, and IPC server through one failure-atomic lifecycle so later bootstrap errors close every previously acquired owner in reverse order. Cover MCP-install and web-identity publication failures; validated with 22 focused tests and the packaged typecheck. * fix(byok): remove raw provider request contract Expose only daemon-owned BYOK profile references from shared run types and the web transport, while retaining the daemon's fail-closed rejection for legacy or untyped raw credential payloads. Validated with 76 web provider tests plus web and contracts typechecks. * fix(daemon): preserve interrupted run idempotency Hydrate queued or running durable requests as DAEMON_RESTARTED failures before idempotency reuse, preserving the original request and workflow mappings instead of creating a second cloud operation. Share the restart transition with boot reconciliation and expose synthetic terminal events to reattaching clients. Validated with 48 focused tests and the daemon typecheck. * fix(byok): roll back failed credential metadata writes Snapshot secure-store values before mutation and compensate create, update, and delete operations when profile metadata cannot be persisted, preventing orphaned or lost credentials. Validated with nine focused credential-service tests and the daemon typecheck. * fix(web): reconcile selected BYOK profile metadata Treat the daemon's selected secure profile as authoritative for protocol, endpoint, model, and API version so CLI profile edits cannot leave the browser showing stale execution settings. Validated with 66 config tests and the web typecheck. * fix(byok): migrate legacy credentials before cleanup Import each supported legacy browser credential into a stable daemon-owned secure profile before removing plaintext copies. Keep the original browser record on secure-store or unsupported-provider failures and surface a Settings recovery path. Cover successful migration, duplicate projections, and injected secure-backend failure while preserving existing Bedrock downgrade behavior in memory. * fix(byok): secure Windows profiles with DPAPI Dispatch native Windows BYOK profiles to a CurrentUser DPAPI backend rooted under the resolved daemon data directory. Secrets enter PowerShell only through stdin, encrypted blobs stay separate from non-secret profile metadata, and API responses remain secret-free. Add platform dispatch coverage, a Windows-only real DPAPI round-trip test, and the packaged Windows smoke path for create, resolve, response-redaction, and delete behavior. * fix(web): preserve config writes during hydration * fix(byok): persist secure credentials across entry flows * test(byok): cover secure onboarding persistence --------- Co-authored-by: Cheems <94773058+itscheems@users.noreply.github.com> Co-authored-by: lefarcen <935902669@qq.com>	2026-07-30 02:00:56 +00:00
open-design-release-bot[bot]	ca4ecf0bf2	chore(release): bump main to 0.16.1 ahead of stable 0.16.0 (#6000) ... Co-authored-by: open-design-release-bot[bot] <open-design-release-bot[bot]@users.noreply.github.com>	2026-07-23 03:15:11 +00:00
Ray Xi	197e61803a	fix(daemon): bound macOS watcher file descriptors (#5889) ... * fix(daemon): bound macOS watcher file descriptors * fix(daemon): preserve symlink roots and refresh Nix hashes Keep the watch-root exemption ahead of the symlink traversal guard and lock the behavior with a real directory-symlink assertion. Refresh the daemon and web pnpm dependency hashes reported by the failing Nix build. Generated-By: looper 0.11.0 (runner=fixer, agent=codex)	2026-07-21 09:55:49 +00:00
PerishFire	3447f60a34	fix packaged payload desktop handoff (#5678) ... * fix packaged payload desktop handoff * fix beta mac full smoke fixture wiring * fix tools-pack mac payload cold start * test payload desktop update restart * fix Nix daemon launcher protocol build * fix(pack): harden Windows long-jump updates * fix(pack): harden mac long-jump acceptance * fix(handoff): defer armed journal writes until spawn and shutdown succeed Previously executeLegacyPayloadDesktopHandoff wrote the armed handoff journal, attempt, and runtime state before spawning the payload desktop and before the old desktop accepted shutdown. When spawn() threw or the shutdown request failed, the armed journal was stranded on disk, so the next cold start bailed out of prepareLegacyPayloadDesktopHandoff() with reason "already-armed" and the install stayed pinned to the old desktop generation indefinitely. Move the three writes to after both the payload child has spawned and the shutdown has been accepted. The old desktop is still alive while it acks the shutdown, and the payload waits for the old pid to exit before resuming, so the state still lands before the payload reads it. Add regression coverage for both the spawn-failed and shutdown-failed paths, asserting the journal stays "prepared" and a later cold start can retry. Generated-By: looper 0.10.3 (runner=fixer, agent=claude-code) * fix(updater): await payload spawn acceptance * fix(packaged): advance confirmed handoff recovery --------- Co-authored-by: Looper <looper@noreply.github.com>	2026-07-20 02:21:49 +00:00
open-design-release-bot[bot]	a1cbe0ec57	chore(release): bump main to 0.15.1 ahead of stable 0.15.0 (#5661) ... Co-authored-by: open-design-release-bot[bot] <open-design-release-bot[bot]@users.noreply.github.com>	2026-07-15 03:30:28 +00:00
open-design-release-bot[bot]	fb9ae974ab	chore(release): bump main to 0.14.2 ahead of stable 0.14.1 (#5441) ... Co-authored-by: open-design-release-bot[bot] <open-design-release-bot[bot]@users.noreply.github.com>	2026-07-10 14:50:47 +00:00
open-design-release-bot[bot]	38c20ef6fa	chore(release): bump main to 0.14.1 ahead of stable 0.14.0 (#5287) ... Co-authored-by: open-design-release-bot[bot] <open-design-release-bot[bot]@users.noreply.github.com>	2026-07-08 06:06:47 +00:00
lefarcen	0fecb15baa	chore(release): bump main to 0.12.1 ahead of stable 0.12.0 (#4900) ... Stable shipped 0.12.0 (tag open-design-v0.12.0, 2026-06-26) but main's packaged base version stayed at 0.11.1. release-beta's metadata guard requires the packaged base version to be strictly greater than the latest stable, so the daily beta build (notify-daily-feishu, 01:00 UTC) has failed every morning since 2026-06-27 with: packaged base version 0.11.1 must be strictly greater than latest stable 0.12.0 Bump all 18 workspace package.json versions in lockstep to 0.12.1 so main leads stable again. Verified the real prepare-beta guard now resolves 0.12.1-beta.1 (EXIT 0) against the live stable/beta feeds.	2026-06-29 14:47:46 +00:00
lefarcen	59bca72f7e	feat(export): programmatic screenshot-based PPTX/PDF export (#4604) ... * feat(export): programmatic screenshot-based PPTX/PDF export Replace the prompt-driven "ask the agent to run python-pptx" PPTX export with a deterministic, programmatic pipeline. The daemon renders each deck slide to a pixel-perfect PNG via the desktop's bundled Electron Chromium (reused over sidecar IPC — no second headless engine, so the packaged app does not grow) and assembles a one-image-per-slide .pptx (PptxGenJS) or raster .pdf (pdf-lib). - sidecar-proto: RENDER_SLIDES message + DesktopRenderSlides{Input,Result} - daemon: deck-export.ts assembler (decode + pptx + pdf), POST /export/pptx and /export/pdf-image routes, desktopSlideRenderer wiring - desktop: deck-capture.ts renders the deck off-screen and captures one PNG per `.deck > .slide` (skips presenter-mode .mini-slide clones) - web: exportProjectAsPptx() fetch+blob download; ProjectView swaps the prompt path for it - cli: `od export pptx|pdf` dual-track closure - remove the now-dead build-pptx-export-prompt lib + test Tests: deck-export assembler unit tests + exportProjectAsPptx web tests. Screenshot mode ships first; editable-rebuild modes are follow-up. * chore(nix): refresh pnpm deps hash * fix(export): deck PDF blank pages on opacity decks + image export capturing the modal Two pre-existing deck-export defects surfaced while validating the new export: - Vector PDF (Print-ready) left blank pages for decks that show one slide at a time via opacity: DECK_PRINT_CSS forced each .slide onto its own page but never reset opacity/visibility, and CSS transitions animated opacity from 0, so inactive slides printed blank. Force opacity/visibility/animation/ transition in print media (both the web and desktop DECK_PRINT_CSS). - "Export as image" captured Open Design's own format-chooser modal: the host compositor snapshot ran after the modal opened, so the overlay leaked into the PNG. Capture the clean preview before showing the modal; the cached snapshot is reused so opening the modal never re-captures over the overlay. * feat(export): dual-mode renderer + reuse screenshot for image/PDF export Unify all screenshot exports on one off-screen renderer and make them viewport-independent: - Renderer (deck-capture.ts) now has two modes: deck → one 1920x1080 PNG per slide (optionally just the slide at `index`); page (no `.slide` sections, e.g. a website) → a single full-document PNG at natural size. Adds `index` to the render input and `mode` to the result. - Image export now renders through the daemon off-screen renderer (deck → the current slide at fixed size; website → the whole page as one long image), so the exported size no longer depends on the preview pane and can never capture Open Design's own UI. Falls back to the host/iframe snapshot on web. - "Export as PDF" (UI) now produces a pixel-perfect screenshot PDF that matches the preview (same renderer as PPTX/image), falling back to the vector print path on web or on failure. - New POST /export/image route; PPTX on a non-deck returns a clear 422. * feat(export): smart full-page image capture + PDF back to print-view default Full-page image export now auto-selects the capture technique (users only see "full page"): - captureBeyondViewport (one clean off-screen pass, no fixed-element duplication) when the output fits the machine's real GPU texture limit — queried at runtime via WebGL MAX_TEXTURE_SIZE, not hard-coded — and below-the-fold content actually rendered. - scroll-segment stitch otherwise (too tall, or blank-below-fold scroll-driven pages like parallax landings): scrolls a viewport at a time, captures each frame, and stitches by real scroll offset into one long PNG. RAM-bound (a plain buffer, not a GPU texture), capped by a memory budget; encoded with a tiny dependency-free PNG encoder (node:zlib) so it bundles cleanly into the ESM packaged main and has no Skia dimension cap. - Output scale derives from the window DPR / actual captured chunk, fixing a double-scale bug (DPR x clip.scale) that produced 4x-sized images. PDF "Export as PDF" reverts to the print-ready vector path (instant, selectable text) as the default; the pixel-perfect screenshot PDF stays available via `od export pdf`. * fix(export): PDF defaults to the CJK-safe screenshot path, not vector printToPDF Chromium's vector printToPDF embeds no fonts in the packaged runtime and drops CJK glyphs entirely — a Chinese page exported to "PDF" lost all its Chinese text (only Latin survived). The off-screen screenshot renderer (already used for image/PPTX) rasterizes the real browser render, so CJK is always correct. "Export as PDF" now produces a pixel-perfect screenshot PDF that matches the preview (one page per deck slide, or the whole page for a website), falling back to the vector/browser print path only on web or on failure. Verified: a Chinese site that lost its text under vector printToPDF renders fully under the raster path. * perf(export): stitch scroll-segments with Electron's native PNG encoder The scroll-segment path was slow (~100s for a long parallax page) because of a hand-written PNG encoder: a per-pixel JS BGRA→RGBA loop over tens of millions of pixels plus zlib.deflate of a ~110MB high-entropy buffer. Replace both with Electron's native image pipeline: stitch chunks as BGRA with one Buffer.copy per chunk (capturePage already returns BGRA, which is what createFromBitmap wants — no channel swap, no per-pixel JS) and encode once via nativeImage.createFromBitmap(...).toPNG(). createFromBitmap is a CPU bitmap, not a GPU texture, so it is not bound by the texture limit. Removes the hand-written PNG encoder (crc32 / chunk framing / node:zlib). Measured on a long parallax page: image 44s→17s, PDF 101s→19s (~5x), and the native encoder also compresses better (55MB→26MB PNG). * fix(export): render the image only on Save, after the format is chosen Image export was rendering eagerly when the modal opened (a holdover from when the capture had to run before the modal to avoid catching the overlay). Now the desktop path renders off-screen and can't see the modal, so capture moves to the Save click: open modal → pick format → Save → render + encode + download. The Save button shows the "Saving…" state during the render; for the web-only host-compositor fallback the modal is hidden during the brief capture so it can't leak into the image. The snapshot is cached, so switching format after a render re-encodes without re-capturing. * perf(export): raster PDF embeds full pages as JPEG (52MB -> a few MB) The screenshot PDF embedded full-page captures as PNG, so a photo-heavy long page produced a ~52MB PDF. Full pages now render as JPEG (quality 82) — visually near-identical for web screenshots but ~10x smaller. Deck slides stay PNG (crisp text/graphics); image export still uses a lossless PNG source the client re-encodes to the user's chosen format. Threads a `pageImageFormat` hint through the render input; the desktop renderer encodes page mode as JPEG (CDP captureScreenshot format:jpeg / nativeImage toJPEG) and the daemon assembler embeds with embedJpg vs embedPng per image. * feat(export): pre-pass for reveal-on-scroll + deck image as one long image Two improvements found while testing real landing pages: 1. Pre-pass before full-page capture: freeze animations/transitions and scroll the whole page once (then back to top) so reveal-on-scroll content (IntersectionObserver / AOS / lazy images) is triggered and holds. This is the standard full-page-screenshot technique. Result: pages that previously came back blank-below-the-fold (and fell to the duplicate-prone scroll- stitch) now succeed with a clean single-pass captureBeyondViewport. Verified: a reveal-on-scroll landing page renders fully in one shot (no black, no duplicates); only pure JS-scrollY parallax (which re-hides at scrollY=0) still falls back to scroll-stitch. 2. Image export of a deck now stitches every slide top-to-bottom into one tall image (the "whole deck as one picture") via the native BGRA stitch, capped so a long deck can't exceed the bitmap limit. Ordinary pages remain a single full-page capture; a specific slide index is still honored if given. * fix(export): show the loading toast at the start (not after) + track real completion The "Exporting" toast was set inside the promise's .then(), so for a multi-second screenshot export it only appeared AFTER the export finished — looking frozen the whole time. Now fireShareExport shows a loading toast immediately, clears it on success, and shows an error toast on failure. The loading toast TTL is raised to 60s so it survives a long export, and PPTX threads its real promise (was fire- and-forget) so the toast reflects actual completion. Adds fileViewer.exportFailed across all locales. * fix(export): detect scroll-driven pages by comparison, not by color The blank-below-fold heuristic (flat-color fraction) was unreliable: a dark- themed page that renders fine (Mindloop, 89% near-black below the fold) looked "blanker" than a scroll-driven page that genuinely fails (Luxury, 78%), so the black middle slipped through and exported with a black band. Replace it with a color-independent comparison: render the document's MIDDLE band two ways — scrolled into view (real content) vs captureBeyondViewport at scroll 0 (what the one-shot produces). If they differ significantly, the page is scroll-driven and we use scroll-segment stitch; otherwise the clean one-shot. Verified: Luxury now exports full content (stitch), Mindloop stays a clean one-shot, dark designs are no longer false-flagged. * fix(export): recognize nested-`.slide` decks (export all slides + show PPTX) A deck whose slides are `.slide` nested under `.deck-viewport`/`.deck-stage` (not direct children of `.deck`/`body`) was missed: PDF/image exported only the first slide and the PPTX option was hidden, even though the slide pager showed "1 / 9". - Renderer: find slides via `.slide` anywhere, filtering out presenter-mode clones (`.mini-slide`/`.overview`/`.thumb`) in-page, instead of the rigid `.deck > .slide` selector. showSlide now also sets `visibility:visible` and toggles the common active-slide classes (active/visible/is-active/current) so decks that hide via `visibility:hidden` and gate reveals on `.visible` render every slide; animations are frozen so reveals reach final state instantly. - UI: PPTX export shows whenever the artifact is deck-like (incl. the content-detected `.slide` decks that drive the pager), matching the pager. Verified on a nested-`.slide` deck: PPTX = 9 slides, image = 9 stitched, all with content (previously only slide 1). * perf(export): cache /raw/ assets + halve per-slide round trips Two performance wins for screenshot export (covers + live preview benefit too): 1. /raw/ now emits ETag + Last-Modified + Cache-Control: no-cache, and answers conditional GETs with 304. Covers, live preview, and the screenshot export window all load project HTML + its fonts/CSS/images through /raw/, and in the packaged app the hidden export window shares the same Chromium session/cache as the web UI — so a second load reuses already-downloaded bytes instead of re-fetching every asset. The validators are derived from file size+mtime, so any agent rewrite changes them and busts the cache immediately (no-cache keeps it always-revalidate, never silently stale). Previously /raw/ sent no cache headers at all, so nothing was reusable. 2. Deck slide capture merges the slide-show DOM toggle and its two-frame settle into a single executeJavaScript round trip (showSlide returns the settle Promise) instead of two separate main<->renderer hops. Output is identical; the loop is measurably faster and the saving scales with slide count. Tests: apps/daemon/tests/project-raw-cache.test.ts covers the validators, 304 on If-None-Match / If-Modified-Since, cache-bust after rewrite, and the streamed media path. The merge is correctness-preserving by construction (same DOM ops, same two-frame settle). * perf(export): hand rendered images to the daemon as files, not base64 IPC The desktop renderer used to return every rendered slide/page as a base64 data URL inside the JSON IPC reply. For large images (photo-heavy decks) that means a 1.33x base64 blow-up plus JSON.stringify/parse of a multi-MB string plus a multi-MB socket transfer across the desktop->daemon sidecar bridge, with a matching RAM spike. The pixels only exist in the desktop process (it owns the Chromium that captures them), so they must cross to the daemon — but they should cross as a file on the shared filesystem, not as base64 in a JSON message. Now the daemon picks a unique scratch dir under its data root (<RUNTIME_DATA_DIR>/export-render/<id>), passes it as `outputDir` in the RENDER_SLIDES request, the desktop writes the images there and returns their paths in `slideFiles`, and the daemon reads them back and deletes the dir in a finally. desktop only ever writes to the absolute path the daemon handed it, so this works identically in dev and packaged (desktop never infers the data root). A unique per-request id means concurrent exports never collide. Base64 data URLs remain a fallback for older desktop builds that don't honor outputDir. - sidecar-proto: DesktopRenderSlidesInput.outputDir + DesktopRenderSlidesResult.slideFiles - deck-capture: emitImages() writes files when outputDir is set (all 3 paths: deck per-slide, deck stitch, full-page incl. scroll-segment) - deck-export: readSlideFiles() reads the handoff files (companion to decodeSlideDataUrls) - import-export-routes: create/own/clean the scratch dir; prefer slideFiles Tests: readSlideFiles unit tests; a route-level test that asserts the renderer is handed an outputDir under the data root, the image returns, the scratch dir is deleted after the response, and concurrent exports each get a unique dir. * chore(export): one-line per-phase timing logs for screenshot export A slow export now leaves a diagnosable trail instead of guesswork: - desktop `[od-export] render`: load / assets(fonts+images) / prepare / render phase breakdown + total, plus mode and whether the handoff used files. - daemon `[od-export] assemble`: renderer(IPC) / read(file handoff vs base64) / assemble(pptx/pdf build) + total + byte size. These immediately surfaced that a slow image export was dominated by the artifact's own in-browser compile (Babel/Tailwind CDN) and uncacheable external media — not the export pipeline (file read was ~2ms). One info line per export. * fix(export): normalize PDF page size to points; honor --title in CLI output name Addresses review feedback on PR #4604: - buildScreenshotPdf sized each PDF page by the captured image's pixel dimensions, so the nominal page size scaled with the capture's device pixel ratio (a 2x retina capture produced a page twice as large as 1x). Normalize each page to a fixed longest-side in points (960pt; a 16:9 slide => 960x540pt, matching PowerPoint) with the image's aspect ratio. The image still embeds at full pixel resolution, only the page's points change. - `od export pptx --title "X"` forwarded the title to the server but always saved the local file under the source HTML's basename. Name the output after the slugified title when --output is not given. Tests: PDF page-size normalization assertion (loads the PDF, checks 960pt not the 1px capture size); sidecar-proto render-slides IPC validation (outputDir, enum, boolean, unknown-key rejection, minimal round-trip). * test(export): cover the server Content-Disposition filename branch The exportProjectAsPptx happy-path test only exercised the no-header local fallback name; production always returns a Content-Disposition. Add a test that pins the branch the desktop download actually uses (server filename wins). * feat(export): support arbitrary-aspect decks (not just 16:9) Screenshot deck export no longer assumes every deck is 16:9. The renderer measures the deck's authored slide box (the rendered rect of the first slide with layout, so fit-to-viewport decks report the stage they actually paint), sizes the capture window + pinned stage to it, and clips capturePage to it. The measured pixel dimensions flow to the PPTX assembler, which derives the slide layout from the real aspect ratio (13.333" wide, height = width/aspect) instead of hardcoding LAYOUT_16x9 — so 4:3, square, and portrait decks export correctly-proportioned slides and PDFs instead of being letterboxed or clipped. Falls back to 1920x1080 / 16:9 when the slide box can't be measured or is out of a sane range, so existing 16:9 decks are unchanged. Verified: demo-deck measures 1920x1080 (16:9, unchanged); a 1024x768 deck measures 4:3. Tests: PPTX layout follows 16:9 / 4:3 / 9:16 aspect (asserted via the slide cx/cy in presentation.xml). * fix(export): capture off-screen carousel slides (translated-strip decks) showSlide only toggled the active class/opacity, so decks that paginate by translating a flex-strip container (e.g. html-ppt-zhangzara-grove) left slide 2+ off-screen and capturePage kept grabbing the first viewport region — exporting the wrong slide or a blank page. showSlide now reports where the active slide actually landed; if it is off the top-left capture stage, showDeckSlide restacks just that slide into the viewport (clears ancestor transforms + pins it fixed at 0,0) and re-settles before capture. This branch only runs when the slide is genuinely off-stage, so transform-scaled fit-to-viewport decks (active slide already at 0,0, and which DO rely on an ancestor scale) are never touched. Verified: a 3-slide flex-strip carousel — slide 0 stays at 0,0 (untouched), slides 1/2 detected off-stage (x=1920) and restacked to 0,0 before capture. * fix(export): gate PPTX on a host runtime; unify + center the image toast - PPTX export has no web-only fallback (it needs the daemon's Electron-Chromium screenshot renderer), so a web-only deployment showed a PPTX button that always failed with 501. Gate `showPptxExport`/`canPptx` on `isOpenDesignHostAvailable()` so the action only appears where it can succeed. Image/PDF keep their web fallbacks and stay shown. - Image export showed an in-modal spinner and a separate, non-portaled "saved" toast that rendered off-center (its `position:fixed` resolved against the preview pane's transform). Route image export progress through the same portaled, viewport-centered `exportToast` used by PPTX/PDF: close the modal on Save, show a loading toast, then success/error — one consistent, centered toast style. Removes the now-dead imageExportBusy/imageExportCapturing/savedToast. * fix(export): screenshot the current deck slide; never drop slides when stitching Two more review findings on the screenshot export path: - captureExportImageSnapshot() routed deck snapshots through the daemon without a slide index, so /export/image fell into the stitch-whole-deck branch even for "Copy screenshot" and "Export as image" — which both promise "the current preview". Pass the active slide index for decks so both capture the current slide. Stitching the whole deck into one long image is reserved for an explicit action (a follow-up modal toggle). - stitchDeckSlides() capped the output at DECK_STITCH_MAX_H by stopping the loop and still returning ok:true, silently dropping trailing slides (~13+ on a 2x capture) — partial-success data loss. It now captures slide 0 to learn the native size, picks one uniform downscale so all `count` slides fit under the cap, and stitches every slide (long decks just get a smaller per-slide size). * fix(export): drop dead `scale` param; keep deck PDF slides PNG (not JPEG) Two more review findings: - The render-slides contract accepted a `scale` field (validated in sidecar-proto, forwarded by handleScreenshotExport) that the desktop renderer never read — a broken protocol surface on the feature's first release. Remove it from the proto, the daemon route, and BuildDeckRenderInputOptions; the capture resolution comes from the measured stage size and host DPR. (No scale multiplier is needed today; if one is added later it must actually be applied in the renderer.) - The deck branch derived its image encoding from `pageImageFormat`, so the screenshot-PDF path (which sets pageImageFormat='jpeg') made deck slides lossy JPEG — contradicting the contract ("deck slides stay PNG; JPEG is a full-page page-mode optimization") and adding compression artifacts to text-heavy slides. The deck branch now always encodes PNG; only `page` mode honors JPEG. * fix(export): no silent truncation for tall pages; deterministic deck slide index - The full-page scroll-stitch path clamped the document height to the RAM budget and returned ok:true, silently dropping everything below the cap on very tall pages. It now refuses with a clear "page is too tall — export as PDF instead" error instead of returning a truncated image as success; pages within budget still stitch their full height. (Decks downscale to fit since they are discrete slides; a continuous page is failed rather than seam-spliced at reduced scale.) - Deck screenshots now always send a concrete slide index (slideState?.active ?? cached ?? 0) so a fresh open — or a deck detected only from `.slide` markup that never emits od:slide-state — captures the current slide instead of falling into the stitch-whole-deck branch. * fix(export): explicit page-vs-deck signal; surface semantic export failures Two review findings: - Treating any `.slide` element as proof of a deck was too broad for the generic /export/image and /export/pdf-image routes — an ordinary page with carousel or testimonial `.slide` markup would skip full-page capture and stitch those elements as slides. The caller now passes an explicit `deck` flag (the web knows `effectiveDeck`; PPTX is deck-only): `deck:false` forces full-page capture, `deck:true` forces slide capture, and the `.slide`-count heuristic remains only as the no-signal fallback (e.g. the CLI). - `exportProjectImageDataUrl()` returned null for every non-OK response, so a semantic failure (e.g. the daemon's new "page is too tall — export as PDF") was treated as "renderer unavailable" and silently downgraded to a partial visible-viewport screenshot. It now returns a discriminated result; the caller only falls back to a web capture when the off-screen renderer is genuinely unavailable (501/no-host/network) and surfaces the real error otherwise (Copy screenshot + Export as image both show the message). Plumbs `deck` through sidecar-proto, the daemon route/options, exports.ts (image + pptx + screenshot-pdf), FileViewer, and ProjectView. Proto test covers deck round-trip + rejection. * fix(export): harden the file handoff (path confinement) + narrow unavailable Three security/contract findings on the render-slides file handoff: - sidecar-proto now rejects a non-absolute `outputDir` (was: any non-empty string), so a malformed render-slides request can't make desktop main mkdir + write outside the daemon scratch area. Negative proto test added. - The daemon canonicalizes every returned `slideFiles` path and requires it to stay under the canonical `renderOutputDir` before reading — a buggy/malicious renderer response can no longer make /export/{pptx,pdf-image,image} read and stream back arbitrary files (path traversal / symlink escape). Returns 502 on an out-of-scope path; handoff test proves an out-of-tree path is refused and its bytes never reach the response. - exportProjectImageDataUrl wrapped the whole flow in one try/catch, so a 200 with a corrupt/unreadable payload was reported as `unavailable` and silently downgraded to the viewport screenshot. The `unavailable` path is now narrowed to transport-level failures (the fetch itself); a bad 200 payload returns a semantic `error` so the real failure surfaces. * fix(export): CLI page/deck flag; reject out-of-range slide index Two review follow-ups: - `od export pdf|pptx` now accepts `--deck` / `--page` and forwards the signal in the request body, so the CLI hits the route with the same page-vs-deck semantics the UI uses (which sends effectiveDeck). Previously the CLI fell back to the daemon's `.slide` heuristic, so an ordinary HTML file with carousel markup could export as a deck from the CLI but a full page from the UI. (PPTX stays deck-only server-side; the flag matters for PDF.) `--deck` and `--page` are mutually exclusive; omitting both keeps the heuristic fallback. - renderDeckSlides rejected nothing for an out-of-range `index`: it fell back to range(count) and the daemon returned slide 0 with 200 for image export, so asking for slide 99 of a 3-slide deck silently returned slide 0. It now fails with a clear "slide index N is out of range" error. * fix(export): If-None-Match precedence; renderer IPC outage -> 502 not 400 - rawRequestIsFresh fell through to If-Modified-Since even when the request sent a non-matching If-None-Match, so a same-second rewrite (ETag changes, but Last-Modified is identical at second granularity) could 304 changed bytes when both headers were sent. If-None-Match is now authoritative when present (RFC 9110 §13.1.3) — freshness is the ETag match alone. Regression test sends a stale ETag + the current If-Modified-Since and expects 200. - A rejection from desktopSlideRenderer (a 600s requestJsonIpc) — missing desktop process, broken socket, timeout — landed in the outer catch and became 400 BAD_REQUEST, making renderer outages look like caller errors to retries / monitoring. The IPC call is now wrapped and translated to 502 UPSTREAM_UNAVAILABLE, matching the !rendered.ok branch; the outer 400 stays for real request-validation / assembly errors. * fix(export): full-page stitch corrupts on fractional DPR (125%/150% scaling) scrollSegmentStitch rounded the device pixel ratio to an integer (`Math.round(size.width / PAGE_W)`), so on non-retina display scaling (1.25x, 1.5x) the output width and every row offset were wrong — the stitched full-page screenshot (/export/image and the raster PDF page path) came back cropped horizontally or with vertical gaps/overlap even though the page rendered fine. Derive width/height/placement from the REAL captured device width and its true (possibly fractional) ratio instead. Extracted scrollStitchGeometry / scrollStitchRowOffset as pure helpers with a non-integer-DPR regression test (1x / 1.25x / 1.5x / 2x). * fix(export): broaden deck slide selector; content ETag for transformed HTML - The renderer only recognized `.slide`, but shipped decks use other slide contracts the print/export path already supports (e.g. html-ppt-zhangzara-creative-mode uses `<section data-screen-label=...>`), so an explicit deck export of those silently downgraded to a single full-page capture. Broaden SLIDE_SELECTOR to the pdf-export family (`.slide, [data-screen-label], .deck-slide, .ppt-slide`), and when `deck === true` finds no slide surfaces, fail fast with a clear error instead of capturing a page. - /raw/ revalidation used the source file's mtime ETag even when the response is substituted by a transform (Vite dev-entry -> dist/index.html, or preview bridge injection). A change to dist/index.html with an unchanged source entry could then return a stale 304. Compute a content ETag from the actual sent bytes for transformed HTML; assets/fonts/images/streamed media keep the fast mtime ETag + early 304. Regression: rewriting only dist/index.html returns 200. * fix(export): gate PPTX on explicit deck; page-mode DOM intact; stitch RAM budget Four review findings: - PPTX action was gated on the `.slide` regex (`effectiveDeck`/`looksLikeDeck`), so ordinary pages with carousel/testimonial `.slide` markup surfaced PPTX and were forced through the deck renderer (hardcoded `deck: true`). Gate show/canPptx on the EXPLICIT deck signal (`isDeckArtifact`: deck renderer / kind / presentation) instead; real decks keep PPTX, pages don't, and `deck: true` is now always correct. Image/PDF stay on the broader signal (they handle pages). - renderDeckSlides ran prepareDeck (hide chrome + freeze animations) BEFORE deciding page vs deck, so page-mode exports rendered on a mutated DOM (content using generic `.notes`/`.overview` classes vanished). Split the non-mutating slide count from the deck-only DOM prep; page mode now captures the original document. - stitchDeckSlides capped only output height, so a wide/high-DPR deck could still allocate >1 GiB (8192px stage @2x => W~16384 * 30000 * 4). Add a RAM byte budget (320MB, like the page stitcher): downscale by min(heightScale, byteScale). - sidecar-proto render-slides test now covers the `index` field (success + reject negative / fractional / non-number). * fix(export): image/PDF deck flag from explicit signal, not .slide heuristic The image and screenshot-PDF exports still passed `deck: effectiveDeck` (the `.slide` regex), so an ordinary HTML page with carousel/testimonial `.slide` markup exported only the current card instead of the full page. Drive both off the explicit `isDeckArtifact` signal (same as PPTX): a real deck → per-slide, a page → full-page capture. Extracted `shouldCaptureAsDeck()` as a pure helper with a regression test (page + slides + deck:false => page, not per-slide). * fix(export): screenshot PDF download must prompt Save As (.pdf in allowlist) The default Export PDF flow now streams a .pdf download via exportProjectScreenshotPdf, but the will-download Save As hook only intercepted .pptx + image extensions — so PDF silently wrote to the OS Downloads folder while PPTX/images prompted. Add .pdf to SAVE_AS_EXTENSIONS with a PDF filter, and extract saveAsDialogOptionsForFilename() as a pure helper with a runtime test (PDF/PPTX/image prompt; uppercase matched; other extensions pass through). * fix(export): single-shot guard for image export (no double-click duplicates) The toast-based image export closes the modal and starts the save without an in-flight guard (the old in-modal busy/disabled states were removed), so a fast double-click / Enter-repeat on Save could enqueue two concurrent exports (duplicate captures, downloads, and fireImageExportResult bookkeeping) before the modal-close re-render removed the button. Add an imageExportInFlightRef guard that returns early on re-entry and resets in finally — mirrors the existing screenshotInFlightRef pattern. * fix(export): If-Range guard on /raw/ stream; block image-modal reopen mid-export Two non-blocking correctness issues: - /raw/ honored Range unconditionally even with the new ETag/Last-Modified, so a client resuming a cached font/media download after the file changed could splice stale + fresh bytes. Gate Range on If-Range (RFC 9110 §13.1.5): serve 206 only when the If-Range validator (ETag or date) still matches the current file, else fall back to a full 200. Regression test: stale If-Range + Range returns 200 with the new full length. - The image-export single-shot guard covered handleImageExportSave, but reopening the modal mid-export reset the shared request/result refs, mis-attributing or dropping the in-flight export's analytics result. openImageExportModal now no-ops while an export is in flight. * fix(export): drive image/PDF deck decision off the viewer signal (effectiveDeck) The desktop screenshot image/PDF paths were gated on isDeckArtifact while the vector-PDF fallback (and the viewer's own prev/next/Present) use effectiveDeck. That diverged: a metadata-free `.slide` deck rendered as a deck in preview but exported as a single full page on a desktop host, yet as a deck via the browser fallback — same artifact, different output depending on host. Drive image + screenshot-PDF off effectiveDeck (the viewer's deck decision), so export matches what the user sees and is host-independent. PPTX keeps the narrower isDeckArtifact: it is deck-only with no vector fallback, so it can't diverge, and it must not offer slide export for incidental carousel markup. Removes the now-dead isDeckForExport binding. * test(web): update image-export specs for capture-on-Save modal flow The image-export modal was redesigned in this PR from eager-capture-on-open (preview + live format re-render + in-modal alert + disabled-until-ready Save) to capture-on-Save unified with the PPTX/PDF portaled-toast flow: the dialog just picks a format, and Save closes it and runs the single capture behind the export toast. The 9 specs in file-viewer-image-export.test.tsx still drove the old eager flow and failed in CI (Web workspace tests). Updated each to click Save before asserting capture, pick the format before Save, assert the portaled toast (role=alert error text unchanged) instead of the removed in-modal alert, and replaced the obsolete "preparing label" spec with one proving no eager capture happens on open or on format change. * fix(cli): od export honors the server Content-Disposition filename The web download helper prefers the daemon's Content-Disposition filename and only falls back to a locally derived name. `od export` ignored it and always synthesized the name from --title/basename, so the two surfaces could write different filenames for the same export. Parse the header (RFC 5987 filename* and plain filename, reduced to a hardened basename so an odd header can't steer the write outside the cwd) and prefer it when --output is not given, keeping the title-slug/basename fallback. Mirrors apps/web/src/runtime/exports.ts. * fix(export): detect runtime-managed decks; image=whole deck; de-dup long pages QA found three blocking export-fidelity issues on this PR: 1. Horizontal decks export only slide 1 (image: all such templates; PDF: some). Runtime-managed decks (`<deck-stage>` web component with slotted `<section data-screen-label>` children toggled via `data-deck-active`) carry no literal `class="slide"`, so the viewer's `looksLikeDeck` regex misses them and the UI sent an authoritative `deck:false`. The host then force-captured page mode (`mode:'page', slides:1`) — a full-page shot of whatever slide was visible. PDF same path: `deck:false` skips the host DECK_PRINT_CSS, so decks without their own `@media print` print one page. Fix: a broader EXPORT-only signal `sourceLooksLikeExportableDeck` / `deckExportSignal` mirroring the host's slide-surface family (`.slide`/`[data-screen-label]`/`.deck-slide`/`.ppt-slide`) plus `<deck-stage>`. Kept OUT of `effectiveDeck` so the host's deck-stage- incompatible prev/next nav is not surfaced as a dead "— / —" control. 2. "Export as image" of a deck returned the current slide only. It now stitches every slide into one long image (matching the slide count the viewer reports); Copy screenshot / Mark-Draw capture keep the current slide via `captureExportImageSnapshot({ wholeDeck })`. 3. Long-page image/PDF export duplicated a fixed/sticky hero down the output: the scroll-segment stitch captures the viewport per offset, so a pinned element was copied into every segment. `preparePageForCapture` now neutralizes `position:fixed`->absolute and `sticky`->static before measuring/capturing, so each renders once (captureBeyondViewport already de-dupes; applied uniformly for consistency). Red specs: exports.test.ts (deck detection), neutralize-positioning.test.ts (fixed/sticky normalization). * chore: re-trigger CI on updated main — needs-validation gate moved to merge_group (#4714) * fix(sidecar): decode IPC frames with StringDecoder (multibyte UTF-8 corruption) Exported CJK artifacts intermittently showed `???` / `◆?` (U+FFFD) in place of a character — e.g. "拥挤" rendered as "拥���", "交付边界" as "交付���界". The bad character varied between exports, the source bytes on disk were correct, and the daemon /raw/ serve was byte-identical, so it was not a font or storage problem. Root cause is in the generic JSON-IPC transport. Both the server and client socket readers did `buffer += chunk.toString()` into a STRING. A render request carries the full artifact HTML over the desktop IPC; when the payload spans multiple `data` events, a multibyte UTF-8 character (CJK = 3 bytes) straddling a chunk boundary is decoded per-chunk, turning each partial half into U+FFFD. Small payloads never hit a boundary (hence "works in my repro, breaks on the real file"); large real artifacts do, at whichever character lands on the split. Fix: feed each chunk through a per-connection `StringDecoder("utf8")`, which holds an incomplete trailing byte sequence until the next chunk completes it. Verified end-to-end against the QA "Blog Post" artifact in a packaged client: "拥���" → "拥挤" after the fix. Red spec: a ~1.3 MB CJK payload round-tripped through createJsonIpcServer/requestJsonIpc (forces multi-chunk delivery) is now byte-exact; it fails on the pre-fix reader. * fix(export): vector deck PDF rendered only the first slide A deck exported via the vector PDF fallback (POST /export/pdf → exportPdfFromHtml) collapsed to a single page: only the runtime-active slide appeared. Decks gate visibility with `.slide:not(.active){display:none!important}` (specificity 0,2,0); the host DECK_PRINT_CSS `.slide{}` rule (0,1,0) cannot win that cascade, so every non-active slide stayed `display:none` in print. Fix: before printToPDF, mark every slide surface active (the same class set the screenshot path toggles in deck-capture's showSlide), so the deck's own `.slide.active` styling applies to all slides and DECK_PRINT_CSS paginates them one per page. Shadow-DOM `<deck-stage>` decks are unaffected (their own `@media print` already lays out every slide). Verified with an offscreen printToPDF of a 12-slide `.slide`-class deck: 1 page -> 12 pages, each a distinct centered slide. * fix(export): screenshot PDF fails fast instead of masking errors as vector PDF Per review: the raster-PDF path fell back to the vector `exportProjectAsPdf` for EVERY non-ok screenshot result, so a semantic failure (bad deck routing, a 422, a renderer-side 502, "page too tall", unreadable output) silently handed the user a different (vector) PDF — the exact fidelity/CJK-glyph class of bug the screenshot path exists to avoid. exportProjectAsPptx now returns the same tri-state as exportProjectImageDataUrl: `{ok:true}` / `{ok:false,unavailable:true}` (501 or transport — caller may fall back) / `{ok:false,error}` (semantic — must surface). The PDF action only falls through to the vector path on `unavailable`; a semantic error throws and is shown in the export toast (onErr now prefers the export's own user-facing message). * chore(nix): refresh pnpm deps hash * fix(export): guard deck capture against stale-frame duplicate pages QA saw a deck export with duplicate pages (e.g. two identical 目录 pages, a slide silently missing). Root cause is a compositor race: after showing slide i, `capturePage()` can return the PREVIOUS slide's frame when the new slide hasn't painted yet (more likely on slower / loaded machines and slides with heavier reveal content), so the loop emits an exact duplicate of the prior page. The source has 12 distinct slides and live navigation is fine — the race is purely in the offscreen capture loop. Fix: after each capture, compare a cheap sampled checksum to the previous slide's; if byte-identical (which can't happen for distinct slides), wait for more frames and re-capture (bounded, 4 attempts × ~60ms). Two genuinely-identical adjacent slides exhaust the retries and emit once. Applied to both the per-slide (PDF/PPTX) and stitch (whole-deck image) loops. Test: imageSignature distinguishes captures by content and length. (The race itself is timing-dependent and not reproducible on a fast/idle machine — both file:// and packaged-http exports of the reported deck render 12 unique pages here — so the guard hardens the failure mode rather than relying on local repro.) * fix(export): paginate tall pages for raster PDF instead of refusing Per review: the single-image RAM/texture guard in capturePage refused any page taller than the budget with "page is too tall — export as PDF instead". That is right for /export/image, but /export/pdf-image routes ordinary-page PDFs through the same branch — and since the screenshot-PDF path now fails fast (no silent vector fallback), a long landing page exported as PDF hit a self-contradictory hard error and regressed tall-website PDF export. Fix: the PDF path (`jpeg`) now paginates a too-tall page into a multi-page raster PDF — captureBeyondViewport per texture/RAM-bounded chunk, one image per chunk, which the daemon assembles into one PDF page each. /export/image (png) keeps its refusal (it has nowhere to paginate to). tallPageChunkHeights extracted + tested. Verified offscreen: a ~20400px page → PDF path returns 3 paginated pages (ok/page), image path still refuses. * fix(export): capture deck slides via CDP (structural fix for duplicate pages) Replaces the pixel-compare/retry guard (88d21c7) with a structural fix, per review feedback: comparing each capture to the previous slide is the wrong abstraction (it can't tell a stale frame from two genuinely-identical adjacent slides, and wastes retries on the latter). Root cause: the deck path used `webContents.capturePage()`, which grabs the last COMPOSITED frame and can return the previous slide's frame when the just-shown slide hasn't composited yet — emitting an exact-duplicate page. The page path never had this because it uses CDP `Page.captureScreenshot`, which renders the CURRENT DOM to a fresh frame. Fix: deck capture now uses CDP `Page.captureScreenshot` too (attach the debugger once around the deck loop; fall back to capturePage if it can't attach). The captured pixels always reflect the slide just shown — no compare, no retry, no identical-slide edge case. Animations/transitions are already frozen (prepareDeckStage), so each slide is captured at its final state, never a mid page-turn frame. Removed imageSignature + the retry loop. Verified: 12-slide deck still stitches to 12 distinct slides at the correct dims. * fix(export): current-slide capture of runtime decks uses the visible slide Per review: deckExportSignal makes runtime-managed decks (<deck-stage> / data-screen-label) exportable, but the current-slide path (Copy screenshot / annotation capture) still resolved the slide index as `slideState?.active ?? 0`. Those decks are deliberately kept out of effectiveDeck, so the viewer never receives their active-slide bridge and slideState is null — meaning Copy screenshot always off-screen-rendered slide 0 instead of the slide on screen, inconsistent with the PPTX/PDF fix on the same templates. Fix: planDeckImageCapture() decides per capture — whole-deck (Export as image), ordinary pages, and tracked .slide decks render off-screen (with the active index when tracked); an untracked deck's current-slide capture skips the off-screen path and falls through to the visible host snapshot (which IS the current slide). Tests: planDeckImageCapture unit cases (exports.test.ts) + a FileViewer regression — Copy screenshot of a data-screen-label deck with no tracked slide uses the host snapshot and does NOT off-screen-render slide 0. * fix(export): don't mask post-response failures / debugger-less tall PDF as fallback Two review edge cases: - exportProjectAsPptx wrapped resp.blob() + triggerDownload() in the same try/catch that maps to `{unavailable:true}`, so a corrupt body or a client-side download failure (after a 200) was reported as "renderer unavailable" — letting the PDF caller silently downgrade to the vector path. Only the fetch (transport) and 501 now map to `unavailable`; post-response failures return `{error}` so they surface. Unit test added. - capturePage's no-debugger fallback still returned "page is too tall — export as PDF instead" for the PDF path (jpeg). Pagination needs CDP, and we only reach this branch when the debugger can't attach, so it now surfaces a distinct retryable error instead of telling the user to switch to the format they already chose. (The debugger attaches in normal packaged exports; this is a rare transient.) * fix(export): distinguish CDP attach failure from later CDP command failure Per review: when the debugger attached but a later CDP command threw (a real Chromium/GPU/clip error), the broad catch swallowed it and the too-tall PDF refusal reported "renderer is busy, please retry" — hiding the actionable error and sending users into a pointless retry loop. The retryable busy message is only correct when the attach itself failed. Track the caught CDP error (cdpError) separately: the too-tall PDF branch now surfaces the real CDP error message when the debugger was available but a command failed, and reserves the retryable "busy" message for true attach contention. * fix(export): reject `od export pptx --page`; test the tall-PDF error split Two review items: - CLI: `od export pptx --page` advertised a page mode that can never work (the daemon forces deck mode for /export/pptx). Reject `--page` for pptx with a clear contract error pointing at `od export pdf --page` instead of silently ignoring it. - Lock down the cdpError split with a regression: extract tooTallPdfErrorMessage and unit-test both branches — attach failure → retryable "busy" message; attached-but-CDP-command-failed → the real Chromium/GPU error surfaces (and neither tells the user to "export as PDF", which they already chose). * fix(export): keep current-view captures viewport-based; reject weak If-Range Two review items: - planDeckImageCapture sent ordinary-page Copy screenshot / captureViewport annotation through the off-screen renderer (useOffscreen:true, no index), which renders the WHOLE document instead of the visible region — a regression for screenshot/annotation viewport semantics. Now: Export-as-image (wholeDeck) and tracked-deck current-slide still render off-screen; an ordinary page's current-view capture (and an untracked deck's) falls back to the visible host snapshot. Tests updated. - ifRangeAllowsPartial accepted weak entity-tags for a 206, but RFC 9110 §13.1.5 requires a strong validator and our /raw/ ETag is weak (W/"size-mtime"). A same-size rewrite / mtime collision could splice stale + fresh bytes under a matching weak tag. Now any entity-tag If-Range falls back to full 200; only the date form authorizes a range. project-raw-cache.test.ts pins it (weak-ETag If-Range → 200, fresh date → 206, stale date → 200). * fix(export): resolve imported-folder project files via metadata.baseDir Per review: the new screenshot export routes (and the vector /export/pdf) read the source with readProjectFile() and no metadata, so it fell back to <OD_DATA_DIR>/projects/:id and returned FILE_NOT_FOUND for imported-folder projects (whose workspace lives at metadata.baseDir) even though the file renders in the UI. Thread project metadata through: BuildDeckRenderInputOptions and BuildDesktopPdfExportInputOptions gain a `metadata` field passed to readProjectFile; handleScreenshotExport and the /export/pdf route load it via getProject(db, id)?.metadata. HTTP regression added: an imported-folder project (created through /api/import/folder) hitting /export/image now returns 200 with the rendered image instead of 404. * chore(nix): refresh pnpm deps hash * Show PPTX export for detected decks * Fix deck export detection for page captures * Route CLI image export through screenshot renderer * Route legacy image export through screenshot renderer * fix(export): per-viewport PDF pagination + parallax-faithful image capture A long non-deck page exported to PDF came out as one giant page, and the same page exported as an image dropped its scroll-pinned text. Both stemmed from the page-capture path: PDF assembled one PDF page from a single tall capture, and the image path flattened fixed/sticky positioning (fixed->absolute, sticky->static), which deleted parallax headline/foreground text. - PDF: add a `paginate` render-slides input. A non-deck page now captures one image PER VIEWPORT, top to bottom, and the daemon assembles a multi-page PDF (one screen per page). Decks still paginate per slide; page-mode only. - Image: capture each viewport live at its real scroll offset and stitch into one tall image, keeping fixed/sticky CSS as authored -- the SAME capture logic as the PDF path, differing only in assembly. Drop the captureBeyondViewport one-shot and its isScrollBound heuristic (it rendered the whole document at scroll 0 and got parallax/reveal-on-scroll content wrong), and drop the fixed-neutralization step (it dropped pinned text). Adds paginateViewportBand unit coverage and a paginate IPC round-trip/rejection case; removes the now-unused neutralizeFixedAndStickyPositioning helper and test. * fix(export): capture deck-stage at authored size; share pptx in contracts Addresses two review findings on the screenshot export surface. - deck-stage fidelity (blocking): the <deck-stage> runtime fits its canvas to the viewport with `transform: scale(...)` by default and documents that PPTX export must set the `noscale` attribute so the DOM is captured at the authored slide size. The renderer never set it, so a deck whose authored canvas differs from the 1920x1080 capture viewport was measured + captured at the preview- scaled size. prepareDeckStage now sets `noscale` on every <deck-stage> (a no-op for plain `.slide` decks). - contract boundary: `pptx` was a first-class CLI/daemon export format but the shared `EXPORT_FORMATS` in `@open-design/contracts` still declared only `['pdf', 'image']`, so the capability was typed through an ad hoc local union. Add `pptx` to the shared contract, import it in the CLI instead of a local duplicate, and route `pptx` through the generic `/export` route (to the screenshot renderer) alongside `image`. * fix(export): route CLI --format pdf through the raster screenshot PDF path `od export --format pdf` still posted to the generic `/export` route, whose desktopArtifactExporter renders vector PDF via printToPDF() and drops CJK glyphs in the packaged runtime. The web UI was deliberately switched to the raster `/export/pdf-image` path for that reason, so the CLI diverged from the UI on the exact decks/pages this feature targets. Route all three CLI formats through the screenshot renderer (pdf → /export/pdf-image, matching the UI). Extract the format→route mapping into a pure `exportRoutePath` helper so it is unit-testable without executing the CLI entrypoint, and assert no format falls through to the vector `/export` route. * fix(export): route generic POST /export pdf through the raster screenshot path The shared ExportRequest contract advertises `pdf` as part of the screenshot- rendered export surface, but the generic `/export` route still sent `format: 'pdf'` to desktopArtifactExporter's vector printToPDF() path, which drops CJK glyphs in the packaged runtime. So a contract caller hitting POST /export got the lower-fidelity PDF while the dedicated /export/pdf-image route, the UI, and the CLI all use the raster screenshot PDF — the API surface was internally inconsistent. Route every /export format (pdf included) through handleScreenshotExport so the generic endpoint matches the dedicated routes and the contract; drop the now unused desktopArtifactExporter / buildDesktopArtifactExportInput wiring from the route. Add an HTTP-level regression asserting POST /export with format:'pdf' runs the screenshot renderer and streams back a real (%PDF) raster PDF. * Restore editable PPTX export * Clarify authored slide measurement * Enable PPTX export from browser * Stabilize large editable PPTX text * Use workspace root for PPTX export resource * Let CLI exports auto-detect decks * Avoid tracking generated PPTX bundle * Fix generic export deck routing * Fix deck export routing regressions * Add CLI page-mode export flag * Preserve authored deck capture DOM * Load PPTX vendor bundle from gzip resource * Harden export CLI and PPTX bundle loading * Preserve editable PPTX slide background images * Preserve export render sizing contract * Classify screenshot export request errors * Preserve freeform slide deck exports * Preserve UTF-8 export filenames * Align export routing and CLI JSON contract * Preserve export compatibility paths * Keep PDF export on screenshot renderer * chore(nix): refresh pnpm deps hash --------- Co-authored-by: open-design-bot[bot] <282769551+open-design-bot[bot]@users.noreply.github.com>	2026-06-29 13:15:14 +00:00
Tom Huang	29b138f7a3	feat(brands): turn any brand into a reusable design system (#4691) ... * Implement brand management routes and CLI support - Added `brand-routes.ts` to handle HTTP endpoints for brand operations: listing, extracting, retrieving details, deleting, and serving logos. - Introduced `brands-cli-help.ts` for CLI commands related to brand management, including usage instructions for listing, creating, retrieving, and deleting brands. - Updated `cli.ts` to integrate brand commands into the existing CLI structure, allowing headless management of brands via the command line. - Created supporting files for brand metadata handling, including `design-md.ts` for rendering brand information in markdown format and `index.ts` for the brand engine API. - Implemented `prefetch.ts` to fetch and process brand material from specified URLs, ensuring a streamlined extraction process. - Enhanced server setup in `server.ts` to register brand routes and manage brand-related data effectively. This commit establishes a comprehensive framework for managing brands within the application, facilitating both HTTP and CLI interactions. * Enhance memory management and onboarding experience - Introduced canonical profile labels to ensure consistent handling of user input in profile forms, preventing duplicate entries. - Updated the `parseProfileBody` and `captureProfileFromForm` functions to utilize the new canonical label matching. - Added a memory callout section in the onboarding view to highlight the benefits of memory usage, including personalized responses and reduced setup questions. - Implemented new UI elements in the onboarding view to improve user engagement with memory features. - Expanded i18n support for new onboarding messages related to memory benefits across multiple languages. * Refactor onboarding flow and enhance design system integration - Updated the onboarding process to include a new brand extraction step, replacing the previous newsletter step. - Adjusted the tracking logic to reflect the new onboarding steps, ensuring accurate analytics for user progress. - Improved the UI for the onboarding view, including new input fields for email collection during the brand extraction phase. - Refined the EntryShell component to remove outdated comments and clarify the onboarding renderer's purpose. - Enhanced CSS styles for the onboarding steps to improve layout and user experience. - Updated internationalization strings across multiple languages to reflect changes in the onboarding flow and brand extraction messaging. * Add brand management features and enhance font handling - Introduced new modules for managing brand assets, including `chrome.ts` for headless Chrome operations and `fonts.ts` for self-hosting web fonts. - Implemented `prefetch.ts` to streamline the brand material extraction process, allowing for efficient harvesting of colors, fonts, and logos. - Enhanced the brand system with new schema definitions in `schema.ts` to support brand color and font management. - Developed the `engine` module to integrate brand building and rendering processes, including token derivation and artifact generation. - Improved the overall structure and organization of brand-related files for better maintainability and scalability. * Enhance brand extraction and project management features - Updated `brand-routes.ts` to include new dependencies for project management, allowing for the registration of brand-related projects. - Modified the `extractBrand` function to support project ID and system files, improving the brand extraction process. - Enhanced the CLI commands in `cli.ts` to handle project IDs during brand creation, enabling better tracking of brand projects. - Updated the server setup in `server.ts` to register new project-related routes. - Improved the UI components to display project information associated with brands, including buttons for opening projects in the `BrandDetailView` and `BrandsTab`. - Added new metadata fields in the contracts to support project tracking and management for brands. This commit establishes a more robust framework for managing brand projects, enhancing both backend and frontend functionalities. * Enhance onboarding profile management and memory persistence - Added new canonical profile labels for 'Organization size', 'Use cases', and 'Discovery source' to improve user input consistency. - Introduced `OnboardingProfileState` type to manage onboarding profile data more effectively. - Implemented functions to build and persist the onboarding profile body to memory, ensuring user selections are saved accurately. - Updated the `OnboardingView` component to handle profile persistence during navigation and submission steps. - Enhanced tests to verify that user selections are correctly persisted to the memory profile. This commit improves the onboarding experience by ensuring that user inputs are consistently captured and stored, enhancing overall user engagement with the application. * Reflow brand extraction into an agent-driven, live flow Replace the deterministic SSE prefetch/preview/system pipeline with an agent-driven extraction: POST /api/brands now reserves the brand and stands up a backing project with the target site open in an in-app browser tab plus a seeded prompt, so the agent measures, synthesizes brand.json incrementally, and the user can clear anti-bot walls by hand. New /preview and /finalize routes let the agent render the kit page live and register the resulting user:<id> design system, so extracted brand facts persist as a structured, reusable brand kit instead of a one-shot deterministic guess. Adds the brand-extract skill (SKILL.md + brand-kit.html template), kit-render engine, brand-extraction-engine tests, brand project covers in the Designs tab, onboarding extract handoff, and the matching od brand extract/preview/ finalize CLI subcommands and contract updates. Co-authored-by: Cursor <cursoragent@cursor.com> * Sediment finalized brands into structured memory Reflow a finalized brand into the memory store (brandToMemoryEntries + reflowBrandToMemory) so future chats can ground vague requests in the brand's palette, type, voice and rules. finalizeBrand now wires through the runtime dataDir and best-effort persists the brand, MemoryChangeEvent gains a 'brand' source, and the brand kit render hardens its inline JSON escaping. Adds brand.previewEmpty / brand.viewDetails across all locales. Co-authored-by: Cursor <cursoragent@cursor.com> * Implement logo fallback and imagery support in brand extraction - Introduced a deterministic logo fallback mechanism to ensure that brand extraction processes can retrieve and save site logos, even when the agent fails to do so. - Enhanced the `startBrandExtraction` and `finalizeBrand` functions to utilize the new logo fallback, allowing for better handling of logo assets. - Added support for imagery samples in brand validation, enabling the inclusion of representative images in the brand kit. - Updated the brand kit rendering to include self-hosted fonts and imagery, improving the overall presentation of brand assets. This commit strengthens the brand extraction workflow by ensuring that logos and imagery are reliably captured and displayed, enhancing the user experience in brand management. * Enhance memory management with rule proposal and verification features - Introduced new functionality for distilling annotations into rule proposals, allowing users to suggest rules based on in-canvas annotations through the `od memory rule suggest` command. - Implemented a verification system that programmatically enforces compliance with active rules during artifact generation, ensuring that all active rules are covered in the self-verify scorecard. - Added endpoints for managing verification outcomes, including listing, removing, and clearing verification records, enhancing the transparency of the verification process. - Updated the memory management system to support the retrieval of active rule entries, ensuring that only linked rules are considered during verification. - Enhanced tests for both rule proposal generation and verification processes to ensure reliability and correctness. This commit strengthens the memory management capabilities by integrating rule proposals and verification, improving the overall user experience in managing design rules and ensuring compliance. * Distill review annotations into memory and enforce self-verify scorecard Add distillAnnotationsToMemory to mine inline preview comments/highlights/ marks into durable feedback + rule memory via a dedicated distiller prompt, threaded through the existing extract pipeline with an 'annotation' change source. Tighten the self-verify prompt (daemon + contracts) to state the daemon programmatically checks the scorecard, so a missing or uncovered scorecard on an artifact turn is an enforcement failure. Cover the rule suggest and verification-history routes with tests. Co-authored-by: Cursor <cursoragent@cursor.com> * Apply brand design system through web config on "Use in new chat" Thread onApplyDesignSystem from the entry shell into BrandsTab so the brand's registered design system is applied via the web config channel instead of a bare daemon PATCH that left the Home composer stale. Add a transient home-intent latch + event so the Brands tab can request the Prototype chip on the already-mounted HomeView, which consumes it once the plugin catalog loads. Co-authored-by: Cursor <cursoragent@cursor.com> * Wire annotation distillation into background memory extraction Add a background distill pass that mines inline review annotations (comments / highlights / drawn marks) from a turn into durable memory alongside the general LLM extraction, surface an `annotation` memory toast source in the web UI, and cover the flow with a unit test. Co-authored-by: Cursor <cursoragent@cursor.com> * Fix brand design system not applying to composer on "Use in new chat" Selecting a brand's "Use in new chat" applies the brand's design system as the default and fires the Prototype chip intent in the same synchronous click handler. HomeView consumed that intent inside the event listener, so `pickChip` ran before React committed the config change and seeded the composer's design-system field from the stale (empty) default — the composer showed "No design system" instead of the brand until a reload. Split the intent handling: the listener now only bumps a tick, and a separate effect consumes the chip after the re-render lands, so the seeded design system reflects the freshly-applied brand. Add the previously-untracked home-intent latch test coverage. Co-authored-by: Cursor <cursoragent@cursor.com> * feat(web): rework Brands into Brand Kit and add Home create entry Co-authored-by: Cursor <cursoragent@cursor.com> * feat(brands): harvest real cover/hero images for the Images module The brand kit's Images gallery only populated when the extraction agent remembered to save imagery — so a forgetful or bot-blocked agent (and the pre-imagery "Open Design" brand) left it empty. Add a deterministic, server-side imagery fallback (imagery-fallback.ts), mirroring the logo fallback: it parses og:image/twitter:image, large <img> (highest-res srcset/<picture>), <link rel=preload as=image>, and CSS background-image hero blocks, fetches candidates with browser-shaped headers, decodes PNG/GIF/JPEG/WebP dimensions to keep only big representative images (dropping icons/sprites/logos/tracking pixels), dedupes by content hash, and saves up to 8 of the largest into imagery/ with labeled samples. finalizeBrand runs it as a timeout-bounded, failure-tolerant safety net (injectable so tests stay offline) when the agent captured too few samples, first adopting any on-disk images. The extraction prompt and brand-extract SKILL now explicitly direct the agent to harvest the site's large/cover/hero images, filtered by rendered size. Co-authored-by: Cursor <cursoragent@cursor.com> * feat(qa): implement deck layout validation and safety checks Add a new QA module for validating the layout of generated brand decks to ensure robustness against clipping and truncation issues. The `analyseDeckLayout` function checks for critical layout invariants, including the presence of `.slide` sections, correct container types, and necessary runtime layers. Introduce `assertDeckLayoutSafe` to enforce these checks during brand system rebuilds, preventing the deployment of decks that fail validation. Additionally, create comprehensive tests to verify the functionality of the new layout validation features. * fix(brands): apply deck shrink-to-fit synchronously so slides never clip The no-clip runtime scheduled its fit pass through requestAnimationFrame, whose callbacks are throttled while the deck is offscreen or occluded. A slide could therefore stay unscaled — and clip its content — until first paint. Fit synchronously on resize/load/fonts-ready with a trailing setTimeout settle pass for late reflow, removing the rAF dependency. Verified at the previously-broken 1024x620 viewport: container-type:size, zero truncations, runtime auto-applies scale (Problem 0.71, ASK 0.87, Product 0.97, Competition 0.97) and frame clip count drops to 0. Co-authored-by: Cursor <cursoragent@cursor.com> * feat(web): let New Brand modal embed scrollable brand reference picker Add a fillHeight mode to BrandReferencePicker so the heading, quick-pick row and controls stay pinned while only the gallery scrolls inside a bounded-height parent. Wire it into NewBrandModal with a stable, spacious dialog and refresh the related newBrand/brandPicker copy across all 18 locales. Co-authored-by: Cursor <cursoragent@cursor.com> * feat(brands): enhance brand extraction with deterministic seed harvesting Introduce a new `seed-fallback` module to provide a server-side deterministic palette and typography seed during brand extraction. This ensures that the brand kit's initial display includes a harvested logo, an approximate color palette, and font families, improving the user experience by reducing the all-skeleton appearance during the first paint. Update the `startBrandExtraction` function to utilize this new module, allowing for a more seamless and visually appealing brand extraction process. Additionally, enhance the `BrandReferencePicker` component to reflect loading states and errors during brand extraction, ensuring users receive immediate feedback on their actions. Update related tests to verify the idempotency of the `finalizeBrand` function, ensuring that re-finalizing a brand correctly reuses the existing design system without duplication. * feat(brand-extract): enhance BrandReferencePicker and localization updates Updated the BrandReferencePicker component to reflect loading states and errors during brand extraction, improving user feedback. Added a new localization key for the brand extraction process and updated existing translations in English, Simplified Chinese, and Traditional Chinese to enhance clarity and user experience. Additionally, introduced new styles for better interaction with brand assets in the brand kit template. * feat(brands): wire in-page lightbox/masonry/asset preview + refine seed Brand-kit preview improvements for the live extraction kit: - brand-kit.html: add in-page overlay system (sandboxed iframe has no top-nav) — clickable image lightbox with prev/next, a "view all" masonry modal, and a full-page asset preview modal that loads system/artifacts/<kind>.html in an iframe. Defer auto-reload while an overlay is open so it never yanks the modal out mid-interaction. - seed-fallback.ts: prefer vivid mid-luminance hues for the seeded accent/accent-secondary, and drop icon/symbol faces (Remix Icon etc.) from the typography seed so specimens never render glyph soup. Co-authored-by: Cursor <cursoragent@cursor.com> * feat(brands): wire in-page lightbox/masonry/asset preview + refine seed Brand-kit preview improvements for the live extraction kit: - brand-kit.html: add in-page overlay system (sandboxed iframe has no top-nav) — clickable image lightbox with prev/next, a "view all" masonry modal, and a full-page asset preview modal that loads system/artifacts/<kind>.html in an iframe. Defer auto-reload while an overlay is open so it never yanks the modal out mid-interaction. - seed-fallback.ts: prefer vivid mid-luminance hues for the seeded accent/accent-secondary, and drop icon/symbol faces (Remix Icon etc.) from the typography seed so specimens never render glyph soup. Co-authored-by: Cursor <cursoragent@cursor.com> * i18n(web): add brandPicker.opening across remaining locales + picker test Completes the brand-reference picker i18n key that was committed only for en/zh-CN/zh-TW, so every locale satisfies the typed Dict, and lands the BrandReferencePicker extraction-feedback test left untracked by the concurrent worker. Co-authored-by: Cursor <cursoragent@cursor.com> * feat(EntryShell): enhance AMR cloud card visibility post-detection Updated the EntryShell component to ensure the AMR cloud card remains visible after detection settles, even when the AMR runtime is unavailable. This change prevents the card from disappearing and allows it to degrade gracefully to fallback content and sign-in flow. Additionally, added tests to verify the new behavior, ensuring a better user experience during onboarding. * feat(library): OD Library asset registry + OD Clipper extension Add a global, cross-project asset registry (OD Library) and a Chrome MV3 capture extension (OD Clipper), wiring the full HTTP + CLI + Web UI three-track loop per specs/od-clipper.md. - contracts: LibraryAsset/Source/Kind, ingest, search, pairing, task DTOs - daemon: 6 additive SQLite tables, content-addressed owned storage, the idempotent registerLibraryAsset hook (hash dedup + append-source), programmatic enrichment (mime/size/image dims/domain/tags), pairing tokens with a persisted extension-origin allowlist, /api/library/* routes, and /api/tools/library/{search,apply} for in-task agent reuse - cli: `od library list|get|rm|search|import|pair` - web: Library tab (grid, source badges, filters, search, live SSE updates, extension pairing affordance) - clipper/: standalone MV3 extension (background SW, content toolbar, popup) - skills/library-curator: utility skill for agent-driven asset reuse Origin middleware now honors paired chrome-extension:// origins (seeded from SQLite on boot) and exempts the pairing-confirm handshake. Enrichment AI stages (caption/OCR/embedding) are recorded as skipped pending a configured model. * feat(brands): programmatic-first design system extraction + rename Make brand extraction two-phase so a usable design system is ready the moment the user enters a URL — the instant "aha" — instead of waiting on the AI agent: 1. PROGRAMMATIC-FIRST (synchronous): startBrandExtraction now harvests the site deterministically (logo, palette, typography, one-line description, cover imagery, source URL) via prefetchBrand, synthesizes a valid design system with brandFromMaterial (no LLM), and finalizes + registers it before returning. finalizeBrand is refactored into a reusable finalizeBrandCore shared by both the programmatic path and the agent path. 2. ASYNC AI ENRICHMENT: the seeded agent prompt is reframed to enrich the already-usable design system and re-finalize in place (same user:<id>), updating every artifact/template. Bounded + best-effort: a blocked/unreachable origin skips phase 1 and stays `extracting` for the agent to drive. Gated on userDesignSystemsRoot so the legacy agent-only path stays intact for tests. Also rename the user-facing "Brand Kit" surface to "Design System" across en + zh-CN strings, project names, and the enrichment prompt. Co-authored-by: Cursor <cursoragent@cursor.com> * feat(library): enhance asset import and management features - Updated the `import` command to allow multiple local files and remote URLs, with restrictions on supported formats. - Added new commands: `apply` for copying assets into project design files, `edit-as-page` for converting HTML assets into editable projects, and `figma` for exporting Figma captures. - Introduced sidecar functionality for storing derived data alongside owned assets, including Figma capture IR and element HTML. - Enhanced server configuration to support larger ingest payloads for asset captures. - Improved error handling and user feedback during asset import and application processes. * feat(asset-management): enhance asset dropzone and introduce chat-to-design feature - Updated the DesignSystemAssetDropzone component to improve file preview handling with new functions for creating and revoking object URLs. - Adjusted CSS for better layout and spacing in the asset dropzone. - Added a new "Chat to design" button in the LibrarySection component, allowing users to send selected assets to the Home chat composer for project creation. - Updated localization strings across multiple languages to reflect changes in asset import terminology. - Enhanced the HomeView component to handle asset staging from the chat composer. * feat(library): enhance asset application with element markup support - Updated the `applyLibraryAsset` function to include an `includeElement` option, allowing the capture of element markup alongside assets. - Modified related components (e.g., `ChatComposer`, `LibrarySection`, `FileWorkspace`) to handle the new element markup feature, ensuring both asset paths and optional element paths are returned and processed. - Introduced a new function, `fetchLibraryAssetElementHtml`, to retrieve the captured HTML for element-pick assets. - Enhanced the UI to display element markup inline within the chat composer, improving user interaction with captured elements. - Updated API contracts to reflect changes in asset application responses, including optional element markup paths. * feat(library): enhance asset filtering and preview handling - Updated the LibraryPicker and LibrarySection components to implement a badge-aware kind filter, allowing for more precise asset filtering based on badge kind. - Introduced a new `matchesKindFilter` function to streamline the filtering logic across components. - Enhanced the DesignSystemAssetDropzone to ensure proper handling of image previews, addressing issues with broken thumbnails under React StrictMode. - Added CSS styles for kind badges to improve asset representation in the UI. - Implemented tests for the DesignSystemAssetDropzone to ensure correct preview lifecycle management. * feat(library): hydrate single asset on SSE ingest Add fetchLibraryAsset(id) so the Library grid can merge just the one asset an `ingest` SSE event references instead of refetching the whole list on every capture. Returns null on miss/error. * feat(clipper): richer in-page image picker Collect CSS background-image url()s in addition to <img> (so hero/section art painted as backgrounds is no longer silently missed), defer thumbnail decode to visible cells via IntersectionObserver, draw downscaled canvas thumbnails instead of second full-res decodes, and add locate-on-page highlighting so a picked image can be traced back to its DOM source. * feat(library): implement lazy loading for thumbnails and enhance asset filtering - Introduced a `LibraryThumb` component to lazily load heavy content (images, videos, iframes) only when they are near the viewport, improving performance. - Added a debounced search feature to optimize asset filtering, reducing unnecessary network requests during rapid input. - Enhanced the asset filtering logic to track active filters using a ref, ensuring efficient updates during live events. - Updated the `snapshotCardRects` and `cardIdsInBand` functions to support improved hit-testing for drag-and-drop interactions. * feat(library): lazy picker thumbnails + debounced search Extend the Library grid's lazy-thumbnail + 250ms debounced-search pattern to the composer LibraryPicker so opening it no longer fires one full-bytes request per asset, and tidy the clipper content-script image collection. * feat(clipper): compress and budget capture inlining Re-encode large raster images to downscaled WebP and inline smallest-first within a fixed budget, dropping only the secondary Figma IR past a safe body size, so an image-heavy page (e.g. a news front page) always saves as an editable HTML capture instead of 413-failing the ingest. * test(library): LibraryPicker debounce + lazy-thumbnail coverage Cover the composer picker's 250ms debounced search and its lazy <img> mount (deferred until the card is in view), matching the grid's perf test. * feat(design-system): enhance asset handling and UI for design systems - Updated the CLI to support additional asset kinds, including 'design-system'. - Enhanced the DesignSystemProvenance type to include source URLs, improving provenance tracking. - Modified the design system generation jobs to correctly summarize source links and GitHub repositories. - Updated UI components to reflect changes in asset handling, including new source link management in the DesignSystemFlow. - Improved tests to cover new functionality for adding source links and ensuring proper handling of design system assets. * refactor(library): rename 'design-system' to 'brand kit' and enhance thumbnail loading - Updated labels and filters in Library components to replace 'design-system' with 'brand kit'. - Introduced a shimmer skeleton for lazy-loaded thumbnails in the LibraryPicker to improve user experience during asset loading. - Enhanced the PickerCard component for better performance by memoizing individual asset cards. - Updated tests to ensure proper handling of brand kit assets and their visibility in the LibraryPicker. * feat(clipper): implement internationalization for toolbar and popup - Added i18n support to the clipper, enabling localization of UI elements and tooltips. - Introduced a new i18n.js file to manage translations for various languages. - Updated content.js and popup.js to utilize the i18n functions for dynamic text rendering. - Enhanced accessibility by ensuring aria-labels and tooltips are also localized. - Improved user experience by providing localized messages for actions and statuses. * feat(clipper): enhance brand kit extraction and localization support - Updated the brand kit extraction process to include improved handling of assets and localization for various UI elements. - Added internationalization support for the brand kit feature, allowing for dynamic text rendering based on user locale. - Enhanced the user experience by ensuring that all relevant messages and tooltips are localized. - Updated tests to cover new localization features and ensure proper functionality of the brand kit extraction process. * feat(clipper): enhance brand color derivation and update localization - Introduced new functions for color manipulation, including linear interpolation and clamping, to improve brand color derivation. - Updated the deriveBrandColors function to better map observed palettes to semantic roles, ensuring consistent brand representation. - Revised localization strings in i18n.js to reflect changes from 'brand kit' to 'design system', enhancing clarity and user experience. - Improved overall code organization and readability by refactoring existing functions and adding new utility methods. * refactor(clipper): update terminology from 'brand kit' to 'design system' - Replaced all instances of 'brand kit' with 'design system' across various components and localization files for consistency. - Updated UI elements, tooltips, and documentation to reflect the new terminology. - Enhanced user experience by ensuring clarity in the design system extraction process and related functionalities. - Adjusted localization strings in multiple languages to align with the updated terminology. * feat(clipper): enhance image fill handling and normalization - Introduced functions to normalize image fills by converting non-PNG/JPEG formats (SVG, WebP, GIF, AVIF) to PNG before import, ensuring all images are properly rendered in Figma. - Updated the UI to report the number of images converted and dropped during the import process, improving user feedback. - Enhanced the overall image processing workflow to prevent silent failures when unsupported formats are encountered. - Revised documentation to reflect the new image handling capabilities and supported formats. * feat(clipper): enhance UI kit and busy state feedback - Updated the UI kit to include new components such as inputs, selection, and overlays, improving the overall design system representation. - Enhanced the busy state feedback during capture processes with localized messages and a step-by-step progress indicator, providing users with clearer status updates. - Revised localization strings to support new UI elements and improve user experience across multiple languages. - Improved documentation to reflect changes in the UI kit and busy state handling. * fix(brands): restore design-systems nav entry + reconcile BrandsTab on re-activation Address review feedback on PR #4260: 1. EntryNavRail dropped the only control that reached view==='design-systems' when Brands replaced it in the rail, leaving the still-rendered/routed design-system manager deep-link only (the entry-nav-design-systems e2e specs assert this). Restore a reachable rail entry (blocks icon, existing navDesignSystems key) alongside Brands. 2. BrandsTab only fetched once on mount, but EntryShell keeps sub-views mounted and toggles visibility, so a brand finishing extraction in its backing project never reconciled until a full reload. Refresh whenever the Brands view becomes active again, and poll while any brand is extracting (torn down once settled / when hidden). Red spec: tests/components/BrandsTab.refresh.test.tsx (fails pre-fix: fetchBrands called once, not twice). * Update clipper/brand-capture.js * fix(clipper): improve busy state handling and UI feedback - Adjusted the spinner CSS to use flex properties for better layout control. - Enhanced the reclampIfMoved function to preserve user position during busy state transitions. - Added loading toast notifications for popup-launched captures to ensure progress visibility even when the on-page bar is hidden. * feat(daemon): add kiwi-schema dependency and enhance Figma API integration - Added kiwi-schema package to the daemon for improved schema handling. - Updated FigmaApiNode interface and related functions to support shared functionality with the offline decoder, ensuring consistency in node processing. - Refactored capture functions in clipper to maintain UI visibility during DOM/IR snapshots, enhancing user experience during capture operations. * fix(web): surface missing backing projects * fix(web): re-enable brand actions after use * fix(daemon): serve brand logos from data roots * fix(brands): reconcile failed extractions * feat(daemon): implement offline Figma import and decoding functionality - Added support for importing `.fig` files directly into the daemon, enabling offline processing without requiring a Figma account. - Introduced a new `fig-decode.ts` module for decoding `.fig` files, handling both ZIP-wrapped and raw formats. - Created `figma-import.ts` to orchestrate the import process, generating a canonical snapshot and associated metadata. - Enhanced the server to handle Figma file uploads and integrate with the new decoding logic. - Updated package dependencies to include `kiwi-schema`, `html2canvas`, and `jspdf` for improved functionality. - Added tests for the new Figma import features to ensure reliability and correctness. * feat(clipper): reload-proof capture progress badge on the extension icon The on-page progress strip dies if a page reloads itself mid-capture (aggressive paywall sites like economist.com do this), leaving no loading signal. Add a per-tab '•••' badge on the extension icon for the lifetime of any capture message — it lives on the action icon, so a page navigation can't take it down. Verified end-to-end via a real loaded extension. * feat(daemon): add export functionality for Figma and enhance PDF export process - Introduced `runFigma` command for importing Figma designs, supporting both local `.fig` files and Figma URLs. - Added detailed usage instructions for the `od figma import` command. - Implemented `runExport` command for programmatic export of HTML/deck artifacts to PDF, PPTX, or image formats. - Enhanced error handling and user feedback during export processes. - Removed obsolete `build-pptx-export-prompt` module and related tests to streamline the codebase. * feat(daemon): enhance library synchronization and export capabilities - Implemented `reconcileLibrary` to mirror design systems and agent-produced project deliverables into the Library as referenced assets. - Added support for programmatic export of artifacts via the `od export` command, including detailed usage instructions. - Introduced new functions for handling Figma imports and exports, improving integration with design workflows. - Enhanced error handling and user feedback during synchronization and export processes. - Added tests for new features to ensure reliability and correctness. * feat(web): PPTX export for any shareable artifact + Library toolbar tooltips * chore(nix): refresh pnpm deps hash * refactor(web): enhance onboarding view and file export progress indicators - Updated the onboarding view layout for improved accessibility and visual hierarchy, including adjustments to spacing, typography, and button styles. - Introduced a loading toast for file export progress, displaying elapsed time and estimated time remaining for slide exports. - Added new translation keys for export progress messages in multiple languages. - Refactored the export progress handling to provide real-time updates during the export process, improving user feedback and experience. * refactor(web): streamline export capture bridge and update connector styles - Removed unused loading logic for html2canvas in the export capture bridge, simplifying the code. - Updated CSS for the onboarding view connector to improve visual clarity and ensure it does not overlap with node numbers. * refactor(web): remove html2canvas dependency and enhance Figma URL handling - Removed the html2canvas package from the project, including its references in the lock file and related components. - Added functionality to manage Figma URLs within the Design System flow, allowing users to add, remove, and validate Figma file links. - Improved drag-and-drop handling to prevent unintended file navigation when dropping files outside designated areas. - Updated UI components to accommodate new Figma URL features, enhancing user experience and accessibility. * refactor(web): unify brand and design system flows - Merged the brand extraction process into the design system creation workflow, allowing users to start from a brand directly within the design system wizard. - Updated routing to redirect legacy brand links to the unified design systems tab. - Enhanced the onboarding experience by removing the separate Brand Kit tab and integrating brand selection into the design system creation process. - Improved UI components to reflect these changes, ensuring a seamless user experience across the application. * feat(web): introduce brand enrichment banner and picker modal - Added a new BrandEnrichmentBanner component to allow users to refine programmatically-extracted design systems with AI by selecting design-system skills. - Implemented a BrandPickerModal for selecting brands from a searchable gallery, enhancing the design system creation flow. - Updated ChatPane to conditionally display the enrichment banner for eligible brand projects, improving user engagement. - Enhanced the design system flow to support the new brand enrichment features, ensuring a seamless experience for users. * feat(web): enhance BrandPickerModal and DesignSystemAssetDropzone - Updated the BrandPickerModal to allow scrolling of the entire picker area, improving user experience by creating a unified scrolling surface. - Added new props to the BrandReferencePicker for action labels and scroll root reference, enhancing flexibility in brand selection. - Introduced a new DesignKitView component for rendering design kits consistently across different surfaces. - Enhanced the DesignSystemAssetDropzone to support a wider variety of file types with appropriate previews, improving asset management during design system creation. - Updated styles for better visual clarity and responsiveness across components. * feat(web): update Design Systems tab actions and enhance localization - Changed the button label in the DesignSystemsTab from "Edit" to "Open" for better clarity in user actions. - Added a new translation key for 'dsManager.openSystem' across multiple languages to support the updated button label. - Enhanced the FileWorkspace component to ensure the Design Files tab aligns correctly with the Design System tab, improving UI consistency. - Implemented a new design system editing feature that allows users to fetch and save design system content from DESIGN.md, enhancing the design workflow. * fix(merge): repair post-merge regressions after origin/main integration Follow-up fixes on top of the origin/main merge (886f925cd) addressing regressions the conflict resolution introduced. main's web suite is the oracle (100% green); resolution principle was main's engine/backend + HEAD's UI, unioned. daemon: - library-sync.ts: correct design-systems import to ./design-systems/index.js (design-systems became a directory module on main). - tests/server-bootstrap-regression: add LIBRARY_DIR to the PathDeps fixture (main-added test x HEAD-added LIBRARY_DIR field). web: - WorkspaceTabsBar: union — restore main's onboarding Search-popover close behaviour + guards, keep HEAD's library/brands nav entries. - HomeView: restore main's composer sending-state (await onSubmit, widen its return type to Promise<boolean>|boolean|void, pass submitting to HomeHero). - MemorySection.test: take main's version to match main's two-loop memory component. - i18n: restore dropped settings.onboardingRoleMarketing key across types.ts and all locales. - App/BrandsTab/EntryNavRail/router/home-intent: union fixes restoring main features dropped during conflict resolution (needs_input handling, etc.). Validation: pnpm guard + full pnpm typecheck (all 23 packages) green. Known-red: EntryShell onboarding step 3 intentionally retains HEAD's "build" step rather than main's brand-extract step; 8 EntryShell.onboarding / App.onboarding-amr-e2e tests stay red pending that onboarding decision. * fix(merge): keep HEAD's unified brand flow (revert main's separate Brands tab) Follow-up to 688544ff7. Per the chosen product direction (brand creation unified into the design-system create wizard, not a standalone Brands tab), revert the brand-flow routing/nav that the post-merge repair had restored from main: - router.ts: keep HEAD's brand routing (brands folded into design-systems), drop main's standalone /brands and /brands/:id view routing. - EntryNavRail.tsx: drop main's standalone "Brands" nav button. - runtime/home-intent.ts: drop main's brand "Use in new chat" confirmation notice plumbing (tied to the separate Brands flow). Kept from the repair commit (additive, non-conflicting): App.tsx loadedActiveProject correctness, composer Sending… state, WorkspaceTabsBar onboarding popover behaviour, two-loop memory test, restored i18n keys, brand needs_input STATUS handling, server.ts plugin-route infrastructure. * feat(library-ui): implement conditional rendering based on LIBRARY_UI_VISIBLE - Updated router.ts to conditionally render the library view based on the LIBRARY_UI_VISIBLE flag. - Modified ComposerPlusMenu.tsx, DesignFilesPanel.tsx, and DesignSystemAssetDropzone.tsx to show the "Select from library" button only when LIBRARY_UI_VISIBLE is true. - Adjusted EntryNavRail.tsx and EntryShell.tsx to include the library navigation button and section conditionally based on the LIBRARY_UI_VISIBLE state. - Enhanced HomeHero.tsx to allow starting a blank project directly, improving user experience by providing more options for project creation. This commit introduces a feature toggle for the library UI, allowing for better control over its visibility during development and testing. * feat(home-hero): implement edge auto-scroll for horizontal overflow - Introduced `useEdgeAutoScroll` hook to manage auto-scrolling behavior for horizontally overflowing components in HomeHero. - Updated `PluginPromptPresets` and `RailGroup` components to utilize the new auto-scroll functionality, enhancing accessibility for users without trackpads. - Added `EdgeScrollZones` component to provide interactive edge zones for scrolling. - Enhanced CSS styles to support the new scrolling layout and ensure proper positioning of elements. This commit improves user experience by making overflow content more accessible and easier to navigate. * feat(design-systems): add project creation from design system and enhance UI components - Implemented `handleCreateProjectFromDesignSystem` function in `AppInner` to facilitate project creation directly from a selected design system. - Updated `DesignKitView` to wrap the iframe in a span for better layout control. - Refactored CSS for `BrandPreviewCard` and `DesignSystemsTab` to improve styling and responsiveness. - Introduced a new `TemplatePicker` component in `HomeHero` for selecting project-type templates, enhancing user experience. - Updated various components to support asynchronous handlers for design system actions, improving overall functionality. This commit enhances the design system integration and user interface, making project creation more intuitive and accessible. * feat(brand-routes): enhance brand reservation API and add DESIGN.md support - Updated the POST /api/brands endpoint to accept optional fields: description and designMd, allowing for more flexible brand reservations. - Modified validation to require either a URL or designMd for brand extraction. - Introduced a new design-md-input module to handle parsing and validation of DESIGN.md content. - Enhanced startBrandExtraction function to support processing of DESIGN.md, improving integration with design systems. - Added utility functions for managing DESIGN.md input and output, streamlining the brand creation process. This commit improves the brand extraction workflow by integrating DESIGN.md support, making it easier for users to create and manage brands. * feat(chat-pane, design-kit-view): enhance chat functionality and design preview features - Added `handleNextStepPromptAction` to `ChatPane` for setting draft prompts, improving user interaction. - Introduced `nextStepVariant` to differentiate design system projects in `ChatPane`. - Updated `DesignKitView` to include a button for previewing design kit covers, enhancing user experience. - Implemented a modal for displaying design kit previews, allowing users to view content in a dedicated space. These changes improve the chat interface and design kit interactions, making the application more intuitive and user-friendly. * feat(brand-extraction): enhance DESIGN.md support and testing - Added a new test case to validate brand extraction from DESIGN.md input without requiring a website. - Implemented functionality to register brands directly from DESIGN.md, improving the brand creation workflow. - Updated the `ChatPane` and `NextStepActions` components to handle design system-specific actions for projects, enhancing user experience. - Enhanced localization files with new carousel hints and project brief options across multiple languages. These changes streamline the brand extraction process and improve the overall functionality of the design system integration. * feat(wireframe-examples): add annotated and greybox wireframe examples - Introduced new wireframe examples for annotated and greybox styles, enhancing design system capabilities. - Added HTML and JSON files for both wireframe types, providing templates for low-fidelity design mockups. - Implemented SKILL.md documentation for each wireframe example, detailing usage and design specifications. These additions improve the design toolkit, offering users more options for creating wireframes in various styles. * feat(brand-extraction): refine Chrome fallback and enhance error handling - Updated the Chrome fallback logic in the prefetch pipeline to clarify its purpose and usage as a diagnostic tool. - Introduced environment variable checks to enable or disable system Chrome usage, improving control over the extraction process. - Enhanced error messages in the DesignSystemCreationFlow component to provide clearer guidance on required inputs for creating a design system. - Added regression tests to ensure that prompts do not instruct the agent to invoke a non-existent `brand-extract` skill, preventing potential failures during brand extraction. These changes improve the robustness of the brand extraction process and enhance user experience by providing clearer instructions and error handling. * feat(brand-extraction): enhance DESIGN.md input handling and introduce brand ready prompt - Updated the BrandFromDesignMdInput interface to explicitly define the description property as optional with undefined. - Enhanced the brand extraction prompts to clarify the inline brand-extract workflow, preventing confusion during the extraction process. - Added a new BrandReadyPrompt component to notify users when a design system is ready for preview, improving user experience. - Introduced CSS styles for the BrandReadyPrompt to ensure a visually appealing and user-friendly interface. - Updated localization files to support new strings related to the brand ready prompt across multiple languages. These changes improve the clarity and usability of the brand extraction process, providing users with timely feedback and a more intuitive interface. * feat(brand-extraction): improve design system focus handling and localization updates - Refactored the handling of browser tabs in the brand extraction tests to ensure proper validation of tab states. - Enhanced the AppInner component to refresh design systems alongside templates, ensuring users see the latest updates without page reloads. - Introduced a pending focus state in the DesignSystemsTab to manage design system selection more effectively after brand extraction. - Added a BrandReadyPrompt in the ProjectView to notify users when a design system is ready for preview, improving user engagement. - Updated localization files for Chinese (Simplified and Traditional) to reflect changes in terminology related to design systems. These changes enhance the user experience by providing timely feedback and ensuring that the design system selection process is seamless and intuitive. * fix(styles): adjust letter-spacing and enhance plus-menu trigger styles - Set letter-spacing to 0 in design-system-flow.css for improved text clarity. - Added styles for plus-menu trigger in plus-menu.css, including background, border, and hover effects to enhance user interaction and visual consistency. These changes refine the design aesthetics and improve the usability of the plus-menu component. * feat(tests): add design-system focus handoff tests - Introduced a new test suite for validating the design-system focus handoff functionality. - Implemented tests to ensure that the focus ID is correctly set, read, and cleared from session storage, preventing user selection hijacking. - Added checks for scenarios where no focus ID is pending, enhancing test coverage for the design system's behavior. These tests ensure the reliability of the design-system focus handling, contributing to a more robust user experience. * feat(export): restrict image format options to PNG and JPEG - Updated the image format options in the export functionality to only allow PNG and JPEG, removing WebP to prevent silent downgrades. - Enhanced error handling to provide clear feedback when an unsupported image format is specified. - Adjusted related documentation and comments to reflect the changes in supported formats across the application. These changes ensure consistency in image export behavior and improve user experience by providing immediate validation errors for unsupported formats. * feat(origin-validation): implement zero-config OD Clipper bypass for library requests - Added a new function `isZeroConfigClipperLibraryRequest` to validate requests from locally-installed browser extensions targeting the `/library/` path. - Updated the origin validation middleware to utilize this function, allowing unpaired browser extensions to access the `/api/library/ingest` endpoint while blocking other cross-origin requests. - Enhanced tests to cover the new bypass functionality, ensuring correct behavior for both valid and invalid origins. These changes improve the integration of browser extensions with the local daemon, enhancing user experience while maintaining security. * feat(design-systems): add download functionality for design systems - Implemented a new command `od design-systems download <id>` to allow users to download design systems as a .zip file, including all system files and a generated SKILLS.md usage guide. - Updated the CLI help documentation to include usage instructions for the new download command. - Enhanced the design systems API to support the download feature, ensuring only user design systems are accessible while handling errors for non-existent presets. - Added localization strings for the new download functionality across multiple languages. These changes enhance the usability of design systems by providing a straightforward method for users to obtain and share their design assets. * feat(design-systems): enhance design system management and localization - Introduced new UI components and styles for managing design systems, including buttons for downloading, refreshing, and resetting edits. - Updated the DesignKitView to support direct actions for DESIGN.md editing, improving user interaction with design systems. - Enhanced the DesignSystemDetail component to include download functionality and improved state management for design system edits. - Added localization strings for new features, ensuring consistent user experience across multiple languages. - Improved error handling and user feedback for design system operations, including download failures. These changes streamline the design system management process, making it more intuitive and user-friendly while ensuring robust localization support. * feat(tests): add comprehensive tests for design system archive functionality - Introduced a new test suite for validating the `buildUserDesignSystemArchive` and `buildDesignSystemSkillsMarkdown` functions. - Implemented tests to ensure correct packing of design system files, including the generation of a `SKILLS.md` guide and exclusion of internal metadata. - Added checks for handling non-user IDs and scenarios where a design system already includes its own `SKILLS.md`. - Enhanced the overall test coverage for design system functionalities, ensuring reliability and correctness in the design system archive process. These changes improve the robustness of the design system features by ensuring thorough testing of critical functionalities. * feat(figma-import): enhance CLI output and add Figma import endpoint - Updated the CLI to conditionally log detailed import information based on the `--json` flag, improving usability for users who prefer JSON output. - Introduced a new API endpoint for importing Figma files, handling file uploads and validating project existence, with appropriate error responses for missing files or invalid URLs. - Added a dedicated route for the Figma import functionality, ensuring seamless integration with existing project workflows. These changes improve the Figma import experience by providing clearer output options and robust error handling, enhancing overall user interaction with the CLI and API. * feat(design-files): enhance DesignFilesPanel with new actions and styles - Added new action buttons for opening a browser and creating a design system in the DesignFilesPanel, improving user interaction in the empty state. - Updated styles for action buttons to enhance visual distinction and usability. - Enhanced tests to verify the functionality of new actions in the DesignFilesPanel, ensuring they trigger correctly. These changes improve the user experience by providing additional functionality and clearer visual cues in the design files interface. * fix(ci): restore new project modal flow * fix(ci): align design kit and onboarding checks * fix(ci): sync bake preview workflow action * fix(ci): include plugin preview helper scripts * fix(review): harden brand source and preview flows * fix(ci): stabilize web workspace tests * fix(review): address latest blocking feedback * chore(ci): retrigger validation after label update * chore: re-trigger CI on updated main — needs-validation gate moved to merge_group (#4714) * refactor(lightbox): implement portal for overlays to resolve z-index issues - Updated the lightbox component to use React's createPortal for rendering overlays directly to the <body>, ensuring proper z-index stacking. - Removed session mode toggle from HomeHero and adjusted related styles and tests accordingly. - Cleaned up CSS by removing unused styles related to session mode toggle. - Updated tests to reflect changes in the HomeHero component and its interaction with the design router. * style(home-hero): remove focus halo from template search input - Updated CSS to eliminate the global input focus outline and box-shadow for the template search field in the HomeHero component. - Added a test to verify that the template picker search field maintains a clean appearance when focused. * feat(design-system): add create design CTA and enhance design kit functionality - Introduced a new `DesignSystemCreateCta` component to facilitate creating new designs from an active design system, enhancing user experience in the chat interface. - Updated `ChatPane` to include the new CTA, allowing users to create designs directly from the chat. - Enhanced `DesignKitView` with sticky header functionality for better accessibility while scrolling. - Added new CSS styles for the `DesignSystemCreateCta` component to ensure a visually appealing and consistent design. - Updated internationalization files to include new strings for the design system creation feature. * feat(upload): enhance file upload handling and error recovery - Introduced `sanitizePath` to preserve directory structures during file uploads, preventing issues with subdirectory paths. - Updated `DesignKitView` and related components to utilize the new `sanitizePath` function for improved file name resolution. - Added `KitErrorBoundary` component to gracefully handle rendering errors in the design kit, providing a user-friendly fallback. - Implemented internationalization updates for new error messages and action confirmations related to uploads and error handling. - Enhanced CSS styles for better visual feedback during error states and improved user experience. * feat(design-kit): add keyboard shortcuts hint and enhance key handling - Introduced a new keyboard shortcuts hint in the DesignKitView, providing users with quick access to essential actions (E edit, C copy, U upload, R refresh, ⌫ delete logo). - Implemented a keydown event handler to manage keyboard shortcuts contextually within the design kit, improving user interaction and accessibility. - Updated CSS for the shortcuts hint to ensure it remains low-contrast until hovered, enhancing the UI experience. - Added internationalization support for new shortcut labels and hints across multiple languages. - Adjusted DesignSystemsTab to prefer user logos for their systems, improving visual consistency. * feat(design-system): introduce DesignSystemExtractionPanel and enhance design system interactions - Added the `DesignSystemExtractionPanel` component to facilitate user interactions during design system extraction, providing a synthesized conversation view and next steps. - Updated `ChatPane` to render the new extraction panel when a design system is active, enhancing user guidance. - Introduced a new utility function `designSystemExtractionSource` to derive human-readable labels for design system sources. - Enhanced internationalization support with new strings for extraction-related actions and prompts across multiple languages. - Updated various components and tests to reflect changes in terminology and functionality, improving overall user experience. * feat(project): add project deletion functionality and enhance design system interactions - Introduced `onDeleteProject` prop in `ProjectView` to handle project deletion, improving project management capabilities. - Updated `AppInner` to include the new delete project handler, enhancing user experience in project interactions. - Enhanced `DesignKitView` and `DesignSystemsTab` with loading states and improved visual feedback during design system resolution. - Removed deprecated `DesignSystemCreateCta` component and associated styles, streamlining the codebase. - Updated internationalization files to reflect changes in project management terminology and actions. * feat(design-kit): enhance internationalization and user feedback in DesignKitView - Updated various labels and error messages in the DesignKitView to utilize internationalization functions, improving accessibility and user experience. - Enhanced color input validation messages and added confirmation prompts for design system deletions in DesignSystemsTab and FileWorkspace. - Introduced new props for handling design system project deletions, streamlining project management. - Updated internationalization files to reflect new strings and translations for improved user guidance across multiple languages. * refactor(design-kit): remove keyboard shortcuts hint and streamline header menu - Eliminated the keyboard shortcuts hint from the DesignKitView, simplifying the header menu. - Updated the sticky-header overflow menu to exclude upload, full-system preview, and shortcut help actions, focusing on essential project operations. - Adjusted related tests to reflect the removal of the shortcuts hint and ensure accurate menu item visibility. * feat(brand-routes): add extract-from-html endpoint for brand extraction - Introduced a new POST endpoint `/api/brands/:id/extract-from-html` to re-run brand extraction using HTML rendered from the in-app browser after clearing anti-bot walls. - Implemented error handling for missing HTML and brand not found scenarios. - Enhanced the `extractBrandFromHtml` function to process the provided HTML and optional CSS, integrating it into the existing brand extraction workflow. - Updated `prefetch` functionality to support extraction from pre-rendered HTML, improving the overall brand data retrieval process. * chore(nix): refresh pnpm deps hash * feat(brand-cli): add extract-from-html command for brand extraction - Introduced a new CLI command `od brand extract-from-html` to facilitate brand extraction from pre-captured rendered HTML, allowing users to bypass anti-bot walls. - Enhanced the command to accept optional CSS and base URL parameters, improving flexibility in extraction scenarios. - Implemented error handling for missing HTML input and invalid brand IDs, ensuring robust user feedback. - Updated the `BRAND_USAGE` documentation to reflect the new command and its usage details. - Adjusted server configuration to accommodate larger payloads for the new extraction endpoint. * feat(design-system): enhance design system extraction and browser tools - Added a new script to collect CSS styles from rendered pages, improving brand extraction capabilities by capturing computed styles from cross-origin stylesheets. - Removed the `DesignSystemExtractionPanel` component and its associated styles, streamlining the codebase. - Updated `ProjectView` and `FileWorkspace` components to enhance design system interactions and improve user experience. - Introduced new internationalization strings for design system phases and actions, ensuring better user guidance across multiple languages. * feat(brand-assist): implement browser assist for brand extraction - Added support for a client-side confirmation mechanism for the brand-browser-assist od-card, allowing users to extract brand information from the unblocked browser DOM. - Enhanced the `ProjectView`, `ChatPane`, and `AssistantMessage` components to handle the new assist functionality, improving user interaction during brand extraction. - Introduced new internationalization strings for browser assist prompts and messages, ensuring clarity and guidance across multiple languages. - Updated the `useBrandReadyPrompt` hook to manage the state of the browser assist, providing a seamless user experience when dealing with anti-bot walls. * feat(brand-prompt): enhance BrandReadyPrompt with refinement options - Updated the BrandReadyPrompt component to include options for AI optimization and manual editing, allowing users to refine extracted brand systems. - Added a new refinement nudge to inform users that automatic extraction may miss details, improving user guidance. - Adjusted styles for the prompt and dismiss button for better alignment and visual consistency. - Introduced new internationalization strings for the refinement features, ensuring clarity across multiple languages. - Removed deprecated PPTX export functionality from the FileViewer component, streamlining the export options. * refactor(export): remove PPTX export functionality and streamline export options - Eliminated PPTX export support across various components, including CLI, desktop, and web, to simplify export formats. - Updated documentation and help messages to reflect the removal of PPTX, ensuring clarity for users. - Adjusted export-related types and constants to focus on PDF and image formats only, enhancing code maintainability. - Improved user experience by refining export options and related UI elements. * refactor(export): remove PPTX references and update export functionality - Removed all instances of PPTX export functionality from the codebase, including related dependencies and comments. - Updated export options to focus solely on PDF and image formats, enhancing clarity and maintainability. - Adjusted UI components and tests to reflect the removal of PPTX, ensuring a streamlined user experience. - Improved internationalization strings and documentation to align with the new export capabilities. * chore(nix): refresh pnpm deps hash * fix(onboarding): preserve selected runtime * fix(brand): localize generated kit copy * fix(onboarding): align first-run flow with main * fix(nav): use palette icon for design systems * fix(analytics): use design system onboarding step * fix(ui): remove design system guide toggle * fix(ui): position design system ready prompt * fix(ui): space plugin task notice * fix(web): restore home ask mode and design kit preview * test(e2e): align onboarding visual capture * test(e2e): align amr onboarding checks * fix(brand): remove blocked reference brands * feat(onboarding): show profile choices as chips * fix(home): prefer design system cover art in recents * test(e2e): select onboarding profile chips * feat(brand-extraction): implement programmatic extraction transcript and UI enhancements for design systems * feat(brand-extraction): enhance programmatic extraction with transcript agent support and UI improvements * feat(brand-extraction): add transcript agent resolution and improve message handling in brand extraction * fix(design-systems): stabilize loading state coverage * test(e2e): align design system detail visual * fix(brand-extraction): backfill programmatic transcripts * fix(web): refresh ready brand design systems * fix(brands): stabilize extraction handoff and seed colors * fix(brands): return extraction transcript immediately * fix(web): open new project modal from entry rail * fix(editing): expose content edits for plain targets * feat(file-viewer): implement manual edit draft dirty state tracking and reset logic * feat(design-system): enhance project creation flow with conversation ID handling * feat(brands): implement light theme handling for color extraction and seed generation * feat(brands): add finalizeBrandProject function for brand project completion * feat(file-workspace): add designSystemBrandId prop and update DesignSystemProjectPanel to use it * Fix manual editing for brand kits * fix(design-system): wait for project refreshes * fix(web): open new project modal from rail * fix(web): restore home ask mode toggle * fix(web): sync brand color edits with seeds * fix(web): stabilize design system workspace tests * test(tools-pack): relax Windows resource cache timeout * chore(pr): retrigger review after validation * fix(web): surface design kit action progress * fix(web): clarify brand next-step actions * fix(web): cancel programmatic brand extraction * fix(web): add design systems tab action feedback --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: xne998808-ai <xne998808@gmail.com> Co-authored-by: PerishCode <perishcode@gmail.com> Co-authored-by: open-design-bot[bot] <282769551+open-design-bot[bot]@users.noreply.github.com> Co-authored-by: lefarcen <935902669@qq.com> Co-authored-by: Siri-Ray <2667192167@qq.com>	2026-06-25 03:56:14 +00:00
PerishFire	0bf1b6d6b8	[codex] converge release workflows and stable dry-runs (#4390) ... * fix(tools-pack): use junctions for Windows standalone peer deps * fix(desktop): expose IPC during startup * fix(tools-pack): preserve Windows inspect diagnostics * fix(tools-pack): report Windows inspect status errors * fix(packaged): use Electron net fetch for app protocol * fix(packaged): load Windows renderer from web sidecar * fix(desktop): show Windows packaged window during startup * fix(packaged): disable Windows GPU startup * fix(tools-pack): keep Windows core smoke observable * fix(packaged): remove Windows startup probes * fix(tools-pack): trace Windows desktop IPC status * fix(tools-pack): add Windows IPC diagnose loop * fix(release): default beta-s Windows updater feed * chore: clean merged test eof * refactor(release): unify prerelease channel model * chore(release): close prerelease doc escape hatches * refactor(release): converge release channel workflows * fix(release): install toolchain in metadata jobs * fix(release): build release package before contracts * chore(release): bump development version to 0.10.1 * fix(e2e): seed windows packaged smoke runtime config * fix(release): install toolchain for metadata publish * fix(release): materialize betas metadata checkout * chore(release): bump development version to 0.10.2 * fix(release): allow betas metadata cold start from s3 * fix(e2e): support betas packaged update scenarios * fix(release): pass betas channel into packaged smoke * fix(release): set betas channel during self-hosted builds * fix(release): verify counted channel reservations * fix(release): use pnpm cmd for betas windows publish * fix(release): add betas manifest artifact fallback * fix(release): skip beta-s public metadata fetch * fix(release): read beta-s manifests from storage * fix(release): cache beta windows tools-pack builds * fix(release): inline beta mac tools-pack builds * fix(pack): deep sign unsigned mac bundles * docs(pack): document payload-first beta updater validation * fix(release): align preview tools-pack cache flow * fix(release): align prerelease tools-pack cache flow * fix(release): pass github token to prerelease metadata * fix(release): setup pnpm before feishu notify * fix(release): add stable dry-run prepublish flow * fix(release): accept completed prerelease metadata gate * fix(release): require stable release branches * fix(release): converge r2 access checks * fix(updater): use release channel parser for defaults * fix(updater): harden windows payload relaunch * fix(release): converge updater smoke fixture contract * test(e2e): require silent updater fixture output * fix(release): align stable windows smoke build path * fix(ci): include release workspace in validation * fix(ci): repair release validation lanes Generated-By: looper 0.9.10+codex.autoclean (runner=fixer, agent=codex) * fix(ci): restore zero-install Feishu notification Generated-By: looper 0.9.10+codex.autoclean (runner=fixer, agent=codex) --------- Co-authored-by: Looper <looper@noreply.github.com>	2026-06-23 06:13:21 +00:00
PerishFire	d3896fa51a	[codex] Clean deprecated launcher payloads on updater startup (#4524) ... * fix(packaged): recover stale launcher and sidecar state * fix(packaged): write launcher cleanup from installer sync * perf(tools-pack): reuse windows payload caches * perf(tools-pack): avoid slow windows 7z filters * fix(tools-pack): bound windows payload archive hangs * test(packaged): stabilize sidecar tests on windows * fix(tools-pack): harden launcher runtime sync helper * fix(tools-pack): invalidate nsis cache for installer helpers * fix(tools-pack): hash nsis helper source in bundled cli * fix(packaged): restart when existing desktop has stale sidecars * chore(release): bump beta base to 0.11.1 * fix(e2e): seed windows smoke onboarding in runtime data * ci(release): let beta runs use default queueing * ci(release): restore beta concurrency guard * ci(release): enable beta mac x64 by default * ci(release): disable beta mac x64 by default * fix(updater): clean deprecated launcher payloads on startup * fix(e2e): align stable dry-run fixture version Generated-By: looper 0.9.10+codex.autoclean (runner=fixer, agent=codex) --------- Co-authored-by: Looper <looper@noreply.github.com>	2026-06-22 04:21:30 +00:00
lefarcen	39cad2b8a5	chore(release): bump version to 0.11.0 for release/v0.11.0	2026-06-17 11:05:56 +08:00
lefarcen	30b8eac48c	chore(release): bump version to 0.10.2 on main (#4387) ... main read 0.10.1 (== latest stable 0.10.1), so the daily beta build's strictly-greater-than-stable version guard refused to produce a beta from main. Advance the 0.10.x dev line to 0.10.2 across the same 16 lockstep workspace package.json that #4381 bumped, and align the packaged-smoke stable dry-run fixture to 0.10.2. This continues the existing beta line on R2 (0.10.2-beta.4) so a build from main produces 0.10.2-beta.5.	2026-06-16 06:08:40 +00:00
lefarcen	a3a5f02d87	chore(release): bump version to 0.10.1 on main (#4381) ... Back-fill the 0.10.1 version bump that shipped via the release/v0.10.1 branch (tag open-design-v0.10.1, already published) but never merged back to main. The feature/perf content of that release already landed on main via #4198, #4203 and #4202; only the version-number bump and the packaged-smoke stable fixture were left behind, so main still read 0.10.0. This applies the release-specific deltas onto current main: - bump version 0.10.0 -> 0.10.1 across the 16 workspace package.json in the 0.10.x release set (apps/daemon, apps/desktop, apps/landing-page, apps/packaged, apps/web, e2e, root, packages/contracts, packages/download, packages/host, packages/launcher-proto, packages/platform, packages/sidecar-proto, packages/sidecar, tools/dev, tools/pack) - align e2e packaged-smoke stable fixture to 0.10.1 launcher-proto was added to main after the 0.10.1 release branch was cut, so it was not in the original release commit; it is part of the lockstep 0.10.x release set (private workspace package, sibling of sidecar-proto), so it is bumped here to keep main release metadata consistent. Independently-versioned workspace packages (agui-adapter, components, diagnostics, metatool, plugin-runtime, registry-protocol, tools/serve, telemetry-worker) are intentionally left untouched. Supersedes the stale release/v0.10.1 PR (#4205).	2026-06-16 03:59:48 +00:00
PerishFire	10dfd32a3e	Revert "feat: add screenshot-based visual validation to critique loop (#3660)" (#3865) ... This reverts commit 931780c914.	2026-06-08 06:24:44 +00:00
nettee	931780c914	feat: add screenshot-based visual validation to critique loop (#3660) ... * feat(daemon): add visual validation atom Generated-By: looper 0.9.3 (runner=worker, agent=codex) * fix(daemon): fail closed in visual validation Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): narrow visual validation defaults Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): add visual validation to default critique stages Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): harden visual validation review fixes Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): fail closed in visual validation discovery Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * test(daemon): tighten visual validation discovery regression Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): match visual validation reference viewport Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): tighten visual validation capture flow Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): fail closed across visual validation refs Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): honor metadata entry file in visual validation Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): capture visual validation through preview route Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): fail closed without preview context Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): disable pre-start visual validation worker Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): narrow visual validation spec discovery Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): stop advertising visual validation as runnable Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): restore visual validation critique worker Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): delay visual validation until run success Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * test(daemon): cover post-run visual validation scheduling Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): gate post-run visual validation before finish Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * chore(nix): refresh pnpm deps hash * fix(daemon): preserve deferred pipeline ordering Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(packaging): bundle Chromium for visual validation Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(scenarios): keep visual validation out of default critique loop Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(packaging): bundle Playwright headless shell Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(packaging): invalidate Playwright resource cache Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * fix(daemon): include visual-validation in bundled atom roster Generated-By: looper 0.9.3 (runner=fixer, agent=codex) * chore(nix): refresh pnpm deps hash * fix: restore pre-run plugin surfaces and nix hashes Generated-By: looper 0.9.5 (runner=fixer, agent=codex) * fix: preserve pre-run surfaces and tolerate headed-only chromium bundles Generated-By: looper 0.9.5 (runner=fixer, agent=codex) * fix: launch visual validation with bundled chromium Generated-By: looper 0.9.5 (runner=fixer, agent=codex) * fix: avoid Playwright fixture teardown races Generated-By: looper 0.9.5 (runner=fixer, agent=codex) * fix: fail packaged visual validation on shell-only chromium Generated-By: looper 0.9.5 (runner=fixer, agent=codex) * fix: isolate synthetic Playwright test bundles Generated-By: looper 0.9.5 (runner=fixer, agent=codex) --------- Co-authored-by: open-design-bot[bot] <282769551+open-design-bot[bot]@users.noreply.github.com>	2026-06-08 04:03:43 +00:00
lefarcen	556eb7f065	chore(release): bump main to 0.10.0 + clear plugin context after send (#3708 residual) (#3731) ... * fix(web): clear plugin context after send * chore(release): bump version 0.9.1 -> 0.10.0 (prep main for 0.10.0 beta from main; clears the beta anti-regression gate) --------- Co-authored-by: yinjialu <2481044901@qq.com> Co-authored-by: lefarcen <ontf116@gmail.com>	2026-06-05 08:35:31 +00:00
PerishFire	8f6cdaaba1	Harden release-beta-s self-hosted beta lane (#3641) ... * Fix Windows smoke launcher payload layout * Harden release-beta-s runner probe * Use cmd shell for release-beta-s probe * Add win beta build script for self-hosted lane * Keep release-beta-s checkout lightweight * Use explicit local beta version for release-beta-s * Install dependencies in beta build script * Repair Electron dist before Windows beta build * Add release-beta-s timings and diagnostics * Polish release-beta-s observability guardrails * Trace tools-pack cache materialization * Reuse materialized workspace build cache * Trace Windows packaging segments * Trace Windows archive process details * Reuse installer unpacked materialization * Preserve reusable Windows unpacked projection * Add fast smoke telemetry for self-hosted beta * Cache Windows archive outputs for beta lane * Tighten fast Windows smoke lane * Scope Windows beta artifact reporting by target * Clean stale Windows target artifacts * Wire Windows Authenticode signing * Expose self-hosted beta validation modes * Add core Windows smoke profile * Decouple core smoke from updater fixture version * Trace Windows smoke lifecycle steps * Skip unpacked materialization on NSIS cache hit * Add Nexu S3 beta publisher * Harden self-hosted Windows beta lane * Use Windows PowerShell for publish probe * Run publish probe via repo script * Require explicit self-hosted S3 public origin * Run real installer acceptance for external feeds * Skip ready-prompt checks for external feeds * Relax optional self-hosted update inputs * Tolerate BOM in self-hosted publish probe * Converge self-hosted beta metadata and signing flow * Run self-hosted beta metadata prep on the runner lane * Use Windows PowerShell for self-hosted beta metadata checks * Bypass execution policy in self-hosted beta metadata checks * Split self-hosted beta metadata publish * Suppress mc output in beta publish helpers * Split Windows NSIS payload cache layers * Require fresh tool dist metadata * Preserve Windows overlay payload paths * Default beta-s gate to core * Optimize win beta packaging reuse * simplify windows full smoke lifecycle * preserve onboarding state after windows upgrade smoke * fix windows tools-pack test portability * recover stale tools-pack locks * Allow auto signing fallback for beta builds * Add self-hosted beta mac arm64 lane * Quote self-hosted signing choices * Run self-hosted beta metadata on mac lane * Use shallow metadata checkout on self-hosted beta * Use sparse beta metadata checkout * Make mac release profile bash-compatible * Allow file sparse metadata checkout * Isolate self-hosted metadata checkout * Clear sparse skip-worktree before mac build * Isolate self-hosted mac build checkout * Run self-hosted beta publish without aws cli * Use unsigned beta prefix for mixed platform publish * Sparse checkout self-hosted beta publish * Publish mac beta platform before metadata * Pass mac publish release profile * Probe mac signing keychain import * Expand mac signing preflight variants * Use sudo keychain helper for self-hosted mac signing * Route self-hosted mac codesign through sudo wrapper * Normalize mac signing identity name * Harden self-hosted mac notarization * Optimize self-hosted mac release cache * Fix mac signing helper cleanup * Retry transient mac notarization uploads * Keep mac notarization fail-fast * Reduce mac symlink diagnostics noise * Normalize self-hosted beta platform inputs * chore: bump beta base version to 0.9.1 * chore: tune release tools-pack cache retention * test: add temporary cache validation marker * chore: key windows nsis base payload by content * Revert "test: add temporary cache validation marker" This reverts commit e8487bfd3e. * chore: probe windows nsis payload cache before materializing * chore: align self-hosted beta smoke modes * chore: skip mac smoke report upload when disabled * chore: default self-hosted beta to publish both platforms * chore: make beta signing modes explicit * Add release report artifacts and metatool metadata * Fix Windows release report zip publishing * Remove artifact handoff from release beta self-hosted lane * Fix release beta merge follow-ups * Fix release beta install regressions * Restore web build dependencies * Route Windows beta downloads through mirrors * Use PowerShell 7 for Windows beta lane * Fix release beta preflight gates Generated-By: looper 0.9.4 (runner=fixer, agent=codex) * Fix Windows beta smoke update reuse Generated-By: looper 0.9.4 (runner=fixer, agent=codex) * Fix release beta review follow-ups * Refresh Nix pnpm dependency hashes Generated-By: looper 0.9.4 (runner=fixer, agent=codex) * Fix Windows signtool fallback resolution * Reject stale beta platform manifests * Validate beta platform manifest run identity Generated-By: looper 0.9.4 (runner=fixer, agent=codex) * Validate beta manifest commit identity Generated-By: looper 0.9.4 (runner=fixer, agent=codex) * Allow beta metadata publish reruns Generated-By: looper 0.9.4 (runner=fixer, agent=codex) * Build tools-pack fully in beta Windows bootstrap Generated-By: looper 0.9.4 (runner=fixer, agent=codex) * Emit r2 metadata for Windows beta publish Generated-By: looper 0.9.4 (runner=fixer, agent=codex) * Stabilize beta publish browser test Generated-By: looper 0.9.4 (runner=fixer, agent=codex) * Stabilize Windows beta metadata smoke test Generated-By: looper 0.9.4 (runner=fixer, agent=codex) * Restore multi-platform Vela CLI package * Refresh Nix pnpm dependency hashes Generated-By: looper 0.9.5 (runner=fixer, agent=codex) --------- Co-authored-by: Looper <looper@noreply.github.com>	2026-06-05 03:00:55 +00:00
Tom Huang	c6722d2671	feat: Lexical composer, interactive terminals, comment attachments & browser reference board (#3516) ... * feat(daemon): add interactive terminal support with node-pty - Introduced a new terminal service to manage interactive terminal sessions. - Added routes for creating, streaming, and managing terminal sessions in the daemon. - Integrated terminal functionality into the CLI, allowing users to open interactive shells. - Updated project routes to support conversation seeding for side chats. - Enhanced the web application to include terminal tab functionality and UI components. This feature enables users to interact with a terminal directly within the application, enhancing the overall user experience and providing a more integrated development environment. * feat(web): implement embedded browser module in Design Files workspace - Added a `+` icon to the Design Files tab for opening a new Browser module. - The Browser module supports navigation features including back, forward, refresh, and address input. - Integrated a curated list of design reference URLs for user convenience. - Implemented browser data clearing functionality via IPC. - Enhanced desktop runtime to support embedded browser with appropriate security measures. - Added tests for browser functionality and URL handling. This commit establishes a new workspace for browsing and referencing design resources directly within the application, improving user experience and accessibility to design tools. * refactor(web): enhance add tab menu functionality in FileWorkspace - Updated the add tab button to toggle the visibility of the menu with improved accessibility attributes. - Refactored the add menu to be portaled to the document body for better positioning and visibility. - Adjusted CSS styles for the add menu to use fixed positioning and increased z-index for proper layering. - Minor CSS adjustments in entry layout for consistent padding. These changes improve the user experience when adding new modules in the FileWorkspace, ensuring the add menu is more accessible and visually consistent. * feat(daemon): introduce session mode for conversations - Added a new `session_mode` column to the `conversations` table with a default value of 'design'. - Implemented logic to handle `session_mode` in conversation creation, updates, and retrieval. - Enhanced the API to support `session_mode` in conversation requests, allowing for 'chat' or 'design' modes. - Updated the web application to include a session mode toggle, enabling users to switch between chat and design modes seamlessly. - Adjusted system prompts to reflect the current session mode, providing context-aware responses. This feature enhances the user experience by allowing for more flexible conversation management, catering to different interaction styles. * feat(web): enhance navigation and settings functionality in DesignBrowserPanel and EntryShell - Introduced a navigation stack in DesignBrowserPanel to manage back and forward navigation states. - Updated the browser navigation logic to handle URL history and improve user experience. - Added a settings menu in EntryShell for quick access to language and appearance options. - Implemented CSS styles for the new settings menu, ensuring a consistent and user-friendly interface. - Enhanced tests for navigation functionality and settings menu interactions. These changes improve the overall usability of the application by streamlining navigation and providing easy access to settings. * feat(daemon): enhance conversation session mode handling - Added a new `mode` flag to CLI commands for project and conversation creation, allowing users to specify 'design' or 'chat' modes. - Implemented `normalizeChatSessionModeFlag` function to validate and normalize session mode inputs. - Updated project routes to handle session mode during conversation creation and updates. - Enhanced web components to support session mode changes, including new props and handlers for managing session modes in conversations. - Adjusted UI elements to reflect the current session mode, improving user experience and interaction flexibility. This update provides a more robust framework for managing conversation modes, catering to diverse user needs and enhancing overall functionality. * feat(web): enhance HandoffButton and DesignBrowserPanel with improved functionality and styling - Updated HandoffButton to support framework-specific CLI prompts and improved local project path handling. - Enhanced DesignBrowserPanel to manage browser history with favicon support and improved address display. - Introduced new utility functions for formatting addresses and extracting hostnames. - Refactored CSS styles for better layout and responsiveness across components. - Added tests for new functionalities in HandoffButton and DesignBrowserPanel, ensuring robust behavior. These changes improve user experience by streamlining the handoff process and enhancing the design browsing capabilities within the application. * feat(web): enhance HandoffButton and ProjectView with improved instructions handling and UI updates - Updated HandoffButton to include a tabbed interface for switching between editor and CLI options, enhancing user experience. - Added support for opening the AMR website directly from the HandoffButton. - Refactored ProjectView to implement a modal for custom instructions, allowing users to edit and review instructions more intuitively. - Improved CSS styles for project instructions modal and handoff menu, ensuring better layout and responsiveness. - Added keyboard accessibility for closing the instructions modal with the Escape key. These changes streamline the handoff process and improve the usability of custom instructions within the application. * feat(daemon): add social share functionality and project folder management - Introduced new `share` command in CLI for building localized social-share targets for Open Design projects. - Implemented `printShareUsage` and `runShare` functions to handle share requests and display usage instructions. - Added API routes for social sharing, allowing users to create shareable links for projects. - Enhanced project routes with new endpoints for listing and creating project folders, improving project organization. - Updated relevant files and tests to support new functionalities, ensuring robust behavior. These changes enhance user experience by facilitating social sharing and better project management within the application. * feat(web): enhance DesignBrowserPanel and DesignFilesPanel with improved address formatting and drag-and-drop functionality - Refactored `formatAddressDisplay` to utilize a new `formatAddressDisplayParts` function, separating URL and title handling for better clarity. - Updated `DesignFilesPanel` to improve drag-and-drop interactions, including enhanced directory navigation and file management features. - Adjusted CSS styles for better visual consistency and responsiveness across components. - Added tests for new functionalities in `DesignBrowserPanel` and `DesignFilesPanel`, ensuring robust behavior. These changes improve user experience by streamlining address formatting and enhancing file management capabilities within the application. * feat(web): enhance DesignBrowserPanel and DesignFilesPanel with new reference categories and improved folder creation - Added new reference categories in DesignBrowserPanel, including 'Inspiration', 'Real Interfaces', 'Color', 'Typography', and more, each with curated design resources. - Improved folder creation logic in DesignFilesPanel to suggest names based on existing folders, enhancing user experience. - Updated CSS styles for better layout and responsiveness across components, particularly in control rows and search functionalities. - Added tests for new reference categories and folder creation features, ensuring robust functionality. These changes enrich the design resource catalog and streamline folder management, improving overall usability within the application. * feat(web): implement reference icon functionality and enhance social share features - Replaced favicon URL generation with a new `referenceIconUrl` function to provide reliable icons for curated design sites, improving visual consistency in the DesignBrowserPanel. - Updated the FileViewer component to enhance social share functionality, including clearer messaging for protected deployments and improved UI for sharing links. - Added CSS styles to support new visual states for social share components, ensuring better user experience. - Expanded tests for the new `referenceIconUrl` function and social share interactions, ensuring robust functionality. These changes enhance the design resource presentation and improve the sharing experience within the application. * feat(web): enhance DesignFilesPanel and FileViewer with improved folder management and social share functionality - Added optimistic folder path management in DesignFilesPanel to improve user experience during folder creation. - Updated social share logic in FileViewer to handle protected deployments more effectively, ensuring clearer messaging and UI updates. - Refactored CSS styles for better layout and responsiveness in both components, enhancing overall usability. - Expanded tests for new folder management features and social share interactions, ensuring robust functionality. These changes streamline folder management and enhance the social sharing experience within the application. * feat(daemon): enhance project tab management with new state handling - Updated database schema to include a new `state_json` column in the `tabs_state` table for improved project tab state management. - Implemented functions to normalize and parse project tab states, including handling browser workspace tabs. - Modified `listTabs` and `setTabs` functions to utilize the new state management features, allowing for better tracking of active tabs and saved states. - Refactored related types in the contracts and web applications to support the new tab state structure. These changes improve the functionality and user experience of managing project tabs within the application. * feat(web): enhance project tab management and browser tab functionality - Updated project routes and server logic to include `browserTabs` in the request body, improving tab state management. - Implemented validation for `browserTabs` to ensure it is an array, enhancing error handling. - Refactored `setTabs` function to accommodate the new structure for managing tabs, including browser-specific tabs. - Added tests for browser tab state persistence and management in the new `project-tabs-state.test.ts` file, ensuring robust functionality. These changes improve the user experience by providing better management and persistence of project and browser tabs within the application. * feat(web): enhance ProjectView with improved chat send management and UI updates - Added support for queue-only chat sends, allowing for better handling of messages during busy conversations. - Refactored chat send functions to improve state management and persistence of queued messages. - Updated CSS styles in the DesignFilesPanel for better layout and responsiveness, including search control enhancements. - Expanded tests for new chat send functionalities and search interactions, ensuring robust behavior. These changes improve the user experience by streamlining chat interactions and enhancing the overall design file management interface. * feat(web): improve project tab state management and caching - Enhanced the `loadTabs` function to utilize cached tab states, improving performance and user experience during data fetching. - Implemented `normalizeTabsState` and caching functions to manage tab states effectively, including validation and error handling. - Updated `writeCachedTabs` to ensure the latest state is stored in local storage, facilitating better persistence of tab information. - Modified `listTabs` in the daemon to include `updatedAt` in the state retrieval, allowing for more accurate tracking of tab updates. These changes streamline tab management and enhance the overall responsiveness of the application. * feat(web): integrate Lexical for enhanced text composition and mention handling - Added Lexical as a dependency to improve text composition capabilities within the chat interface. - Implemented mention functionality with the creation of `MentionNode` and related serialization/deserialization logic for inline mentions. - Enhanced `ChatComposer` and `ChatPane` components to support queue-only message sending and improved state management for queued messages. - Updated `DesignBrowserPanel` and `PreviewDrawOverlay` to incorporate new features for capturing and annotating browser snapshots. - Refactored various components to streamline interactions and improve user experience during chat and design tasks. These changes significantly enhance the text editing experience and provide better management of chat interactions, improving overall usability in the application. * feat(workspace): integrate terminal viewer and enhance chat functionality - Added a new terminal viewer component with customizable themes and improved styling for better user experience. - Integrated terminal functionality into the workspace, allowing users to interact with a terminal directly within the application. - Updated chat components to support active conversation states, enabling seamless message handling and interaction. - Refactored chat-related props and state management to enhance performance and maintainability. - Removed deprecated file tree explorer components to streamline the workspace interface. This update enhances the overall functionality of the workspace, providing users with a more integrated and responsive environment for both terminal and chat interactions. * feat(workspace): enhance chat and session mode functionality - Introduced a new `+` launcher in the workspace for easy access to project files and new tabs, including Side Chat and Terminal. - Added Side Chat functionality that allows users to create context-aware conversations based on existing chats. - Implemented a new terminal tab type for interactive terminal sessions using `node-pty`, enabling users to run shell commands directly within the workspace. - Enhanced chat functionality with a new session mode toggle, allowing users to switch between 'design' and 'chat' modes seamlessly. - Added a feature to copy chat responses as markdown to the clipboard, improving usability and sharing capabilities. - Updated various components and styles to support these new features, ensuring a cohesive user experience. This update significantly improves the workspace's interactivity and usability, providing users with more tools for collaboration and development. * feat(workspace): enhance session mode toggle and chat functionality - Improved the SessionModeToggle component to include localized guidance cards that provide context-aware descriptions for each mode. - Updated the UI to display a popover with mode descriptions when hovering over options, enhancing user understanding of the available modes. - Added a new copy button in the AssistantMessage footer to allow users to copy responses as raw Markdown, improving usability for external documentation. - Enhanced localization support by updating i18n keys and translations for various languages, ensuring consistent user experience across different locales. - Refactored styles for the session mode toggle and associated components to improve layout and responsiveness. This update significantly enhances the user experience by providing clearer guidance and improved functionality in chat interactions. * feat(styles): enhance session mode toggle styling for improved visibility - Added new CSS rules to ensure the session mode toggle popover and hover cards are displayed correctly with increased z-index and visibility. - Updated styles for various chat components to maintain consistent positioning and overflow behavior when session mode elements are present. - Improved overall layout responsiveness for chat interactions, enhancing user experience during mode transitions. This update refines the visual presentation of session mode toggles, ensuring they are more accessible and user-friendly. * feat(web): finish Lexical composer input with atomic mention pills * fix(web): make browser reference board scroll with a pinned toolbar The browser tab's default Reference Board (.db-start) is wrapped by PreviewDrawOverlay's position:absolute container, which is not a flex parent — so .db-start's flex:1 1 auto never bounded its height and the board grew to its content height instead of scrolling (and the sticky .db-reference-toolbar could not pin). Fill the overlay with height:100% like the .db-webview/.db-fallback siblings already do, restoring scroll and the sticky toolbar. * test(daemon): expect updatedAt in persisted tab state round-trip listTabs() returns the tabs_state row's updatedAt timestamp on the saved-state path, but these two toEqual assertions predated that field and failed strictly. Match the real shape with expect.any(Number). * feat(chat): enhance ChatComposer with session mode management and UI improvements - Introduced a new `sessionMode` prop to the ChatComposer, allowing users to switch between different session modes (e.g., 'design'). - Added a SessionModeToggle component for improved user interaction and visibility of session options. - Updated the ToolsTab type to reflect the removal of the pet option, streamlining the tools available in the composer. - Refactored styles to enhance the visibility and positioning of session mode elements, ensuring a better user experience during mode transitions. - Improved the handling of draft state and user interactions within the composer, enhancing overall functionality. These changes significantly improve the ChatComposer's usability and flexibility, providing users with clearer options and a more responsive interface. * feat(chat): implement caret floating layer for mention and slash popovers - Introduced a new `CaretFloatingLayer` component to manage the positioning of mention and slash command popovers relative to the caret. - Enhanced `ChatComposer` to utilize the caret rectangle for accurate popover placement, improving user experience during text input. - Updated `LexicalComposerInput` to pass caret position data to the trigger handling logic, allowing for dynamic popover adjustments. - Refactored styles for popovers to ensure consistent appearance and behavior, including improved animations and responsiveness. - Added accessibility features to mention and slash popovers, enhancing usability for keyboard navigation. These changes significantly improve the interaction model for mentions and commands within the chat interface, providing a more intuitive and responsive user experience. * feat(chat): update mention tab order and improve search functionality - Reordered the mention tab sections in the ChatComposer to prioritize 'Design files' over other categories, enhancing user experience during mentions. - Updated the search prompt to reflect the new tab order, ensuring clarity in search functionality. - Enhanced the mention selection logic to accommodate the new tab structure, allowing for a more intuitive navigation experience. - Added tests to verify the correct display and functionality of the updated mention tabs and search behavior. These changes significantly improve the usability of the mention feature within the chat interface, making it easier for users to find and select relevant items. * feat(chat): enhance context management in ChatComposer and HomeHero - Added functionality to manage MCP servers and connectors within the ChatComposer, allowing users to remove these contexts seamlessly. - Updated the HomeHero component to support the selection and removal of MCP servers and connectors, improving context handling in user interactions. - Enhanced the search prompt to include files, ensuring users can search across all relevant categories. - Refactored related components and styles for better integration and user experience. - Added tests to verify the correct functionality of the new context management features. These changes significantly improve the usability of context features in the chat interface, making it easier for users to manage their interactions effectively. * feat(chat): enhance message handling with session mode and plugin snapshot support - Added new columns to the database schema for `session_mode` and `applied_plugin_snapshot_json` to support enhanced message context. - Updated the `upsertMessage` and `listMessages` functions to handle the new fields, ensuring messages can store and retrieve session mode and plugin snapshot data. - Enhanced the `ChatComposer` to manage and send the applied plugin snapshot as part of the message context, improving user interaction with plugins. - Introduced a new `MessageSessionModeChip` component to visually represent the session mode in the chat interface. - Updated styles for better presentation of session mode and plugin context within messages, enhancing user experience. These changes significantly improve the context management capabilities in the chat interface, allowing for richer interactions and better tracking of session-specific data. * feat(chat): add annotation handling and UI improvements in ChatComposer and PreviewDrawOverlay - Implemented functionality to stage draw annotations into the composer input without sending, enhancing user interaction. - Added a new button in the PreviewDrawOverlay to allow users to append notes to the input, improving workflow flexibility. - Updated the ChatComposer tests to verify the correct staging of annotations and their integration into the input. - Enhanced internationalization support by adding new translation keys for annotation actions across multiple languages. These changes significantly improve the user experience by providing more intuitive annotation handling and better integration within the chat interface. * feat(capture): implement page capture functionality and enhance folder management dialogs - Added new capture functionality to allow users to take snapshots of the current page, improving user interaction with visual content. - Introduced in-app dialogs for folder creation and moving files, replacing the unsupported window.prompt in the Electron desktop host, enhancing usability across platforms. - Updated the DesignFilesPanel to support these new dialogs, ensuring a seamless experience for managing project files. - Enhanced internationalization support by adding new translation keys for folder management actions across multiple languages. These changes significantly improve the user experience by providing intuitive capture options and streamlined file management within the application. * feat(projects): implement folder deletion and enhance project file management - Added a new API endpoint to delete project folders, improving the file management capabilities within the application. - Introduced utility functions for ensuring project subdirectories and safely deleting folders, enhancing the robustness of folder operations. - Updated the DesignFilesPanel and FileWorkspace components to support folder deletion actions, providing users with a more intuitive interface for managing project files. - Enhanced internationalization support by adding new translation keys for folder management actions. These changes significantly improve the user experience by streamlining folder management and providing clearer options for users to organize their projects effectively. * feat(composer): enhance BoardComposerPopover with image attachment functionality - Added support for attaching images to comments, allowing users to upload and preview images directly within the composer. - Implemented new handlers for image input changes and clipboard pasting, improving the user experience for image uploads. - Updated the component's props to include image-related callbacks and state management for attached images. - Enhanced styles for image thumbnails and removal buttons, ensuring a cohesive design with the existing comment popover interface. These changes significantly improve the functionality of the BoardComposerPopover, providing users with a more interactive and visually rich commenting experience. * feat(file-viewer): enhance comment attachment functionality with image support - Updated the `onSendBoardCommentAttachments` prop to accept an additional `images` parameter, allowing for image attachments alongside comments. - Introduced state management for handling attached images, including functions to add and remove images, and to generate previews. - Implemented a modal for previewing attached images, improving user interaction when managing comment attachments. - Updated the `FileWorkspace` component to reflect changes in the props, ensuring consistency across components. These enhancements significantly improve the commenting experience by enabling users to attach and preview images directly within the file viewer. * feat(home-hero, project-view, styles): enhance functionality and user experience - Updated the HomeHero component to prevent unnecessary state changes during programmatic updates, improving user interaction with prompts. - Enhanced the ProjectView component to support image attachments alongside comments, allowing for a more versatile commenting experience. - Implemented a new image upload process that queues tasks efficiently, ensuring smooth handling of comment attachments. - Added CSS to reserve scrollbar space in design files, preventing layout shifts when scrollbars appear, thus enhancing visual stability. These changes collectively improve the user experience by streamlining interactions and ensuring consistent UI behavior across components. * feat(preview-comments, chat): enhance comment functionality with attachment support - Added support for `attachments_json` in the `preview_comments` table, allowing users to attach files to comments. - Updated relevant functions to handle attachments, including `upsertPreviewComment` and `listPreviewComments`, ensuring attachments are properly managed and displayed. - Enhanced the `CommentSidePanel` to render attached files, providing users with a visual representation of their attachments. - Improved the `BoardComposerPopover` and `ChatPane` components to support image attachments, including drag-and-drop functionality for reordering queued sends. These changes significantly enhance the commenting experience by enabling users to attach and manage files directly within the chat interface, improving overall usability and interaction. * refactor(comment-attachments): rename attachment normalization functions for clarity - Updated the `normalizeCommentAttachments` function to `normalizePreviewCommentAttachments` for better context in handling preview comment attachments. - Adjusted the `upsertPreviewComment` and `normalizePreviewComment` functions to utilize the renamed attachment normalization function. - Added tests to ensure that image attachments are correctly saved and retrieved, addressing a regression issue with attachment persistence. These changes enhance code clarity and maintainability while ensuring the functionality for handling comment attachments remains robust. * feat(comment-attachments): enhance comment submission with image and note validation - Updated the `upsertPreviewComment` function to require either a text note or at least one image attachment for comment submission, improving validation logic. - Modified the `BoardComposerPopover` to allow saving comments with only images, enhancing user experience by simplifying the commenting process. - Adjusted the `FileViewer` to support saving comments with image-only notes, ensuring consistency across components. - Improved styles in the chat and home hero components for better visual representation of attachments and comments. These changes collectively enhance the commenting functionality, providing users with more flexibility in how they submit comments while ensuring robust validation. * feat(project-view): implement auto-start for queued chat sends - Replaced the `startingQueuedChatSendIdRef` with a state variable `queuedAutoStartBlocked` to manage the auto-start behavior of queued chat sends. - Updated the `useEffect` to ensure that queued sends are processed one at a time after the active conversation completes, enhancing the chat experience. - Added a test to verify that queued sends auto-start correctly after the active run finishes, ensuring reliable functionality. These changes improve the handling of queued chat messages, providing a smoother user experience during conversations. * feat(project-view): refine auto-start logic for queued chat sends - Replaced the state variable `queuedAutoStartBlocked` with a reference `startingQueuedChatSendIdRef` to manage the auto-start behavior of queued chat sends more effectively. - Updated the `useEffect` to ensure that queued sends are processed sequentially, improving the handling of chat messages during active conversations. - Introduced a new state variable `queuedAutoStartTick` to track the auto-start process, enhancing the responsiveness of the chat interface. These changes improve the reliability and user experience of the chat functionality by ensuring queued messages are handled smoothly and efficiently. * feat(comment-attachments): improve attachment handling in preview comments - Updated the `upsertPreviewComment` function to merge existing and incoming attachments, ensuring that image attachments are preserved when updating comments without new files. - Introduced a new helper function, `mergePreviewCommentAttachments`, to handle the merging of attachments without duplicates, enhancing the robustness of attachment management. - Added tests to verify the correct merging of attachments and the preservation of existing attachments during comment updates, improving overall functionality and user experience. These changes enhance the commenting system by providing better management of image attachments, ensuring users can update comments seamlessly while retaining their attached images. * feat(BoardComposerPopover): enhance popover positioning and measurement - Updated the `popoverAnchorStyle` function to incorporate viewport scroll positions, ensuring the popover remains within visible bounds. - Introduced a new `PopoverSize` type to manage measured dimensions, improving the accuracy of popover placement. - Implemented a `useLayoutEffect` to dynamically measure the popover size and adjust its position accordingly, enhancing user experience during interactions. - Added tests to verify that the popover correctly adjusts its position based on target and viewport dimensions, ensuring it remains fully visible. These changes improve the usability of the BoardComposerPopover by ensuring it is properly positioned within the viewport, enhancing the overall commenting experience. * feat(comment-attachments): enhance image attachment handling in comments - Updated the `normalizeCommentAttachments` function to include image attachments in the comment payload, allowing comments to be submitted with only images. - Introduced a fallback message for comments that consist solely of image attachments, improving user guidance. - Enhanced the `renderCommentAttachmentHint` function to display image attachment details, ensuring users are informed about attached images. - Added tests to verify that image attachments are preserved in comment submissions and correctly rendered in hints, improving overall functionality and user experience. These changes enhance the commenting system by providing better support for image-only comments, ensuring users can effectively utilize image attachments in their interactions. * feat(comment-attachments): refine comment context handling and enhance drag-and-drop functionality - Updated the `normalizeCommentAttachments` function to conditionally omit comment text when the context is set to 'query', improving clarity in comment submissions. - Enhanced the `renderCommentAttachmentHint` function to only display comments when not in 'query' context, ensuring a cleaner output. - Implemented drag-and-drop functionality in the `CommentSidePanel` for reordering comments, improving user interaction and organization of comments. - Added tests to verify the correct handling of comment context and the functionality of the drag-and-drop feature, ensuring robust performance. These changes enhance the commenting system by providing clearer context management and improved usability through drag-and-drop capabilities. * feat(FileViewer, ProjectView): enhance comment attachment handling and status updates - Updated the `FileViewer` component to manage the state of sent comment IDs, ensuring that active previews are correctly updated after sending comments. - Refined the `ProjectView` component to filter out comment attachments from the board-batch source and update their status to 'applying' during processing, improving user feedback on attachment handling. - Introduced logic to handle the removal of sent comment IDs from the preview, enhancing the overall user experience when managing comments and attachments. These changes improve the functionality and responsiveness of the commenting system, providing clearer feedback and better management of comment attachments. * feat(conversation-forking): introduce message-based conversation forking - Added the ability to fork conversations from a specific message, enhancing the chat experience by allowing users to create new conversations that inherit context up to a chosen point. - Updated the CLI commands and help documentation to reflect the new `--fork-after` option, which specifies the message ID to stop copying from. - Enhanced the backend to handle the new forking logic, ensuring that only messages up to the specified ID are included in the new conversation. - Implemented tests to verify the forking functionality, ensuring robust performance and correct behavior when forking conversations. These changes improve the flexibility of conversation management, allowing users to create tailored discussions based on previous interactions. * feat(terminal-service): enhance session output management and memory handling - Introduced new parameters for managing session output, including `maxBufferBytes`, `exitTailBytes`, `flushIntervalMs`, and `flushThresholdBytes`, to optimize memory usage and performance. - Implemented a `trimBuffer` function to efficiently evict old events based on byte and count limits, improving memory management during active sessions. - Added logic to coalesce buffered PTY output into single `data` events, reducing the frequency of event emissions and enhancing performance during high-throughput scenarios. - Updated session event structure to include `byteLength`, allowing for better tracking of output size and memory usage. These changes improve the efficiency and responsiveness of terminal sessions, ensuring better resource management and user experience. * feat(workspace-context): enhance project attachment handling and workspace context management - Introduced `formatProjectAttachmentHint` function to render project attachments in a user-visible order, improving clarity for users referencing attachments. - Added `normalizeWorkspaceContextItems` function to standardize workspace context items, ensuring consistent handling of various context types. - Updated `mergeRunContextSelections` to include workspace items, enhancing the context management during chat interactions. - Enhanced `renderRunContextPrompt` to display active workspace context, providing users with better visibility of their current workspace state. - Implemented tests for new functions to ensure robust functionality and correct behavior in handling project attachments and workspace contexts. These changes improve the user experience by providing clearer context and better management of project attachments within the application. * feat(database, chat): enhance message and conversation data structure - Added `run_context_json` to the `messages` table schema to store contextual information for each message. - Updated migration logic to include the new `run_context_json` field and ensure backward compatibility. - Enhanced conversation retrieval to include `messageCount`, providing better insights into the number of messages per conversation. - Improved attachment handling in the `ChatComposer` component by introducing ordering logic for attachments, ensuring a consistent user experience. - Refactored `SessionModeToggle` to simplify state management and improve tooltip visibility. These changes enhance data management and user interaction within the chat application, providing clearer context and improved functionality. * feat(attachment-handling): improve attachment sorting and context management - Introduced `sortAttachmentsByUserOrder` function to ensure attachments are displayed in a user-defined order, enhancing clarity and usability. - Updated `historyWithApiAttachmentContext` to utilize the new sorting function, improving the context provided with message histories. - Refactored `buildAnthropicMessageContent` to apply sorting for image attachments, ensuring consistent handling across different message types. These changes enhance the user experience by providing better organization and visibility of attachments within the chat application. * feat(chat): enhance conversation listing and loading states - Improved the SQL query for listing conversations to include message counts, providing better insights into conversation activity. - Added loading states to the ChatPane component, enhancing user experience during data fetching. - Implemented a search feature in the conversation history, allowing users to filter conversations by title for easier navigation. - Updated styles for loading indicators and conversation list to improve visual feedback during loading states. These changes enhance the usability and responsiveness of the chat interface, providing users with clearer context and improved interaction capabilities. * feat(chat): optimize suggestion filtering and enhance design system integration - Refactored suggestion filtering in the ChatComposer component to utilize `useMemo`, improving performance by memoizing results based on dependencies. - Added new props in ChatPane for handling plugin and design system details, enhancing the integration of these features within the chat interface. - Updated the FileWorkspace component to manage tab states for design system and browser tabs, improving user navigation and context management. - Introduced modals for displaying plugin and design system details in the ProjectView, enhancing user experience by providing contextual information. These changes improve the efficiency of suggestion handling and enhance the overall user experience in managing plugins and design systems within the chat application. * fix(chat): adjust styling and layout for improved chat interface - Reduced the conversation row height in ChatPane for better alignment with design specifications. - Updated CSS styles across various components to enhance layout consistency, including adjustments to margins, padding, and flex properties. - Improved visual feedback and responsiveness in chat elements, ensuring a more cohesive user experience. These changes refine the chat interface, making it more visually appealing and user-friendly. * feat(comments): implement structural equality checks for comment snapshots - Added `commentSnapshotOverlayEqual` and `commentSnapshotEqual` functions to compare comment snapshots based on their structural properties, improving performance by avoiding unnecessary state updates in the `FileViewer` component. - Updated `HtmlViewer` to utilize these equality checks, optimizing the handling of live comment targets during pointer movements and hover events. - Enhanced the overall responsiveness of the comment system by preventing redundant re-renders when comment snapshots remain unchanged. These changes enhance the efficiency of comment handling and improve user experience in the commenting interface. * feat(chat): enhance comment attachment sorting and order management - Introduced `sortChatCommentAttachmentsByOrder` function to ensure comment attachments are displayed in a user-defined order, improving clarity and usability. - Updated the `currentCommentAttachments` function to utilize the new sorting logic, enhancing the organization of attachments. - Adjusted the order assignment for visual attachments to ensure consistent handling based on existing attachment orders. These changes improve the user experience by providing better organization and visibility of comment attachments within the chat application. * feat(chat): enhance queued send strip with overflow handling and styling improvements - Added overflow handling to the queued send strip, allowing for better visibility of additional queued items when the list exceeds the visible limit. - Updated CSS styles for the chat components, including adjustments to layout, padding, and font sizes to improve overall aesthetics and usability. - Refactored the structure of the queued send row to utilize a grid layout, enhancing alignment and responsiveness of the elements within the chat interface. These changes improve the user experience by providing clearer visibility of queued messages and a more polished interface. * feat(database): add index for created_at and enhance comment retrieval - Introduced a new index on `preview_comments` for `created_at` to optimize query performance when retrieving comments. - Updated the `listPreviewComments` function to order results by `created_at` and `rowid`, improving the organization of displayed comments. - Enhanced the test suite to verify the injection of the new URL preview selection bridge and its functionality in various scenarios. These changes improve the efficiency of comment retrieval and enhance the user experience in the commenting interface. * feat(tooltip): implement tooltip system for enhanced user guidance - Introduced a new `TooltipLayer` component to manage tooltip display across the application, improving user interaction by providing contextual information on hover and focus. - Updated various components to utilize the tooltip system, including buttons and icons, ensuring consistent tooltip behavior and styling. - Enhanced CSS styles for tooltips, improving visibility and responsiveness, while maintaining a cohesive design across the application. These changes enhance the user experience by providing clearer guidance and improving the overall usability of interactive elements. * feat(tooltip): enhance tooltip integration across components - Updated various components to include tooltip functionality, improving user guidance with contextual information on hover and focus. - Added `data-tooltip` and `data-tooltip-placement` attributes to buttons and interactive elements for consistent tooltip behavior. - Enhanced CSS styles to ensure tooltips are displayed correctly and responsively, maintaining a cohesive design across the application. These changes improve the overall user experience by providing clearer guidance and enhancing the usability of interactive elements. * feat(project-view): refactor comment handling and enhance tooltip positioning - Introduced `mergeSavedPreviewComment` function to streamline the management of preview comments, improving clarity and maintainability. - Updated `ProjectView` to utilize the new comment merging function, enhancing the efficiency of comment updates. - Refactored `TooltipLayer` to use x and y coordinates for positioning, improving tooltip display accuracy and responsiveness. - Enhanced CSS styles for tooltips, ensuring better visibility and layout consistency across the application. These changes improve the user experience by providing more efficient comment handling and refined tooltip interactions. * feat(design-files): enhance workspace hint and file handling in project context - Introduced `formatDesignFilesWorkspaceHint` function to provide a detailed overview of the current Design Files workspace, including folder and file listings. - Added limits for the number of folders and files displayed to improve clarity and prevent overwhelming users with excessive information. - Updated the `startServer` function to integrate the new workspace hint, ensuring that the context of existing project files and folders is communicated effectively. - Enhanced tests for the new workspace hint functionality to ensure accurate representation of project context. These changes improve user experience by providing clearer insights into the Design Files workspace and facilitating better project management. * feat(composer): atomic @mention keyboard navigation and deletion * feat(database): add attachments_json field to comments and enhance migration logic - Introduced `attachments_json` field in the database schema for comments to support attachment storage. - Updated migration functions to include the new field, ensuring existing data is properly migrated. - Refactored related SQL queries to accommodate the new field, improving data handling for comments. These changes enhance the comment functionality by allowing attachments to be stored and retrieved effectively. * chore(nix): refresh pnpm deps hash * feat(chat-composer): implement design toolbox for enhanced design actions - Added a new design toolbox feature to the ChatComposer, allowing users to access various design actions such as 'auto-match', 'motion', and 'visual-polish'. - Introduced a state management system for the design toolbox, including hooks for opening and closing the toolbox. - Enhanced the user interface with new components and styles for the design toolbox, improving accessibility and usability. - Implemented functionality to apply design actions directly from the toolbox, streamlining the design workflow. - Added tests to ensure the correct behavior of the design toolbox and its interactions within the ChatComposer. These changes significantly enhance the design capabilities within the ChatComposer, providing users with a more efficient and intuitive design experience. * feat(chat-composer): enhance design toolbox resource management - Expanded the design toolbox functionality in ChatComposer to include a comprehensive resource index, allowing for better organization and retrieval of skills, plugins, MCP servers, templates, connectors, and project files. - Introduced new types and interfaces to support the expanded resource management, improving type safety and clarity in the codebase. - Updated the design toolbox action descriptions and search functionality to reflect the new resource capabilities, enhancing user experience. - Added tests to validate the new resource indexing and search features, ensuring robust functionality. These enhancements significantly improve the design workflow by providing users with a more organized and efficient way to access various design resources. * feat(workspace): enhance workspace context management and UI integration - Introduced a new function `renderWorkspaceContextToolHints` to provide contextual hints based on the type of workspace items (browser, terminal, files, live artifacts). - Updated `ChatComposer`, `ChatPane`, and `FileWorkspace` components to support and display workspace context items, improving user interaction and accessibility. - Enhanced the `QuickSwitcher` and `TabLauncherMenu` components to include workspace context items in search results, allowing users to navigate between tabs and files more efficiently. - Added new translations and updated existing ones to reflect the inclusion of workspace tabs in the user interface. These enhancements significantly improve the usability and functionality of the workspace, providing users with better context and navigation options. * test(e2e): assert Lexical composer content with toHaveText, not toHaveValue The chat composer and home hero input are now Lexical contenteditable editors, not native form controls, so Playwright's toHaveValue (form-only) fails with "Not an input element". Switch all chat-composer-input and home-hero-input content assertions to toHaveText, and assert multi-line soft-break cases with separate toContainText checks since the editor's textContent collapses the newline (the newline reaching the sent payload is already covered by downstream message/payload assertions). * chore(nix): refresh pnpm deps hash * chore(nix): refresh pnpm deps hash * test(e2e): open settings through the entry settings menu The home settings entry is now a menu (EntrySettingsMenu): clicking the gear opens a popover whose "Settings" item opens the full execution-mode dialog. Update the three specs that assumed a single click opened the dialog directly to go through the menu trigger + open-details item. * test(web): drive HomeView context picker through the Lexical helper The home hero input is a Lexical contenteditable, so fireEvent.change / reading .value throws "element does not have a value setter". Switch the MCP+connector first-turn-context spec to setHomeHeroPrompt / homeHeroPromptText like the rest of the file already does. * Fix PR review blockers * Update Nix pnpm deps hash * Enhance project folder routes with error handling and tests - Added checks for project existence in GET, POST, and DELETE folder routes, returning a 404 error if the project is not found. - Updated tests to verify 404 responses for unknown project IDs in folder operations. - Improved folder metadata handling in project routes. - Refactored the TabLauncherMenu component for better UI structure and scrolling behavior. - Adjusted styles for the TabLauncherMenu to improve usability and visual consistency. * Update ProjectView component and enhance design toolbox localization - Modified the ProjectView component to include workspacePanelTrack in chat panel width adjustments. - Updated localization files to add new keys and translations for the design toolbox in English, Simplified Chinese, and Traditional Chinese. - Enhanced user experience by providing comprehensive tooltips and prompts for design toolbox actions. * Add browser use prompt launcher * Cover browser use prompt launcher * Add design toolbox badge translations * Refactor ChatComposer and DesignBrowserPanel components - Removed the design system picker from the ChatComposer component and integrated it into the StagedRunContexts for better context handling. - Updated the DesignBrowserPanel to include a new function for determining viewport icons and modified the browser use categories to reflect changes in action prompts and titles. - Enhanced the HandoffButton component with a new feature to copy the project path to the clipboard, improving user experience. - Added new styles for search input and empty states in design files, enhancing the UI consistency across components. * Enhance ChatPane and DesignBrowserPanel components with new features and styles - Added scroll handling features to the ChatPane component, including scrollable state management and improved user experience during chat interactions. - Updated the DesignBrowserPanel to include new localization keys and improved category titles for better clarity in the browser use prompt. - Enhanced styles for chat log scrolling behavior, providing a more intuitive interface for users. - Implemented keyboard shortcuts for tab navigation in the WorkspaceTabsBar, improving accessibility and user efficiency. * Fix web workspace test hang * Update styles and functionality for workspace tabs and chat components - Adjusted CSS for the MAC_WINDOW_CHROME to improve spacing and margins for better layout. - Enhanced the ChatComposer component to ensure proper tab order and mention handling, improving user experience. - Implemented keyboard shortcuts for navigating workspace tabs, allowing for more efficient tab management. - Updated localization strings for clarity in search prompts across multiple languages. - Improved the HandoffButton component's UI for better visibility and interaction when copying project paths. * Update visual settings flow * Refresh Nix pnpm deps hashes --------- Co-authored-by: open-design-bot[bot] <282769551+open-design-bot[bot]@users.noreply.github.com> Co-authored-by: qiongyu1999 <2694684348@qq.com> Co-authored-by: Siri-Ray <2667192167@qq.com>	2026-06-03 15:46:22 +00:00
lefarcen	fa59871428	Merge origin/main into release/v0.9.0 — back-merge to reconcile v0.9.0 with main ... Syncs release/v0.9.0 with main so PR #3282 (release/v0.9.0 → main) merges cleanly. 17 conflicts resolved by commit-time + per-area ownership: - Comment/edit/preview: keep main (newer). FileViewer combines main's #3438 (pin manual-edit inspector, no full-height panel) + #3347 deck/queue work WITH release's #3401 hover-card anti-flicker grafted on; #2879 Button kept. - Toolbar: footer layout (reviewer-validated, ca03a7e0f) overrides main #3447 — CLI/agent selector in the composer footer, settings gear in the header, no settings item in the AvatarMenu dropdown. - AMR: keep release's client-side model polling (mergeAmrModelsIntoAgents) and all release AMR fixes (#3450 sign-out, #3504 console, #3487 acp tool-only guard, amrCloudVisible onboarding, #3511 analytics provider id). - Pet composer button stays removed (release decision); only /pet slash props retained. - Pickers: main's providerModelsCache approach. Validation: web typecheck + guard + full web suite (2638) + daemon suite green.	2026-06-03 17:21:00 +08:00
kami	333a62cda6	fix: link od bin after fresh install (#2069) ... * fix: link od bin after fresh install * test: lock root od bin shim path * test: cover root workspace deps in postinstall scan * chore(nix): refresh pnpm deps hash	2026-05-31 04:36:49 +00:00
lefarcen	e69306ecbe	chore(release): prepare 0.9.0	2026-05-29 15:40:34 +08:00
lefarcen	df8a0faff6	feat(runtimes): register AMR (vela) as an ACP stdio agent (#2355) ... * feat(runtimes): register AMR (vela) as an ACP stdio agent AMR is the vela CLI's ACP runtime mode. `vela agent run --runtime opencode` speaks ACP JSON-RPC over stdio (see vela's `specs/current/runtime/manual-agent-run-openrouter.md`); per `docs/new-agent-runtime-acp.md` we expose it through the same `streamFormat: 'acp-json-rpc'` transport that already powers Hermes, Devin, Kimi, etc. The new `defs/amr.ts` is the entire wiring — `buildArgs` returns `['agent', 'run', '--runtime', 'opencode']`, `fetchModels` reuses `detectAcpModels`, and the fallback list seeds the OpenRouter ids vela's e2e baseline uses. `executables.ts`/`app-config.ts`/`metadata.ts` get the matching `VELA_BIN`/`VELA_LINK_URL`/`VELA_RUNTIME_KEY`/`VELA_OPENCODE_BIN` allowlist + install/docs URLs, so users can configure the per-agent env in Settings without leaking into other adapters. Coverage: `tests/fixtures/fake-vela.mjs` is a minimal ACP stub that returns the documented `initialize` / `session/new` / `session/set_model` / `session/prompt` shapes; `tests/amr-acp-integration.test.ts` spawns it via `child_process.spawn` and drives a full turn through `attachAcpSession` and `detectAcpModels`, so the ACP transport contract for AMR is end-to-end verified locally even before a real `vela` binary is installed. Validated: - pnpm guard - pnpm typecheck (all workspace projects) - pnpm --filter @open-design/daemon test (2881/2881) Deferred: real OpenRouter-backed turn through a built `vela` binary — the runtime def needs no changes for that path, only `VELA_RUNTIME_KEY` and `VELA_LINK_URL` in env (or Settings). * fix(runtimes/amr): pin a concrete default model and bare openai ids End-to-end validation against a freshly-built `vela` (nexu-io/vela@main) + OpenRouter surfaced two contract details the first AMR runtime def got wrong: 1. vela rejects `session/prompt` with `session/set_model must be called before session/prompt`. attachAcpSession in apps/daemon/src/acp.ts skips set_model whenever the picked model is the synthetic 'default' id, so AMR's fallback list must NOT include DEFAULT_MODEL_OPTION. The def now ships a concrete `gpt-5.4-mini` as both `fetchModels`' default option and `fallbackModels[0]`, which makes attachAcpSession always send a real `session/set_model` for AMR turns. 2. `vela --runtime opencode` auto-prepends `openai/` to whatever modelId it forwards to opencode's openai provider. With OpenRouter-style ids like `openai/gpt-5.4-mini`, opencode receives the double-prefixed `openai/openai/gpt-5.4-mini` and replies `ProviderModelNotFoundError`. The new fallback list ships the bare ids opencode's openai registry actually knows about (gpt-5.4, gpt-5.4-mini, gpt-5.4-fast, etc.). Stub + tests: - tests/fixtures/fake-vela.mjs now enforces the set_model gate the same way real vela does, so a regression that silently goes back to model: 'default' would surface as a fatal error in tests instead of a hidden production failure. - tests/amr-acp-integration.test.ts pins both contracts: no 'default' / no 'openai/' prefix in fallbackModels, and a negative case that asserts session/prompt fails when no model is set. Adds `apps/daemon/scripts/verify-amr-real-vela.mjs` — a small dev-time runner that drives `attachAcpSession` against a real `vela` binary and prints the daemon's chat events, so future protocol drift can be checked against an actual OpenRouter call. Verified locally: `vela agent run --runtime opencode` + OpenRouter returns the prompted string ("AMR-E2E-PASS") through the full daemon pipeline; daemon test suite stays 2883/2883. * fix(runtimes/amr): substitute concrete model when chat run sends 'default' A plugin-driven AMR run from the UI surfaced a real-world hole in the prior commit: json-rpc id 3: session/set_model must be called before session/prompt The Default-design-router plugin (and any caller that doesn't pin a real model) sends `model: 'default'` straight through, which the AMR runtime def cannot accept — vela rejects `session/prompt` without `session/set_model` and attachAcpSession skips set_model whenever model === 'default'. Just leaving DEFAULT_MODEL_OPTION out of the adapter's `fallbackModels` is not enough: the chat-run handler in server.ts still forwarded 'default' verbatim. This adds `resolveModelForAgent(def, resolved, env?)` as the single source of truth for the substitution: 1. If the caller picked a real id, pass it through. 2. Else, if `def.defaultModelEnvVar` is set and the daemon process env has a non-empty value for it, return that (operator escape hatch — see below). 3. Else, if the def's `fallbackModels` does NOT contain a 'default' id, return `fallbackModels[0].id`. 4. Else, return the original value (the historic shape — defs that list 'default' themselves are untouched). AMR sets `defaultModelEnvVar: 'VELA_DEFAULT_MODEL'`, so when opencode's openai-provider registry deprecates `gpt-5.4-mini` upstream, an operator can swap the fallback id without a code change by exporting `VELA_DEFAULT_MODEL=gpt-5.5` before launching tools-dev / od. Worth noting the env var must live in the daemon's `process.env` (Settings-UI per-agent env values only reach the spawned child, not the daemon's resolver) — the new field's docblock spells this out. Coverage: - `tests/runtimes/resolve-model.test.ts` — 8 unit tests covering all four resolver branches plus the env-override happy path / fallback / ignore-when-user-picked-a-real-id case. - `pnpm --filter @open-design/daemon typecheck` clean. * chore(runtimes/amr): move AMR to the top of the base agent list So `AMR (vela)` shows up first in the agent picker / status views, ahead of claude / codex. Pure ordering change; no behavior delta. * feat(amr): Sign-in / Sign-out button on the AMR Settings card The first half of the AMR work assumed the operator would set VELA_RUNTIME_KEY / VELA_LINK_URL on the daemon process and never surfaced login state to users. This adds the missing UX so a fresh install can drive the full path from Settings: - GET /api/integrations/vela/status reads ~/.vela/config.json for the active profile and returns { loggedIn, profile, user } (without leaking the runtime/control keys themselves). - POST /api/integrations/vela/login spawns `vela login` once (409 if one is already in flight). The vela CLI opens the user's browser to the device-authorization page itself — Open Design only needs to kick the subprocess off. - POST /api/integrations/vela/logout removes ~/.vela/config.json so the next status read returns logged-out. `AmrAgentCard` is a dedicated agent-card component for AMR because the existing `<button>` row can't host an interactive sub-control (nested interactive elements). It polls /status after a login click until the daemon reports loggedIn=true (or 5 minutes elapse), and exposes a Sign-out action on hover. Other adapters (claude, codex, hermes, …) keep their existing `<button>` card. i18n: 8 new keys (settings.amrLogin / Logout / LoggingIn / etc.) added to en + zh-CN. Other locales spread `en` and inherit the English copy until translations land. Coverage: - `tests/integrations/vela.test.ts` pins the config.json reader against a tmp HOME — including the negative case where a profile has user info but no runtimeKey (still logged-out), and the secret-leak guard ("rt-secret-*" must not appear in the projection payload). - `tests/components/AmrAgentCard.test.tsx` covers all four UI states (logged-out, logging-in, logged-in, logging-out) plus the click-propagation invariant the divergent card was built to keep. `pnpm --filter @open-design/daemon test` 2901 / 2901 passing. `pnpm --filter @open-design/web test` 1719 / 1719 passing. `pnpm typecheck` + `pnpm guard` clean. Dev script side-effects: `apps/daemon/scripts/verify-amr-real-vela.mjs` no longer requires both VELA_RUNTIME_KEY and VELA_LINK_URL — if VELA_PROFILE is set, the vela CLI is allowed to resolve credentials from `~/.vela/config.json`. Added the two AMR `.mjs` fixtures to `scripts/guard.ts` allowlist with the executable-fixture / dev-runner rationale. * fix(connection-test): substitute model for AMR before attachAcpSession The chat-run path in server.ts already routes the requested model through `resolveModelForAgent` so AMR / vela (whose CLI demands an explicit `session/set_model` before `session/prompt`) gets the def's first concrete fallback id when the chat run ships `model: 'default'`. `connectionTest.ts` was wiring `attachAcpSession({ ..., model: model ?? null })` directly, which made the Test Connection button on the AMR Settings card deadlock with the same `session/set_model must be called before session/prompt` error the chat-run path already handles — surfaced as a permanent "Testing connection…" spinner in the UI. Reuse the same helper here so Test Connection mirrors chat-run behavior. * test(amr): three-layer end-to-end coverage for the AMR login + turn flow The PR up to this point shipped runtime + UI code with unit-level Vitest coverage. This commit adds the cross-layer regression net the live demo relied on: 1. apps/daemon/tests/integrations/vela.routes.test.ts (HTTP, Vitest) Spins up the real daemon Express app via `startServer({port:0,...})`, persists `agentCliEnv.amr.VELA_BIN = <fake>` into app-config.json, and exercises every /api/integrations/vela/* endpoint against the extended fake-vela stub: - status reads ~/.vela/config.json under various states - login spawns the fake, waits for config.json to appear, returns pid + startedAt + profile - 409 already-running guard with the stub's delay knob - logout removes the file (idempotent) - secrets (runtimeKey / controlKey) never leak in the projection - login → status round-trip flips loggedIn=false → true 2. e2e/tests/amr/turn.test.ts (tools-dev orchestrated, Vitest) Boots a namespaced daemon + web pair through `createSmokeSuite`, inlines a self-contained fake `vela` binary that handles BOTH `vela login` (writes ~/.vela/config.json) and `vela agent run --runtime opencode` (ACP stdio with the `session/set_model must precede session/prompt` gate the real binary enforces), then drives a complete /api/runs lifecycle for `agentId: 'amr', model: 'default'` and asserts the assistant message captures the fake's streamed text. This is the test that would have surfaced today's plugin-default-model regression (the `set_model before prompt` error) at PR time instead of demo time. 3. e2e/ui/amr-login-pill.test.ts (Playwright) Mocks /api/agents + /api/integrations/vela/{status,login,logout} to drive the Settings AMR card through the full Sign in → Signed in → Sign out cycle. Pins the AmrLoginPill polling contract and the aria-label semantics (the pill's accessible name is "Sign out" once logged in, regardless of which label the hover-state text shows). fake-vela.mjs extensions: - Handles `vela login` argv by writing ~/.vela/config.json for the active VELA_PROFILE and exiting 0 — mirrors real vela's on-disk side-effect without the device-auth loop. - FAKE_VELA_LOGIN_DELAY_MS knob so route tests can observe the in-flight state of the spawn lifecycle. - FAKE_VELA_LOGIN_USER_EMAIL / _USER_PLAN to assert the surfaced user fields end-to-end. Validated: - `pnpm guard` + `pnpm typecheck` (all workspace projects) - `pnpm --filter @open-design/daemon test`: 2998 / 2998 passing, including the new 8-test integration suite. - `cd e2e && pnpm test tests/amr`: 1 / 1 passing. - `cd e2e && pnpm exec playwright test ui/amr-login-pill.test.ts`: 1 / 1 passing (6.7s). * feat(amr): package native cli and refine login ui * feat(amr): wire vela cli beta packaging * docs(amr): document vela ci packaging review * docs(amr): refine vela ci integration review * fix(ci): refresh nix pnpm dependency hashes * fix(pack): clean up Vela CLI packaging * fix(pack): bundle Vela CLI support files * fix(amr): recover login attempts from stale auth state * test: expand AMR and automations coverage * fix(amr): address review follow-ups * test(web): align tasks fixtures with contracts * fix(daemon): type wildcard route params * fix(ci): refresh PR merge validation * fix(amr): clear env credentials on logout * feat(settings): inline local CLI model configuration * fix(amr): recognize daemon env credentials * [codex] Fix Vela companion packaging (#2979) * Fix Vela companion packaging * Update Nix pnpm dependency hashes * [codex] Surface AMR account failures (#2980) * fix: surface AMR account failures * fix: cover AMR recovery error guidance * chore: bump beta base version to 0.8.1 (#2990) * Fix AMR profile and packaged runtime review issues * Detect packaged AMR OpenCode companion tree * feat(web): polish AMR frontend flows * Polish AMR onboarding card * fix: read AMR login state from dot-amr config (#3048) * test: tighten AMR credential and packaging coverage * test: restore AMR executable test env helper * [codex] Fix packaged mac Dock identity and AMR label (#3076) * Fix packaged mac sidecar Dock identity * Rename AMR assistant label * Fix AMR live models and dot-amr login state (#3073) * fix: read AMR login state from dot-amr config * fix: load live AMR models before runs * fix: point AMR onboarding link to production wallet * fix: address AMR model review feedback * fix: persist live AMR model fallback * [codex] Fix AMR link catalog model ids (#3088) * Fix packaged mac sidecar Dock identity * Rename AMR assistant label * Fix AMR link catalog model ids * Fix AMR model normalization typecheck * Use live AMR model for default runs * fix: polish AMR runtime settings UI * Accelerate AMR startup defaults (#3092) * Surface AMR insufficient balance wallet URL (#3099) * fix(web): polish onboarding controls (#3112) * fix(web): show CLI scan loading state * Avoid duplicate AMR wallet recharge links (#3117) * Avoid duplicate AMR wallet recharge links * Use Vela CLI 0.0.3 test package * chore(nix): refresh pnpm deps hash * Fix AMR wallet guidance display --------- Co-authored-by: open-design-bot[bot] <282769551+open-design-bot[bot]@users.noreply.github.com> * chore(pack): pin Vela CLI 0.0.3-test.1 (#3127) * chore(nix): refresh pnpm deps hash * chore(pack): pin Vela CLI 0.0.3 * chore(nix): refresh pnpm deps hash * fix(web): suppress AMR exit 130 fallback (#3136) * feat(web): nudge users to hosted AMR on model/auth/quota failures (#3083) * feat(web): nudge users to hosted AMR on model/auth/quota failures When a non-AMR agent run fails with an auth / quota / upstream model error, surface an inline nudge under the error pill linking to Open Design's hosted AMR gateway (https://open-design.ai/amr). The nudge fires `surface_view` (element=run_failed_toast) on impression and `ui_click` (element=go_amr) on the link. Also teach the daemon to classify CLI-agent auth/quota/upstream failures (Claude Code, codex, ...) into specific API error codes (AGENT_AUTH_REQUIRED / RATE_LIMITED / UPSTREAM_UNAVAILABLE) instead of the generic AGENT_EXECUTION_FAILED, so both the error message and the nudge key off accurate codes. AMR's own runs are excluded from the nudge — they keep the dedicated sign-in / recharge affordances. * feat(web): rework failed-run AMR guidance into per-case error UI Replace the single inline nudge with a per-case failed-run experience driven by the run's error code + agent: - The error card is now neutral gray (was red) and always carries a retry button; it is driven by the persisted per-message error event so it survives a reload. - Non-AMR agent hitting a model/auth/quota wall: a theme-color promotion card under the error card offers "switch to AMR & retry" — switches the run to AMR, opens Settings on the AMR card, and auto-retries once the account signs in (ProjectView polls vela login status, independent of the Settings pill lifecycle, with success / 5-min-timeout / unmount exits). - AMR agent unauthorized: clearer copy + an "authorize & retry" button. - AMR agent out of balance: clearer copy + a "top up" button to the AMR wallet, with manual retry. - Settings AMR card: when opened from the nudge, it scrolls into view and pulses, and an authorize-button coachmark (a fake hand cursor that rises in and dismisses on hover) points at the sign-in control when not yet authorized. analytics: surface_view (run_failed_toast) on the promotion card and ui_click (go_amr) on its action are retained. i18n adds chat.amrCard.* and chat.amrError.* (en / zh-CN / zh-TW translated; other locales fall back to en) and drops the old chat.amrErrorGuidance keys. * fix(daemon): require status context for numeric service-failure codes Per review on #3083: the model-service classifier matched bare HTTP status numbers (`500`, `502`, `429`, `401`), so ordinary CLI output like `line 500`, `read 502 bytes`, or `exit code 401` could be misclassified as a provider outage / auth wall and wrongly surface the AMR nudge. Now a status number only counts when it carries explicit context (`HTTP 500`, `status 503`, `code: 401`, `502 Bad Gateway`); textual provider phrases (overloaded, bad gateway, service unavailable, rate limit, …) are unchanged. Adds fixtures proving unrelated numeric output stays null. * fix(web): keep error pill for failed runs ChatPane's card doesn't cover Per review on #3083: the per-message gray error pill was suppressed for every persisted error status event, but ChatPane only renders the replacement top-level error card for `retryableAssistantMessage` (the last failed assistant). So a failed turn that is no longer last (after a follow-up) or an older failed run in history showed neither the pill nor the card — its error detail vanished, undercutting reload/history survival. ChatPane now passes `errorCardOwnerId` (the assistant id whose error the card represents); AssistantMessage suppresses only that one pill and keeps rendering StatusPill for all other error events. * fix(daemon): don't treat a process exit code as an HTTP status Follow-up to review on #3083: the status-context helper accepted a bare `code` prefix, so `exit code 401` / `process exited with code 429` still matched and got classified as AGENT_AUTH_REQUIRED / RATE_LIMITED (the very `exit code 401` case the comment calls out as noise). `code` now only counts when qualified (`status code` / `error code` / `response code`) or punctuation-bound (`code: 401`); bare `exit code N` no longer matches. Adds fixtures for exit-code lines returning null. * chore(web): translate AMR card / error keys for 16 remaining locales PR #3083 added 10 new `chat.amrCard.*` / `chat.amrError.*` keys but only provided en/zh-CN/zh-TW translations; the other 16 locales fell back to English. Translate the card title/body, three chips, primary CTA, and the AMR self-error (auth / balance) messages and buttons for ar, de, es-ES, fa, fr, hu, id, it, ja, ko, pl, pt-BR, ru, th, tr, uk. * fix(amr): address review feedback on #2355 Targeted fixes for the unresolved review threads on #2355. Each fix includes / updates a focused test. - runtimes/executables.ts: `packagedVelaOpenCodeCompanionTree` now verifies the inner `opencode` executable exists + is runnable, not just the directory. This closes the false-positive availability path that let `detectAgents()` surface AMR as available even when the packaged companion was empty / partially copied (mrcfps, 4 threads). - runtimes/executables.ts: `resolveAmrOpenCodeExecutable` now prefers the bundled `<OD_RESOURCE_ROOT>/bin/libexec/opencode/opencode` over a stale `opencode` on the user's PATH, so packaged AMR builds can't be hijacked by a global installation. - web/EntryShell.tsx: when the Local CLI scan returns an available agent and the previously-selected agent is AMR, switch the selection to the first available local agent so the runtime and persisted agent agree before Continue. - server.ts (model-probe branch): for AMR, check `readVelaLoginStatus` BEFORE rejecting on an empty live-model catalog — a signed-out user was getting `AMR_MODEL_UNAVAILABLE` ("choose a model") instead of the correct `AMR_AUTH_REQUIRED` (sign-in affordance). - server.ts (default model fallback): if the user asked for the AMR agent default and the cached id is no longer in the FRESH catalog, fall back to `liveModels[0]` from the probe instead of rejecting the run as `AMR_MODEL_UNAVAILABLE`. - integrations/vela.ts: route `vela login` through `createCommandInvocation` so an npm/Node-style `vela.cmd` / `.bat` shim on Windows gets the correct `cmd.exe /d /s /c …` wrapping with verbatim args (matches `execAgentFile` / chat-run spawning). - tools/pack/src/linux.ts: in containerized Linux builds, bind-mount the host directory of `OPEN_DESIGN_VELA_CLI_BIN` and rewrite the env to the container-side path. The host path was being passed in as-is even though the default container only mounts /project, /tools-pack and cache/home — `copyOptionalVelaCliBinary` saw a missing path. Deferred (out of scope for this PR): - `od amr status/login/logout/cancel` CLI subcommands (AGENTS.md UI/CLI dual-track rule, server.ts:5763) — sizable surface; tracked for a separate focused PR. - Strict `--require-vela-cli` for Windows + mac-x64 beta builds: prematurely blocked — `@powerformer/vela-cli` only publishes the `darwin-arm64` platform binary today; adding the flag elsewhere would fail the builds. Revisit once win/x64/linux binaries ship. * fix(amr): hoist sendAmrAccountFailure above the AMR catalog preflight (TDZ) The new signed-out AMR branch in the catalog preflight at server.ts:10875 calls `sendAmrAccountFailure(...)` to emit AMR_AUTH_REQUIRED, but the const declaration sat ~100 lines below at the outer function scope. Because `const` is TDZ-aware, that branch would have thrown `ReferenceError: Cannot access 'sendAmrAccountFailure' before initialization` for the exact users it tries to help — defeating the original intent. Hoist the helper to just above the AMR preflight block so it's available to every AMR code path in this function. Behavior elsewhere is unchanged. Also rerun the daemon test suite: `launch.test.ts > resolveAgentLaunch uses packaged built-in Vela for AMR` was creating the `<resourceRoot>/bin/libexec/opencode/` companion *directory* only, but this PR's earlier tightening of `packagedVelaOpenCodeCompanionTree` also requires the inner `opencode` executable. Add it to that fixture to match the new contract; the test was a sibling of the executables / env-and-detection fixtures already updated in 13fc4f4. Addresses #2355 review (mrcfps, 2026-05-28). * feat(web): add hover cancel for AMR login (#3158) * feat(web): add hover cancel for AMR login * fix(web): don't bounce AmrLoginPill back to 'Signing in…' after local cancel Both codex-connector (P2) and looper (CHANGES_REQUESTED) on this PR flagged the same race in the new local-cancel path: `handleCancelLogin` dispatches `notifyAmrLoginStatusChanged('login-canceled')` immediately after `/login/cancel` returns, but the `AMR_LOGIN_STATUS_EVENT` listener unconditionally re-enters `refresh()` and then restarts polling whenever `/api/integrations/vela/status` still reports `loginInFlight: true`. That is a real race because the daemon's `cancelVelaLogin()` only sends SIGTERM (escalating to SIGKILL after `LOGIN_CANCEL_KILL_GRACE_MS` = 2000 ms) and keeps the child in `activeLoginProcs` until it actually exits — so the first `/status` read after a successful cancel can legally still come back as in-flight. Under that window the pill flips back to 'Signing in…' and can later surface the timeout/error path even though the user already canceled, defeating the behavior promised in the PR description. Fix the listener instead of every dispatch site: in the `login-canceled` branch, after the local reset (stopPolling + setPending(null) + clear refs), optimistically mark every subscribed pill instance as not-in-flight (`setStatus((c) => c ? { ...c, loginInFlight: false } : c)`) and `return` — skip the refresh-and-reconcile branch below entirely. The next explicit refresh (component mount, user interaction, or a `status-changed` event) will pick up the daemon's confirmed state once the child has actually exited. Add a focused regression test that holds `/api/integrations/vela/status` at `loginInFlight: true` even after a successful `/login/cancel`, asserting that the pill stays at the Canceled → Authorize sequence and never bounces back to 'Signing in…'. This test fails on the pre-fix listener and passes on the new behavior; existing 'cancels an in-flight AMR sign-in…' and 'reconciles late AMR browser completion to Signed in after local cancel' tests continue to pass. Addresses review feedback on #3158 (chatgpt-codex-connector, nettee). --------- Co-authored-by: lefarcen <935902669@qq.com> --------- Co-authored-by: a1chzt <chizblank@gmail.com> Co-authored-by: Amy <1184569493@qq.com> Co-authored-by: Mason <jinmeihong0201@gmail.com> Co-authored-by: Caprika <56862773+alchemistklk@users.noreply.github.com> Co-authored-by: open-design-bot[bot] <282769551+open-design-bot[bot]@users.noreply.github.com>	2026-05-28 05:09:55 +00:00
Patrick A	7bc11b398d	chore(deps): upgrade express 4 -> 5 in daemon (#2311) ... * chore(deps): upgrade express 4.22.1 -> 5.2.1 and @types/express Breaking changes addressed: - Renamed all bare wildcard route segments from * to *splat across src/server.ts, src/static-resource-routes.ts, src/project-routes.ts, src/import-export-routes.ts, and all three test stubs that define app.get/options/delete routes using /raw/* or /raw/* patterns - Updated wildcard param access from (req.params as any)[0] / req.params[0] to Array.isArray(req.params.splat) ? req.params.splat.join('/') : String(...) to handle the Express 5 / path-to-regexp v8 change where wildcard params are now string[] instead of string - Updated app.get('*') SPA fallback to app.get('/*splat') in server.ts - Annotated five connector route handlers with Request<{ connectorId: string }> so the typed param resolves as string, not string | string[], fixing the 10 TS2345 / TS2322 errors that surfaced when @types/express moved to 5.0.6 - Fixed two app.listen() beforeAll callbacks in origin-validation.test.ts to accept and propagate the optional Error argument Express 5 now passes to the listen callback, resolving TS2769 overload mismatch * chore(nix): refresh daemonHash for rebased lockfile * fix(daemon): await res.sendFile() in async route handlers for Express 5 compatibility Express 5 res.sendFile() returns a Promise. Without await, async route handlers return before the response is sent, causing Express to call next() and fall through to a 404. Add await to all res.sendFile() calls in async handlers in static-resource-routes.ts and server.ts. * fix(daemon): use readFile+send for spritesheet route instead of sendFile Express 5 res.sendFile() returns undefined (not a Promise). ENOENT errors call next() asynchronously after the route handler's try/catch has returned, causing unhandled 404 responses. Replacing with fs.promises.readFile + res.send keeps the error path fully within the handler's try/catch. --------- Co-authored-by: Patrick A <259201958+eefynet@users.noreply.github.com>	2026-05-26 03:16:48 +00:00
lefarcen	c14baf07d3	Merge origin/main into release/v0.8.0 ... PR #2461 sync prep — resolves 14 conflicts merging 84 main-side commits on top of 58 release-side commits accumulated during the 0.8.0 cycle. Resolution summary: Take main (theirs) where main carried deliberate forward progress: - apps/web/src/components/PluginCard.tsx — 7 hunks, i18n migration: hardcoded English aria-labels/titles replaced with t() calls keyed on pluginCard.* (all 8 keys verified present in en.ts). - apps/web/src/components/TasksView.tsx — 1 hunk, source-ingestion feature: sortedRoutines (newest-first), sourceIngestionTemplates, patchSourceForm, submitSourceIngestion. activeCount/pausedCount semantics preserved (now keyed on sortedRoutines, count unchanged). - e2e/ui/app.test.ts — new node:fs/promises + tmpdir + path + @/timeouts imports needed by main-side test helpers. - e2e/ui/settings-local-cli-codex-fallback.test.ts — menu-dismissal helper block added by main. Keep both sides where each added a different field to the same object literal: - apps/web/src/components/ProjectView.tsx (locale + analyticsHints spread). - apps/web/src/components/DesignSystemFlow.tsx (locale + analyticsHints). Take release (ours) where release carried deliberate work that ships 0.8.0: - CHANGELOG.md — release-side 0.8.0 entry + PR link refs; main's Unreleased section was the same body of work, now finalized. - apps/landing-page/public/{apple-touch-icon,favicon}.png + apps/web/public/app-icon.svg — release-side visual refresh assets consistent with 0.8.0 stable ship. - tools/pack/src/linux.ts — packageVersion const required by line 466; taking main's empty line would build-error. - e2e/ui/project-management-flows.test.ts + e2e/ui/settings-api-protocol.test.ts + e2e/ui/settings-memory-routines.test.ts — release-side release-smoke hardening (shangxinyu1 + PerishFire) takes precedence on overlap. Closes-issue / unblocks: PR #2461 sync release/v0.8.0 → main.	2026-05-23 12:17:18 +08:00
YOMXXX	3e2f037730	feat(daemon): add CTA hierarchy static QA pass (refs #2251) (#2427) ... * feat(daemon): add CTA hierarchy static QA pass Introduce apps/daemon/src/qa/cta-hierarchy.ts exporting a pure analyseCtaHierarchy(html) that parses generated prototypes with cheerio and flags three precision-biased findings: multiple-primary CTAs in the same section, ambiguous-weight (all CTAs share identical class + inline style), and misleading-prominence (secondary-coded copy like "Learn more" / "了解更多" styled with primary weight). CTA candidates come from <button>, <a>, role="button" with btn/button/cta class markers plus CTA copy keywords covering both English (Get started, Sign up, Buy, Subscribe, Learn more, ...) and Chinese (立即购买, 立即下单, 了解更多, ...). Weight is inferred from class tokens (primary/solid/filled/accent/cta) and from non-transparent inline background-color, matching the inverse of the issue #2251 sample where the header CTA was rendered with the neutral .btn style. This PR only ships the pure function plus its tests. HTTP route, CLI subcommand, and any auto-repair feedback loop are deliberate follow-ups so the first cut can land without touching the daemon HTTP surface. Refs #2251 * fix(qa): respect container boundaries in CTA hierarchy heuristics Two precision fixes from review of #2427: - computeContainerKey()'s parent fallback keyed by tag name alone, so flat layouts like <div><a class=btn-primary>...</a></div> repeated for sibling cards all landed in 'parent:div' and detectMultiplePrimary() reported a fake shared-section conflict on what is in fact one CTA per card. Switch to parent-node identity (positional index of the matched parent within its tag group, same trick the landmark branch already uses), so each sibling wrapper gets its own bucket. - detectAmbiguousWeight() compared signatures across the entire document, so two unrelated sections each containing one '.btn' CTA with matching style would trigger 'ambiguous-weight' despite neither container having 2+ CTAs. The PR body's rule is narrower — 'every CTA in a container shares the same class + inline style' — so bucket by containerKey first and only emit the finding for containers with 2+ CTAs whose signatures are identical. Tests lock both behaviors down: - sibling <div> card-grid without a landmark ancestor stays under the multiple-primary threshold; - one-CTA-per-section pairs stay under the ambiguous-weight threshold.	2026-05-22 16:53:14 +08:00
lefarcen	aedbb9dbe4	release: Open Design 0.8.0 ... Bumps 14 workspace package.json files from 0.7.0 to 0.8.0: - root, apps/{web,daemon,desktop,landing-page} - packages/{contracts,host,platform,sidecar,sidecar-proto} - tools/{dev,pack,pr}, e2e apps/packaged was already at 0.8.0 from the preview lane. Independently versioned packages keep their own tracks. Adds CHANGELOG [0.8.0] - 2026-05-20 entry covering the 305 PRs merged since 0.7.0 by 75 contributors: - Plugin engine rebuild + Plugin Registry surface - Headless by default (desktop is thin wrapper around CLI) - Critique Theater Phases 9 through 16 - 149 design systems with structured tokens.css - Italian locale + CJK font fallback - Leonardo.ai, ElevenLabs, SenseAudio providers - Windows packaged auto-update - Visual refresh + Quick-brief discovery overhaul - PostHog v2 analytics - Manual edit UX overhaul	2026-05-20 21:22:17 +08:00
Patrick A	aa8f02dbac	chore(deps): upgrade posthog-node 4.18.0 -> 5.34.6 in daemon (#2309) ... Breaking changes addressed: - posthog-node v5 replaces axios/follow-redirects/proxy-from-env with @posthog/core (native fetch); no call-site changes required — the PostHog constructor signature, capture(), identify(), groupIdentify(), on(), and shutdown() surface used by apps/daemon/src/analytics.ts is stable across the major boundary. - shutdown() is still async in @posthog/core (PostHogCoreStateless base class); the IPostHog interface in posthog-node types it as void but the inherited Promise<void> from @posthog/core keeps await client.shutdown() correct at runtime. - protobufjs resolved version: 7.5.7 (pre-existing; posthog-node v5 does not pull in @opentelemetry, so no change to protobufjs from this bump).	2026-05-20 15:23:28 +08:00
lefarcen	80d305858b	feat(diagnostics): add one-click log export from Settings → About (#798) ... * feat(diagnostics): add one-click log export from Settings → About Adds a new "Export diagnostics" entry under the About section that bundles daemon/web/desktop logs, machine info, and recent macOS crash reports into a zip the user can share when reporting issues. - Browser hits a new daemon HTTP endpoint and triggers a download. - Electron uses an IPC bridge with the native save dialog and reveals the saved file in Finder/Explorer; the Help menu also exposes it as a fallback when the daemon is unresponsive. Packaging + redaction lives in a new @open-design/diagnostics package so both surfaces share it. Sensitive JSON keys, URL query secrets, and the current user's home path are redacted before packaging. * build(nix): include packages/diagnostics in daemon build targets The Nix daemon derivation builds workspace siblings in dependency order before compiling apps/daemon. Without @open-design/diagnostics in that list, the daemon TypeScript build fails inside the Nix sandbox with `Cannot find module '@open-design/diagnostics'` because pnpm install only creates the symlink — the dist output that the package.json exports point at isn't produced until each sibling's build script runs. * build(tools-pack): include @open-design/diagnostics in packaged INTERNAL_PACKAGES Without this, packaged win/mac/linux builds fail with `npm error 404` when the post-build `npm install --omit=dev --no-package-lock` step in the assembled app tries to resolve `@open-design/diagnostics@0.2.0` from the public npm registry. The package is workspace-private, so it has to be tarballed via `pnpm pack` and file:-referenced from the assembled package.json like every other internal workspace dep that daemon/desktop depend on. Also wires the package's `pnpm --filter ... build` into the pre-pack workspace build step so the dist/ exists before pnpm pack runs, and updates the two test fixtures (`win-app.test.ts`, `workspace-build.test.ts`) that mirror INTERNAL_PACKAGES. The diagnostics package itself is repinned to exact dependency versions already used elsewhere in the workspace (`jszip 3.10.1`, `@types/node 20.19.39`, `esbuild 0.28.0`, `typescript 5.9.3`, `vitest 4.1.6`) so it passes the new `pnpm guard` exact-version rule and produces a minimal lockfile diff vs main (additions only, no resolution-string churn). * fix(diagnostics): include `~` in bearer-token redaction char class RFC 6750 token68 syntax allows `~`, so tokens like `Authorization: Bearer abcd~efgh` were only partially matched by `HTTP_AUTH_SCHEME_RE`. The regex stopped at the first `~`, leaving the tail (`~efgh`) un-redacted in the exported diagnostics zip — a clear leak since this feature explicitly generates support bundles for external sharing. Add `~` to the character class and a regression test. * fix(diagnostics): only collect renderer.log from desktop `buildSidecarLogSources` unconditionally added `logs/${app}/renderer.log` for daemon/web/desktop, but only the desktop runtime writes a renderer log (see apps/desktop/src/main/runtime.ts) — daemon and web are pure Node services with no Electron renderer. Every export therefore produced missing-file placeholders and manifest warnings for the two phantom paths, polluting the bundle. Gate the renderer.log source on APP_KEYS.DESKTOP so the daemon-side collector matches the desktop-side collector in apps/desktop/src/main/ diagnostics.ts:63. * fix(diagnostics): mirror desktop-side renderer.log gate The previous fix only updated the daemon-side `buildSidecarLogSources` in `apps/daemon/src/diagnostics-export.ts`. The desktop-side collector at `apps/desktop/src/main/diagnostics.ts` had an identical copy of the same bug that I overlooked: it also unconditionally added `logs/${appKey}/renderer.log` for daemon/web/desktop, producing missing-file placeholders + manifest warnings for the two phantom paths on every desktop-initiated export. Apply the same `appKey === APP_KEYS.DESKTOP` gate here so both export entry points (browser via daemon HTTP, Electron via native save dialog) emit the same clean manifest. * feat(diagnostics): add `od diagnostics export` CLI subcommand AGENTS.md's dual-track capability-exposure contract requires every user-facing feature to ship on both the web UI and the `od` CLI. The diagnostics export was only reachable through Settings → About and the desktop Help menu; this commit closes the loop with an `od diagnostics export [<path>] [--json]` subcommand registered in SUBCOMMAND_MAP. The CLI is a thin shell over the existing GET /api/diagnostics/export endpoint — same zip output, same redaction, same crash-report scope. Defaults to writing `open-design-diagnostics-<timestamp>.zip` in the current directory; `--output <path>` or a positional arg overrides. `--json` prints `{path, sizeBytes}` for shell pipelines. Use cases this unlocks: - A CI script can `od diagnostics export ~/artifacts/bundle.zip` after a failed run. - Bug reporters on headless boxes can grab a bundle without booting the web UI. - `od doctor` follow-ups can collect a full snapshot when a probe fails. * fix(diagnostics): surface non-sidecar launch in manifest warnings `buildSidecarLogSources()` returns `[]` when the daemon has no sidecar runtime context, which is the standard `od` (plain) launch path — `runDaemonCliStartup()` -> `startDaemonRuntime()` does not pass a runtime. Settings → About and the new `od diagnostics export` previously reported success but produced a bundle with only the summary JSONs, so operators could not tell "no logs because plain launch" from "no logs because something genuinely broke." - Extend `DiagnosticsContext` with an optional upstream `warnings: string[]` that `buildManifest` merges into the manifest warnings. - Emit STANDALONE_LAUNCH_WARNING from the daemon handler when `options.runtime == null`. The warning names the limitation and points the user at the sidecar entry points that DO capture logs. - Add a regression spec at `apps/daemon/tests/diagnostics-export.test.ts` that drives the handler with `runtime: null` and asserts the warning surfaces in `summary/manifest.json` (and that `files` is empty so a user reading the bundle does not confuse "no log sources" with "missing files").	2026-05-20 09:10:51 +08:00
PerishFire	bd48c597b0	chore: pin dependency versions and harden CI caches (#2189) ... * chore: pin dependency versions * ci: enforce pinned dependency specs * ci: fix pnpm executable invocation	2026-05-19 13:58:27 +08:00
lefarcen	b268bbe169	Merge origin/garnet-hemisphere (post-9e196d34) — Use Plugin handoff fix ... Brings in 11 new garnet commits, most importantly: - 1a90aef4 feat(plugin-use): implement plugin use handoff functionality — fixes the bug QA reported where /plugins Use Plugin would 422 silently for template plugins; new flow hands off to HomeView with the plugin pre-bound + input form prompted there. - 2ac58544 feat(plugin-inputs): enhance plugin input handling with file upload support — extends PluginInputsForm for file uploads. - 3b167b69 feat(plugins): registry protocol — new @open-design/registry-protocol workspace package (needs build before daemon boot). - Plus enhancements to plugin metadata, GitHub installer, plugin detail view, login/whoami, static HTML preview paths. Conflicts resolved: - packages/contracts/src/api/projects.ts: HEAD's skipDiscoveryBrief field + garnet's contextPlugins (@-mention plugin context refs) both kept on ProjectMetadata. - apps/landing-page/* (3 files): accepted HEAD — garnet had the older single-page landing-page header; main has the multi-page layout (/skills/, /systems/, /templates/, /craft/) with dynamic counts. Not related to the Use Plugin core fix. New @open-design/registry-protocol package must be built before daemon boots; pnpm install does this via postinstall already.	2026-05-14 16:32:35 +08:00
pftom	3b167b6921	feat(plugins): add registry protocol and enhance plugin management features ... - Introduced the `@open-design/registry-protocol` package, enabling improved interactions with plugin registries. - Updated the `typecheck` script in the daemon's `package.json` to include the new registry protocol. - Enhanced the CLI with new flags and commands for better plugin management, including `yank` and additional marketplace functionalities. - Implemented a plugin lockfile system to manage installed plugins and their versions, improving reliability during upgrades. - Added new marketplace doctor functionality to validate plugin entries and ensure compliance with registry standards. This update significantly enhances the plugin ecosystem by providing robust registry interactions and improved management capabilities.	2026-05-14 08:55:36 +08:00
lefarcen	53997990b7	Merge origin/main (post-0.7.0) into reconciled garnet branch ... Second-pass merge layering 41+ new commits from origin/main on top of the first reconcile commit. Headline upstream additions absorbed: - 0.7.0 release: redesigned chat bubble user-text styling, neutralised palette, lucide icons, ElevenLabs audio voice option discovery in the prompt composer, analytics tracking (PostHog) wired across home / studio / create surfaces, Prometheus `/api/metrics` endpoint, critique-theater drop-in mount with a settings toggle. - Misc upstream fixes (titlebar padding, release header layout, deck preview chrome, feedback form auto-scroll, conversation-created SSE on routine runs, etc.) Conflict resolutions (12 files, ~22 hunks): - contracts barrel + prompts/system: union of both sides; new analytics exports (`./analytics/events`, `./analytics/public-params`) added alongside garnet's plugin/atom/genui exports. Both ElevenLabs voice fields (audioVoiceOptions/audioVoiceOptionsError, main) and pluginBlock/activeStageBlocks (garnet) preserved on ComposeInput. - daemon/server.ts: Prometheus `/api/metrics` route inserted after garnet's `/api/daemon/shutdown`. main's `createAnalyticsService` call added before the chat-run service init alongside the prior reconcile note about the dropped legacy POST /api/projects body. - App.tsx: handleCreateProject now consumes both garnet's plugin fields (pluginId / appliedPluginSnapshotId / pluginInputs / autoSendFirstMessage) and main's analytics requestId. Tracking fires success + failure paths; PluginLoopHome auto-send sessionStorage flag is preserved. - ProjectView.tsx: the garnet auto-send useEffect coexists with main's `useCritiqueTheaterEnabled()` hook. - ChatComposer.tsx: imports merged (drop now-unused fetchSkills, add analytics provider + tracking + buildVisualAnnotationAttachment). - index.css: main's redesigned `.msg.user .user-text` chat bubble styling wins over garnet's plain text rule; garnet's `.msg-plugin-chip*` rules preserved alongside. - EntryView.tsx: accepted HEAD (garnet wrapper) — consistent with reconcile decision #2. main's added PetRail / TopTab / analytics view tracking is intentionally NOT brought into the wrapper; the follow-up to re-integrate PetRail / image-templates / video-templates into EntryShell still stands and now also covers analytics view-tracking hooks. - daemon/package.json + pnpm-lock: merged dep set (tar + posthog-node + prom-client coexist). - Test fixtures (FileWorkspace.test): kept garnet's plugin-folders describe block intact; main's projectKind="prototype" addition is dropped where it conflicted with garnet's plugin-folder fixture files. Verification: `pnpm install` (after lockfile reconciled), `pnpm typecheck` exits 0 across all workspace packages. Follow-up not done in this commit: - PetRail / image-templates / video-templates / 0.7.0 analytics view-tracking hooks need to be added to EntryShell. - Critique-theater settings toggle UX (added on main) lives in the SettingsDialog hierarchy; the reconcile state preserves the SettingsDialog so this should work without changes, but no end-to-end verification yet.	2026-05-13 23:29:56 +08:00
lefarcen	d3602be666	Merge origin/main into garnet-hemisphere (reconcile) ... Merge of `origin/main` (`03ed3960`, 2026-05-13 pre-0.7.0) into the 161-commit garnet-hemisphere line, reconciling the product-vibe-coded plugin/marketplace/EntryShell surfaces from garnet with the routines / skills / live-artifacts feature work landed on main since the fork point. Headline decisions (full rationale + side-by-side screenshots in `specs/change/20260513-garnet-skills-automations/reconcile-result-vs-garnet.md`): - #1 SettingsDialog: keep main's Memory / Skills / External MCP / Connectors / Routines / MCP server nav items even though the top-level /integrations + /automations routes also cover them. Two entries coexist for now; revisit once Track A/B fill in the placeholder content. - #2 EntryView: accept garnet's thin wrapper delegating to EntryShell. Main's PetRail sidebar + image-templates/video-templates tabs are intentionally deferred to a follow-up that re-integrates them into the new EntryShell layout. - #3 /integrations + /automations top-level routes: kept (garnet's product intent). Skills tab is still a "Coming soon" placeholder awaiting Track A; Routines/Schedules/Live-artifacts cards on /automations are still mock awaiting Track B. - #5 DesignFilesPanel: hybrid — main's pagination as primary list, garnet's Plugin folders section preserved between the live-artifacts block and the pagination block. (by-kind sections drop in favour of pagination; plugin-folders rendering stays because it is a garnet-specific product addition.) - #7 server.ts (10 hunks, ~5400 conflict lines): manual hunk-by-hunk merge. Both daemon admin routes + plugin/genui routes (garnet) and routines/memory/skills upgrades (main) preserved. Garnet's inline project route block kept alongside main's `registerProjectRoutes` / `registerProjectUploadRoutes` modular wiring — duplicate route audit is a follow-up. Garnet's POST /api/projects plugin-snapshot resolution + default-scenario fallback is intentionally dropped from the inline body (now handled by registerProjectRoutes) and listed for follow-up re-integration into `project-routes.ts`. Verification (worktree at /Users/elian/Documents/open-design-garnet): - `pnpm typecheck` exits 0 across all workspace packages - daemon (`pnpm tools-dev run web --namespace reconcile-shots`) boots, serves `/api/daemon/status` healthy, and survives a Playwright walkthrough of /integrations / /automations / home / projects / design-systems / plugins / settings dialog - `@open-design/plugin-runtime` package built (was missing dist/ on garnet); without it the daemon's plugins/* imports fail at boot Track A (Skills tab → real SkillsSection) and Track B (Automations cards → real routines / live-artifacts backend) are the two remaining follow-ups blocking the placeholder/mock content from going live. See `spec.md` and `track-skills.md` in the same directory.	2026-05-13 22:29:21 +08:00
Nagendhra Madishetti	38a5ab69e6	feat(daemon): Critique Theater Phase 12 (9 Prometheus metrics + 6 log events + OTel span + Grafana dashboard) (#1485) ... * feat(web): pure reducer for Critique Theater states (Phase 7.1) Pure CritiqueState reducer driven by the contracts-level PanelEvent (the same shape both the live SSE stream and the recorded transcript emit), so a single reducer powers both the in-flight panel and the rerun replay. Lifecycle covers run_started → running → (shipped / degraded / interrupted / failed), with panelist_open / dim / must_fix / close / round_end events building per-round CritiquePanelistView entries as they arrive. Defensive behaviour that surfaced while writing the spec tests: - Terminal phases (shipped / degraded / interrupted / failed) are sticky against further lifecycle events for the same run, except for parser_warning which can land late and is recorded in a side channel without changing phase. - A new run_started for a different runId at any time discards the prior state and reboots, so the UI can launch consecutive runs without an explicit reset action. - Events whose runId does not match the active run return the same state reference, so React's useReducer doesn't re-render subscribers on stray traffic. - Round bookkeeping keys by round number rather than "always last", so an out-of-order panelist_dim for round 1 arriving after a round 2 dim does not corrupt the round 2 bucket. Test coverage: 18 cases covering each transition, the runId guard, sticky-terminal behaviour, the out-of-order round invariant, and the stable-identity guarantee. Sets up Phase 7.2 and 7.3 to wire SSE + replay into the same reducer. * feat(web): useCritiqueStream hook subscribes to SSE and feeds reducer (Phase 7.2) createCritiqueEventsConnection is a pure connection manager that mirrors apps/web/src/providers/project-events.ts: opens an EventSource at /api/projects/:id/events, listens for every name in CRITIQUE_SSE_EVENT_NAMES, decodes each frame back into a PanelEvent (stripping the critique. prefix and merging the data payload), and hands it to the caller's onEvent. Reconnect uses exponential backoff (1s → 30s) and resets on `ready`; malformed payloads drop with a dev-mode warning rather than tearing the stream. useCritiqueStream wraps the manager in a useReducer that owns the CritiqueState. enabled=false or a null projectId tears down the connection cleanly; switching projectId closes the old connection and opens a fresh one. The returned dispatch lets local UI synthesise actions (e.g. an Esc keypress firing a synthetic interrupted while a kill request is in flight); production traffic comes from the SSE stream. Test coverage: - sse.test.ts (10 cases, node env): subscription set covers every CRITIQUE_SSE_EVENT_NAMES channel; payload decoding lifts the wire shape back to PanelEvent; malformed JSON is swallowed and does not stop the stream; exponential backoff schedule and ready-reset semantics are pinned with a setTimeout seam; close() cancels pending reconnects and shuts the live source; no-op fallback when EventSource is unavailable. - useCritiqueStream.test.tsx (6 cases, jsdom env): idle pre-event, reducer driven by synthetic actions, no connection when disabled or projectId is null, clean close on unmount, projectId change reopens cleanly. * feat(web): useCritiqueReplay hook drives reducer from transcript file (Phase 7.3) Fetches the per-run NDJSON transcript (one PanelEvent per line), parses every line via the shared isPanelEvent predicate, and dispatches into the same CritiqueState reducer the live SSE stream uses. A single reducer means the UI rendering a replay can be identical to the live panel, and a UI mounting both useCritiqueStream and useCritiqueReplay in parallel does not have to reconcile two state shapes. speed knob is `paused | instant | live | { intervalMs: N }`. - instant flushes every event synchronously, useful for opening a finished run already at its terminal state. - intervalMs paces dispatches at a fixed cadence so the reviewer can watch the run unfold. - paused parses the transcript but holds events back until the caller advances speed (consumers can drive a scrubber later). - live is reserved for the future "playback at original cadence" feature, currently treated as instant; replay timestamps are not yet persisted with each event so honest pacing requires a follow-up Phase 7+ task. gunzip seam handles `.ndjson.gz` transcripts via DecompressionStream when present; the production fetch path picks between text and arrayBuffer based on the URL extension. Both seams are injectable so the unit tests don't need to spin up a real network or a real gzip pipeline. Test coverage (8 cases, jsdom env): - Idle status before any URL is provided. - speed=instant flushes the full transcript synchronously to shipped state. - speed={intervalMs:N} paces with the setTimeout seam, reaching done after the last tick. - speed=paused leaves status=playing with no dispatches. - Empty transcript reports done with state still idle. - Fetch rejection surfaces an error status with the message. - Malformed NDJSON lines are skipped; valid events around them still land. - .gz transcripts route through the gunzip seam. Closes the Phase 7 plan tasks 7.1 / 7.2 / 7.3 (reducer + stream + replay), all on one branch ready for review. Phases 8+ (Theater components) consume these from this PR. * fix(web): close payload-override gap + paused-resume bug in Critique Theater hooks (Phase 7 review) Two P1 fixes from lefarcen's review on PR #1307: SSE payload override `sseToPanelEvent` previously spread `data` after the channel-derived `type`, so a payload-provided `type` could override the channel and route a `critique.run_started` frame into the reducer as a `ship` action. Reversed the spread so the channel-derived `type` is authoritative, and revalidated the resulting object through the contracts-level `isPanelEvent` predicate before returning. Frames that fail validation (missing runId, empty runId, unknown type) are dropped, so a malformed or compromised SSE frame can no longer dispatch a wrong-shape action into the reducer. Three new sse.test.ts cases pin the regression: hostile `type:'ship'` in the payload still resolves to `run_started`, missing runId is dropped, empty runId is dropped. Replay pause/resume `useCritiqueReplay` had one big effect keyed on `transcriptUrl` only, so flipping `speed` from `paused` to `instant` never re-fired and the held events sat undispatched. Split into a parse effect (depends on URL, fetches and stores events in state) and a pace effect (depends on parsed-events + speed, owns the cursor + timers). The playback cursor lives in a ref that survives pause/resume cycles, so flipping `paused` -> `instant` flushes from the current position rather than restarting (which would double-dispatch `run_started` and reset the reducer). Two new useCritiqueReplay.test.tsx cases: - paused-then-instant transitions from `playing` to `done` and reaches the shipped terminal phase - intervalMs paced playback dispatches one event, pauses to drain the next scheduled timer, flips to instant, and confirms the remaining transcript drains exactly once (cursor was preserved) Doc consistency The earlier source comment in useCritiqueReplay.ts claimed `live` "paces by recorded timestamps" while the impl used zero-delay timers and the PR body said it behaves like `instant`. Aligned to reality: `live` currently behaves like `{ intervalMs: 0 }` (events drain on successive microtasks via setTimeoutFn) because transcripts do not yet carry per-event timestamps. Honest timestamp-driven pacing is queued as a Phase 7+ follow-up. Validated: pnpm guard, pnpm --filter @open-design/web typecheck, Theater suite 47/47 (up from 42, +3 sse + 2 replay), full web suite 96 files / 888 tests. * feat(i18n): seed Critique Theater key block (en + zh-CN; other locales fall back via spread) * feat(web): Theater PanelistLane component (Phase 8.1) * feat(web): Theater ScoreTicker component (Phase 8.2) * feat(web): Theater RoundDivider component (Phase 8.3) * feat(web): Theater InterruptButton component with Escape keybind (Phase 8.4) * feat(web): Theater TheaterDegraded chip (Phase 8.5) * feat(web): Theater TheaterCollapsed post-run summary (Phase 8.6) * feat(web): Theater TheaterTranscript replay surface (Phase 8.7) * feat(web): Theater TheaterStage top-level container (Phase 8.8) * feat(web): Theater CSS using existing semantic tokens (no hex literals) * feat(web): Theater public exports barrel * fix(web): resolve P2 + P3 review feedback on Phase 8 (PR #1314) Addresses all 4 P2 + 3 P3 items from codex, Siri-Ray, and lefarcen. State-lifecycle fixes (3 x P2) 1. Reducer learns a synthetic `__reset__` action (`CritiqueResetAction`). Host hooks dispatch it when their gating prop changes so a stale run from a prior project / transcript cannot bleed into the next context. Reset is idempotent on idle (returns the same reference). 2. `useCritiqueStream` dispatches `__reset__` at the top of its connection effect, so a workspace switch from project A (which streamed a critique) to project B clears the reducer before the new EventSource opens. enabled=false also clears. 3. `useCritiqueReplay` dispatches `__reset__` at the top of its parse effect, so transcriptUrl swaps (including swap-to-null after a replay reached `shipped`) lift the reducer back to idle before the new fetch starts. SSE validation (1 x P2) 4. `sseToPanelEvent` now runs a per-variant `hasValidVariantShape` check after the cheap `isPanelEvent` predicate. A `critique.ship` frame missing `composite` / `round` / `status` / `artifactRef` is rejected before reaching the reducer, so TheaterCollapsed can no longer crash on `undefined.toFixed(1)`. Every variant's required fields are validated: run_started (protocolVersion, non-empty cast, maxRounds, threshold, scale), panelist_* (round, role, plus variant-specific shape), round_end (round, composite, mustFix, decision in {continue,ship}, reason), ship (round, composite, status, artifactRef.{projectId,artifactId}, summary), degraded (reason, adapter), interrupted (bestRound, composite), failed (cause), parser_warning (kind, position). Reducer correctness (1 x P2) 5. `panelist_open` now materializes the round + an empty panelist view (`{dims: [], mustFixes: []}`) so TheaterStage can highlight the in-progress lane the instant the tag opens. Before this, a stream that emitted only `panelist_open` after `run_started` left `rounds = []` and the UI rendered no current round until a later `panelist_dim` arrived. Polish (3 x P3) 6. Brand role tint swaps from `var(--magenta, var(--accent))` to `var(--purple, var(--accent))`. `--purple` is actually defined across the design systems; `--magenta` is not, so Brand was silently falling through to `--accent` and looking identical to Designer. 7. New i18n key `critiqueTheater.interruptedSummary` for the interrupted-collapse copy ("Interrupted at round N, best composite X.X"). Previously the interrupted branch reused `shippedSummary` and the UI read "Shipped at round..." for a run that specifically did not ship. Native value in en + zh-CN; other locales fall back via `...en` spread. 8. `TheaterDegraded` heading id comes from `useId()` instead of a hardcoded `theater-degraded-heading`, so two chips rendered on the same page (chat history with multiple completed runs) keep their aria-labelledby references unambiguous. Tests (15 new cases) - reducer.test.ts (+5): __reset__ on running/terminal/idle, panelist_open materializes round, panelist_open does not stomp prior panelist data. - sse.test.ts (+6): variant-level rejection for ship without required fields, degraded without adapter, run_started with empty cast, panelist_dim with non-numeric score, round_end with unknown decision, plus a positive fully-formed ship. - useCritiqueStream.test.tsx (+2): state reset on projectId change, state reset on enabled flip false. - useCritiqueReplay.test.tsx (+1): state reset on transcriptUrl swap to null after a replay reached shipped. - TheaterCollapsed.test.tsx (text-pinning update): asserts the interrupted branch reads "Interrupted at round 1" + "best composite 7.9", and explicitly NOT "Shipped at round...". - TheaterDegraded.test.tsx (+1): two chips on the same page get unique aria-labelledby ids that each resolve to an `<h3>`. Validated - pnpm guard clean - pnpm --filter @open-design/web typecheck clean - Theater suite: 13 files, 101 tests (was 86 on the first Phase 8 push, +15 new) - tests/i18n/locales.test.ts 5 of 5 across 18 locales * feat(web): CritiqueTheaterMount wires SSE + reducer into a single drop-in (Phase 9.1) * feat(i18n): Critique Theater strings for de + ja + ko + zh-TW (Phase 9.2) * fix(web): resolve P1 + P2 review feedback on Phase 9 (PR #1315) Addresses every blocker from codex, Siri-Ray, and lefarcen. The three state-lifecycle and SSE-validation issues they also flagged inherit fixes from PR #1314's review pass that this branch now sits on top of after rebase. Real daemon kill on Interrupt (P1) - CritiqueTheaterMount now POSTs to /api/projects/:id/critique/:runId/interrupt alongside the optimistic local dispatch. Before this fix, clicking Interrupt only flipped the React state to interrupted while the daemon job kept running. The fetch is best-effort: a 404 (endpoint not wired yet, lands in Phase 15) is swallowed with a dev-mode console.warn so the UI still moves to the collapsed badge. - New fetchInterrupt test seam lets RTL assert on the URL / method and simulate the "daemon not ready yet" path. Two tests pin both: the happy URL proj-42/critique/run-abc/interrupt POSTs, and a rejected fetch still flips the UI. interruptPending reset on new run (P2) - A ref-backed effect compares the current runId against the last one we saw; when it changes, interruptPending is cleared. A user who interrupts run-1 and then triggers run-2 from the same mount now gets a fresh, enabled kill button instead of one stuck in "Interrupting…". Pinned by a new mount test. Escape keybind scope (P2) - InterruptButton now checks the keydown target. Escape inside an input, textarea, select, or contenteditable element is ignored (and any ancestor of those via closest() is treated the same way). Body-level focus still fires the keybind so the Theater area's affordance keeps working. Four new tests cover textarea, input, contenteditable, and the body-focus positive case. userFacingName i18n key (P2) - The spec at specs/current/critique-theater.md:6 mandates a single critiqueTheater.userFacingName key so the "Design Jury" label can be renamed without touching code. Phase 8 introduced critiqueTheater.title by mistake; renamed across types.ts, en.ts, zh-CN.ts, de.ts, ja.ts, ko.ts, zh-TW.ts, and the lone consumer TheaterStage.tsx. The locale alignment test stays green. Validated - pnpm guard clean - pnpm --filter @open-design/web typecheck clean - Theater suite: 14 files, 112 tests (was 101 before, +11 new for the Phase 9 review pass: 3 mount + 4 InterruptButton focus scope; the rest were already in #1314's review fix). - tests/i18n/locales.test.ts 5 of 5 across 18 locales. * feat(daemon): adapter-degraded registry with TTL (Phase 10.1) In-memory registry recording adapters that produced malformed or oversize transcripts so the orchestrator can skip them for a TTL window (default 24h) instead of cycling through known-bad providers on every run. Records carry reason (malformed_block | oversize_block | missing_artifact), source label, and expiresAt. The test-only clock seam lets the suite advance time deterministically and prove that an expired entry stops counting as degraded without anyone calling clearDegraded. 7/7 vitest cases green. * feat(daemon): synthetic good + bad adapter fixtures (Phase 10.2) Two test-only adapters that read the existing v1 transcript fixtures (happy-3-rounds and malformed-unbalanced) and replay them as either a full string or a 512-byte chunked stream. The chunked form is what the conformance harness uses to prove the parser holds together when the transcript arrives in arbitrary network slices, not as one buffered blob. * feat(daemon): adapter conformance harness (Phase 10.3) runAdapterConformance pulls a transcript through the same parseCritiqueStream pipeline the orchestrator uses and classifies the outcome as shipped, degraded, or failed. On a degraded outcome it forwards the matched reason to the adapter-degraded registry, so a single nightly conformance run is what populates the skip list rather than the orchestrator learning each adapter is broken at request time. 5/5 vitest cases green covering shipped, malformed degraded, oversize degraded, no-ship failure, and the harness-thrown failure path. * test(e2e): Critique Theater Playwright suite (Phase 11) Six tests, one viewport per visual case, deterministic SSE fixtures stubbed via page.route(). Adds the suite to test:ui:extended so the existing extended-UI lane picks it up. Coverage: 1. Happy path: a single mounted theater plays the full fixture (1 run_started, 5 panelists open / dim / must_fix / close, 1 round_end, 1 ship) and ends on the score badge. 2. Interrupt mid-run: the panelist that is open at the time the interrupt button is clicked closes with an interrupted marker and the transcript freezes there. 3. Visual regression at 375x720 mobile. 4. Visual regression at 768x1024 tablet. 5. Visual regression at 1280x800 desktop. 6. A11y role tree: the theater region exposes a labelled landmark, each panelist lane is a group with an accessible name, the score is a status live region. All SSE traffic is stubbed by page.route so the suite runs in CI without a daemon. The toggle is seeded via localStorage by bootAppWithCritiqueEnabled so the gate behaves as if Settings flipped it on. typecheck clean; playwright --list reports 6. * test(web): reducer p99 bench at 10k iterations (Phase 13.1) Locks the documented 2ms budget for the Critique Theater reducer on a representative SSE script (27 actions, one full happy run) behind a regression gate. Asserts p99 stays under 4ms (2x the documented budget) so CI runners with a noisy neighbour do not flake while a real regression to 20ms or 200ms still trips. The bench is a vitest case rather than a bare microbenchmark so it runs in the same CI lane as every other web test and does not need a parallel runner. * test(web): critique surface coverage walker (Phase 13.2) Walks the public critique surface (11 SSE event names, 5 panelist roles, 6 lifecycle phases, 9 named i18n keys) and asserts each named symbol appears in both the src corpus and the test corpus. The walker is the gate that catches a rename in one half of the codebase without a matching update in the other half: a future PR that drops 'panelist_must_fix' from the reducer without also removing its test reference fails this suite. 62 assertions, one per symbol per corpus. * docs: Critique Theater user guide (Phase 14.1) Seven sections aimed at end users (not contributors): 1. What is Design Jury 2. How it works (the five panelists, auto-converging rounds, the composite formula) 3. Settings (the M1 toggle and what it does) 4. Reading the score badge 5. Replay surface 6. Troubleshooting (degraded, interrupted, failed) 7. FAQ The composite formula is documented as designer * 0 + critic * 0.4 + brand * 0.2 + a11y * 0.2 + copy * 0.2 because anyone trying to reverse-engineer the score is going to search for those weights and the docs are the place they should land first. * docs(daemon): critique module AGENTS map (Phase 14.2) Daemon-side wayfinder for the apps/daemon/src/critique directory. Tables every file, what owns what invariant, and the 'when you change anything here' guide so a future contributor does not have to reverse-engineer the rollout resolver before adding a new SSE event. * docs(web): Theater module AGENTS map (Phase 14.3) Web-side mirror of the daemon AGENTS map. Same file table, same invariants section, same change-impact guide, sized to the Theater component package. * feat(daemon): rollout flag resolver (Phase 15.1) Single decision point every caller consults to know whether the orchestrator should wire the critique pipeline for a given run. Priority: 1. Skill-level policy (required wins, opt-out wins inversely) 2. Per-project override from the Settings toggle 3. OD_CRITIQUE_ENABLED env override 4. Rollout phase default M0 dark-launch false M1 settings only false (toggle is off until the user flips it) M2 per-skill true if skill opted in M3 global default true OD_CRITIQUE_ROLLOUT_PHASE parser defaults to M0 on unknown input so a fresh install never surprises a user with the feature on. 10/10 vitest cases green covering every cell of the matrix. * feat(web): Settings toggle hook for Critique Theater (Phase 15.2) React hook that reads critiqueTheaterEnabled from the existing open-design:config localStorage blob and stays in sync via: - the platform storage event (cross-tab) - a open-design:critique-theater-toggle CustomEvent (same-tab) Same-tab event is the one that fires when the Settings panel saves in the current window: the toggle and every mounted theater update without a page reload. setCritiqueTheaterEnabled(next) is the imperative setter the Settings panel calls. It preserves the rest of the stored config (mode, apiKey, etc.) and dispatches the same-tab event after the localStorage write. The web hook reflects what the user toggled; the daemon-side isCritiqueEnabled is the final routing authority (project override, env, rollout phase). When they disagree, the daemon wins for backend gating and the web reflects the toggle state. 6/6 vitest cases green covering first read, stored read, same-tab event flip, config preservation, corrupted JSON tolerance, and cross-tab storage event. * test(web): Phase 15 toggle hook failure-mode coverage (PR #1320) lefarcen P2 on PR #1320 flagged that the PR body claimed safe behavior for disabled localStorage, non-object JSON, and missing CustomEvent shim, but the suite only covered corrupt JSON plus happy-path storage events. Added four failure-mode tests so the swallowed errors are not silently traded for a throw in a future refactor: 1. Returns false on a stored JSON value that parses to an array (non-object). Catches a regression where the guard treats anything truthy as a config blob. 2. Returns false on a stored JSON value of literal 'null'. typeof null === 'object' in JS, so the guard has to check null explicitly; this test pins that check. 3. Returns false when localStorage.getItem throws (private mode / disabled storage / SecurityError). The hook must swallow and return false so the rest of the app keeps rendering. 4. setCritiqueTheaterEnabled still dispatches the same-tab CustomEvent when localStorage.setItem throws (quota exceeded / disabled storage). The dispatch path is the in-session broadcast that keeps every mounted hook coherent even when persistence is unavailable; verified by mounting two probes and asserting both flip after the setter is called with a throwing setItem. 10/10 vitest cases green (6 existing + 4 new). * fix(web): honor CustomEvent payload in toggle hook listener (PR #1320) Both Siri-Ray (blocking) and lefarcen (P2 new) caught the same real bug in the failure-mode test I added in affcdd27: the test asserts the in-session UI flips when localStorage.setItem throws, but the CustomEvent listener was ignoring the event's typed detail and just calling readToggle(). Under a throwing setItem the localStorage value is stale (or absent), so the listener would see the OLD value and the test would fail (or worse, the production claim 'in-session event keeps mounts coherent' was hollow). Fixed the hook, not the test: the listener now reads event.detail.enabled when it is a boolean, falling back to readToggle() only for malformed events or for cross-tab storage events (which do not carry a typed payload). The setter already dispatched the detail; the listener just was not consuming it. Test changes: - The existing 'setItem throws' test now asserts the right behavior for the right reason. Updated the inline comment to say the listener reads from detail, not localStorage. - New test 'falls back to readToggle when the CustomEvent carries no usable detail' pins the fallback path: a malformed dispatcher (no detail, or detail.enabled not a boolean) degrades cleanly instead of throwing or being silently ignored. 11 / 11 vitest cases green (10 prior + 1 new fallback). * feat(daemon): route critique spawn-path eligibility through the rollout resolver The wireup edit Phase 10 and Phase 15 carved out: today server.ts gates the critique pipeline on critiqueCfg.enabled, which is just the OD_CRITIQUE_ENABLED env var. After this commit it gates on isCritiqueEnabled(...) from the Phase 15 resolver, so the full priority matrix is live: 1. Per-skill od.critique.policy veto (opt-out / required) 2. Per-project override (M1 Settings toggle, written through the existing Phase 6 settings endpoint) 3. OD_CRITIQUE_ENABLED env override (power-user lane / CI fixtures) 4. OD_CRITIQUE_ROLLOUT_PHASE default M0 dark-launch false M1 settings only false M2 per-skill only when skillPolicy === 'opt-in' M3 global default true Default behaviour on a fresh install is unchanged: the resolver returns false at M0 without an env override or a project override, so prod traffic falls through to the legacy single-pass path exactly the way it did before. Inputs threaded today: phase from OD_CRITIQUE_ROLLOUT_PHASE, envOverride from OD_CRITIQUE_ENABLED. skillPolicy and projectOverride are passed as null for the v1 cutover; the daemon-side handler that round-trips critiqueTheaterEnabled on the project settings row and the od.critique.policy frontmatter resolver land as the next two commits in this branch. The three call sites that used critiqueCfg.enabled (the brand-thread guard, the skill-thread guard, the top-line critiqueShouldRun compound) now read from a single locally-scoped critiqueEnabledForRun boolean, so the eligibility check is computed exactly once per spawn and the prompt composer + orchestrator stay in lockstep the way the existing comment already promised. Tests still green: daemon vitest 22 / 22 across rollout + conformance + adapter-degraded. Daemon typecheck clean. * feat(web): mount CritiqueTheaterMount in ProjectView The web counterpart of the daemon wireup. ProjectView now renders <CritiqueTheaterMount projectId={project.id} enabled={...} /> as a sibling of <AppChromeHeader> inside the top-level <div className="app">. The mount is the drop-in from the Phase 9 stack: it owns the SSE subscription, the kill-request handshake, and the phase-aware swap from the live <TheaterStage> to the collapsed badge once a run settles. The mount returns null until the daemon emits a critique.run_started for the active project, so the visual surface is byte-for-byte unchanged for users who have not opted in. Enabled wiring: useCritiqueTheaterEnabled() reads the M1 Settings toggle from the existing open-design:config localStorage blob and stays in sync with both the platform storage event (cross-tab) and the same-tab open-design:critique-theater-toggle CustomEvent the Phase 15 setter dispatches. The hook honors the event payload directly so a private-mode browser that cannot persist the toggle still updates the in-session UI correctly. The daemon-side gate (isCritiqueEnabled in apps/daemon/src/server.ts) remains the authority for whether a run is actually wired through the critique pipeline. This hook only governs whether the web layer renders the resulting SSE stream when the daemon emits one. The two-layer gate is intentional: an integrator embedding the Theater in a custom UI can flip the web visibility independent of the daemon's routing decision, and a daemon-side env override flips backend gating without touching the web's localStorage. Tests still green: web Theater suite 181 / 181 across 16 files. Web typecheck clean. * feat(daemon): resolve od.critique.policy frontmatter at the spawn site The next step in the wireup branch's ladder: replace the placeholder `skillPolicy: null` with the actual value parsed from the active skill's SKILL.md frontmatter. Three small edits, one new field on a public type: 1. SkillInfo gains a `critiquePolicy: SkillCritiquePolicy` field carrying the parsed `od.critique.policy` token (required / opt-in / opt-out / null). The field is null when the skill has no opinion, which lets the lower-priority resolver tiers (projectOverride, envOverride, phase default) decide. 2. listSkills() populates the new field via a small `normalizeCritiquePolicy` helper that tolerates the YAML scalar's casing and trims whitespace. Unknown tokens collapse to null so a typo in SKILL.md cannot accidentally force the panel on or off; it just falls through. Derived example cards inherit the parent's policy. 3. server.ts captures `skill.critiquePolicy` into a hoisted `skillCritiquePolicy` variable inside the existing skill-load block, then threads it into the isCritiqueEnabled call as the skillPolicy input. The hoisting keeps the variable in scope at the resolver call site without restructuring the spawn handler. After this commit, the priority matrix the rollout resolver was designed for is live for its top tier. The previous commit wired env + phase; this one wires skill. The projectOverride input remains null pending the next commit that extends the Phase 6 settings endpoint. Daemon vitest: 10 / 10 rollout cases pass against the new wiring. Daemon typecheck: clean. * feat(daemon): feed projectOverride into the rollout resolver from project metadata Replaces the placeholder `projectOverride: null` in the spawn handler with the actual value the Settings panel writes onto the project's metadata blob: `critiqueTheaterEnabled?: boolean`. The read is defensive at the boundary: the metadata object is typed loosely (it round-trips through SQLite as a free-form JSON blob), so the spawn handler narrows to `boolean` and falls through to `null` for any other shape. A missing key, a malformed value, or a project that has never visited Settings collapses to `null`, which is exactly the resolver's "no opinion, fall through to env / phase" signal. The `critique` frontmatter slot also gets typed on the SkillFrontmatter shape so the `od.critique.policy` chain the previous commit introduced no longer needs a bracket-access cast. Same pattern as the existing `craft`, `preview`, and `design_system` nested-record slots. After this commit, every tier of the rollout resolver's priority matrix is wired: 1. skillPolicy (from SKILL.md od.critique.policy) 2. projectOverride (from project metadata critiqueTheaterEnabled) 3. envOverride (from OD_CRITIQUE_ENABLED) 4. rollout phase (from OD_CRITIQUE_ROLLOUT_PHASE) The write path for projectOverride still flows through the existing project-update handler the Settings panel already uses to persist project metadata; no new endpoint is needed. The Settings UI button that calls setCritiqueTheaterEnabled and posts the new field is the next commit on this branch. Daemon typecheck: clean. Daemon vitest: 10 / 10 rollout cases still green against the new wiring. * fix(daemon): forward critique events to project sinks + align composer gate (PR #1338) Two codex review items addressed in one commit since they share the same root cause (resolver-enabled run hits a transport / prompt contract that was still env-gated): P1 (transport mismatch). The daemon emits critique.* SSE frames through critiqueBus -> design.runs.emit, which fans out on /api/runs/:runId/events. The web CritiqueTheaterMount subscribes to /api/projects/:projectId/events (it's project-scoped, not run- scoped, because the mount lives at the project workspace and follows the user across runs). Result: in production the mount never sees a real frame and the e2e tests' stubbed routes hide the mismatch. Fixed by extending critiqueBus.emit to fan out to BOTH sinks: the existing runs.emit transport, AND the per-project event-sinks map. The project-events route emits via sse.send(payload.type, payload), so we pack the SSE channel name onto payload.type and let the sink push the right channel. The web sseToPanelEvent overwrites type from the channel name on the way back into a PanelEvent, so the round-trip stays correct. P2 (prompt gate misalignment). composeSystemPrompt reads cfg.enabled to decide whether to append the panel addendum, but critiqueCfg.enabled is loaded from OD_CRITIQUE_ENABLED only. A run the resolver enabled via phase / project / skill (env unset) would have critiqueShouldRun = true while critiqueCfg.enabled remained false, dropping the panel prompt while still routing through runOrchestrator -> parser waits for tags that never arrive -> run degrades. Fixed by passing a derived config { ...critiqueCfg, enabled: true } to the composer when critiqueShouldRun is true. The composer's own gate now agrees with the resolver decision on every input the spec defines. Daemon typecheck: clean. Daemon vitest: 10 / 10 rollout cases still green against the new wiring. * fix: address PerishCode P1 + P2 follow-ups on PR #1338 Two follow-up items PerishCode flagged on the activation PR. Non-blocking but both are real: 1. Phase 11 e2e suite was wired into test:ui:extended but lands the user on '/' (home route) where ProjectView (and therefore CritiqueTheaterMount) is never rendered. With the suite as written, every assertion would time out the first time the lane runs in CI, contradicting the PR body's claim that the suite stays parked behind test.describe.fixme. The state diverged from my earlier Phase 11 work because the merge from main on commit 4ab719c6 brought in #1307's squash-merged version of the e2e file (the pre-fixme shape). Re-applied test.describe.fixme to the describe block plus removed ui/critique-theater.test.ts from the test:ui:extended script in e2e/package.json. Added a file-header docblock explaining what the follow-up commit needs to do: replace goto('/') with /projects/:id navigation similar to app-design-files.test.ts, split the SSE fixture into a live prefix and terminal suffix (Codex P2 on PR #1320), and commit the first PNG baselines. 2. bestRoundOf in CritiqueTheaterMount returned the LAST round with a numeric composite, not the round with the HIGHEST composite, while bestCompositeOf correctly returned the max. A run that closed round 1 at 8.5 and round 2 at 6.0 would dispatch interrupted { bestRound: 2, composite: 8.5 } on a user-clicked interrupt. Folded the two helpers into a single bestRoundAndComposite that walks state.rounds once and returns the matching pair so the two values cannot drift. The onInterrupt callback now destructures from one helper instead of two independent reads. Falls back to (state.activeRound, 0) when no round has closed with a composite yet. Web typecheck: clean. CritiqueTheaterMount.test.tsx: 7 / 7 cases still green against the new helper. * fix: wire M1 project override end-to-end + correct deferred-surface doc claims (PR #1338) Three lefarcen P2s on the latest review pass, all real: 1. M1 project override was half-wired: the daemon read metadata.critiqueTheaterEnabled but the web setter only wrote localStorage. A user opt-in would render the Theater on the web (localStorage was set) while the daemon resolved projectOverride=null and skipped critique unless env / phase already permitted. Two halves talking past each other. Extended setCritiqueTheaterEnabled to accept an optional { projectId, fetchProjectSettings } options bag. When a projectId is supplied, the setter ALSO sends a PATCH /api/projects/:id with { metadata: { critiqueTheaterEnabled } } so the daemon's spawn-time resolver picks the same value up on the next generation. The existing project-routes endpoint already accepts arbitrary metadata patches, so no new endpoint is needed. The local write + the CustomEvent dispatch still fire before the PATCH, so a network failure does not unwind the in-session UI flip. Three new vitest cases pin the new path: PATCHes when projectId is provided, skips when it is not, swallows a rejected PATCH so the in-session UI still flips. 2. Rollout docs (docs/critique-theater.md section 3) claimed the Settings toggle persists into the daemon settings store, but the previous implementation only had a localStorage reader / writer plus a daemon read of project metadata, with no round-trip. Rewrote the section to lead with the four-tier resolver (skill policy / project override / env / phase), document that the setter now round-trips via the existing PATCH endpoint when given a projectId, and call out the Settings panel UI control as a deliberate follow-up. 3. Troubleshooting table pointed users at /api/metrics/critique (Phase 12, deferred) and 'od adapters clear-degraded <id>' (CLI wrapper that does not exist). Replaced the metrics reference with the local conformance harness command (pnpm --filter @open-design/daemon vitest run tests/critique-conformance.test.ts) that ships today, with a note that the Phase 12 dashboard surfaces this status as a series once that PR lands. Replaced the CLI command with the programmatic clearDegraded() helper that exists today and flagged the CLI wrapper as planned follow-up. Web typecheck: clean. Toggle hook tests: 14 / 14 green (11 existing + 3 new for the round-trip path). * test(web): multi-round interrupt regression for bestRoundAndComposite (PR #1338) lefarcen P3 follow-up to the previous bestRoundAndComposite fix: the existing CritiqueTheaterMount.test.tsx interrupt cases only exercised a single-round state, so a future refactor back to two independent helpers wouldn't be caught by the test suite even though it'd reintroduce the round / composite drift bug. Added a regression case that: 1. Drives the reducer through two complete rounds with the full 5-role cast closing at distinct composites: round 1 at 8.5, round 2 at 6.0 (the high-composite round is NOT the most recent one). 2. Clicks Interrupt + waits for the daemon ack via the test seam fetcher returning 204. 3. Asserts the collapsed badge displays "round 1" (the correct best-composite round), and queryByText for "round 2 ... 8.5" returns null (the buggy pairing would have produced that string). The bestRoundAndComposite helper walks state.rounds in one pass and returns the matching pair, so the round number and the composite cannot drift apart. This test locks the fix in: a refactor that splits the helpers back into independent walks will be caught here. 8 / 8 vitest cases green on the file. * fix(web): read-merge-write the project metadata in setCritiqueTheaterEnabled (PerishCode P2 on PR #1338) The previous round-trip sent { metadata: { critiqueTheaterEnabled: next } } as the entire PATCH body. The daemon's project-routes handler only re-stamps three immutable fields (baseDir, importedFrom, fromTrustedPicker) before calling updateProject(db, id, patch), which then does a shallow { ...existing, ...patch } in apps/daemon/ src/db.ts. So patch.metadata replaces the row's metadata wholesale, dropping kind, templateId, linkedDirs, and every other field the rest of the app reads. No in-tree caller passes projectId today (only vitest cases), so the bug had not surfaced yet. But the surface is documented in docs/critique-theater.md section 3 and the function's own JSDoc as the M1 round-trip path, so it would have shipped as a latent footgun for the next integrator: a Settings UI follow-up, or any third party that wires the setter into a project-aware surface. Fix: read-merge-write rather than a bare patch. - GET /api/projects/:id to read the row's current metadata. - Spread that metadata into the PATCH body and overlay critiqueTheaterEnabled: next on top, mirroring the partial-metadata pattern already used in ChatComposer.tsx for linkedDirs. - PATCH the merged object. Failure handling: - GET fails: skip the PATCH entirely. We cannot construct a safe merged body without the current state, and a bare patch would wipe other metadata. The in-session CustomEvent fired earlier in the setter still keeps every mounted hook consistent; the next save retries the round-trip. - PATCH fails: log in dev. The in-session UI is already correct via the CustomEvent. Tests (TDD, red-first): - 'GETs the project then PATCHes with merged metadata when a projectId is supplied': stubs a GET that returns { kind: 'template', templateId: 'modern-blog', linkedDirs: [...] } and asserts the PATCH body equals the merge plus the toggle. - 'PATCHes with just the toggle when the project has no prior metadata': stubs a GET that returns no metadata block. - 'skips the PATCH (does not stomp metadata) when the prefetch GET fails': stubs a rejecting GET and asserts only the GET fires. - 'swallows a rejected PATCH after a successful prefetch': stubs a successful GET and a rejecting PATCH; asserts the in-session UI still flips via the CustomEvent. Doc updated on the setter's JSDoc to describe the new three-step flow (localStorage, CustomEvent, read-merge-write PATCH) and the two failure modes. Verified: - pnpm --filter @open-design/web typecheck clean. - pnpm --filter @open-design/web test: 111 files / 1055 tests green (was 1052, +3 from the new merge-flow cases). * fix(web): restore wait-for-daemon-ack pattern on Theater interrupt Same regression as flagged on PR #1316 post-main-merge: the optimistic local dispatch fired before the POST resolved, so a daemon 404 / 409 still terminalized the UI and the real SSE terminal event got ignored by the sticky interrupted phase. Snapshot runId / bestRound / composite at click time, dispatch interrupted only on res.ok, clear interruptPending on rejection or non-2xx so the user can retry. Tests cover rejection + 404 leaving the run on the live stage; the 204 path waits for the ack. * feat(daemon): Critique Theater Phase 12 observability foundations Lands the metrics registry, the structured logger, the /api/metrics route, and the adapter-degraded bump that wires up the first data point. The orchestrator-side bumps for runs / rounds / composite / must-fix / interrupted / parser_errors / protocol_version land in a follow-up commit on this branch (kept separate so the wiring diff reads cleanly against the registry shape). Surfaces added: - apps/daemon/src/metrics/index.ts: 9 Prometheus series under the open_design_critique_* namespace with the histogram buckets the spec calls out (round_duration_ms at 100 / 250 / 500 / 1000 / 2500 / 5000 / 10000 / 30000 / 60000 ms; composite_score at 0-10 integer steps). - apps/daemon/src/logging/critique.ts: 6 typed events, one JSON line per call on stdout, namespaced critique. Matches the JSON-per-line convention cli.ts already uses; no new logger framework. - apps/daemon/src/server.ts: GET /api/metrics route. Honors OD_METRICS_ENDPOINT=disabled to opt out for air-gapped installs. - apps/daemon/src/critique/adapter-degraded.ts: markDegraded now bumps degraded_total so the adapter-health dashboard panel reflects every TTL refresh and every fresh mark. Deps: prom-client ^15.1.0, @opentelemetry/api ^1.9.0 added to apps/daemon/package.json. Both are zero-config no-ops without an exporter wired; daemon bundle size impact is ~150 KB uncompressed. The @opentelemetry/api dep is in place ahead of the OTel-spans follow-up commit; it adds no behavior on this commit. Tests: - tests/metrics/critique.test.ts (3 cases): registry shape + exposition text + reset-between-tests - tests/logging/critique.test.ts (4 cases): event shape + ordering + newline framing + namespace stamping Verification (Windows-local): - pnpm --filter @open-design/daemon typecheck: clean - New metrics + logging suites: 7 / 7 green - Existing adapter-degraded + conformance + rollout suites: 22 / 22 green; the bump is non-breaking * feat(daemon): wire Critique Theater metrics + structured logs from the orchestrator Lights up the bump sites the Phase 12 foundations PR registered the series for. Every panel event the parser surfaces now reaches the matching Prometheus counter / histogram and the matching JSON log line on stdout. Switch-loop bumps + logs: - run_started: log run_started, set protocol_version gauge to the observed protocol version (small-integer cardinality). - panelist_open: record the first-open wall-clock per round so round_end can compute round_duration_ms; subsequent opens in the same round leave the start time untouched. - panelist_must_fix: bump must_fix_total with the panelist role. The wire event does not yet carry a dim name, so the label is 'unspecified' for now; a future parser revision can drop in the real dim without a metric rename. - round_end: bump rounds_total, observe composite_score, observe round_duration_ms (current ms minus the tracked start), log round_closed with the composite / mustFix / decision triple. - parser_warning (parser-yielded): bump parser_errors_total with the kind label, log parser_recover with kind + position. Orchestrator-side parser warnings (composite_mismatch and duplicate_ship from the daemon-authoritative scoring checks) go through a new emitParserWarning helper so the bus emit, the collectedEvents push, the metric bump, and the log line stay in lockstep. Three inline emission sites collapse to one-line helper calls. After the try/catch, a single terminal-status switch bumps runs_total{status, adapter, skill} once per run, with branch- specific log + counter: - shipped / below_threshold: log run_shipped - interrupted: bump interrupted_total, log run_failed{cause: interrupted} - timed_out: log run_failed{cause: timed_out} - failed: log run_failed{cause: orchestrator_internal} - degraded: log degraded{reason: orchestrator_classified} OrchestratorParams gains optional skill: string for the label; defaults to 'unknown' so spawn sites that have not yet threaded it keep working without a metric shape change. Tests: - The new metrics + logging suites (7 / 7) verify registry shape and event framing; orchestrator-side metric integration is exercised through the existing critique-conformance and critique-adapter-degraded suites (22 / 22 still green). - Logger test reassigns process.stdout.write directly instead of vi.spyOn so the Node overloaded write signature does not collide with MockInstance<unknown>. * feat(observability): Grafana dashboard JSON for Critique Theater Three default rows mapping to the metrics this branch wires up: 1. Fleet quality: composite score p50 / p90 / p99 line graph by adapter, plus a heatmap of the composite distribution. The line graph answers 'are my agents getting better over time'; the heatmap answers 'are the bad runs clustered around one adapter or smeared across the fleet'. 2. Adapter health: stacked bar charts for degraded marks (by adapter / reason) and parser errors (by adapter / kind) over a 5-minute window. The two queries together let an operator see 'is this adapter degraded because of malformed wire output or because of oversize blocks' without flipping panels. 3. Brief throughput: runs-per-hour by terminal status, an average rounds-per-run stat per adapter, and a round-duration ms p50 / p90 / p99 line. Throughput numbers fall straight out of the runs_total / rounds_total counters; the duration histogram is the same one the runs feed. The dashboard uses a templated $datasource var (defaults to 'prometheus') so an operator with multiple Prometheus instances can switch without editing JSON. Schema version 39 (Grafana 11). Operators import via: pnpm dlx @grafana/cli dashboard import tools/dev/dashboards/critique.json or paste into a provisioned dashboards directory. The file is checked into the repo as a starting artifact; alert rules and SLO panels ship after the first 1000 runs inform the right thresholds. JSON validates with node -e 'JSON.parse(...)' (sanity checked locally). * feat(daemon): OpenTelemetry outer span around the critique run Wraps each runOrchestrator call in a 'critique.run' span via the existing @opentelemetry/api dep added in the Phase 12 foundations commit. Attributes set on the span: - critique.run_id, critique.adapter, critique.skill at start - critique.final_status, critique.final_composite on terminal resolution - span status flipped to ERROR for failed / timed_out runs so a Tempo / Honeycomb / Jaeger filter on traces.status=error surfaces the right slice without joining back to Prometheus No exporter is wired by default; @opentelemetry/api is the API package and intentionally splits from @opentelemetry/sdk-*, so the span is zero-overhead until an operator attaches an SDK through their runtime config. Inner per-round / parse_chunk / scoreboard_eval / persist_round / ship.persist spans defined in the Phase 12 plan are a follow-up: the outer span alone gives the trace a duration + final status + adapter/skill labels, which is the 80% value for dashboards that correlate runs across services. Adding child spans inside the existing 600-line orchestrator without restructuring is a separate careful change. Verification: - pnpm --filter @open-design/daemon typecheck: clean - 29 / 29 critique + metrics + logging tests still green * fix(nix): bump pnpmDepsHash for prom-client + @opentelemetry/api lockfile bump nix-check failed on PR #1485 with hash mismatch in open-design-daemon-pnpm-deps and open-design-web-pnpm-deps after the Phase 12 foundations commit (2b8b7445) added prom-client and @opentelemetry/api to apps/daemon/package.json and refreshed pnpm-lock.yaml. CI reported the new sha: specified: HFLm+8hv3o5x3Xem4MXNsNclIgiVRc70+EBafL0rVn8= got: 7R1sQC38gOT0gsZ2oNOviCZ486cbbGJGJCis6WI8z9s= Both nix files pin the same workspace lockfile, so both flip in lockstep. No other Nix surface changes required. * fix(daemon): four Phase 12 review findings (Codex P2 x2 + Siri-Ray P2 + lefarcen P2) 1. Siri-Ray P2 in orchestrator.ts (round metric / log used untrusted agent values). The new observability path now records rs.composite and rs.mustFix (daemon-authoritative) instead of event.composite and event.mustFix when rs exists, and skips the bumps + log entirely when rs is missing (a degenerate round_end without any matching panelist_open). The dashboard p50 / p90 / p99 now agrees with persistence and ship decisions; an adapter reporting <ROUND_END composite='10'> while the daemon computed 6 logs 6 and still emits the composite_mismatch parser warning the prior block was already producing. 2. Codex P2 in server.ts (skill label always 'unknown'). The spawn path called runOrchestrator without passing the resolved skill id, so every live run bumped open_design_critique_*{skill='unknown'} and the per-skill dashboard breakdown was always empty. Threaded effectiveSkillId (already computed at the same handler scope as the project skill fallback) through skill: . . . so the metric reflects the real skill when one is assigned, and the orchestrator default of 'unknown' only fires for runs that genuinely have none. 3. Codex P2 in conformance.ts (protocol-version mismatch let through). An adapter that emitted <CRITIQUE_RUN version='2'> followed by a valid SHIP classified as shipped because the harness only watched for terminal events. Added a guard inside the parse loop: if a run_started carries protocolVersion !== CRITIQUE_PROTOCOL_VERSION, mark the adapter degraded with reason 'protocol_version_mismatch' (already in DEGRADED_REASONS) and return early. ConformanceOutcome union widened to accept the new reason. 4. lefarcen P2 in tools/dev/dashboards/critique.json (runs-per-hour panel under-reported by 3600x). 'rate(...[1h])' returns per-second. Multiplied by 3600 so the panel title and unit match the actual value rendered. Verification: - pnpm --filter @open-design/daemon typecheck: clean - New metrics + logging suites (7), existing adapter-degraded (7), conformance (5), rollout (10): 29 / 29 green - Grafana JSON re-parses with node -e 'JSON.parse(...)' * fix(nix): set pnpmDepsHash to fakeHash so CI surfaces the real hash for the regenerated lockfile (lefarcen P1 on PR #1485) * fix(nix): pin pnpmDepsHash to sha256-NtXbiRU0YZ4EVJVNC6N3sR1S0ozA3BvCwgXI0L0OMH4= from CI nix-check output --------- Co-authored-by: Nagendhra <nagendhra405@gmail.com>	2026-05-13 22:11:27 +08:00
lefarcen	e1bc83a476	feat(analytics): PostHog product analytics (P0 events, consent-gated, packaged) (#1428) ... * feat(analytics): scaffold PostHog product-analytics integration - Add @open-design/contracts/analytics subpath with the 17 P0 event payload types, header constants, and code↔CSV enum mapping helpers. - Add apps/daemon/src/analytics.ts with env-gated posthog-node client, request-scoped analytics context reader, and artifact-id anonymizer. - Expose GET /api/analytics/config so the web bundle never embeds the PostHog key at build time; daemon owns POSTHOG_KEY / POSTHOG_HOST. - Add apps/web/src/analytics module (identity + lazy posthog-js client + React provider) and mount it under <I18nProvider> in app/layout. No event wiring yet — that lands in the next commit alongside trigger points (App.tsx, EntryView, NewProjectPanel, SettingsDialog, FileViewer, runs.ts). * feat(analytics): wire app_launch, home_view, home_click, project_create_result - App.tsx: fire app_launch once after first effect tick. handleCreateProject now emits project_create_result on both success and failure paths. - EntryView.tsx: home_view (page) gated on agents loading so has_available_cli isn't transiently false; home_view (asset_panel) fires per top-tab change with the right result_count. - NewProjectPanel.tsx: home_click create_button fires before delegating to the parent; a fresh request_id is generated here and threaded through onCreate so the matching project_create_result stitches via $insert_id. - contracts/analytics: tighten createTabToTracking and topTabToTracking for the worktree branch's renamed tabs (live-artifact, templates). * feat(analytics): wire settings_view + 3 settings_click events - settings_view fires on dialog mount and on every section switch, carrying the active section (mapped via settingsSectionToTracking for the 16-section worktree layout), execution_mode, and the selected CLI provider id when present. - settings_click execution_mode_tab: setMode now emits before/after values whenever the user toggles between Local CLI and BYOK. - settings_click cli_provider_card: agent card onClick reports cli_provider_id via agentIdToTracking (kiro → other). - settings_click byok_field: onFocus added to api_key, model select, and base_url inputs; provider_id widened to include google so the worktree's Gemini protocol slot type-checks. * feat(analytics): wire studio_view + studio_click chat, studio_view artifact - packages/contracts/src/analytics/artifact-id.ts: FNV-1a 64-bit helper produces a 16-hex anonymized id for (projectId, fileName). Stable cross-platform so the daemon and the web bundle resolve the same id without a Web Crypto round-trip; daemon now re-exports it. - ChatComposer: studio_view chat_panel fires once per project mount, studio_click chat_composer fires on attachment + send buttons with estimated user_query_tokens (length/4) and has_attachment. - FileViewer: studio_view artifact fires once per (project, file) at the dispatcher level, before any sub-viewer renders, with artifact_kind derived from the renderer registry / file.kind table. - Widen TrackingExportFormat to include markdown and cloudflare_pages so the worktree branch's full share menu can emit verbatim. * feat(analytics): wire studio_click share_option + artifact_export_result HtmlViewer's share menu now emits both events per click via a fireShareExport helper: - studio_click share_option fires immediately on click with the chosen export_format and a fresh request_id. - artifact_export_result fires when the export resolves — success for sync exporters (html, markdown, template) the moment the call returns, success/failed for async exporters (pdf, zip, deploy) via .then/.catch. The same request_id threads both events so PostHog stitches click → result via $insert_id. DEPLOY_PROVIDER_OPTIONS maps to the CSV's vercel / cloudflare_pages slots; markdown is now a first-class export_format value. Also ignore .env.local so local POSTHOG_KEY / .env-style secrets don't get committed. * feat(analytics): emit run_created and run_finished from the daemon POST /api/runs now reads the analytics context off the x-od-analytics-* headers the web client sets on every fetch, then: - Captures run_created with project_id, conversation_id, run_id, model_id, agent_provider_id (mapped via agentIdToTracking), skill_id, design_system_id, plus the token_count_source marker. - Schedules a run_finished capture on runs.wait(run) resolution, mapping succeeded/canceled/failed to success/cancelled/failed and reporting total_duration_ms. Both events use a stable insert_id derived from the same uuid so PostHog dedupes the daemon-side mirror against any future web-side capture without double-counting. Token sub-fields (user_query_tokens/system_prompt_tokens/...) stay omitted in v1 — the claude-stream parser only exposes input/output totals today. See tracking-doc-issues.md §3.2. * feat(analytics): emit settings_cli_test_result + settings_byok_test_result The original BLOCKING-list assumed these CSV P0 events were not implementable in this branch because main lacked Test buttons. The worktree HEAD actually wires `handleTestAgent` and `handleTestProvider` in SettingsDialog, so both events are now in scope. - handleTestAgent emits settings_cli_test_result on success and failure paths with cli_provider_id mapped via agentIdToTracking, result drawn from result.ok / catch branch, error_code from result.kind or the thrown error name, and duration_ms timed via performance.now(). - handleTestProvider emits settings_byok_test_result analogously, using apiProtocol (anthropic|openai|azure|ollama|google) directly as provider_id — wider than the CSV's 5-value enum, documented in tracking-doc-issues.md §2.5. Contracts: add SettingsCliTestResultProps / SettingsByokTestResultProps plus matching track* helpers. AnalyticsEventName union now covers all 14 P0 events this branch supports. * feat(analytics): gate PostHog on the existing telemetry.metrics consent The integration now reuses the same first-launch privacy banner + Settings → Privacy toggle that gates Langfuse, so a single user decision controls both telemetry sinks. - /api/analytics/config now consults the persisted AppConfigPrefs: it returns enabled=true only when POSTHOG_KEY is set AND the user has chosen "Share usage data" (telemetry.metrics === true). The response also echoes installationId so the web client uses the same anonymous id Langfuse keys off of — one identity per install, shared across both sinks. - Web AnalyticsProvider: - Bootstrap fetch resolves installationId and threads it through the x-od-analytics-anonymous-id header on every /api/* fetch, so daemon-side captures (run_created / run_finished / project_create_result) land on the same person record. - Exposes a setConsent(granted) method that calls posthog-js's opt_in_capturing / opt_out_capturing, wired from App.tsx via a useEffect watching config.telemetry?.metrics. Toggling Privacy → metrics now stops/resumes events immediately, no reload. - app_launch additionally gates on telemetry.metrics so a freshly- declined user fires nothing, and a freshly-opted-in user fires on the next reload. * feat(packaging): bake POSTHOG_KEY into packaged daemon spawn env Wires PostHog product analytics through the same Langfuse-style build- secret pipeline so official Open Design builds ship with the key while fork builds compile without it (the integration short-circuits cleanly when POSTHOG_KEY is absent). tools/pack - resolveToolPackConfig reads POSTHOG_KEY / POSTHOG_HOST from process.env at packaging time, validates them (no whitespace in the key, http(s) URL for host, trailing-slash strip), and stamps them on ToolPackConfig. Fork builds without the env vars simply omit the fields; the daemon-side gate keeps things off in that case. - Mac, Windows, and Linux packaged-config writers each append the two fields to open-design-config.json next to the existing telemetryRelayUrl entry. apps/packaged - RawPackagedConfig / PackagedConfig surface posthogKey / posthogHost so the Electron entry and headless entry both forward them to the daemon sidecar. - buildPackagedDaemonSpawnEnv emits POSTHOG_KEY / POSTHOG_HOST into the daemon child env when present. The daemon's existing analytics module reads these via process.env — no daemon-side changes needed. - The headless packaged path falls back to process.env for fields the builder hasn't injected, mirroring how OPEN_DESIGN_TELEMETRY_RELAY_URL is read there. CI - release-beta.yml and release-stable.yml expose POSTHOG_KEY (secret) and POSTHOG_HOST (var) at workflow-env scope so every packaging job inherits them. PR / fork builds without these set simply skip the bake step. Tests - tools/pack: config.test.ts covers bake-through, fork-build omission, whitespace rejection, invalid-URL rejection, and trailing-slash normalization. - apps/packaged: sidecars.test.ts covers buildPackagedDaemonSpawnEnv forwarding the keys when present and omitting them when null. * feat(analytics): enable PostHog autocapture + perf + exceptions Flip on the PostHog SDK's automatic diagnostic features so we capture click paths, page transitions, web vitals, dead clicks, and browser exceptions without scattering instrumentation through the codebase. Privacy defense lives in one place — apps/web/src/analytics/scrub.ts — wired in via posthog-js's `before_send` hook so every outgoing event passes through the same audit point: - $autocapture / $rageclick / $dead_click / $copy_autocapture: strips $el_text and value/placeholder/aria-label attrs from any input, textarea, password input, or contenteditable element. PostHog autocapture does not capture input.value by default, but $el_text on a <textarea> reflects the typed content — that's the prompt body for us, so it has to be scrubbed every time. - $pageview / $pageleave: drops query string and fragment from $current_url / $referrer so any future ?q=… can't leak. - $exception: rewrites file:// and absolute filesystem paths in stack frames to app://apps/<repo-relative> so we don't ship the user's home directory. - Suppresses $opt_in entirely — duplicate of our explicit setConsent toggle in App.tsx. Element-level defense in depth is limited to the single most sensitive surface: the chat composer textarea gets `ph-no-capture` so PostHog never even generates an event for clicks inside that subtree. Every other input relies on scrub.ts — sprinkling the class through every form would be noisy and easy to forget on new surfaces. The existing Privacy → "Share usage data" toggle continues to gate every new feature: posthog-js's opt_out_capturing() halts autocapture, $pageview, $exception, web vitals, and dead clicks alongside the explicit capture() calls — one global switch. 11 unit tests pin the scrub rules in apps/web/tests/analytics-scrub.test.ts. * ci(nix): bump pnpmDepsHash for posthog-js + posthog-node additions Adding posthog-js to apps/web and posthog-node to apps/daemon changed pnpm-lock.yaml, which Nix's fixed-output pnpmDeps derivation pins by sha256. The CI nix flake check failed with: specified: sha256-KF3Mld72/iau+pJmA7HvnanRx8VLtDP0N624SKrtrrc= got: sha256-PGFgX4lYyeH2TRAXfUq52A3EOa6bb1gO59hPsXhEk3s= Copy the new hash into both nix/package-web.nix and nix/package-daemon.nix per the procedure documented in nix/README.md §"First-build hash pinning". * feat(analytics): unify PostHog identity with Langfuse installationId PostHog's distinct_id is the installationId stamped by /api/analytics/ config; Langfuse already reads the same id off app-config.json to populate trace.userId. With both sinks keying off the same anonymous identity, dashboards can correlate user actions (PostHog events) with LLM runs (Langfuse traces) without re-identifying. Two gaps closed: 1. applyConsent(false) — clear posthog-js's persisted ph_*_posthog localStorage entry on opt-out via posthog.reset(). Without this, a user who opts out, then clicks Delete my data, then re-opts in would see PostHog stitch their new session to the deleted identity because bootstrap.distinctID only takes effect on first init. 2. applyIdentity(newInstallationId) — Delete my data rotates the installationId in app-config; App.tsx now watches config.installationId and calls posthog.reset() then identify(newId) so the next event batch is fully decoupled from the deleted one. Idempotent on same-id re-renders so benign config refreshes don't churn PostHog identities. The fetch wrapper's x-od-analytics-anonymous-id header also flips to the new id on rotation so daemon-side captures (run_created / run_finished) land on the same person record from the very next API call, not after a reload. The end-to-end rotation flow is verified against a live PostHog project; these unit tests pin the safety guards (no-client paths, null inputs) since stubbing posthog-js's init-loaded callback chain is brittle. * fix(langfuse): require both metrics AND content consent for trace reports Tightens the Langfuse gate so a user who shares anonymous metrics but NOT conversation content stops emitting Langfuse traces entirely — Langfuse is used for turn-quality evals which only make sense with prompt/output bodies. PostHog (product analytics, content-free) stays gated on `metrics` alone and is unaffected. i18n: "Conversation content" → "Conversation and tool content" with hints expanded to mention tool inputs/outputs so the consent surface matches what the trace actually carries (en + zh-CN). Bundled here per PR scope — change originated outside this PostHog PR but lands cleanly on the same files; gating Langfuse strictly on `content` makes the dual-sink consent model (PostHog = metrics, Langfuse = metrics + content) symmetric across both i18n locales and the daemon-side gate. * feat(analytics): wire byok_provider_option + fix PR review P1s Adds the BYOK protocol-chip click event (5-value provider_id mirroring the apiProtocol Settings UI) and resolves four P1 review threads on PR #1428. byok_provider_option: - New SettingsClickByokProviderOptionProps in contracts (provider_id = anthropic|openai|azure|google|ollama; maps to CSV's 5 values per tracking-doc-issues.md §2.5). - trackSettingsClickByokProviderOption helper in apps/web/src/analytics. - SettingsDialog hooks it on the protocol-chip onClick alongside the existing setApiProtocol call; is_selected reflects whether the chip was already active. Review fixes: 1. client.ts (Siri-Ray): clear `initPromise` when the resolution is null so a Privacy → metrics opt-in after a previous decline triggers a fresh /api/analytics/config fetch. Without this, the disabled response was cached forever — first-session opt-in needed a reload to start sending PostHog events. 2. provider.tsx (Siri-Ray): replace `url.includes('/api/')` with a strict same-origin + /api/ pathname check (shared `isSameOriginApiCall` helper). Outbound third-party URLs containing `/api/` (e.g. provider.example.com/api/x) no longer receive our x-od-analytics-* headers. 3. provider.tsx (codex-connector, lefarcen): gate header injection on `resolvedAnonId` being non-null. When Privacy → metrics is off, /api/analytics/config returns enabled=false → resolvedAnonId stays null → wrapper never installs → daemon can't read consent-bearing headers → no daemon-side PostHog event. setConsent now also clears resolvedAnonId on opt-out and re-fetches on opt-in. 4. daemon/analytics.ts (defense in depth): createAnalyticsService now takes dataDir and capture() re-reads app-config to check telemetry.metrics inside the fire-and-forget wrapper. Even if a stale header somehow reaches the daemon after opt-out, the capture is dropped before posthog-node.capture is called. * fix(web): place "Share usage data" on the right in privacy consent banner Swap button order in PrivacyConsentModal and the in-settings ConsentCard so the affirmative "Share usage data" lands on the right and "Not now" on the left. Matches the OK-on-the-right pattern users expect for primary actions. Both buttons keep equal visual prominence (same .privacy-consent-action styling) so the swap doesn't change the EDPB equal-prominence stance called out in the original Langfuse telemetry spec. * feat(analytics): populate run_finished token totals from claude-stream usage Daemon's claude-stream parser already emits agent usage events with input_tokens / output_tokens totals; the run service buffers them in run.events and Langfuse reads them out the same way. The run_finished PostHog event was leaving these fields empty. Scan run.events for the most recent agent usage frame on terminal transition and emit input_tokens / output_tokens / total_tokens when present. token_count_source flips to 'provider_usage' only when at least one count landed; runs without provider-side usage data keep 'unknown'. Provider does not break the input down into the 7 sub-fields the tracking doc lists (memory / context / attachment / system_prompt / …); those stay omitted until a parser change exposes them. * feat(analytics): estimate user_query_tokens from prompt length The user_query_tokens field for run_created / run_finished was hardcoded to 0. We can't tokenize without bundling a model-specific tokenizer, but the character/4 heuristic is the industry-standard estimate when one isn't available and is enough for funnel analysis (prompt-length cohorts, short-vs-long-query conversion rates). Extracted from req.body via the same telemetryPromptFromRunRequest pattern the daemon already uses for langfuse-bridge (currentPrompt then message fallback). Only the integer count goes to PostHog — the prompt text itself never leaves the daemon. token_count_source flips appropriately: - run_created with a prompt: 'estimated' (was 'unknown') - run_created with no prompt: 'unknown' - run_finished with provider usage: 'provider_usage' (overrides baseProps' 'estimated' value) - run_finished without provider usage: inherits 'estimated' or 'unknown' from baseProps so input/output absent doesn't mask the estimate.	2026-05-12 22:32:42 +08:00
lefarcen	2a0ebea50b	release: Open Design 0.7.0 ... - bump 14 monorepo package.json files to 0.7.0 (root + apps/{web,daemon,desktop,packaged,landing-page} + packages/{contracts,platform,sidecar,sidecar-proto} + tools/{dev,pack,pr} + e2e); apps/packaged was already at 0.6.1 from beta lane, all others at 0.6.0 - add CHANGELOG.md [0.7.0] - 2026-05-12 entry covering 97 merged PRs since 0.6.0: - Critique Theater: Phase 7 web client state machine (#1307) + Phase 6.2 daemon artifact extraction (#1085) - Web/UI: thumbs-up/down feedback widget (#1308), Cmd+, opens Settings (#1173), Finalize design package + Continue in CLI (#974), fetch models button for BYOK (#1034), provider models alphabetical sort (#1097), collapsible MCP JSON field-mapping (#1136), design file rename (#894) - Daemon: auto-memory store with chat-protocol-aware extraction (#999), install/uninstall skills & design systems (#1003), HTTP 206 range requests for video/audio (#1105), scheduled routines (#1033), agent runtime + route registration refactor (#1063, #1043) - HyperFrames: HTML-in-Canvas across web + skills (#866) - Skills/design systems: generic skills + design-templates split + finalize-design API (#955), agent-browser skill (#1284), WeChat design system + login-flow skill (#1083), hud/loom/trading-terminal design systems (#1069), release-notes-one-pager skill (#873), tokens.css schema (#1231) - Packaging: macOS Intel (x64) build (#759), official Nix flake (#402), beta packaging cache (#1095) - Maintainer ops: tools-pr PR-duty workspace (#1259), MAINTAINERS.md (#1290), contributor card bot (#932), PR→issue linking discipline (#1263) - Changed: conversation run isolation (#1271), default English i18n fallback (#1270), Codex CLI exit diagnostics / empty-response handling / path fallback (#1267, #1244, #1205) - Fixed: ~30 web + desktop + daemon + packaging bugfixes - Internal: nightly UI/desktop regression coverage (#1256), e2e/release report hardening (#1140), entry/settings automation (#954) - catch up [Unreleased] compare link to v0.7.0 and add missing [0.6.0] release link - add 97 PR footnote refs ([#402]..[#1330]) Verified locally: pnpm install + pre-build contracts/daemon/desktop dist + pnpm typecheck (exit 0 across all 14 packages on Node 22.22 with engine-warning). Release workflow validation runs after merge via release-stable.	2026-05-12 15:33:28 +08:00
Cursor Agent	0631f04a00	feat(plugins): @open-design/agui-adapter package + GET /api/runs/:id/agui ... Plan J1 + J2 / spec §10.3.5 / Phase 4. New workspace package: packages/agui-adapter/. Pure-TS bidirectional bridge between OD's native PersistedAgentEvent / GenUIEvent / PluginPipelineStageEvent union and the AG-UI canonical event protocol (https://github.com/CopilotKit/CopilotKit). - src/types.ts — AGUIEvent discriminated union (agent.message, tool_call, state_update, ui.surface_requested, ui.surface_responded, run.lifecycle). - src/encode.ts — encodeOdEventForAgui(event, ctx): maps every OD native event onto the canonical shape; drops events the encoder can't translate so external AG-UI clients always see a clean stream. - tests/encode.test.ts (9 cases) covers message_chunk, tool_call, run_started, end → started/completed/failed/ cancelled, pipeline_stage_started/completed, genui_surface_request/response/timeout, genui_state_synced, and the unknown-event drop. apps/daemon/src/server.ts mounts GET /api/runs/:id/agui: - 404 for unknown run ids. - Replays the run's recorded events through the encoder on subscribe (so a reconnecting client with Last-Event-ID picks up exactly the AG-UI events it missed). - Subscribes to future events via a thin adapter client wrapper that routes through the existing run.clients fan-out, so the encoder runs lazily on each broadcast (no double event buffering). Daemon depends on @open-design/agui-adapter; the package builds clean and ships pure ESM. v1 plugins consume CopilotKit / agent-protocol clients without modification — the adapter ships independently from daemon main, so upstream protocol revs do not couple to the daemon release cadence (per spec §10.3.5 Phase 4 contract). Tests: agui-adapter 9/9, daemon 1481 → 1482 (+1 case on agui-route). Co-authored-by: Tom Huang <1043269994@qq.com>	2026-05-09 13:11:48 +00:00
Marc Chan	b03a504da6	release: Open Design 0.6.0 (#1080)	2026-05-09 19:58:11 +08:00
Cursor Agent	b9d40094b5	feat(plugins): github tarball + https archive install sources ... Plan §3.A6 / spec §7.2. The installer gains a top-level dispatcher `installPlugin` that picks the right backend off the source string: - ./folder, /abs/path → installFromLocalFolder (existing behavior) - github:owner/repo[@ref][/subpath] → fetch codeload tarball, extract via tar.x, optionally chroot into a subpath, then re-use the local backend for copy / persist - https://*.tar.gz, *.tgz → same archive backend, recorded as source_kind=url Hard guards inherited from spec §7.2: - Symbolic / hard link entries inside the archive abort the install with a clean error. - Path-traversal segments (..) abort. - Total extracted size is measured against maxBytes (50 MiB default) and rejected if exceeded. - Local-folder backend now preserves the recorded source / source_kind when called from the archive backend so installed_plugins records accurate provenance. POST /api/plugins/install accepts the new shapes; the SSE event stream shape is unchanged. The fetcher is pluggable so tests don't need network. apps/daemon/package.json adds tar@^7 + @types/tar@^6. Daemon tests: 1429 → 1434 (added plugins-installer-archive with 5 cases). Co-authored-by: Tom Huang <1043269994@qq.com>	2026-05-09 11:26:54 +00:00
pftom	4c7cd5d9f2	feat(plugins): introduce plugin system with installation and management capabilities ... - Added support for a new plugin system, allowing users to install, uninstall, and manage plugins through the daemon. - Implemented API endpoints for listing installed plugins, retrieving plugin details, and applying plugins with input validation. - Introduced a plugin doctor feature to validate plugin manifests and check for issues before application. - Established a plugin persistence layer with SQLite migrations for managing installed plugins and their metadata. - Enhanced the CLI with commands for plugin operations, improving user interaction with the plugin ecosystem.	2026-05-09 18:24:44 +08:00
nettee	ef9ca7baff	fix(daemon): typecheck core server paths (#952)	2026-05-08 20:43:51 +08:00
ferasbusiness666	1e8926271b	Harden security scan findings and upgrade dependencies (#806) ... * feat: add accent color control and launcher for Open Design * fix: remove launcher binary from PR * test: cover accent appearance edge cases * Harden security scan findings and upgrade deps * Address proxy security review * Pin jsdom for web test stability --------- Co-authored-by: ferasbusiness666 <ferasbusiness666@users.noreply.github.com> Co-authored-by: lefarcen <935902669@qq.com>	2026-05-08 19:46:34 +08:00
lefarcen	2bb029cb58	release: Open Design 0.5.0 (#820) ... 0.5.0 已从 c21cbc6 发布（https://github.com/nexu-io/open-design/releases/tag/open-design-v0.5.0）；本次 squash 把版本 bump 与 CHANGELOG [0.5.0] 条目带到 main 历史，便于后续 0.5.1 release 在 main 上走标准 dispatch 流程。	2026-05-08 00:41:01 +08:00