mirror of
https://github.com/muratcankoylan/Agent-Skills-for-Context-Engineering.git
synced 2026-09-14 20:36:54 +08:00
muratcankoylan
9cd3073785
Addresses bugs and content issues found during code review of
commit c847b20 (the textbook-to-instructional rewrite).
Critical fixes:
- evaluator.py: Remove free +0.2 completeness bonus (inflated scores)
- evaluator.py: Replace bracket-based citation check with regex
pattern matching to avoid false positives from code/JSON
- coordination.py: Fix run_workflow to simulate worker responses
instead of silently returning empty results
- degradation_detector.py: Replace numpy dependency with stdlib
random module (was the only third-party dep across all scripts)
Important fixes:
- compaction.py: summarize_conversation now retains actual decision
text instead of discarding content and keeping only counts
- memory_store.py: Use np.random.default_rng() instead of
np.random.seed() to avoid corrupting global numpy state
- memory_store.py: Replace late 'import time' with datetime (already
imported) for consistency
- description_generator.py: ToolSchemaBuilder.build() now returns a
ToolSpec-compatible object; add add_trigger/add_example methods;
demo now connects builder -> generator -> evaluator
- sandbox_manager.py: Fix demo to look up actual session_id from
active_sessions instead of constructing a mismatched key
- context_manager.py: Fix validate_context_structure false positive
on empty lists (e.g., documents: [])
- evaluator.py: Move random import to __init__ with local RNG instance
Content fixes:
- context-degradation SKILL.md: Replace fabricated model benchmark
table (GPT-5.2, Gemini 3) with general guidance
- multi-agent-patterns SKILL.md: Remove specific model name claims;
deduplicate gotcha 1 vs Practical Guidance section
- context-optimization SKILL.md: Standardize compaction threshold to
70% (was inconsistently 70% and 70-80%)
- advanced-evaluation SKILL.md: Fix created date 2024 -> 2025
- memory-systems SKILL.md: Fix missing space in description
- filesystem-context SKILL.md: Add "Read when:" to external resources
- bdi-mental-states SKILL.md: Add missing Skill Metadata section and
"Read when:" triggers on primary sources
- skills-improvement-analysis.md: Mark gotchas gap as resolved
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>