mirror of
https://github.com/max-sixty/worktrunk.git
synced 2026-09-14 20:00:38 +08:00
Maximilian Roos
16027a6a58
## What this does Removes the third-party `awalsh128/cache-apt-pkgs-action` from CI entirely, installing zsh + fish with a plain `sudo apt-get update && sudo apt-get install -y zsh fish` at all four call sites: - `ci.yaml` — `code-coverage` - `nightly.yaml` — `feature-powerset` and `benchmarks` - `.github/actions/test-setup/action.yaml` — composite action used by the required `test` matrix It also drops the Dependabot `ignore` entry for the action (no longer needed once the action is gone). ## Why (and why this supersedes #3321) `awalsh128/cache-apt-pkgs-action@v1.6.2` (dependabot bump #3311) empties its own `packages: zsh fish` argument in the "Normalizing package list" step and aborts with `Packages argument is empty`, in ~20s, before any compilation — killing `code-coverage` on every PR, which in turn stopped `codecov/patch` from posting anywhere. Root cause is upstream PR #177 quoting `${packages}`, tracked at [awalsh128/cache-apt-pkgs-action#210](https://github.com/awalsh128/cache-apt-pkgs-action/issues/210). #3321 already fixed main by pinning back to `v1.6.1`. This PR takes the sturdier route — dropping the dependency — based on the upstream's health: - Issue #210 is open with **no maintainer engagement**; affected users call the action "basically non-functional," with a fresh repro confirmed on 2026-06-29. - **No open PR** reverts #177 or fixes the regression; v1.6.2 (broken) is still tagged `Latest`, and contributor PRs sit unmerged for months. - The action's mutable `v1`/`latest` tags are actively being retargeted upstream (open PR #211), which is how a `@v1.6.1` ref can resolve to drifted code — so even the pin isn't a stable anchor. `zsh` and `fish` are in the standard Ubuntu repos (no PPA), so the action only *cached* an install of two tiny packages — a negligible speed-up for a third-party dependency that is under-maintained, broke CI repo-wide, and can't be stably pinned. Dropping it removes the whole failure class and matches the existing `musl-tools` install already in `nightly.yaml`. Verified: the identical `apt-get` step already runs green in the required `test (linux)` job (installs zsh 5.9 + fish 3.7.0), and a full `code-coverage` run on this branch completed green end-to-end with `codecov/patch` posting again. ## Guard against recurrence #3311 merged while its own `code-coverage` was red because `code-coverage`/`codecov/patch` aren't *required* status checks (only `test (linux/macos/windows)` are), and `codecov/patch` was absent rather than red (the job died before uploading), so the mechanical-bump merge saw nothing blocking. Recommended guard: make the `code-coverage` job a required status check — it fails only on genuine breakage (the codecov upload already soft-fails on fork PRs), so it blocks this class without re-introducing the flake that keeps `codecov/patch` itself advisory. > _This was written by Claude Code on behalf of max_ Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
24 lines
560 B
YAML
24 lines
560 B
YAML
version: 2
|
|
updates:
|
|
- package-ecosystem: cargo
|
|
directory: "/"
|
|
schedule:
|
|
interval: weekly
|
|
commit-message:
|
|
prefix: "chore: "
|
|
# Bump all patch versions of rust dependencies as a single PR
|
|
groups:
|
|
patch:
|
|
update-types:
|
|
- patch
|
|
# Exclude labels due to https://github.com/dependabot/dependabot-core/issues/7645#issuecomment-1986212847
|
|
labels: []
|
|
|
|
- package-ecosystem: "github-actions"
|
|
directory: "/"
|
|
commit-message:
|
|
prefix: "chore: "
|
|
schedule:
|
|
interval: daily
|
|
labels: []
|