mirror of
https://github.com/larksuite/cli.git
synced 2026-09-14 18:42:53 +08:00
liangshuo-1
2a1613484a
* feat: add framework flag aliases and unified IM pagination Introduce declarative exact-name flag aliases at the shortcut framework boundary while keeping semantic compatibility domain-owned. Add a shared, format-aware IM pagination pipeline with consistent flags, metadata, safety bounds, resumable cursors, and request throttling. * fix: align alias attribution and pagination contracts * fix: align alias contracts and documentation * test: remove environment-dependent contact bot e2e * test: restore contact bot e2e * docs: reduce IM pagination guidance noise --------- Co-authored-by: liangshuo-1 <266696938+liangshuo-1@users.noreply.github.com>
81 lines
2.2 KiB
Go
81 lines
2.2 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package flagcontract
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
func TestScanRejectsLocalNormalizer(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeFixture(t, root, "shortcuts/demo/demo.go", `package demo
|
|
func mount(cmd interface{ SetNormalizeFunc(any) }) { cmd.SetNormalizeFunc(nil) }
|
|
var flags = []struct { Name, Desc string; Hidden bool }{
|
|
{Name: "sort-order", Hidden: true, Desc: "hidden alias for --order"},
|
|
{Name: "legacy-sort", Hidden: true, Desc: "legacy vocabulary normalized to --order"},
|
|
}
|
|
`)
|
|
writeFixture(t, root, "shortcuts/demo/demo_test.go", `package demo
|
|
func ignored(cmd interface{ SetNormalizeFunc(any) }) { cmd.SetNormalizeFunc(nil) }
|
|
`)
|
|
writeFixture(t, root, aliasOwnerPath, `package flagalias
|
|
func bind(cmd interface{ SetNormalizeFunc(any) }) { cmd.SetNormalizeFunc(nil) }
|
|
`)
|
|
|
|
got, err := ScanRepoWithOptions(root, ScanOptions{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(got) != 1 {
|
|
t.Fatalf("violations = %#v, want 1", got)
|
|
}
|
|
if got[0].Rule != "flag_alias_normalizer_owner" {
|
|
t.Fatalf("rule = %q", got[0].Rule)
|
|
}
|
|
}
|
|
|
|
func TestScanDoesNotInferAliasSemanticsFromHelpText(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeFixture(t, root, "shortcuts/demo/demo.go", `package demo
|
|
var flags = []struct { Name, Desc string; Hidden bool }{
|
|
{Name: "range", Hidden: true, Desc: "alias for --start-cell; ranges collapse to their top-left cell"},
|
|
}
|
|
`)
|
|
|
|
got, err := ScanRepoWithOptions(root, ScanOptions{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(got) != 0 {
|
|
t.Fatalf("help prose must not define alias structure: %#v", got)
|
|
}
|
|
}
|
|
|
|
func TestScanCurrentRepositoryHasNoViolations(t *testing.T) {
|
|
root, err := filepath.Abs("../..")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
got, err := ScanRepoWithOptions(root, ScanOptions{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(got) != 0 {
|
|
t.Fatalf("flag contract violations: %#v", got)
|
|
}
|
|
}
|
|
|
|
func writeFixture(t *testing.T, root, rel, content string) {
|
|
t.Helper()
|
|
path := filepath.Join(root, filepath.FromSlash(rel))
|
|
if err := os.MkdirAll(filepath.Dir(path), 0o755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := os.WriteFile(path, []byte(content), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|