Files
larksuite__cli/shortcuts/mail/mail_template_create.go
bubbmon233 b624948e48 Support repeated mail compose flags (#2271)
* feat: support repeated mail compose flags

* fix(mail): address review feedback for repeatable inline flags

Change-Type: ci-fix

* test(mail): cover inline validation and upload assertions

Change-Type: ci-fix

* test(mail): assert inline validation category

Change-Type: ci-fix

* fix(mail): preserve inline compatibility cases

* test(mail): strengthen inline compatibility coverage

* docs(mail): prefer one repeatable flag form

* docs(mail): keep skill references unchanged

* docs(mail): drop skill reference edits

* docs(mail): document repeatable mail flags consistently

* docs(mail): standardize quoted flag examples

* docs(mail): keep inline flag constraints in help

* fix(mail): validate template inline cids

* fix(mail): preserve recipient names and validate template cids

* fix(mail): support repeated recipient parsing

Normalize repeated recipient values through ParseMailboxList for every flag occurrence so legacy comma lists still split, quoted display-name commas stay intact, and Unicode display names remain raw before final header rendering.

Local check: gofmt -l shortcuts/mail/helpers.go shortcuts/mail/mail_repeatable_flags_test.go

* fix(mail): scope template inline update validation

---------

Co-authored-by: bubbmon233 <272202079+bubbmon233@users.noreply.github.com>
2026-08-24 15:38:30 +08:00

245 lines
11 KiB
Go

// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package mail
import (
"context"
"fmt"
"io"
"strings"
"github.com/larksuite/cli/shortcuts/common"
)
var MailTemplateCreate = common.Shortcut{
Service: "mail",
Command: "+template-create",
Description: "Create a personal mail template. Scans HTML <img src> local paths (reusing draft inline-image detection), uploads inline images and non-inline attachments to Drive, rewrites HTML to cid: references, and POSTs a Template payload to mail.user_mailbox.templates.create.",
Risk: "write",
Scopes: []string{"mail:user_mailbox.message:modify", "mail:user_mailbox:readonly"},
AuthTypes: []string{"user", "bot"},
HasFormat: true,
Flags: []common.Flag{
{Name: "mailbox", Desc: "Mailbox email address that owns the template (default: me)."},
{Name: "name", Desc: "Required. Template name (≤100 chars).", Required: true},
{Name: "subject", Desc: "Optional. Default subject saved with the template."},
{Name: "template-content", Desc: "Template body content. Prefer HTML. Referenced local images (<img src=\"./file.png\">) are auto-uploaded to Drive and rewritten to cid: refs."},
{Name: "template-content-file", Desc: "Optional. Path to a file whose contents become --template-content. Relative path only. Mutually exclusive with --template-content."},
{Name: "plain-text", Type: "bool", Desc: "Mark the template as plain-text mode (is_plain_text_mode=true). Cannot be used with --inline; use only for pure plain-text templates."},
{Name: "to", Type: "string_array", Desc: "Optional. Default To recipient email address. Repeat --to once per recipient; quote each value. Display-name format is supported."},
{Name: "cc", Type: "string_array", Desc: "Optional. Default Cc recipient email address. Repeat --cc once per recipient; quote each value."},
{Name: "bcc", Type: "string_array", Desc: "Optional. Default Bcc recipient email address. Repeat --bcc once per recipient; quote each value."},
{Name: "attach", Type: "string_array", Desc: "Optional. Non-inline attachment file path, relative path only. Repeat --attach once per file; order is preserved for LARGE/SMALL classification."},
{Name: "inline", Type: "string_array", Desc: "Optional. Inline image as one JSON object. Repeat --inline once per image; quote each value. Example value: '{\"cid\":\"<unique-id>\",\"file_path\":\"<relative-path>\"}'. file_path must be relative. Reference it from HTML as <img src=\"cid:<unique-id>\">. CID must be unique, e.g. a random hex string."},
},
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
mailboxID := resolveComposeMailboxID(runtime)
content, _, rcErr := resolveTemplateContent(runtime)
if rcErr != nil {
fmt.Fprintf(runtime.IO().ErrOut, "warning: dry-run could not load template content: %v\n", rcErr)
}
logTemplateInfo(runtime, "create.dry_run", map[string]interface{}{
"mailbox_id": mailboxID,
"is_plain_text_mode": runtime.Bool("plain-text"),
"name_len": len([]rune(runtime.Str("name"))),
"attachments_total": len(normalizeCommaListFlagValues(runtime.StrArray("attach"))) + len(parseLocalImgs(content)) + countInlineSpecsForLog(runtime.StrArray("inline")),
"inline_count": len(parseLocalImgs(content)) + countInlineSpecsForLog(runtime.StrArray("inline")),
"tos_count": countAddresses(normalizeRecipientFlagValues(runtime.StrArray("to"))),
"ccs_count": countAddresses(normalizeRecipientFlagValues(runtime.StrArray("cc"))),
"bccs_count": countAddresses(normalizeRecipientFlagValues(runtime.StrArray("bcc"))),
})
api := common.NewDryRunAPI().
Desc("Create a new mail template. The command scans HTML for local <img src> references, uploads each inline image to Drive (≤20MB single upload_all; >20MB upload_prepare+upload_part+upload_finish), rewrites <img src> values to cid: references, uploads any non-inline --attach files the same way, and finally POSTs a Template payload to mail.user_mailbox.templates.create.")
// Surface the Drive upload steps explicitly so AI callers see the
// chunked vs single-part branch point for each local image.
for _, img := range parseLocalImgs(content) {
addTemplateUploadSteps(runtime, api, img.Path)
}
for _, spec := range inlineSpecsFromFlagValuesForLog(runtime.StrArray("inline")) {
addTemplateUploadSteps(runtime, api, spec.FilePath)
}
for _, p := range normalizeCommaListFlagValues(runtime.StrArray("attach")) {
addTemplateUploadSteps(runtime, api, p)
}
api = api.POST(templateMailboxPath(mailboxID)).
Body(map[string]interface{}{
"template": map[string]interface{}{
"name": runtime.Str("name"),
"subject": runtime.Str("subject"),
"template_content": "<rewritten-HTML-or-text>",
"is_plain_text_mode": runtime.Bool("plain-text"),
"tos": renderTemplateAddresses(normalizeRecipientFlagValues(runtime.StrArray("to"))),
"ccs": renderTemplateAddresses(normalizeRecipientFlagValues(runtime.StrArray("cc"))),
"bccs": renderTemplateAddresses(normalizeRecipientFlagValues(runtime.StrArray("bcc"))),
"attachments": "<computed from uploads>",
},
})
return api
},
Validate: func(ctx context.Context, runtime *common.RuntimeContext) error {
if err := validateBotMailboxNotMe(runtime); err != nil {
return err
}
if strings.TrimSpace(runtime.Str("name")) == "" {
return mailValidationParamError("--name", "--name is required")
}
if len([]rune(runtime.Str("name"))) > 100 {
return mailValidationParamError("--name", "--name must be at most 100 characters")
}
if runtime.Str("template-content") != "" && runtime.Str("template-content-file") != "" {
return mailValidationError("--template-content and --template-content-file are mutually exclusive").
WithParams(
mailInvalidParam("--template-content", "mutually exclusive with --template-content-file"),
mailInvalidParam("--template-content-file", "mutually exclusive with --template-content"),
)
}
inlineFlag, err := normalizeInlineFlagValues(runtime.StrArray("inline"))
if err != nil {
return err
}
if inlineFlag != "" && runtime.Bool("plain-text") {
return mailValidationError("--inline is not supported with --plain-text (inline images require HTML body)").
WithParams(
mailInvalidParam("--inline", "requires HTML body"),
mailInvalidParam("--plain-text", "mutually exclusive with --inline"),
)
}
return nil
},
Execute: func(ctx context.Context, runtime *common.RuntimeContext) error {
mailboxID := resolveComposeMailboxID(runtime)
content, _, err := resolveTemplateContent(runtime)
if err != nil {
return err
}
name := runtime.Str("name")
subject := runtime.Str("subject")
isPlainText := runtime.Bool("plain-text")
tos := renderTemplateAddresses(normalizeRecipientFlagValues(runtime.StrArray("to")))
ccs := renderTemplateAddresses(normalizeRecipientFlagValues(runtime.StrArray("cc")))
bccs := renderTemplateAddresses(normalizeRecipientFlagValues(runtime.StrArray("bcc")))
inlineFlag, err := normalizeInlineFlagValues(runtime.StrArray("inline"))
if err != nil {
return err
}
if inlineFlag != "" && isPlainText {
return mailValidationError("--inline is not supported with --plain-text (inline images require HTML body)").
WithParams(
mailInvalidParam("--inline", "requires HTML body"),
mailInvalidParam("--plain-text", "mutually exclusive with --inline"),
)
}
inlineSpecs, err := parseInlineSpecs(inlineFlag)
if err != nil {
return err
}
content = wrapTemplateContentIfNeeded(content, isPlainText)
if _, err := validateTemplateInlinePlan(content, nil, inlineSpecs); err != nil {
return err
}
if int64(len(content)) > maxTemplateContentBytes {
return mailFailedPreconditionError("template content exceeds %d MB (got %.1f MB)",
maxTemplateContentBytes/(1024*1024),
float64(len(content))/1024/1024)
}
rewritten, atts, err := buildTemplatePayloadFromFlags(
ctx, runtime, name, subject, content, tos, ccs, bccs,
normalizeCommaListFlagValues(runtime.StrArray("attach")),
inlineSpecs,
)
if err != nil {
return err
}
if err := validateTemplateInlinePayload(rewritten, atts); err != nil {
return err
}
inlineCount, largeCount := countAttachmentsByType(atts)
logTemplateInfo(runtime, "create.execute", map[string]interface{}{
"mailbox_id": mailboxID,
"is_plain_text_mode": isPlainText,
"name_len": len([]rune(name)),
"attachments_total": len(atts),
"inline_count": inlineCount,
"large_count": largeCount,
"tos_count": len(tos),
"ccs_count": len(ccs),
"bccs_count": len(bccs),
})
payload := &templatePayload{
Name: name,
Subject: subject,
TemplateContent: rewritten,
IsPlainTextMode: isPlainText,
Tos: tos,
Ccs: ccs,
Bccs: bccs,
Attachments: atts,
}
resp, err := createTemplate(runtime, mailboxID, payload)
if err != nil {
return mailDecorateProblemMessage(err, "create template failed")
}
tpl, _ := extractTemplatePayload(resp)
out := map[string]interface{}{
"template": tpl,
}
runtime.OutFormat(out, nil, func(w io.Writer) {
fmt.Fprintln(w, "Template created.")
if tpl != nil {
fmt.Fprintf(w, "template_id: %s\n", tpl.TemplateID)
fmt.Fprintf(w, "name: %s\n", tpl.Name)
fmt.Fprintf(w, "attachments: %d\n", len(tpl.Attachments))
}
})
return nil
},
}
// resolveTemplateContent returns the final template_content string, loading
// --template-content-file when set. The second return value is the unmodified
// source path (if any) to assist DryRun logging.
func resolveTemplateContent(runtime *common.RuntimeContext) (content, sourcePath string, err error) {
if raw := runtime.Str("template-content"); raw != "" {
return raw, "", nil
}
path := runtime.Str("template-content-file")
if path == "" {
return "", "", nil
}
f, err := runtime.FileIO().Open(path)
if err != nil {
return "", path, mailValidationParamError("--template-content-file", "open --template-content-file %s: %v", path, err).WithCause(mailInputStatError(err))
}
defer f.Close()
buf, err := io.ReadAll(f)
if err != nil {
return "", path, mailValidationParamError("--template-content-file", "read --template-content-file %s: %v", path, err).WithCause(err)
}
return string(buf), path, nil
}
// addTemplateUploadSteps enumerates the Drive steps needed to upload one
// local file, based on its on-disk size. Used by DryRun output.
func addTemplateUploadSteps(runtime *common.RuntimeContext, api *common.DryRunAPI, path string) {
if strings.TrimSpace(path) == "" {
return
}
info, err := runtime.FileIO().Stat(path)
if err != nil {
api.POST("/open-apis/drive/v1/medias/upload_all").Desc("Upload: " + path + " (size unknown: " + err.Error() + ")")
return
}
if info.Size() <= common.MaxDriveMediaUploadSinglePartSize {
api.POST("/open-apis/drive/v1/medias/upload_all").Desc("Upload " + path)
return
}
api.POST("/open-apis/drive/v1/medias/upload_prepare").Desc("Large file prepare: " + path)
api.POST("/open-apis/drive/v1/medias/upload_part").Desc("Large file parts")
api.POST("/open-apis/drive/v1/medias/upload_finish").Desc("Large file finish")
}