mirror of
https://github.com/larksuite/cli.git
synced 2026-09-14 18:42:53 +08:00
evandance
2b4c6349a1
Replace every command-facing error path in the event domain — the consume/schema command layer, the +subscribe shortcut, EventKey definitions, and the consume orchestration — with typed errs.* envelopes, so consumers get stable type, subtype, param, hint, and missing_scopes metadata for classification and recovery instead of free-form message text. - Input validation (--jq, --param, --output-dir, --filter, --route, unknown EventKey, EventKey params) reports validation / invalid_argument with the offending flag in param and an actionable hint. - Scope preflight reports authorization / missing_scope with the machine-readable missing_scopes list; console-subscription and single-bus preconditions report failed_precondition with recovery hints. - The consume API boundary passes already-typed errors through and classifies transport, non-JSON HTTP, and unparsable responses; the vc note-detail retry now matches the not-found code on typed errors (it silently never fired against the legacy envelope shape). - Previously-bare failures exited 1 with a plain-text "Error:" line and now exit with their category code (validation 2, auth 3, network 4, internal 5) alongside the typed stderr envelope. - forbidigo and errscontract guards now cover the event paths so regressions fail lint; AGENTS.md and the lark-event skill document the typed contract for agent consumers. Validation: make unit-test (race) green; event unit and e2e suites assert category/subtype/param/hint and cause preservation against the real binary; errscontract and golangci lint clean.
36 lines
1.1 KiB
Go
36 lines
1.1 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package vc
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/larksuite/cli/errs"
|
|
)
|
|
|
|
// isLarkCode must match the API code on typed errs.* errors — the consume
|
|
// runtime classifies OAPI failures via errclass.BuildAPIError, so the
|
|
// not-found retry in fillVCNoteGeneratedDetails depends on this reading
|
|
// Problem.Code rather than the legacy envelope shape.
|
|
func TestIsLarkCode_MatchesTypedAPIErrorCode(t *testing.T) {
|
|
typedNotFound := errs.NewAPIError(errs.SubtypeNotFound, "note not ready").
|
|
WithCode(vcNoteDetailNotFoundCode)
|
|
if !isLarkCode(typedNotFound, vcNoteDetailNotFoundCode) {
|
|
t.Fatal("typed API error carrying the not-found code must match (retry path)")
|
|
}
|
|
if isLarkCode(typedNotFound, 99999) {
|
|
t.Error("a different expected code must not match")
|
|
}
|
|
|
|
otherTyped := errs.NewAPIError(errs.SubtypeServerError, "boom").WithCode(500)
|
|
if isLarkCode(otherTyped, vcNoteDetailNotFoundCode) {
|
|
t.Error("typed error with another code must not match")
|
|
}
|
|
|
|
if isLarkCode(errors.New("plain failure"), vcNoteDetailNotFoundCode) {
|
|
t.Error("untyped error must not match")
|
|
}
|
|
}
|