mirror of
https://github.com/larksuite/cli.git
synced 2026-09-14 18:42:53 +08:00
be2a96f490
Aggregate the sheets work from feat/lark-sheets-develop: - Improve validation errors with schema hints, aggregated issues, enum guidance, and prescriptive flag/style-field messages. - Harden +batch-update input contracts, key normalization, style vocabulary handling, and resource-budget checks. - Add read offload and truncation handling for cells, csv, and table-get, with typed output-path errors and safer jq/output-path semantics. - Correct freeze semantics by emitting full-state freeze/unfreeze operations and adding --rows/--cols for +dim-freeze. - Improve +styles-put and shared --styles parsing for styles, merges, row/column sizing, freeze, and sheet-prefixed range validation. - Fix dim-insert inherit-style mapping, table-get date/time handling, table-put style anchors, and CSV path-shaped input guards. - Update lark-sheets skill docs, scripts, tests, and generated flag data. Tested with: - go test ./shortcuts/common ./shortcuts/sheets/... - go test ./shortcuts/... ./internal/... - python3 -m py_compile skills/lark-sheets/scripts/*.py
84 lines
2.7 KiB
Go
84 lines
2.7 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package cmdutil
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/larksuite/cli/errs"
|
|
"github.com/larksuite/cli/internal/output"
|
|
)
|
|
|
|
func TestRequireConfirmation_TypedShape(t *testing.T) {
|
|
err := RequireConfirmation("drive +delete")
|
|
if err == nil {
|
|
t.Fatal("expected non-nil error")
|
|
}
|
|
|
|
var cre *errs.ConfirmationRequiredError
|
|
if !errors.As(err, &cre) {
|
|
t.Fatalf("expected *errs.ConfirmationRequiredError, got %T", err)
|
|
}
|
|
if cre.Category != errs.CategoryConfirmation {
|
|
t.Errorf("Category = %q, want %q", cre.Category, errs.CategoryConfirmation)
|
|
}
|
|
if cre.Subtype != errs.SubtypeConfirmationRequired {
|
|
t.Errorf("Subtype = %q, want %q", cre.Subtype, errs.SubtypeConfirmationRequired)
|
|
}
|
|
if got := output.ExitCodeOf(err); got != output.ExitConfirmationRequired {
|
|
t.Errorf("ExitCodeOf = %d, want %d", got, output.ExitConfirmationRequired)
|
|
}
|
|
if !strings.Contains(cre.Message, "drive +delete") || !strings.Contains(cre.Message, "requires confirmation") {
|
|
t.Errorf("Message = %q, want it to mention action and 'requires confirmation'", cre.Message)
|
|
}
|
|
// The hint is the plain add-yes contract and nothing more: no pre-built
|
|
// retry command may ride behind it (argv cannot faithfully reproduce the
|
|
// invocation and may carry sensitive payloads — see RequireConfirmation).
|
|
if cre.Hint != "add --yes to confirm" {
|
|
t.Errorf("Hint = %q, want exactly 'add --yes to confirm'", cre.Hint)
|
|
}
|
|
if cre.Risk != errs.RiskHighRiskWrite {
|
|
t.Errorf("Risk = %q, want %q", cre.Risk, errs.RiskHighRiskWrite)
|
|
}
|
|
if cre.Action != "drive +delete" {
|
|
t.Errorf("Action = %q, want drive +delete", cre.Action)
|
|
}
|
|
}
|
|
|
|
func TestRequireConfirmation_JSONShape(t *testing.T) {
|
|
err := RequireConfirmation("mail +send")
|
|
var cre *errs.ConfirmationRequiredError
|
|
if !errors.As(err, &cre) {
|
|
t.Fatalf("expected *errs.ConfirmationRequiredError, got %T", err)
|
|
}
|
|
raw, mErr := json.Marshal(cre)
|
|
if mErr != nil {
|
|
t.Fatalf("marshal: %v", mErr)
|
|
}
|
|
var back map[string]interface{}
|
|
if err := json.Unmarshal(raw, &back); err != nil {
|
|
t.Fatalf("unmarshal: %v", err)
|
|
}
|
|
|
|
// No fix_command field leaks into the envelope: the typed protocol stays
|
|
// action-only.
|
|
if _, has := back["fix_command"]; has {
|
|
t.Errorf("unexpected fix_command present in JSON: %s", raw)
|
|
}
|
|
|
|
if back["risk"] != "high-risk-write" {
|
|
t.Errorf("risk in JSON = %v", back["risk"])
|
|
}
|
|
if back["action"] != "mail +send" {
|
|
t.Errorf("action in JSON = %v", back["action"])
|
|
}
|
|
// Action-only protocol: no UpgradedBy / fix_command / upgraded_by leak.
|
|
if _, has := back["upgraded_by"]; has {
|
|
t.Errorf("unexpected upgraded_by present in JSON: %s", raw)
|
|
}
|
|
}
|