Files
jackwener__opencli/clis/twitter/unblock.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

77 lines
2.7 KiB
TypeScript

import { CommandExecutionError } from '@jackwener/opencli/errors';
import { cli, Strategy } from '@jackwener/opencli/registry';
import type { IPage } from '@jackwener/opencli/types';
cli({
site: 'twitter',
name: 'unblock',
description: 'Unblock a Twitter user',
domain: 'x.com',
strategy: Strategy.UI,
browser: true,
args: [
{ name: 'username', type: 'string', positional: true, required: true, help: 'Twitter screen name (without @)' },
],
columns: ['status', 'message'],
func: async (page: IPage | null, kwargs: any) => {
if (!page) throw new CommandExecutionError('Browser session required for twitter unblock');
const username = kwargs.username.replace(/^@/, '');
await page.goto(`https://x.com/${username}`);
await page.wait({ selector: '[data-testid="primaryColumn"]' });
const result = await page.evaluate(`(async () => {
try {
let attempts = 0;
let unblockBtn = null;
while (attempts < 20) {
// Check if not blocked (follow button visible means not blocked)
const followBtn = document.querySelector('[data-testid$="-follow"]');
if (followBtn) {
return { ok: true, message: 'Not blocking @${username} (already unblocked).' };
}
unblockBtn = document.querySelector('[data-testid$="-unblock"]');
if (unblockBtn) break;
await new Promise(r => setTimeout(r, 500));
attempts++;
}
if (!unblockBtn) {
return { ok: false, message: 'Could not find Unblock button. Are you logged in?' };
}
// Click the unblock button — this opens a confirmation dialog
unblockBtn.click();
await new Promise(r => setTimeout(r, 1000));
// Confirm the unblock in the dialog
const confirmBtn = document.querySelector('[data-testid="confirmationSheetConfirm"]');
if (confirmBtn) {
confirmBtn.click();
await new Promise(r => setTimeout(r, 1000));
}
// Verify
const verify = document.querySelector('[data-testid$="-follow"]');
if (verify) {
return { ok: true, message: 'Successfully unblocked @${username}.' };
} else {
return { ok: false, message: 'Unblock action initiated but UI did not update.' };
}
} catch (e) {
return { ok: false, message: e.toString() };
}
})()`);
if (result.ok) await page.wait(2);
return [{
status: result.ok ? 'success' : 'failed',
message: result.message
}];
}
});