Files
jackwener__opencli/clis/google/news.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

67 lines
2.2 KiB
TypeScript

/**
* Google News via public RSS feed.
* Supports top stories (no keyword) and search (with keyword).
*/
import { cli, Strategy } from '@jackwener/opencli/registry';
import { CliError } from '@jackwener/opencli/errors';
import { parseRssItems } from './utils.js';
cli({
site: 'google',
name: 'news',
description: 'Get Google News headlines',
strategy: Strategy.PUBLIC,
browser: false,
args: [
{ name: 'keyword', positional: true, help: 'Search query (omit for top stories)' },
{ name: 'limit', type: 'int', default: 10, help: 'Number of results' },
{ name: 'lang', default: 'en', help: 'Language short code (e.g. en, zh)' },
{ name: 'region', default: 'US', help: 'Region code (e.g. US, CN)' },
],
columns: ['title', 'source', 'date', 'url'],
func: async (_page, args) => {
const limit = Math.max(1, Math.min(Number(args.limit), 100));
const lang = encodeURIComponent(args.lang);
const region = encodeURIComponent(args.region);
const ceid = `${args.region}:${args.lang}`;
// Top stories or search
const base = args.keyword
? `https://news.google.com/rss/search?q=${encodeURIComponent(args.keyword)}&hl=${lang}&gl=${region}&ceid=${ceid}`
: `https://news.google.com/rss?hl=${lang}&gl=${region}&ceid=${ceid}`;
const resp = await fetch(base);
if (!resp.ok) {
throw new CliError('FETCH_ERROR', `HTTP ${resp.status}`, 'Check your network connection');
}
const xml = await resp.text();
const items = parseRssItems(xml, ['title', 'link', 'pubDate', 'source']);
if (!items.length) {
throw new CliError('NOT_FOUND', 'No news articles found', 'Try a different keyword or region');
}
return items.slice(0, limit).map(item => {
// Extract source: prefer <source> element, fallback to parsing title
let title = item['title'] || '';
let source = item['source'] || '';
if (!source) {
const idx = title.lastIndexOf(' - ');
if (idx !== -1) {
source = title.slice(idx + 3);
title = title.slice(0, idx);
}
}
return {
title,
source,
date: item['pubDate'] || '',
url: item['link'] || '',
};
});
},
});