mirror of
https://github.com/jackwener/OpenCLI.git
synced 2026-09-14 18:25:42 +08:00
jakevin
80eef46b4e
* refactor: move adapters from src/clis/ to root clis/ for monorepo separation Separates CLI adapters from the core runtime to prepare for independent adapter distribution via postinstall fetch. Key changes: - Move src/clis/ → clis/ (adapters at repo root) - Change tsconfig rootDir from "src" to "." so tsc compiles both - Create root-level shim files (registry.ts, errors.ts, etc.) so adapter relative imports (../../registry.js) resolve correctly - Update build-manifest.ts, main.ts paths for new dist/src/ structure - Expand ensureUserCliCompatShims() to cover all adapter import targets (types, utils, logger, launcher, browser/*, download/*, pipeline/*) - Add scripts/fetch-adapters.js postinstall for ~/.opencli/clis/ sync - Update vitest.config.ts adapter test paths - Add package.json files field to exclude adapters from npm package Official adapter files are unconditionally overwritten on update; user-created files not in the manifest are preserved. * fix: add dist/clis/ and cli-manifest.json to npm files, harden fetch-adapters - Add dist/clis/ and dist/cli-manifest.json to package.json files field so built-in adapters and manifest ship with the npm package - Replace execSync with execFileSync to prevent command injection - Add version check to skip redundant adapter fetches - Track tmpRoot explicitly for reliable cleanup * fix: address review blockers — manifest-based updates, global-only fetch, first-run fallback 1. Manifest-based update strategy: - Read old manifest to identify previously-official files - Clean up files removed upstream (in old manifest but not new) - User-created files (never in any manifest) remain untouched 2. Only run fetch-adapters on global install (npm_config_global=true) or explicit OPENCLI_FETCH=1, preventing heavy side effects for local/dev installs 3. First-run fallback in discovery.ts: - ensureUserAdapters() checks for adapter-manifest.json - If missing and ~/.opencli/clis/ is empty, spawns fetch-adapters.js - Guarantees adapters are available even with --ignore-scripts * fix: remove OPENCLI_FETCH env var, use internal _OPENCLI_FIRST_RUN instead * feat: also support OPENCLI_FETCH=1 for explicit adapter fetch trigger * simplify: replace git clone with local copy from dist/clis/ Adapters already ship in the npm package (dist/clis/), so there's no need to clone from GitHub. Copy directly from the installed package: - Eliminates git, curl, tar dependencies - No network calls in postinstall - No timeout/offline issues - Version always matches the installed CLI - ~65 lines of clone/download code replaced by one cpSync loop
79 lines
2.5 KiB
TypeScript
79 lines
2.5 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import {
|
|
canonicalizeProductUrl,
|
|
dedupeSearchItems,
|
|
normalizeProductId,
|
|
normalizeSearchItem,
|
|
sanitizeSearchItems,
|
|
} from './utils.js';
|
|
|
|
describe('normalizeProductId', () => {
|
|
it('extracts product id from canonical path', () => {
|
|
expect(normalizeProductId('https://www.coupang.com/vp/products/123456789')).toBe('123456789');
|
|
});
|
|
|
|
it('preserves numeric ids', () => {
|
|
expect(normalizeProductId('987654321')).toBe('987654321');
|
|
});
|
|
});
|
|
|
|
describe('canonicalizeProductUrl', () => {
|
|
it('normalizes relative Coupang paths', () => {
|
|
expect(canonicalizeProductUrl('/vp/products/123456789?itemId=1', '')).toBe(
|
|
'https://www.coupang.com/vp/products/123456789'
|
|
);
|
|
});
|
|
|
|
it('builds url from product id', () => {
|
|
expect(canonicalizeProductUrl('', '123456789')).toBe('https://www.coupang.com/vp/products/123456789');
|
|
});
|
|
});
|
|
|
|
describe('normalizeSearchItem', () => {
|
|
it('maps raw fields into compare-ready shape', () => {
|
|
const item = normalizeSearchItem({
|
|
productId: '123456789',
|
|
productName: '무선 마우스',
|
|
salePrice: '29,900원',
|
|
originalPrice: '39,900원',
|
|
rating: '4.8',
|
|
reviewCount: '1,234',
|
|
sellerName: '쿠팡',
|
|
badge: ['ROCKET', 'TOMORROW', '무료배송'],
|
|
categoryName: 'PC',
|
|
url: '/vp/products/123456789?itemId=1',
|
|
}, 0);
|
|
|
|
expect(item).toMatchObject({
|
|
rank: 1,
|
|
product_id: '123456789',
|
|
title: '무선 마우스',
|
|
price: 29900,
|
|
original_price: 39900,
|
|
rating: 4.8,
|
|
review_count: 1234,
|
|
rocket: '로켓배송',
|
|
delivery_type: '무료배송',
|
|
delivery_promise: '내일도착',
|
|
seller: '쿠팡',
|
|
category: 'PC',
|
|
url: 'https://www.coupang.com/vp/products/123456789',
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('sanitizeSearchItems', () => {
|
|
it('drops duplicates and invalid rows', () => {
|
|
const rows = [
|
|
normalizeSearchItem({ productId: '1', productName: 'A', price: '1000', url: '/vp/products/1' }, 0),
|
|
normalizeSearchItem({ productId: '1', productName: 'A', price: '1000', url: '/vp/products/1' }, 1),
|
|
normalizeSearchItem({ productId: '', productName: '', price: '1000' }, 2),
|
|
normalizeSearchItem({ productId: '2', productName: 'B', price: '2000', url: '/vp/products/2' }, 3),
|
|
];
|
|
|
|
expect(dedupeSearchItems(rows)).toHaveLength(3);
|
|
expect(sanitizeSearchItems(rows, 10)).toHaveLength(2);
|
|
expect(sanitizeSearchItems(rows, 10).map(item => item.rank)).toEqual([1, 2]);
|
|
});
|
|
});
|