mirror of
https://github.com/jackwener/OpenCLI.git
synced 2026-09-14 18:25:42 +08:00
jakevin
80eef46b4e
* refactor: move adapters from src/clis/ to root clis/ for monorepo separation Separates CLI adapters from the core runtime to prepare for independent adapter distribution via postinstall fetch. Key changes: - Move src/clis/ → clis/ (adapters at repo root) - Change tsconfig rootDir from "src" to "." so tsc compiles both - Create root-level shim files (registry.ts, errors.ts, etc.) so adapter relative imports (../../registry.js) resolve correctly - Update build-manifest.ts, main.ts paths for new dist/src/ structure - Expand ensureUserCliCompatShims() to cover all adapter import targets (types, utils, logger, launcher, browser/*, download/*, pipeline/*) - Add scripts/fetch-adapters.js postinstall for ~/.opencli/clis/ sync - Update vitest.config.ts adapter test paths - Add package.json files field to exclude adapters from npm package Official adapter files are unconditionally overwritten on update; user-created files not in the manifest are preserved. * fix: add dist/clis/ and cli-manifest.json to npm files, harden fetch-adapters - Add dist/clis/ and dist/cli-manifest.json to package.json files field so built-in adapters and manifest ship with the npm package - Replace execSync with execFileSync to prevent command injection - Add version check to skip redundant adapter fetches - Track tmpRoot explicitly for reliable cleanup * fix: address review blockers — manifest-based updates, global-only fetch, first-run fallback 1. Manifest-based update strategy: - Read old manifest to identify previously-official files - Clean up files removed upstream (in old manifest but not new) - User-created files (never in any manifest) remain untouched 2. Only run fetch-adapters on global install (npm_config_global=true) or explicit OPENCLI_FETCH=1, preventing heavy side effects for local/dev installs 3. First-run fallback in discovery.ts: - ensureUserAdapters() checks for adapter-manifest.json - If missing and ~/.opencli/clis/ is empty, spawns fetch-adapters.js - Guarantees adapters are available even with --ignore-scripts * fix: remove OPENCLI_FETCH env var, use internal _OPENCLI_FIRST_RUN instead * feat: also support OPENCLI_FETCH=1 for explicit adapter fetch trigger * simplify: replace git clone with local copy from dist/clis/ Adapters already ship in the npm package (dist/clis/), so there's no need to clone from GitHub. Copy directly from the installed package: - Eliminates git, curl, tar dependencies - No network calls in postinstall - No timeout/offline issues - Version always matches the installed CLI - ~65 lines of clone/download code replaced by one cpSync loop
88 lines
2.3 KiB
TypeScript
88 lines
2.3 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
|
|
import {
|
|
assertSpotifyCredentialsConfigured,
|
|
getFirstSpotifyTrack,
|
|
hasConfiguredSpotifyCredentials,
|
|
mapSpotifyTrackResults,
|
|
parseDotEnv,
|
|
resolveSpotifyCredentials,
|
|
} from './utils.js';
|
|
|
|
describe('spotify utils', () => {
|
|
it('parses dotenv-style credential files', () => {
|
|
const env = parseDotEnv(`
|
|
# Spotify credentials
|
|
SPOTIFY_CLIENT_ID=abc123
|
|
SPOTIFY_CLIENT_SECRET=def456
|
|
`);
|
|
|
|
expect(env).toEqual({
|
|
SPOTIFY_CLIENT_ID: 'abc123',
|
|
SPOTIFY_CLIENT_SECRET: 'def456',
|
|
});
|
|
});
|
|
|
|
it('prefers explicit process env over file values', () => {
|
|
const credentials = resolveSpotifyCredentials(
|
|
{
|
|
SPOTIFY_CLIENT_ID: 'file-id',
|
|
SPOTIFY_CLIENT_SECRET: 'file-secret',
|
|
},
|
|
{
|
|
SPOTIFY_CLIENT_ID: 'env-id',
|
|
SPOTIFY_CLIENT_SECRET: 'env-secret',
|
|
},
|
|
);
|
|
|
|
expect(credentials).toEqual({
|
|
clientId: 'env-id',
|
|
clientSecret: 'env-secret',
|
|
});
|
|
});
|
|
|
|
it('treats placeholder values as unconfigured credentials', () => {
|
|
expect(hasConfiguredSpotifyCredentials({
|
|
clientId: 'your_spotify_client_id_here',
|
|
clientSecret: 'your_spotify_client_secret_here',
|
|
})).toBe(false);
|
|
});
|
|
|
|
it('throws a helpful CONFIG error for empty or placeholder credentials', () => {
|
|
expect(() => assertSpotifyCredentialsConfigured({
|
|
clientId: '',
|
|
clientSecret: '',
|
|
}, '/tmp/spotify.env')).toThrow(/Missing Spotify credentials/);
|
|
|
|
expect(() => assertSpotifyCredentialsConfigured({
|
|
clientId: 'your_spotify_client_id_here',
|
|
clientSecret: 'real-secret',
|
|
}, '/tmp/spotify.env')).toThrow(/Fill in SPOTIFY_CLIENT_ID and SPOTIFY_CLIENT_SECRET/);
|
|
});
|
|
|
|
it('maps search payloads into stable track summaries', () => {
|
|
const results = mapSpotifyTrackResults({
|
|
tracks: {
|
|
items: [
|
|
{
|
|
name: 'Numb',
|
|
artists: [{ name: 'Linkin Park' }, { name: 'Jay-Z' }],
|
|
album: { name: 'Encore' },
|
|
uri: 'spotify:track:123',
|
|
},
|
|
],
|
|
},
|
|
});
|
|
|
|
expect(results).toEqual([
|
|
{
|
|
track: 'Numb',
|
|
artist: 'Linkin Park, Jay-Z',
|
|
album: 'Encore',
|
|
uri: 'spotify:track:123',
|
|
},
|
|
]);
|
|
expect(getFirstSpotifyTrack({ tracks: { items: [] } })).toBeNull();
|
|
});
|
|
});
|