Files
jackwener__opencli/clis/pixiv/illusts.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

79 lines
2.6 KiB
TypeScript

/**
* Pixiv illusts — list illustrations by an artist.
*
* Two-step process:
* 1. Fetch all illust IDs from the user's profile
* 2. Batch-fetch details for the most recent ones (max 48 IDs per request)
*/
import { cli, Strategy } from '@jackwener/opencli/registry';
import { CommandExecutionError } from '@jackwener/opencli/errors';
import { pixivFetch, BATCH_SIZE } from './utils.js';
cli({
site: 'pixiv',
name: 'illusts',
description: "List a Pixiv artist's illustrations",
domain: 'www.pixiv.net',
strategy: Strategy.COOKIE,
args: [
{ name: 'user-id', positional: true, required: true, help: 'Pixiv user ID' },
{ name: 'limit', type: 'int', default: 20, help: 'Number of results' },
],
columns: ['rank', 'title', 'illust_id', 'pages', 'bookmarks', 'tags', 'created'],
func: async (page, kwargs) => {
const userId = String(kwargs['user-id'] ?? '');
const limit = Number(kwargs.limit) || 20;
if (!/^\d+$/.test(userId)) {
throw new CommandExecutionError(`Invalid user ID: ${userId}`);
}
// Step 1: get all illust IDs
const profileBody = await pixivFetch(page, `/ajax/user/${userId}/profile/all`, {
notFoundMsg: `User not found: ${userId}`,
});
const allIds = Object.keys(profileBody?.illusts || {})
.sort((a, b) => Number(b) - Number(a))
.slice(0, limit);
if (allIds.length === 0) return [];
// Step 2: batch fetch details (Pixiv supports up to ~48 IDs per request)
const allWorks: Record<string, any> = {};
for (let offset = 0; offset < allIds.length; offset += BATCH_SIZE) {
const batch = allIds.slice(offset, offset + BATCH_SIZE);
const idsParam = batch.map(id => `ids[]=${id}`).join('&');
// pixivFetch navigates on each call; for subsequent batches we re-navigate,
// which is fine — the cookie is already attached.
const detailBody = await pixivFetch(
page,
`/ajax/user/${userId}/profile/illusts?${idsParam}&work_category=illustManga&is_first_page=${offset === 0 ? 1 : 0}`,
);
Object.assign(allWorks, detailBody?.works || {});
}
return allIds
.map((id, i) => {
const w = allWorks[id];
if (!w) return null;
return {
rank: i + 1,
title: w.title || '',
illust_id: w.id,
pages: w.pageCount || 1,
bookmarks: w.bookmarkCount || 0,
tags: (w.tags || []).slice(0, 5).join(', '),
created: (w.createDate || '').split('T')[0],
url: 'https://www.pixiv.net/artworks/' + w.id,
};
})
.filter(Boolean);
},
});