Files
jackwener__opencli/clis/notebooklm/source-fulltext.test.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

124 lines
3.8 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from 'vitest';
const {
mockListNotebooklmSourcesViaRpc,
mockListNotebooklmSourcesFromPage,
mockGetNotebooklmSourceFulltextViaRpc,
mockGetNotebooklmPageState,
mockRequireNotebooklmSession,
} = vi.hoisted(() => ({
mockListNotebooklmSourcesViaRpc: vi.fn(),
mockListNotebooklmSourcesFromPage: vi.fn(),
mockGetNotebooklmSourceFulltextViaRpc: vi.fn(),
mockGetNotebooklmPageState: vi.fn(),
mockRequireNotebooklmSession: vi.fn(),
}));
vi.mock('./utils.js', async () => {
const actual = await vi.importActual<typeof import('./utils.js')>('./utils.js');
return {
...actual,
listNotebooklmSourcesViaRpc: mockListNotebooklmSourcesViaRpc,
listNotebooklmSourcesFromPage: mockListNotebooklmSourcesFromPage,
getNotebooklmSourceFulltextViaRpc: mockGetNotebooklmSourceFulltextViaRpc,
getNotebooklmPageState: mockGetNotebooklmPageState,
requireNotebooklmSession: mockRequireNotebooklmSession,
};
});
import { getRegistry } from '@jackwener/opencli/registry';
import './source-fulltext.js';
describe('notebooklm source-fulltext', () => {
const command = getRegistry().get('notebooklm/source-fulltext');
beforeEach(() => {
mockListNotebooklmSourcesViaRpc.mockReset();
mockListNotebooklmSourcesFromPage.mockReset();
mockGetNotebooklmSourceFulltextViaRpc.mockReset();
mockGetNotebooklmPageState.mockReset();
mockRequireNotebooklmSession.mockReset();
mockRequireNotebooklmSession.mockResolvedValue(undefined);
mockGetNotebooklmPageState.mockResolvedValue({
url: 'https://notebooklm.google.com/notebook/nb-demo',
title: 'Browser Automation',
hostname: 'notebooklm.google.com',
kind: 'notebook',
notebookId: 'nb-demo',
loginRequired: false,
notebookCount: 1,
});
});
it('returns fulltext for a source matched from rpc source rows', async () => {
mockListNotebooklmSourcesViaRpc.mockResolvedValue([
{
id: 'src-1',
notebook_id: 'nb-demo',
title: '粘贴的文字',
url: 'https://notebooklm.google.com/notebook/nb-demo',
source: 'rpc',
type: 'pasted-text',
},
]);
mockGetNotebooklmSourceFulltextViaRpc.mockResolvedValue({
source_id: 'src-1',
notebook_id: 'nb-demo',
title: '粘贴的文字',
kind: 'generated-text',
content: '第一段\n第二段',
char_count: 7,
url: 'https://example.com/source',
source: 'rpc',
});
const result = await command!.func!({} as any, { source: 'src-1' });
expect(result).toEqual([
{
source_id: 'src-1',
notebook_id: 'nb-demo',
title: '粘贴的文字',
kind: 'generated-text',
content: '第一段\n第二段',
char_count: 7,
url: 'https://example.com/source',
source: 'rpc',
},
]);
});
it('matches by title from dom rows when rpc source list is unavailable', async () => {
mockListNotebooklmSourcesViaRpc.mockResolvedValue([]);
mockListNotebooklmSourcesFromPage.mockResolvedValue([
{
id: 'src-1',
notebook_id: 'nb-demo',
title: '粘贴的文字',
url: 'https://notebooklm.google.com/notebook/nb-demo',
source: 'current-page',
},
]);
mockGetNotebooklmSourceFulltextViaRpc.mockResolvedValue({
source_id: 'src-1',
notebook_id: 'nb-demo',
title: '粘贴的文字',
kind: 'generated-text',
content: '第一段\n第二段',
char_count: 7,
url: 'https://example.com/source',
source: 'rpc',
});
const result = await command!.func!({} as any, { source: '粘贴的文字' });
expect(result).toEqual([
expect.objectContaining({
source_id: 'src-1',
title: '粘贴的文字',
content: '第一段\n第二段',
}),
]);
});
});