Files
jackwener__opencli/clis/codex/extract-diff.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

49 lines
1.7 KiB
TypeScript

import { cli, Strategy } from '@jackwener/opencli/registry';
import type { IPage } from '@jackwener/opencli/types';
export const extractDiffCommand = cli({
site: 'codex',
name: 'extract-diff',
description: 'Extract visual code review diff patches from Codex',
domain: 'localhost',
strategy: Strategy.UI,
browser: true,
columns: ['File', 'Diff'],
func: async (page) => {
const diffs = await page.evaluate(`
(function() {
const results = [];
// Assuming diffs are rendered with standard diff classes or monaco difference editors
const diffBlocks = document.querySelectorAll('.diff-editor, .monaco-diff-editor, [data-testid="diff-view"]');
diffBlocks.forEach((block, index) => {
// Very roughly scrape text representing additions/deletions mapped from the inner wrapper
results.push({
File: block.getAttribute('data-filename') || \`DiffBlock_\${index+1}\`,
Diff: block.innerText || block.textContent
});
});
// If no structured diffs found, try to find any code blocks labeled as patches
if (results.length === 0) {
const codeBlocks = document.querySelectorAll('pre code.language-diff, pre code.language-patch');
codeBlocks.forEach((code, index) => {
results.push({
File: \`Patch_\${index+1}\`,
Diff: code.innerText || code.textContent
});
});
}
return results;
})()
`);
if (diffs.length === 0) {
return [{ File: 'No diffs found', Diff: 'Try running opencli codex send "/review" first' }];
}
return diffs;
},
});