Files
jackwener__opencli/clis/ones/resolve-labels.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

81 lines
2.4 KiB
TypeScript

/**
* 把 status / project 的 uuid 解析为中文名(团队级接口各查一次或按批)
*/
import type { IPage } from '@jackwener/opencli/types';
import { onesFetchInPage } from './common.js';
import { getTaskProjectRawId } from './task-helpers.js';
export async function loadTaskStatusLabels(
page: IPage,
team: string,
skipGoto: boolean,
): Promise<Map<string, string>> {
const map = new Map<string, string>();
try {
const parsed = (await onesFetchInPage(page, `team/${team}/task_statuses`, {
method: 'GET',
skipGoto,
})) as Record<string, unknown>;
const list = Array.isArray(parsed.task_statuses)
? (parsed.task_statuses as Record<string, unknown>[])
: [];
for (const s of list) {
const id = String(s.uuid ?? '');
const name = String(s.name ?? '');
if (id && name) map.set(id, name);
}
} catch {
/* 降级为仅显示 uuid */
}
return map;
}
const PROJECT_INFO_CHUNK = 25;
export async function loadProjectLabels(
page: IPage,
team: string,
projectUuids: string[],
skipGoto: boolean,
): Promise<Map<string, string>> {
const map = new Map<string, string>();
const ids = [...new Set(projectUuids.filter(Boolean))];
if (ids.length === 0) return map;
try {
for (let i = 0; i < ids.length; i += PROJECT_INFO_CHUNK) {
const slice = ids.slice(i, i + PROJECT_INFO_CHUNK);
const q = slice.map(encodeURIComponent).join(',');
const path = `team/${team}/projects/info?ids=${q}`;
const parsed = (await onesFetchInPage(page, path, {
method: 'GET',
skipGoto,
})) as Record<string, unknown>;
const projects = Array.isArray(parsed.projects) ? (parsed.projects as Record<string, unknown>[]) : [];
for (const p of projects) {
const id = String(p.uuid ?? '');
const name = String(p.name ?? '');
if (id && name) map.set(id, name);
}
}
} catch {
/* 降级 */
}
return map;
}
export async function resolveTaskListLabels(
page: IPage,
team: string,
entries: Record<string, unknown>[],
skipGoto: boolean,
): Promise<{ statusByUuid: Map<string, string>; projectByUuid: Map<string, string> }> {
const projectUuids = entries.map((e) => getTaskProjectRawId(e)).filter(Boolean);
const [statusByUuid, projectByUuid] = await Promise.all([
loadTaskStatusLabels(page, team, skipGoto),
loadProjectLabels(page, team, projectUuids, skipGoto),
]);
return { statusByUuid, projectByUuid };
}