Files
jackwener__opencli/clis/yuanbao/shared.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

58 lines
2.0 KiB
TypeScript

import type { IPage } from '@jackwener/opencli/types';
import { AuthRequiredError } from '@jackwener/opencli/errors';
export const YUANBAO_DOMAIN = 'yuanbao.tencent.com';
export const YUANBAO_URL = 'https://yuanbao.tencent.com/';
const SESSION_HINT = 'Likely login/auth/challenge/session issue in the existing yuanbao.tencent.com browser session.';
/**
* Reusable visibility check for injected browser scripts.
* Embed in page.evaluate strings via `${IS_VISIBLE_JS}`.
*/
export const IS_VISIBLE_JS = `const isVisible = (node) => {
if (!(node instanceof HTMLElement)) return false;
const rect = node.getBoundingClientRect();
const style = window.getComputedStyle(node);
return rect.width > 0
&& rect.height > 0
&& style.display !== 'none'
&& style.visibility !== 'hidden';
};`;
export function authRequired(message: string) {
return new AuthRequiredError(YUANBAO_DOMAIN, `${message} ${SESSION_HINT}`);
}
export async function isOnYuanbao(page: IPage): Promise<boolean> {
const url = await page.evaluate('window.location.href').catch(() => '');
if (typeof url !== 'string' || !url) return false;
try {
const hostname = new URL(url).hostname;
return hostname === YUANBAO_DOMAIN || hostname.endsWith(`.${YUANBAO_DOMAIN}`);
} catch {
return false;
}
}
export async function ensureYuanbaoPage(page: IPage): Promise<void> {
if (!(await isOnYuanbao(page))) {
await page.goto(YUANBAO_URL, { waitUntil: 'load', settleMs: 2500 });
await page.wait(1);
}
}
export async function hasLoginGate(page: IPage): Promise<boolean> {
const result = await page.evaluate(`(() => {
const bodyText = document.body.innerText || '';
const hasWechatLoginText = bodyText.includes('微信扫码登录');
const hasWechatIframe = Array.from(document.querySelectorAll('iframe'))
.some((frame) => (frame.getAttribute('src') || '').includes('open.weixin.qq.com/connect/qrconnect'));
return hasWechatLoginText || hasWechatIframe;
})()`);
return Boolean(result);
}