Files
jackwener__opencli/clis/producthunt/utils.test.ts
jakevin 80eef46b4e refactor: monorepo adapter separation (clis/ at root) (#782)
* refactor: move adapters from src/clis/ to root clis/ for monorepo separation

Separates CLI adapters from the core runtime to prepare for independent
adapter distribution via postinstall fetch.

Key changes:
- Move src/clis/ → clis/ (adapters at repo root)
- Change tsconfig rootDir from "src" to "." so tsc compiles both
- Create root-level shim files (registry.ts, errors.ts, etc.) so adapter
  relative imports (../../registry.js) resolve correctly
- Update build-manifest.ts, main.ts paths for new dist/src/ structure
- Expand ensureUserCliCompatShims() to cover all adapter import targets
  (types, utils, logger, launcher, browser/*, download/*, pipeline/*)
- Add scripts/fetch-adapters.js postinstall for ~/.opencli/clis/ sync
- Update vitest.config.ts adapter test paths
- Add package.json files field to exclude adapters from npm package

Official adapter files are unconditionally overwritten on update;
user-created files not in the manifest are preserved.

* fix: add dist/clis/ and cli-manifest.json to npm files, harden fetch-adapters

- Add dist/clis/ and dist/cli-manifest.json to package.json files field
  so built-in adapters and manifest ship with the npm package
- Replace execSync with execFileSync to prevent command injection
- Add version check to skip redundant adapter fetches
- Track tmpRoot explicitly for reliable cleanup

* fix: address review blockers — manifest-based updates, global-only fetch, first-run fallback

1. Manifest-based update strategy:
   - Read old manifest to identify previously-official files
   - Clean up files removed upstream (in old manifest but not new)
   - User-created files (never in any manifest) remain untouched

2. Only run fetch-adapters on global install (npm_config_global=true)
   or explicit OPENCLI_FETCH=1, preventing heavy side effects for
   local/dev installs

3. First-run fallback in discovery.ts:
   - ensureUserAdapters() checks for adapter-manifest.json
   - If missing and ~/.opencli/clis/ is empty, spawns fetch-adapters.js
   - Guarantees adapters are available even with --ignore-scripts

* fix: remove OPENCLI_FETCH env var, use internal _OPENCLI_FIRST_RUN instead

* feat: also support OPENCLI_FETCH=1 for explicit adapter fetch trigger

* simplify: replace git clone with local copy from dist/clis/

Adapters already ship in the npm package (dist/clis/), so there's no
need to clone from GitHub. Copy directly from the installed package:

- Eliminates git, curl, tar dependencies
- No network calls in postinstall
- No timeout/offline issues
- Version always matches the installed CLI
- ~65 lines of clone/download code replaced by one cpSync loop
2026-04-05 01:46:36 +08:00

73 lines
2.8 KiB
TypeScript

import { describe, it, expect } from 'vitest';
import { parseFeed, pickVoteCount, PRODUCTHUNT_CATEGORY_SLUGS } from './utils.js';
const SAMPLE_ATOM = `<?xml version="1.0" encoding="UTF-8"?>
<feed xmlns="http://www.w3.org/2005/Atom">
<title>Product Hunt</title>
<entry>
<id>tag:www.producthunt.com,2005:Post/1001</id>
<published>2026-03-26T10:00:00-07:00</published>
<title>Awesome AI Tool</title>
<content type="html">&lt;p&gt;The best AI tool ever made&lt;/p&gt;&lt;p&gt;&lt;a href="..."&gt;Discussion&lt;/a&gt;&lt;/p&gt;</content>
<author><name>Jane Doe</name></author>
<link rel="alternate" type="text/html" href="https://www.producthunt.com/products/awesome-ai-tool"/>
</entry>
<entry>
<id>tag:www.producthunt.com,2005:Post/1002</id>
<published>2026-03-25T08:00:00-07:00</published>
<title>Dev Helper</title>
<content type="html">&lt;p&gt;Speeds up your workflow&lt;/p&gt;</content>
<author><name>John Smith</name></author>
<link rel="alternate" type="text/html" href="https://www.producthunt.com/products/dev-helper"/>
</entry>
</feed>`;
describe('parseFeed', () => {
it('parses entries into ranked posts', () => {
const posts = parseFeed(SAMPLE_ATOM);
expect(posts).toHaveLength(2);
expect(posts[0].rank).toBe(1);
expect(posts[0].name).toBe('Awesome AI Tool');
expect(posts[0].author).toBe('Jane Doe');
expect(posts[0].date).toBe('2026-03-26');
expect(posts[0].url).toBe('https://www.producthunt.com/products/awesome-ai-tool');
expect(posts[0].tagline).toContain('best AI tool');
});
it('strips HTML and Discussion link from tagline', () => {
const posts = parseFeed(SAMPLE_ATOM);
expect(posts[0].tagline).not.toContain('<p>');
expect(posts[0].tagline).not.toContain('Discussion');
});
it('returns empty array for empty feed', () => {
expect(parseFeed('<feed></feed>')).toHaveLength(0);
});
it('assigns sequential ranks', () => {
const posts = parseFeed(SAMPLE_ATOM);
expect(posts.map(p => p.rank)).toEqual([1, 2]);
});
it('prefers vote-like candidates over unrelated numeric badges', () => {
const votes = pickVoteCount([
{ text: '12', className: 'font-semibold', inButton: false, inReviewLink: false },
{ text: '98', className: 'vote-button', inButton: true, inReviewLink: false },
]);
expect(votes).toBe('98');
});
it('ignores numbers inside review links', () => {
const votes = pickVoteCount([
{ text: '120', className: 'text-secondary', inButton: false, inReviewLink: true },
{ text: '45', className: 'vote-button', inButton: true, inReviewLink: false },
]);
expect(votes).toBe('45');
});
it('shares category slugs across commands', () => {
expect(PRODUCTHUNT_CATEGORY_SLUGS).toContain('developer-tools');
expect(PRODUCTHUNT_CATEGORY_SLUGS).toContain('ai-agents');
});
});