Files
jackwener__opencli/clis/producthunt/browse.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

110 lines
3.8 KiB
TypeScript

/**
* Product Hunt category browse — INTERCEPT strategy.
*
* Navigates to a Product Hunt category page and scrapes the top-rated products.
* Shows all-time best products for a category (ranked by review score, not daily votes).
*/
import { cli, Strategy } from '@jackwener/opencli/registry';
import { CliError } from '@jackwener/opencli/errors';
import type { IPage } from '@jackwener/opencli/types';
import { PRODUCTHUNT_CATEGORY_SLUGS } from './utils.js';
cli({
site: 'producthunt',
name: 'browse',
description: 'Best products in a Product Hunt category',
domain: 'www.producthunt.com',
strategy: Strategy.INTERCEPT,
args: [
{
name: 'category',
type: 'string',
positional: true,
required: true,
help: `Category slug, e.g. vibe-coding, ai-agents, developer-tools`,
},
{ name: 'limit', type: 'int', default: 20, help: 'Number of results (max 50)' },
],
columns: ['rank', 'name', 'tagline', 'reviews', 'url'],
func: async (page: IPage, args) => {
const count = Math.min(Number(args.limit) || 20, 50);
const slug = String(args.category || '').trim().toLowerCase();
await page.installInterceptor('producthunt.com');
await page.goto(`https://www.producthunt.com/categories/${slug}`);
await page.waitForCapture(5);
const domItems: any = await page.evaluate(`
(() => {
const seen = new Set();
const results = [];
// Card links: <a class="...flex-col" href="/products/<slug>"> (not review links)
const cardLinks = Array.from(document.querySelectorAll('a[href^="/products/"]')).filter(a => {
const href = a.getAttribute('href') || '';
const cls = a.className || '';
return cls.includes('flex-col') && !href.includes('/reviews');
});
for (const cardLink of cardLinks) {
const href = cardLink.getAttribute('href');
if (!href || seen.has(href)) continue;
// Child 0: div with name (strip "Launched this month/week/year" noise)
const nameDiv = cardLink.querySelector('div');
const rawName = nameDiv?.textContent?.trim() || '';
const name = rawName
.replace(/\\s*Launched\\s+this\\s+(month|week|year|day)\\s*/gi, '')
.replace(/\\s*Featured\\s*/gi, '')
.trim();
// Child 1: span.text-secondary — tagline
const taglineEl = cardLink.querySelector('span.text-secondary, span[class*="text-secondary"]');
const tagline = taglineEl?.textContent?.trim() || '';
if (!name) continue;
// Find reviews count from sibling /reviews link
let reviews = '';
let container = cardLink.parentElement;
for (let i = 0; i < 5 && container; i++) {
const reviewLink = container.querySelector('a[href="' + href + '/reviews"]');
if (reviewLink) {
reviews = (reviewLink.textContent?.trim() || '').replace(/\\s*reviews?\\s*/i, '').trim();
break;
}
container = container.parentElement;
}
seen.add(href);
results.push({
name,
tagline: tagline.slice(0, 120),
reviews: reviews || '0',
url: 'https://www.producthunt.com' + href,
});
}
return results;
})()
`);
const items = Array.isArray(domItems) ? (domItems as any[]) : [];
if (items.length === 0) {
throw new CliError(
'NO_DATA',
`No products found for category "${slug}"`,
'Check the category slug or try: ' + PRODUCTHUNT_CATEGORY_SLUGS.slice(0, 5).join(', '),
);
}
return items.slice(0, count).map((item: any, i: number) => ({
rank: i + 1,
name: item.name,
tagline: item.tagline,
reviews: item.reviews,
url: item.url,
}));
},
});