Files
jackwener__opencli/clis/ones/tasks.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

93 lines
2.8 KiB
TypeScript

import { cli, Strategy } from '@jackwener/opencli/registry';
import { CliError } from '@jackwener/opencli/errors';
import { gotoOnesHome, onesFetchInPage } from './common.js';
import { enrichPeekEntriesWithDetails } from './enrich-tasks.js';
import { resolveTaskListLabels } from './resolve-labels.js';
import { defaultPeekBody, flattenPeekGroups, mapTaskEntry, parsePeekLimit } from './task-helpers.js';
function buildQuery(project?: string, assign?: string): Record<string, unknown> {
const must: unknown[] = [];
if (project?.trim()) {
must.push({ in: { 'field_values.field006': [project.trim()] } });
}
if (assign?.trim()) {
must.push({ equal: { assign: assign.trim() } });
}
if (must.length === 0) {
return { must: [] };
}
return { must };
}
cli({
site: 'ones',
name: 'tasks',
description:
'ONES Project API — list work items (POST team/:team/filters/peek); use token-info -f json for team uuid',
domain: 'ones.cn',
strategy: Strategy.COOKIE,
browser: true,
navigateBefore: false,
args: [
{
name: 'team',
type: 'str',
required: false,
positional: true,
help: 'Team UUID (8 chars), or set ONES_TEAM_UUID',
},
{
name: 'project',
type: 'str',
required: false,
help: 'Filter by project UUID (field006 / 所属项目)',
},
{
name: 'assign',
type: 'str',
required: false,
help: 'Filter by assignee user UUID (负责人 assign)',
},
{
name: 'limit',
type: 'int',
default: 30,
help: 'Max rows after flattening groups (default 30)',
},
],
columns: ['title', 'status', 'project', 'uuid', 'updated', '工时'],
func: async (page, kwargs) => {
const team =
(kwargs.team as string | undefined)?.trim() ||
process.env.ONES_TEAM_UUID?.trim() ||
process.env.ONES_TEAM_ID?.trim();
if (!team) {
throw new CliError(
'CONFIG',
'team UUID required',
'Pass team as first argument or set ONES_TEAM_UUID (see `opencli ones token-info -f json` → teams[].uuid).',
);
}
const project = (kwargs.project as string | undefined)?.trim();
const assign = (kwargs.assign as string | undefined)?.trim();
const limit = parsePeekLimit(kwargs.limit, 30);
await gotoOnesHome(page);
const body = defaultPeekBody(buildQuery(project, assign));
const path = `team/${team}/filters/peek`;
const parsed = (await onesFetchInPage(page, path, {
method: 'POST',
body: JSON.stringify(body),
skipGoto: true,
})) as Record<string, unknown>;
const entries = flattenPeekGroups(parsed, limit);
const enriched = await enrichPeekEntriesWithDetails(page, team, entries, true);
const labels = await resolveTaskListLabels(page, team, enriched, true);
return enriched.map((e) => mapTaskEntry(e, labels));
},
});