Files
jackwener__opencli/clis/notion/favorites.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

88 lines
3.3 KiB
TypeScript

import { cli, Strategy } from '@jackwener/opencli/registry';
import type { IPage } from '@jackwener/opencli/types';
export const favoritesCommand = cli({
site: 'notion',
name: 'favorites',
description: 'List pages from the Notion Favorites section in the sidebar',
domain: 'localhost',
strategy: Strategy.UI,
browser: true,
args: [],
columns: ['Index', 'Title', 'Icon'],
func: async (page: IPage) => {
const items = await page.evaluate(`
(function() {
const results = [];
// Strategy 1: Use Notion's own class 'notion-outliner-bookmarks-header-container'
const headerContainer = document.querySelector('.notion-outliner-bookmarks-header-container');
if (headerContainer) {
// Walk up to the section parent that wraps header + items
let section = headerContainer.parentElement;
if (section && section.children.length === 1) section = section.parentElement;
if (section) {
const treeItems = section.querySelectorAll('[role="treeitem"]');
treeItems.forEach((item) => {
// Title text is in a div.notranslate sibling of the icon area
const titleEl = item.querySelector('div.notranslate:not(.notion-record-icon)');
const title = titleEl
? titleEl.textContent.trim()
: (item.textContent || '').trim().substring(0, 80);
// Icon/emoji is in the notion-record-icon element
const iconEl = item.querySelector('.notion-record-icon');
const icon = iconEl ? iconEl.textContent.trim().substring(0, 4) : '';
if (title && title.length > 0) {
results.push({ Index: results.length + 1, Title: title, Icon: icon || '📄' });
}
});
}
}
// Strategy 2: Fallback — find "Favorites" text node and walk DOM
if (results.length === 0) {
const walker = document.createTreeWalker(document.body, NodeFilter.SHOW_TEXT, null);
let node;
let favEl = null;
while (node = walker.nextNode()) {
const text = node.textContent.trim();
if (text === 'Favorites' || text === '收藏' || text === '收藏夹') {
favEl = node.parentElement;
break;
}
}
if (favEl) {
let section = favEl;
for (let i = 0; i < 6; i++) {
const p = section.parentElement;
if (!p || p === document.body) break;
const treeItems = p.querySelectorAll(':scope > [role="treeitem"]');
if (treeItems.length > 0) { section = p; break; }
section = p;
}
const treeItems = section.querySelectorAll('[role="treeitem"]');
treeItems.forEach((item) => {
const text = (item.textContent || '').trim().substring(0, 120);
if (text && text.length > 1 && !text.match(/^(Favorites|收藏夹?)$/)) {
results.push({ Index: results.length + 1, Title: text, Icon: '📄' });
}
});
}
}
return results;
})()
`);
if (items.length === 0) {
return [{ Index: 0, Title: 'No favorites found. Make sure sidebar is visible and you have favorites.', Icon: '⚠️' }];
}
return items;
},
});