Files
jackwener__opencli/clis/notebooklm/notes-get.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

66 lines
2.2 KiB
TypeScript

import { cli, Strategy } from '@jackwener/opencli/registry';
import type { IPage } from '@jackwener/opencli/types';
import { EmptyResultError } from '@jackwener/opencli/errors';
import { NOTEBOOKLM_DOMAIN, NOTEBOOKLM_SITE } from './shared.js';
import {
findNotebooklmNoteRow,
getNotebooklmPageState,
listNotebooklmNotesFromPage,
readNotebooklmVisibleNoteFromPage,
requireNotebooklmSession,
} from './utils.js';
function matchesNoteTitle(title: string, query: string): boolean {
const needle = query.trim().toLowerCase();
if (!needle) return false;
const normalized = title.trim().toLowerCase();
return normalized === needle || normalized.includes(needle);
}
cli({
site: NOTEBOOKLM_SITE,
name: 'notes-get',
description: 'Get one note from the current NotebookLM notebook by title from the visible note editor',
domain: NOTEBOOKLM_DOMAIN,
strategy: Strategy.COOKIE,
browser: true,
navigateBefore: false,
args: [
{
name: 'note',
positional: true,
required: true,
help: 'Note title or id from the current notebook',
},
],
columns: ['title', 'content', 'source', 'url'],
func: async (page: IPage, kwargs) => {
await requireNotebooklmSession(page);
const state = await getNotebooklmPageState(page);
if (state.kind !== 'notebook') {
throw new EmptyResultError(
'opencli notebooklm notes-get',
'No NotebookLM notebook is open in the automation workspace. Run `opencli notebooklm open <notebook>` first.',
);
}
const query = typeof kwargs.note === 'string' ? kwargs.note : String(kwargs.note ?? '');
const visible = await readNotebooklmVisibleNoteFromPage(page);
if (visible && matchesNoteTitle(visible.title, query)) return [visible];
const rows = await listNotebooklmNotesFromPage(page);
const listed = findNotebooklmNoteRow(rows, query);
if (listed) {
throw new EmptyResultError(
'opencli notebooklm notes-get',
`Note "${query}" is listed in Studio, but opencli currently reads note content only from the visible note editor. Open that note in NotebookLM, then retry.`,
);
}
throw new EmptyResultError(
'opencli notebooklm notes-get',
`Note "${query}" was not found in the current notebook.`,
);
},
});