Files
jackwener__opencli/clis/hupu/mentions.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

195 lines
5.7 KiB
TypeScript

import { AuthRequiredError, CommandExecutionError } from '@jackwener/opencli/errors';
import { cli, Strategy } from '@jackwener/opencli/registry';
import { stripHtml } from './utils.js';
interface MentionItem {
id?: number;
msgType?: number;
puid?: number;
username?: string;
headerUrl?: string;
postContent?: string;
threadTitle?: string;
tid?: number;
pid?: number;
topicId?: number;
quoteContent?: string;
publishTime?: string;
updateTime?: number;
}
interface BrowserMentionResult {
ok?: boolean;
status?: number;
data?: {
items: MentionItem[];
hasNextPage: boolean;
pageStr?: string;
};
error?: string;
}
cli({
site: 'hupu',
name: 'mentions',
aliases: ['mention'],
description: '查看虎扑提到我的回复 (需要登录)',
domain: 'my.hupu.com',
strategy: Strategy.COOKIE,
navigateBefore: false,
args: [
{
name: 'limit',
type: 'int',
default: 20,
help: '最多返回多少条消息'
},
{
name: 'max_pages',
type: 'int',
default: 3,
help: '最多抓取多少页'
},
{
name: 'page_str',
help: '分页游标;不传时从第一页开始'
}
],
columns: ['time', 'username', 'thread_title', 'post_content', 'quote_content', 'reply_url'],
func: async (page, kwargs) => {
const plate = '1';
const limit = Math.max(1, Math.min(Number(kwargs.limit) || 20, 100));
const maxPages = Math.max(1, Math.min(Number(kwargs.max_pages) || 3, 10));
const inputPageStr = kwargs.page_str ? String(kwargs.page_str) : '';
const referer = `https://my.hupu.com/message?tabKey=${plate}`;
await page.goto(referer);
const result = await page.evaluate(`
(async () => {
const plate = ${JSON.stringify(plate)};
const limit = ${JSON.stringify(limit)};
const maxPages = ${JSON.stringify(maxPages)};
let pageStr = ${JSON.stringify(inputPageStr)};
const apiBase = 'https://my.hupu.com/pcmapi/pc/space/v1/getMentionedRemindList';
const items = [];
let hasNextPage = false;
let nextPageStr = pageStr || '';
const parseJson = async (response) => {
const text = await response.text();
try {
return text ? JSON.parse(text) : {};
} catch {
return {
message: text || 'invalid json response'
};
}
};
try {
for (let pageIndex = 0; pageIndex < maxPages && items.length < limit; pageIndex++) {
const url = new URL(apiBase);
url.searchParams.set('plate', plate);
if (pageStr) {
url.searchParams.set('pageStr', pageStr);
}
const response = await fetch(url.toString(), {
method: 'GET',
credentials: 'include'
});
const api = await parseJson(response);
if (response.status === 401 || response.status === 403) {
return {
ok: false,
status: response.status,
error: 'please log in to Hupu first'
};
}
if (!response.ok) {
return {
ok: false,
status: response.status,
error: api?.msg || api?.message || ('HTTP ' + response.status)
};
}
if ((api?.code ?? 0) > 1) {
return {
ok: false,
status: response.status,
error: api?.msg || api?.message || ('API error code=' + api?.code)
};
}
const data = api?.data || {};
const currentItems = Array.isArray(data.hisList) ? data.hisList : [];
items.push(...currentItems);
hasNextPage = Boolean(data.hasNextPage);
nextPageStr = typeof data.pageStr === 'string' ? data.pageStr : '';
if (!hasNextPage || !nextPageStr || nextPageStr === pageStr) {
break;
}
pageStr = nextPageStr;
}
return {
ok: true,
data: {
items: items.slice(0, limit),
hasNextPage,
pageStr: nextPageStr
}
};
} catch (error) {
return {
ok: false,
error: error instanceof Error ? error.message : String(error)
};
}
})()
`) as BrowserMentionResult;
if (!result || typeof result !== 'object') {
throw new CommandExecutionError('Read Hupu mentions failed: invalid browser response');
}
if (result.status === 401 || result.status === 403) {
throw new AuthRequiredError('my.hupu.com', 'Read Hupu mentions failed: please log in to Hupu first');
}
if (!result.ok) {
throw new CommandExecutionError(`Read Hupu mentions failed: ${result.error || 'unknown error'}`);
}
const items = result.data?.items || [];
return items.map((item) => {
const tid = item.tid ? String(item.tid) : '';
const pid = item.pid ? String(item.pid) : '';
return {
time: item.publishTime || '',
username: item.username || '',
thread_title: item.threadTitle || '',
post_content: stripHtml(item.postContent || ''),
quote_content: stripHtml(item.quoteContent || ''),
url: tid ? `https://bbs.hupu.com/${tid}.html` : '',
reply_url: tid && pid ? `https://bbs.hupu.com/${tid}.html?pid=${pid}` : '',
tid,
pid,
topic_id: item.topicId ? String(item.topicId) : '',
msg_type: item.msgType ?? '',
has_next_page: result.data?.hasNextPage ?? false,
next_page_str: result.data?.pageStr || ''
};
});
},
});