Files
jackwener__opencli/clis/google/search.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

134 lines
4.9 KiB
TypeScript
Raw Permalink Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
/**
* Google Web Search via browser DOM extraction.
* Uses browser mode to navigate google.com and extract results from the DOM.
*
* Extraction strategy (2026-03): Google no longer uses `.g` class containers.
* Instead, we find all `a` tags containing `h3` within `#rso`, then walk up
* to the result container (`div.tF2Cxc` or closest `div[data-hveid]`) to find
* snippets. This approach is resilient to class name changes.
*/
import { cli, Strategy } from '@jackwener/opencli/registry';
import { CliError } from '@jackwener/opencli/errors';
cli({
site: 'google',
name: 'search',
description: 'Search Google',
domain: 'google.com',
strategy: Strategy.PUBLIC,
browser: true,
args: [
{ name: 'keyword', positional: true, required: true, help: 'Search query' },
{ name: 'limit', type: 'int', default: 10, help: 'Number of results (1-100)' },
{ name: 'lang', default: 'en', help: 'Language short code (e.g. en, zh)' },
],
columns: ['type', 'title', 'url', 'snippet'],
func: async (page, args) => {
const limit = Math.max(1, Math.min(Number(args.limit), 100));
const keyword = encodeURIComponent(args.keyword);
const lang = encodeURIComponent(args.lang);
const url = `https://www.google.com/search?q=${keyword}&hl=${lang}&num=${limit}`;
await page.goto(url);
await page.wait(2);
const results = await page.evaluate(`
(function() {
var results = [];
var seenUrls = {};
var rso = document.querySelector('#rso');
if (!rso) return results;
// -- Featured snippet (scoped to #rso to avoid matching unrelated elements) --
var featuredEl = rso.querySelector('.xpdopen .hgKElc')
|| rso.querySelector('.IZ6rdc');
if (featuredEl) {
var parentBlock = featuredEl.closest('[data-hveid]') || featuredEl.parentElement;
var fLink = parentBlock ? parentBlock.querySelector('a[href]') : null;
var fUrl = fLink ? fLink.href : '';
if (fUrl) seenUrls[fUrl] = true;
results.push({
type: 'snippet',
title: featuredEl.textContent.trim().slice(0, 200),
url: fUrl,
snippet: '',
});
}
// -- Standard search results --
// Strategy: find all links containing h3 within #rso
var allLinks = rso.querySelectorAll('a');
for (var i = 0; i < allLinks.length; i++) {
var link = allLinks[i];
var h3 = link.querySelector('h3');
if (!h3) continue;
var href = link.href || '';
// Skip non-http, Google internal links, and duplicates
if (!href.match(/^https?:\\/\\//)) continue;
if (href.indexOf('google.com/search') !== -1) continue;
if (seenUrls[href]) continue;
seenUrls[href] = true;
// Walk up to find result container for snippet extraction
var container = link;
for (var j = 0; j < 6; j++) {
if (container.parentElement && container.parentElement !== rso) {
container = container.parentElement;
}
// Stop at a known result boundary
if (container.getAttribute && container.getAttribute('data-hveid')) break;
}
// Find snippet: look for descriptive text, skip breadcrumbs and metadata
var snippetText = '';
var titleText = h3.textContent.trim();
var candidates = container.querySelectorAll('span, div');
for (var k = 0; k < candidates.length; k++) {
var el = candidates[k];
if (el.querySelector('h3') || el.querySelector('a[href]')) continue;
var text = el.textContent.trim();
if (text.length < 40 || text.length > 500) continue;
if (text === titleText) continue;
// Skip URL breadcrumbs (e.g. "https://example.com › path..." or "Site Namehttps://...")
if (text.indexOf('\u203A') !== -1) continue;
if (new RegExp('https?://').test(text.slice(0, 60))) continue;
snippetText = text;
break;
}
results.push({
type: 'result',
title: h3.textContent.trim(),
url: href,
snippet: snippetText.slice(0, 300),
});
}
// -- People Also Ask --
var paaContainers = document.querySelectorAll('[data-sgrd="true"]');
for (var i = 0; i < paaContainers.length; i++) {
var questionEl = paaContainers[i].querySelector('span.CSkcDe');
if (questionEl) {
results.push({
type: 'paa',
title: questionEl.textContent.trim(),
url: '',
snippet: '',
});
}
}
return results;
})()
`);
if (!Array.isArray(results) || results.length === 0) {
throw new CliError('NOT_FOUND', 'No search results found', 'Try a different keyword or check for CAPTCHA');
}
return results;
},
});