Files
jackwener__opencli/clis/ctrip/search.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

112 lines
3.3 KiB
TypeScript

/**
* 携程旅行搜索 — public destination and hotel suggestion lookup.
*/
import { ArgumentError, CliError, EmptyResultError } from '@jackwener/opencli/errors';
import { cli, Strategy } from '@jackwener/opencli/registry';
interface CtripSearchResultItem {
displayName?: string;
word?: string;
cityName?: string;
displayType?: string;
type?: string;
commentScore?: number | string;
cStar?: number | string;
price?: number | string;
minPrice?: number | string;
}
function clampLimit(raw: unknown, fallback = 15): number {
const parsed = Number(raw);
if (!Number.isFinite(parsed)) return fallback;
return Math.max(1, Math.min(Math.floor(parsed), 50));
}
function mapSearchResults(results: unknown[], limit: number) {
return results
.filter((item): item is CtripSearchResultItem => !!item && typeof item === 'object')
.slice(0, limit)
.map((item, index) => ({
rank: index + 1,
name: String(item.displayName || item.word || item.cityName || '').replace(/\s+/g, ' ').trim(),
type: String(item.displayType || item.type || '').replace(/\s+/g, ' ').trim(),
score: item.commentScore ?? item.cStar ?? '',
price: item.price ?? item.minPrice ?? '',
url: '',
}))
.filter((item) => item.name);
}
cli({
site: 'ctrip',
name: 'search',
description: '搜索携程目的地、景区和酒店联想结果',
strategy: Strategy.PUBLIC,
browser: false,
args: [
{ name: 'query', required: true, positional: true, help: 'Search keyword (city or attraction)' },
{ name: 'limit', type: 'int', default: 15, help: 'Number of results' },
],
columns: ['rank', 'name', 'type', 'score', 'price', 'url'],
func: async (_page, kwargs) => {
const query = String(kwargs.query || '').trim();
if (!query) {
throw new ArgumentError('Search keyword cannot be empty');
}
const limit = clampLimit(kwargs.limit);
const response = await fetch('https://m.ctrip.com/restapi/soa2/21881/json/gaHotelSearchEngine', {
method: 'POST',
headers: {
'content-type': 'application/json',
},
body: JSON.stringify({
keyword: query,
searchType: 'D',
platform: 'online',
pageID: '102001',
head: {
Locale: 'zh-CN',
LocaleController: 'zh_cn',
Currency: 'CNY',
PageId: '102001',
clientID: 'opencli-ctrip-search',
group: 'ctrip',
Frontend: {
sessionID: 1,
pvid: 1,
},
HotelExtension: {
group: 'CTRIP',
WebpSupport: false,
},
},
}),
});
if (!response.ok) {
throw new CliError(
'FETCH_ERROR',
`ctrip search failed with status ${response.status}`,
'Retry the command or verify ctrip.com is reachable',
);
}
const payload = await response.json();
const rawResults = Array.isArray(payload?.Response?.searchResults) ? payload.Response.searchResults : [];
const results = mapSearchResults(rawResults, limit);
if (!results.length) {
throw new EmptyResultError(
'ctrip search',
'Try a destination, scenic spot, or hotel keyword such as "苏州" or "朱家尖"',
);
}
return results;
},
});
export const __test__ = {
clampLimit,
mapSearchResults,
};