mirror of
https://github.com/jackwener/OpenCLI.git
synced 2026-09-14 18:25:42 +08:00
4fe9a73ebc
* refactor: migrate adapter imports to package exports Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.) with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.) across all 484 adapter files. This decouples adapter import resolution from directory structure: - User CLIs in ~/.opencli/clis/ resolve via node_modules symlink - Internal adapters resolve via Node.js self-referencing - No more shim files needed for import resolution Changes: - package.json: add sub-path exports for all public modules - clis/**: replace relative imports with @jackwener/opencli/... - discovery.ts: simplify ensureUserCliCompatShims to symlink-only - registry-api.ts: export CommandArgs type - Remove root-level shim directories (browser/, download/, pipeline/) - Remove shim entries from tsconfig.json include and package.json files * test: add regression tests for package exports Prevents regressions like #788/#791 by: 1. Scanning all adapter files for forbidden relative imports (../../src/, ../../browser/, etc.) — fails if any remain 2. Verifying every package.json export maps to an existing source file 18 new test cases. * fix: use junction on Windows + broaden test patterns - discovery.ts: use 'junction' symlink type on Windows (no admin required) - package-exports.test.ts: generalize forbidden patterns to catch any depth of ../ traversal (not just ../../ and ../../../) * fix: update stale vi.mock/importActual paths in adapter tests Test files still used old relative paths for vi.mock() and vi.importActual() calls. Updated 5 test files to use package exports. Also broadened regression test patterns to catch mock/importActual paths. * fix: use rm instead of unlink for symlink cleanup, add warn on failure Addresses review feedback from Astro-Han: - rm() handles both symlinks and stale directories (unlink fails on dirs) - Log a warning when symlink creation fails instead of silent catch * docs: update import examples to use package exports Update all documentation, contributing guides, and skills to use @jackwener/opencli/registry instead of ../../src/registry.js. Without this, users following the docs would write adapters with broken imports since the old shim files are no longer created.
132 lines
4.8 KiB
TypeScript
132 lines
4.8 KiB
TypeScript
import { CommandExecutionError } from '@jackwener/opencli/errors';
|
|
import { cli, Strategy } from '@jackwener/opencli/registry';
|
|
import type { IPage } from '@jackwener/opencli/types';
|
|
import {
|
|
buildProductUrl,
|
|
buildProvenance,
|
|
cleanText,
|
|
extractAsin,
|
|
PRIMARY_PRICE_SELECTORS,
|
|
parsePriceText,
|
|
parseRatingValue,
|
|
parseReviewCount,
|
|
normalizeProductUrl,
|
|
uniqueNonEmpty,
|
|
assertUsableState,
|
|
gotoAndReadState,
|
|
} from './shared.js';
|
|
|
|
interface ProductPayload {
|
|
href?: string;
|
|
title?: string;
|
|
product_title?: string | null;
|
|
byline?: string | null;
|
|
price_text?: string | null;
|
|
rating_text?: string | null;
|
|
review_count_text?: string | null;
|
|
review_url?: string | null;
|
|
qa_url?: string | null;
|
|
bullets?: string[];
|
|
breadcrumbs?: string[];
|
|
}
|
|
|
|
const PRODUCT_TITLE_SELECTOR = '#productTitle, #title span, [data-feature-name="title"] h1 span';
|
|
const BYLINE_SELECTOR = '#bylineInfo, [data-feature-name="bylineInfo"] #bylineInfo';
|
|
|
|
function normalizeProductPayload(payload: ProductPayload): Record<string, unknown> {
|
|
const sourceUrl = cleanText(payload.href) || buildProductUrl(cleanText(payload.product_title) || cleanText(payload.href));
|
|
const asin = extractAsin(payload.href ?? '') ?? null;
|
|
const price = parsePriceText(payload.price_text);
|
|
const ratingText = cleanText(payload.rating_text) || null;
|
|
const reviewCountText = cleanText(payload.review_count_text) || null;
|
|
const provenance = buildProvenance(sourceUrl);
|
|
|
|
return {
|
|
asin,
|
|
title: cleanText(payload.product_title) || cleanText(payload.title) || null,
|
|
product_url: normalizeProductUrl(payload.href),
|
|
...provenance,
|
|
brand_text: cleanText(payload.byline) || null,
|
|
price_text: price.price_text,
|
|
price_value: price.price_value,
|
|
currency: price.currency,
|
|
rating_text: ratingText,
|
|
rating_value: parseRatingValue(ratingText),
|
|
review_count_text: reviewCountText,
|
|
review_count: parseReviewCount(reviewCountText),
|
|
review_url: cleanText(payload.review_url) || null,
|
|
qa_url: cleanText(payload.qa_url) || null,
|
|
breadcrumbs: uniqueNonEmpty(payload.breadcrumbs ?? []),
|
|
bullet_points: uniqueNonEmpty(payload.bullets ?? []),
|
|
};
|
|
}
|
|
|
|
async function readProductPayload(page: IPage, input: string): Promise<ProductPayload> {
|
|
const url = buildProductUrl(input);
|
|
const state = await gotoAndReadState(page, url, 2500, 'product');
|
|
assertUsableState(state, 'product');
|
|
|
|
// Amazon can report a "stable" DOM before the product title block hydrates,
|
|
// especially when reconnecting to an existing shared CDP target.
|
|
await page.wait({ selector: PRODUCT_TITLE_SELECTOR, timeout: 6 }).catch(() => {});
|
|
|
|
return await page.evaluate(`
|
|
(() => ({
|
|
href: window.location.href,
|
|
title: document.title || '',
|
|
product_title: document.querySelector(${JSON.stringify(PRODUCT_TITLE_SELECTOR)})?.textContent || '',
|
|
byline: document.querySelector(${JSON.stringify(BYLINE_SELECTOR)})?.textContent || '',
|
|
price_text: (() => {
|
|
const selectors = ${JSON.stringify(PRIMARY_PRICE_SELECTORS)};
|
|
for (const selector of selectors) {
|
|
const text = document.querySelector(selector)?.textContent || '';
|
|
if (text.trim()) return text;
|
|
}
|
|
return '';
|
|
})(),
|
|
rating_text:
|
|
document.querySelector('#acrPopover')?.getAttribute('title')
|
|
|| document.querySelector('#acrPopover')?.textContent
|
|
|| '',
|
|
review_count_text: document.querySelector('#acrCustomerReviewText')?.textContent || '',
|
|
review_url: document.querySelector('a[href*="#customerReviews"]')?.href || '',
|
|
qa_url: document.querySelector('a[href*="ask/questions"]')?.href || '',
|
|
bullets: Array.from(document.querySelectorAll('#feature-bullets li .a-list-item')).map((node) => node.textContent || ''),
|
|
breadcrumbs: Array.from(document.querySelectorAll('#wayfinding-breadcrumbs_feature_div a')).map((node) => node.textContent || ''),
|
|
}))()
|
|
`) as ProductPayload;
|
|
}
|
|
|
|
cli({
|
|
site: 'amazon',
|
|
name: 'product',
|
|
description: 'Amazon product page facts for candidate validation',
|
|
domain: 'amazon.com',
|
|
strategy: Strategy.COOKIE,
|
|
navigateBefore: false,
|
|
args: [
|
|
{
|
|
name: 'input',
|
|
required: true,
|
|
positional: true,
|
|
help: 'ASIN or product URL, for example B0FJS72893',
|
|
},
|
|
],
|
|
columns: ['asin', 'title', 'price_text', 'rating_value', 'review_count'],
|
|
func: async (page, kwargs) => {
|
|
const input = String(kwargs.input ?? '');
|
|
const payload = await readProductPayload(page, input);
|
|
if (!cleanText(payload.product_title)) {
|
|
throw new CommandExecutionError(
|
|
'amazon product page did not expose product content',
|
|
'The product page may have changed or hit a robot check. Open the product page in Chrome and retry.',
|
|
);
|
|
}
|
|
return [normalizeProductPayload(payload)];
|
|
},
|
|
});
|
|
|
|
export const __test__ = {
|
|
normalizeProductPayload,
|
|
};
|