mirror of
https://github.com/jackwener/OpenCLI.git
synced 2026-09-14 18:25:42 +08:00
4fe9a73ebc
* refactor: migrate adapter imports to package exports Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.) with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.) across all 484 adapter files. This decouples adapter import resolution from directory structure: - User CLIs in ~/.opencli/clis/ resolve via node_modules symlink - Internal adapters resolve via Node.js self-referencing - No more shim files needed for import resolution Changes: - package.json: add sub-path exports for all public modules - clis/**: replace relative imports with @jackwener/opencli/... - discovery.ts: simplify ensureUserCliCompatShims to symlink-only - registry-api.ts: export CommandArgs type - Remove root-level shim directories (browser/, download/, pipeline/) - Remove shim entries from tsconfig.json include and package.json files * test: add regression tests for package exports Prevents regressions like #788/#791 by: 1. Scanning all adapter files for forbidden relative imports (../../src/, ../../browser/, etc.) — fails if any remain 2. Verifying every package.json export maps to an existing source file 18 new test cases. * fix: use junction on Windows + broaden test patterns - discovery.ts: use 'junction' symlink type on Windows (no admin required) - package-exports.test.ts: generalize forbidden patterns to catch any depth of ../ traversal (not just ../../ and ../../../) * fix: update stale vi.mock/importActual paths in adapter tests Test files still used old relative paths for vi.mock() and vi.importActual() calls. Updated 5 test files to use package exports. Also broadened regression test patterns to catch mock/importActual paths. * fix: use rm instead of unlink for symlink cleanup, add warn on failure Addresses review feedback from Astro-Han: - rm() handles both symlinks and stale directories (unlink fails on dirs) - Log a warning when symlink creation fails instead of silent catch * docs: update import examples to use package exports Update all documentation, contributing guides, and skills to use @jackwener/opencli/registry instead of ../../src/registry.js. Without this, users following the docs would write adapters with broken imports since the old shim files are no longer created.
122 lines
3.7 KiB
TypeScript
122 lines
3.7 KiB
TypeScript
/**
|
|
* Shared command factories for Electron/desktop app adapters.
|
|
* Eliminates duplicate screenshot/status/new/dump implementations
|
|
* across cursor, codex, chatwise, etc.
|
|
*/
|
|
|
|
import * as fs from 'node:fs';
|
|
import { cli, Strategy } from '@jackwener/opencli/registry';
|
|
import type { IPage } from '@jackwener/opencli/types';
|
|
import type { CliOptions } from '@jackwener/opencli/registry';
|
|
|
|
/**
|
|
* Factory: capture DOM HTML + accessibility snapshot.
|
|
*/
|
|
export function makeScreenshotCommand(site: string, displayName?: string, extra: Partial<CliOptions> = {}) {
|
|
const label = displayName ?? site;
|
|
return cli({
|
|
...extra,
|
|
site,
|
|
name: 'screenshot',
|
|
description: `Capture a snapshot of the current ${label} window (DOM + Accessibility tree)`,
|
|
domain: 'localhost',
|
|
strategy: Strategy.UI,
|
|
browser: true,
|
|
args: [
|
|
{ name: 'output', required: false, help: `Output file path (default: /tmp/${site}-snapshot.txt)` },
|
|
],
|
|
columns: ['Status', 'File'],
|
|
func: async (page: IPage, kwargs: any) => {
|
|
const outputPath = (kwargs.output as string) || `/tmp/${site}-snapshot.txt`;
|
|
|
|
const snap = await page.snapshot({ compact: true });
|
|
const html = await page.evaluate('document.documentElement.outerHTML');
|
|
|
|
const htmlPath = outputPath.replace(/\.\w+$/, '') + '-dom.html';
|
|
const snapPath = outputPath.replace(/\.\w+$/, '') + '-a11y.txt';
|
|
|
|
fs.writeFileSync(htmlPath, html);
|
|
fs.writeFileSync(snapPath, typeof snap === 'string' ? snap : JSON.stringify(snap, null, 2));
|
|
|
|
return [
|
|
{ Status: 'Success', File: htmlPath },
|
|
{ Status: 'Success', File: snapPath },
|
|
];
|
|
},
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Factory: check CDP connection status.
|
|
*/
|
|
export function makeStatusCommand(site: string, displayName?: string, extra: Partial<CliOptions> = {}) {
|
|
const label = displayName ?? site;
|
|
return cli({
|
|
...extra,
|
|
site,
|
|
name: 'status',
|
|
description: `Check active CDP connection to ${label}`,
|
|
domain: 'localhost',
|
|
strategy: Strategy.UI,
|
|
browser: true,
|
|
columns: ['Status', 'Url', 'Title'],
|
|
func: async (page: IPage) => {
|
|
const url = await page.evaluate('window.location.href');
|
|
const title = await page.evaluate('document.title');
|
|
return [{ Status: 'Connected', Url: url, Title: title }];
|
|
},
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Factory: start a new session via Cmd/Ctrl+N.
|
|
*/
|
|
export function makeNewCommand(site: string, displayName?: string, extra: Partial<CliOptions> = {}) {
|
|
const label = displayName ?? site;
|
|
return cli({
|
|
...extra,
|
|
site,
|
|
name: 'new',
|
|
description: `Start a new ${label} session`,
|
|
domain: 'localhost',
|
|
strategy: Strategy.UI,
|
|
browser: true,
|
|
columns: ['Status'],
|
|
func: async (page: IPage) => {
|
|
const isMac = process.platform === 'darwin';
|
|
await page.pressKey(isMac ? 'Meta+N' : 'Control+N');
|
|
await page.wait(1);
|
|
return [{ Status: 'Success' }];
|
|
},
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Factory: dump DOM + snapshot for reverse-engineering.
|
|
*/
|
|
export function makeDumpCommand(site: string) {
|
|
return cli({
|
|
site,
|
|
name: 'dump',
|
|
description: `Dump the DOM and Accessibility tree of ${site} for reverse-engineering`,
|
|
domain: 'localhost',
|
|
strategy: Strategy.UI,
|
|
browser: true,
|
|
columns: ['action', 'files'],
|
|
func: async (page: IPage) => {
|
|
const dom = await page.evaluate('document.body.innerHTML');
|
|
fs.writeFileSync(`/tmp/${site}-dom.html`, dom);
|
|
|
|
const snap = await page.snapshot({ interactive: false });
|
|
fs.writeFileSync(`/tmp/${site}-snapshot.json`, JSON.stringify(snap, null, 2));
|
|
|
|
return [
|
|
{
|
|
action: 'Dom extraction finished',
|
|
files: `/tmp/${site}-dom.html, /tmp/${site}-snapshot.json`,
|
|
},
|
|
];
|
|
},
|
|
});
|
|
}
|